mclow.lists added a comment. Some nits while reading this. More to come.
Also, I don't see how this can be retargeted "at runtime"; are you implying that someone can choose at program launch time what threading system to use? How could that work given (say) a constexpr constructor for a mutex type? ================ Comment at: src/algorithm.cpp:99 @@ -90,1 +98,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# undef __LOCK_LOCK ---------------- Why the undef here? ================ Comment at: src/mutex.cpp:277 @@ -261,1 +276,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# undef __LOCK_INIT ---------------- Again; why undef at the end of a source file (not an include)? For that matter, there's no need to use reserved identifiers here - `__LOCKXXX` http://reviews.llvm.org/D20328 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
