Author: abataev
Date: Wed Mar 9 03:49:00 2016
New Revision: 263002
URL: http://llvm.org/viewvc/llvm-project?rev=263002&view=rev
Log:
[OPENMP 4.5] Codegen for data members in 'linear' clause.
OpenMP 4.5 allows to use data members in private clauses. Patch adds
codegen support for 'linear' clause.
Author: abataev
Date: Wed Mar 9 03:49:09 2016
New Revision: 263003
URL: http://llvm.org/viewvc/llvm-project?rev=263003&view=rev
Log:
[OPENMP 4.5] Codegen for data members in 'linear' clause
OpenMP 4.5 allows privatization of non-static data members in OpenMP
constructs. Patch adds proper codegen
Author: klimek
Date: Wed Mar 9 04:06:45 2016
New Revision: 263004
URL: http://llvm.org/viewvc/llvm-project?rev=263004&view=rev
Log:
Pacify gcc's parenthesis warning, which doesn't realize that parens don't
matter here.
Modified:
cfe/trunk/lib/Index/IndexingContext.cpp
Modified: cfe/trunk/l
DmitryPolukhin updated this revision to Diff 50113.
DmitryPolukhin marked 17 inline comments as done.
DmitryPolukhin added a comment.
- fixed comments
- rebase with resolving conflicts
http://reviews.llvm.org/D17567
Files:
docs/ItaniumMangleAbiTags.rst
include/clang/Basic/Attr.td
include/
DmitryPolukhin added a comment.
Thank you for the comments!
Comment at: docs/ItaniumMangleAbiTags.rst:83
@@ +82,3 @@
+For s all active tags used in the local part () are available, but not implicit tags which were not active!
+
aaron.ballman wrote:
> Replace the
Alexander_Droste retitled this revision from "getVariableName() for MemRegion"
to "getDescriptiveName() for MemRegion".
Alexander_Droste updated the summary for this revision.
Alexander_Droste updated this revision to Diff 50114.
Alexander_Droste added a comment.
Looking at the `printPretty` impl
Author: mzuckerm
Date: Wed Mar 9 05:26:45 2016
New Revision: 263007
URL: http://llvm.org/viewvc/llvm-project?rev=263007&view=rev
Log:
Fixing wrong header title name.
Differential Revision: http://reviews.llvm.org/D17917
Modified:
cfe/trunk/lib/Headers/avx512vbmiintrin.h
cfe/trunk/lib/H
a.sidorin updated this revision to Diff 50119.
a.sidorin added a comment.
Improved doxygen comments.
http://reviews.llvm.org/D17446
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
lib/ASTMatchers/Dynamic/Re
> > From: Eric Christopher [echri...@gmail.com]
> > Sent: 09 March 2016 06:50
> > To: reviews+d16139+public+275805419034a...@reviews.llvm.org; Bhushan
> > Attarde; Vasileios Kalintiris; Daniel Sanders
> > Cc: Sagar Thakur; Nitesh Jain; Mohit Bhakkad; Jaydeep Patil;
> > cfe-commits@lists.llvm.org
dsanders added a comment.
Thanks for working on this.
Comment at: llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2715-2718
@@ -2714,3 +2714,6 @@
- unsigned TrgReg;
+ // TrgReg should never normally be assigned NUM_TARGET_REGS.
+ // If you end up with NUM_TARGET_REGS, you
s.egerton added a subscriber: s.egerton.
s.egerton added a comment.
Hello. I will take a look at fixing the warnings coming from LLVMMipsAsmParser.
http://reviews.llvm.org/D17983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
omtcyf0 created this revision.
omtcyf0 added reviewers: alexfh, rsmith, LegalizeAdulthood.
omtcyf0 added a subscriber: cfe-commits.
This patch introduces a minor list of changes as proposed by Richard Smith in
the mailing list.
See original comments with an impact on the future check state below
Hi!
Sorry for a late response: I was away for a while.
Alexander, thank you for the message forwarding, I wasn’t subscribed to
cfe-commits, I guess I should do it now not to miss the comments on some of my
patches!
Richard, thank you for the valuable feedback!
I’ve created a patch, which chan
roman.shirokiy added a comment.
For now every native Windows installation of Clang contains small compiler-rt
builtins lib (http://reviews.llvm.org/rL261432: [CMake] Add partial support for
MSVC in compiler-rt builtins), but there is no specific interface to make use
of this lib on Windows. Thi
etienneb created this revision.
etienneb added reviewers: alexfh, rnk.
etienneb added a subscriber: cfe-commits.
Summary:
Clang-tidy fails when parsing MSVC inline assembly statements. The native
target and asm parser aren't initialized.
The following patch is fixing the issue by using the same
baloghadamsoftware created this revision.
baloghadamsoftware added a reviewer: alexfh.
baloghadamsoftware added a subscriber: cfe-commits.
Existing checker misc-misplaced-widening-cast was extended:
- New use cases: casted expression as lhs or rhs of a logical comparison or
function argument
- Ne
baloghadamsoftware created this revision.
baloghadamsoftware added a reviewer: klimek.
baloghadamsoftware added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
A checker (will be uploaded after this patch) needs to check implicit casts.
Existing generic matcher "has" ignores implici
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D17567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D17446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D17410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D17419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
LGTM
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping @danalbert
http://reviews.llvm.org/D17416
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer created this revision.
bkramer added reviewers: rsmith, rjmccall.
bkramer added a subscriber: cfe-commits.
Also thread -f(no-)delete-null-pointer-checks through to CodeGen and
make it disable this behavior. It's not a full implementation of that
flag but it would be good to stay compatible
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263015: [GCC] PR23529 Sema part of attrbute abi_tag support
(authored by dpolukhin).
Changed prior to commit:
http://reviews.llvm.org/D17567?vs=50113&id=50137#toc
Repository:
rL LLVM
http://reviews.
Author: dpolukhin
Date: Wed Mar 9 09:30:53 2016
New Revision: 263015
URL: http://llvm.org/viewvc/llvm-project?rev=263015&view=rev
Log:
[GCC] PR23529 Sema part of attrbute abi_tag support
Original patch by Stefan Bühler http://reviews.llvm.org/D12834
Difference between original and this one:
- f
Author: bcraig
Date: Wed Mar 9 09:39:39 2016
New Revision: 263016
URL: http://llvm.org/viewvc/llvm-project?rev=263016&view=rev
Log:
Reorganize _LIBCPP_LOCALE__L_EXTENSIONS
Instead of checking _LIBCPP_LOCALE_L_EXTENSIONS all over, instead check it
once, and define the various *_l symbols once. Th
bcraig accepted this revision.
bcraig added a reviewer: bcraig.
bcraig added a comment.
This revision is now accepted and ready to land.
Committed
http://reviews.llvm.org/D17456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
andreybokhanko abandoned this revision.
andreybokhanko added a comment.
It seems the discussion
(http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160229/thread.html#151860)
concluded that we don't want this fix to be committed until we see some
compelling code that relies on "static_as
dblaikie added a subscriber: dblaikie.
dblaikie added a comment.
I think we had a discussion about this before.
Clang has a few versions of this warning. One version is probably as
aggressive as the warning you are trying to quiet (-Wmaybe-uninitialized)
and we made a deliberate choice not to ena
jroelofs added a comment.
LGTM
http://reviews.llvm.org/D17419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I think we had a discussion about this before.
Clang has a few versions of this warning. One version is probably as
aggressive as the warning you are trying to quiet (-Wmaybe-uninitialized)
and we made a deliberate choice not to enable it for the project. I think
we should probably make the same c
Author: sfantao
Date: Wed Mar 9 09:46:05 2016
New Revision: 263019
URL: http://llvm.org/viewvc/llvm-project?rev=263019&view=rev
Log:
[OpenMP] Add support for multidimensional array sections in map clause SEMA.
Summary: In some cases it can be proved statically that multidimensional array
sectio
Author: bcraig
Date: Wed Mar 9 09:49:59 2016
New Revision: 263020
URL: http://llvm.org/viewvc/llvm-project?rev=263020&view=rev
Log:
Split locale management out of locale_win32. NFCI
For the locale refactor, the locale management functions (newlocale,
freelocale, uselocale) are needed in a separa
bcraig accepted this revision.
bcraig added a reviewer: bcraig.
bcraig added a comment.
This revision is now accepted and ready to land.
Committed
http://reviews.llvm.org/D17419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
arpith-jacob updated this revision to Diff 50143.
arpith-jacob marked 2 inline comments as done.
arpith-jacob added a comment.
Stylistic changes to address feedback.
http://reviews.llvm.org/D17877
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRun
arpith-jacob marked 9 inline comments as done.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:69
@@ +68,3 @@
+ /// evaluates to false.
+ virtual void emitTargetOutlinedFunctionHelper(const OMPExecutableDirective
&D,
+StringRef ParentNa
a.sidorin removed rL LLVM as the repository for this revision.
a.sidorin updated this revision to Diff 50140.
a.sidorin added a comment.
Stylish fixes.
Serge: ASTMatcher review is complete so there should be no more build problems.
Could you try again?
Also, I'd prefer to add your changes in the
hfinkel added a subscriber: hfinkel.
hfinkel added a comment.
I'm *really* nervous about doing anything with
-f(no-)delete-null-pointer-checks that makes it look like we support this
feature without actually supporting it in the backend.
In computePointerICmp in InstructionSimplify.cpp, we hav
tejohnson added a subscriber: tejohnson.
tejohnson added a comment.
Thanks for doing this!
I will fix these 3, which one of my changes would have provoked. It is a benign
case since we do have an assert at the use site checking the same condition
that the inits are guarded with, but there is no
On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" <
llvm-comm...@lists.llvm.org> wrote:
>
> tejohnson added a subscriber: tejohnson.
> tejohnson added a comment.
>
> Thanks for doing this!
>
> I will fix these 3, which one of my changes would have provoked. It is a
benign case since we do h
manmanren added a comment.
Ping
http://reviews.llvm.org/D17865
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren added a comment.
Ping
http://reviews.llvm.org/D15314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Mar 9, 2016 at 8:13 AM, David Blaikie wrote:
>
> On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" <
> llvm-comm...@lists.llvm.org> wrote:
> >
> > tejohnson added a subscriber: tejohnson.
> > tejohnson added a comment.
> >
> > Thanks for doing this!
> >
> > I will fix these 3, whi
Author: dpolukhin
Date: Wed Mar 9 10:19:04 2016
New Revision: 263023
URL: http://llvm.org/viewvc/llvm-project?rev=263023&view=rev
Log:
NFC fix documentation build by rL263015
Modified:
cfe/trunk/docs/ItaniumMangleAbiTags.rst
Modified: cfe/trunk/docs/ItaniumMangleAbiTags.rst
URL:
http://llv
On Mar 9, 2016 8:18 AM, "Teresa Johnson" wrote:
>
>
>
> On Wed, Mar 9, 2016 at 8:13 AM, David Blaikie wrote:
>>
>>
>> On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" <
llvm-comm...@lists.llvm.org> wrote:
>> >
>> > tejohnson added a subscriber: tejohnson.
>> > tejohnson added a comment.
On Wed, Mar 9, 2016 at 8:23 AM, David Blaikie wrote:
>
> On Mar 9, 2016 8:18 AM, "Teresa Johnson" wrote:
> >
> >
> >
> > On Wed, Mar 9, 2016 at 8:13 AM, David Blaikie
> wrote:
> >>
> >>
> >> On Mar 9, 2016 8:11 AM, "Teresa Johnson via llvm-commits" <
> llvm-comm...@lists.llvm.org> wrote:
> >> >
rengolin added a comment.
Hi,
The error is very sensible, but I'm not sure why you're adding compiler-rt in
the second change. Why is that necessary, and where are the tests for it.
Thanks!
--renato
http://reviews.llvm.org/D17453
___
cfe-commits
Author: aaronballman
Date: Wed Mar 9 10:48:08 2016
New Revision: 263025
URL: http://llvm.org/viewvc/llvm-project?rev=263025&view=rev
Log:
Implement support for [[maybe_unused]] in C++1z that is based off existing
support for unused, and treat it as an extension pre-C++1z. This also means
extend
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
I like the idea of a potential fixit being provided by the attribute, but I do
not agree with the way the feature is surfaced in this patch.
For the GNU-style attribute,
Author: aaronballman
Date: Wed Mar 9 11:11:51 2016
New Revision: 263027
URL: http://llvm.org/viewvc/llvm-project?rev=263027&view=rev
Log:
Adding new AST matchers for: addrLabelExpr, atomicExpr,
binaryConditionalOperator, designatedInitExpr, designatorCountIs,
hasSyntacticForm, implicitValueInit
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r263027.
http://reviews.llvm.org/D17446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Wed Mar 9 11:19:07 2016
New Revision: 263029
URL: http://llvm.org/viewvc/llvm-project?rev=263029&view=rev
Log:
Add some more tests for the containers type requirements
Modified:
libcxx/trunk/test/std/containers/sequences/array/types.pass.cpp
libcxx/trunk/test/std/c
zaks.anna added a comment.
I thunk the closest we have is region-store* tests, which is not quite the
same. Feel free to add a new test.
http://reviews.llvm.org/D16044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
rjmccall added a comment.
Hal, I think you're talking about a slightly different thing. This patch is
adding an assumption that C++ this pointers are non-null, but only when
-fno-delete-null-pointer-checks is not passed. The flag is therefore at least
somewhat functional. (I would argue that
chandlerc added a subscriber: chandlerc.
chandlerc added a comment.
If we're not going to fully implement "fdelete-null-pointer-checks" we
shouldn't claim to... I'm really worried about us accepting that flag and not
actually honoring it.
However, I *do* think this should be guarded by a flag,
Author: hans
Date: Wed Mar 9 11:26:46 2016
New Revision: 263031
URL: http://llvm.org/viewvc/llvm-project?rev=263031&view=rev
Log:
ReleaseNotes: update 'you may prefer' link to 3.8
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewv
Author: aaronballman
Date: Wed Mar 9 11:34:16 2016
New Revision: 263034
URL: http://llvm.org/viewvc/llvm-project?rev=263034&view=rev
Log:
Speculative fix for this test case (the test doesn't run on my typical build
environment).
Modified:
cfe/trunk/test/Misc/ast-dump-color.cpp
Modified: cf
Author: marshall
Date: Wed Mar 9 11:51:43 2016
New Revision: 263036
URL: http://llvm.org/viewvc/llvm-project?rev=263036&view=rev
Log:
Implement LWG#2583: There is no way to supply an allocator for
basic_string(str, pos)
Modified:
libcxx/trunk/include/string
libcxx/trunk/test/std/strings
steven_wu added a comment.
ping
http://reviews.llvm.org/D17392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steven_wu added a comment.
ping
http://reviews.llvm.org/D17627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tnorthover
Date: Wed Mar 9 12:00:06 2016
New Revision: 263038
URL: http://llvm.org/viewvc/llvm-project?rev=263038&view=rev
Log:
AArch64: remove a couple more tests already covered elsewhere.
Removed:
cfe/trunk/test/CodeGen/arm64-scalar-test.c
cfe/trunk/test/CodeGen/arm64-vrsqrt.c
Author: aaronballman
Date: Wed Mar 9 12:07:17 2016
New Revision: 263041
URL: http://llvm.org/viewvc/llvm-project?rev=263041&view=rev
Log:
Use an explicit instantiation to work around delayed template parsing for
MSVC-built bots.
Modified:
cfe/trunk/unittests/ASTMatchers/ASTMatchersTest.cpp
Author: marshall
Date: Wed Mar 9 12:08:29 2016
New Revision: 263042
URL: http://llvm.org/viewvc/llvm-project?rev=263042&view=rev
Log:
Implement LWG#2579: Inconsistency wrt Allocators in basic_string assignment vs.
basic_string::assign
Modified:
libcxx/trunk/include/string
libcxx/trunk/
Author: marshall
Date: Wed Mar 9 12:09:07 2016
New Revision: 263043
URL: http://llvm.org/viewvc/llvm-project?rev=263043&view=rev
Log:
Update status to mark 2579 complete
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/ll
Anastasia added inline comments.
Comment at: test/SemaOpenCL/nosvm.cl:9
@@ +8,3 @@
+#else
+void f(__attribute__((nosvm)) int* a); // expected-warning {{'nosvm' attribute
ignored}}
+#endif
yaxunl wrote:
> Anastasia wrote:
> > yaxunl wrote:
> > > yaxunl wrote:
> >
sfantao added a comment.
Hi Kelvin,
Thanks for working on this! I have some minor comments inlined.
Comment at: lib/Sema/SemaOpenMP.cpp:9392
@@ +9391,3 @@
+ SemaRef.Diag(ELoc, diag::err_omp_map_shared_storage) << ERange;
+else
+ SemaRef.Dia
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: include/clang/Basic/Attr.td:701
@@ -699,1 +700,3 @@
+def OpenCLNoSVM : Attr {
+ let Spellings = [GNU<"nosvm">];
Since the attribute is ignored by clang,
yaxunl marked 7 inline comments as done.
Comment at: include/clang/Basic/Attr.td:701
@@ -699,1 +700,3 @@
+def OpenCLNoSVM : Attr {
+ let Spellings = [GNU<"nosvm">];
aaron.ballman wrote:
> Since the attribute is ignored by clang, you should inherit from IgnoredA
bkramer added a comment.
GCC 6 is already doing this and people are already annotating their builds with
-fno-delete-null-pointer-checks. Putting it under a different flag will break
compatibility there :(
http://reviews.llvm.org/D17993
___
cfe-co
echristo added a subscriber: echristo.
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
This is a compromise I can live with :)
Thanks for doing this Tim.
-eric
http://reviews.llvm.org/D17999
___
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:701
@@ -699,1 +700,3 @@
+def OpenCLNoSVM : Attr {
+ let Spellings = [GNU<"nosvm">];
yaxunl wrote:
> aaron.ballman wrote:
> > Since the attribute is ignored by clang, you should inherit
Modified: cfe/trunk/test/CodeGen/builtins-arm-exclusive.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtins-arm-exclusive.c?rev=263048&r1=263047&r2=263048&view=diff
==
--- cfe/trunk/test/CodeGen/buil
t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Eric. Committed as r263048.
http://reviews.llvm.org/D17999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren added a comment.
Hi Aaron,
Thanks for the review!
> I like the idea of a potential fixit being provided by the attribute, but I
> do not agree with the way the feature is surfaced in this patch.
>
> For the GNU-style attribute, the named argument functionality is sufficiently
> no
spatel added a subscriber: spatel.
spatel added a comment.
Nothing to do with the patch itself (although it looks great and thanks!) - is
the CHECK line generator script available somewhere? I'd love to be able to use
that.
http://reviews.llvm.org/D17999
rjmccall added a comment.
Er, sorry. You are not inspiring *me* to disagree with Chandler.
http://reviews.llvm.org/D17993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
Well, no, we can do it under a different flag and just ensure that
-fno-delete-null-pointer-checks *also* has the effect of disabling the
optimization.
But you are not inspiring to disagree with Chandler about whether this
optimization should be enabled by default.
rjmccall added a comment.
The right fix is probably at the PseudoObjectExpr level; you should probably be
looking at the semantic expressions instead of the syntactic.
http://reviews.llvm.org/D17627
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: kbarton
Date: Wed Mar 9 13:28:31 2016
New Revision: 263051
URL: http://llvm.org/viewvc/llvm-project?rev=263051&view=rev
Log:
[PPC] FE support for generating VSX [negated] absolute value instructions
Includes new built-in, conversion of built-in to target-independent intrinsic
and update
kbarton closed this revision.
kbarton added a comment.
Committed r263051
http://reviews.llvm.org/D17816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dpolukhin
Date: Wed Mar 9 13:39:16 2016
New Revision: 263052
URL: http://llvm.org/viewvc/llvm-project?rev=263052&view=rev
Log:
NFC fix documentation build by rL263015
This time I hope it will fix the build for real.
Modified:
cfe/trunk/docs/ItaniumMangleAbiTags.rst
cfe/trunk/doc
aaron.ballman added a comment.
In http://reviews.llvm.org/D17865#370912, @manmanren wrote:
> Hi Aaron,
>
> Thanks for the review!
>
> > I like the idea of a potential fixit being provided by the attribute, but I
> > do not agree with the way the feature is surfaced in this patch.
>
> >
>
> > Fo
ariccio added a comment.
In http://reviews.llvm.org/D17983#370717, @dblaikie wrote:
> Initializations we never expect to use (eg because we have a covered switch
> that initializes in all cases, or some slightly complex control flow the
> compiler can't see through) hinder our ability to find u
ariccio added a comment.
Oh, and by the way, what's the policy on using `enum class`es instead of C
style enums? I bet the compiler would have fewer false positives with strongly
typed enums?
http://reviews.llvm.org/D17983
___
cfe-commits mailing
davide created this revision.
davide added reviewers: rsmith, silvas, doug.gregor.
davide added a subscriber: cfe-commits.
I stumbled upon this yesterday. Without this patch in palce, the module map
load is silently ignored, and this might cause subtle breakages.
http://reviews.llvm.org/D18011
davide updated this revision to Diff 50181.
davide added a comment.
Typo.
http://reviews.llvm.org/D18011
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
lib/Frontend/FrontendActions.cpp
test/Modules/Inputs/insufficient-privileges.modulemap
Index: lib/Frontend/FrontendActions.cpp
==
On 9 March 2016 at 11:12, Sanjay Patel wrote:
> Nothing to do with the patch itself (although it looks great and thanks!) -
> is the CHECK line generator script available somewhere? I'd love to be able
> to use that.
It's horribly hacky and fragile, but what I've got should be attached
here. Pa
Alexander_Droste added a comment.
Thanks for pointing this out. What's actually the best way to test the
function?
If I test this function with an integration test, I need to rely on a checker
which uses the function to output diagnostics.
Is it possible to test this with a unit test? My assump
bob.wilson added a comment.
> I do like the explicit nature of this approach, but I'm worried about it
> being too novel. For instance, would this compel GCC to implement a similar
> parsing feature since they also support the deprecated attribute, that sort
> of thing. Also, it feels like a bi
steven_wu updated this revision to Diff 50186.
steven_wu added a comment.
Update the patch to address John's feedback. We shouldn't even checking
ObjCSubscript but looking at the Semantics for PseudoObjectExpr only.
http://reviews.llvm.org/D17627
Files:
lib/Sema/SemaStmt.cpp
test/SemaObjC/w
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Addressed comment in new version of diff.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
carlo.bertolli updated this revision to Diff 50187.
carlo.bertolli added a comment.
[OPENMP] This new version of the patch uses the inlining machinery of
CGOpenMPRuntime.cpp instead of just dumping the teams body statement using
EmitStmt.
Repository:
rL LLVM
http://reviews.llvm.org/D17963
Author: davide
Date: Wed Mar 9 15:09:51 2016
New Revision: 263060
URL: http://llvm.org/viewvc/llvm-project?rev=263060&view=rev
Log:
[modules] Simplify code logic. NFC.
Modified:
cfe/trunk/lib/Basic/Module.cpp
Modified: cfe/trunk/lib/Basic/Module.cpp
URL:
http://llvm.org/viewvc/llvm-project
On 9 March 2016 at 13:20, David Blaikie via cfe-commits
wrote:
> If we are touching these tests at all, as a cleanup, why aren't we adjusting
> them to not pass through the llvm optimizers/code generators at all?
> Generally we are pretty clear that any test in Clang looking at llvms
> generated a
On Wed, Mar 9, 2016 at 1:32 PM Tim Northover via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 9 March 2016 at 13:20, David Blaikie via cfe-commits
> wrote:
> > If we are touching these tests at all, as a cleanup, why aren't we
> adjusting
> > them to not pass through the llvm optimizers/
On Wed, Mar 9, 2016 at 11:33 AM Kit Barton via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: kbarton
> Date: Wed Mar 9 13:28:31 2016
> New Revision: 263051
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263051&view=rev
> Log:
> [PPC] FE support for generating VSX [negated] absolute
1 - 100 of 138 matches
Mail list logo
