[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

owenpan added a comment. Yes, the said invalid code may get reformatted. However, the main purpose of this patch is to fix the efficiency issue as nested function declarators would no longer be checked for possible K&R C function definitions. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0057c7185d1c: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address. (authored by hoy). Repository: rG LLVM Github Monorepo C

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. 1. modf works now. 2. if I modify the complile.sh clang++ -fopenmp -fopenmp-targets=nvptx64 -c classA.cpp rm -f libmylib.a ar qc libmylib.a classA.o ranlib libmylib.a clang++ -fopenmp -fopenmp-targets=nvptx64 main.cpp -L. -lmylib ./a.out doesn't work. I think

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. In D108695#2999677 , @Szelethus wrote: > rGfb4d590a622f4031900516360c07ee6ace01c5e6 > should > sort this out! Yes now it works. Thank you! Repository: rG

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

NoQ added a comment. In D105756#2990495 , @mizvekov wrote: > Hello! Thanks for reporting this. Thanks for fixing! In D105756#2990495 , @mizvekov wrote: > The double implicit lvalue-to-rvalue cast is an unfortun

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

rjmccall added a comment. Hmm. I think "v-tables are in the address space of the object pointer" is not a good assumption. Probably this ought to be determined by the C++ ABI for the target. In principle it could even be class-specific, but I think we can start by assuming it's universal.

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#3000556 , @erichkeane wrote: > In D108643#3000540 , @rjmccall > wrote: > >> > > I don't work on the microcode, it is just what I was told when we asked about > this. SO un

[clang-tools-extra] 626586f - Re-Revert "clang-tidy: introduce readability-containter-data-pointer check"

Author: Nico Weber Date: 2021-09-14T22:27:59-04:00 New Revision: 626586fc253c6f032aedb325dba6b1ff3f11875e URL: https://github.com/llvm/llvm-project/commit/626586fc253c6f032aedb325dba6b1ff3f11875e DIFF: https://github.com/llvm/llvm-project/commit/626586fc253c6f032aedb325dba6b1ff3f11875e.diff LO

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. The test is still failing on Windows, see e.g. http://45.33.8.238/win/45205/step_8.txt or https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8836086236638553313/+/u/package_clang/stdout?format=raw or https://lab.llvm.org/buildbot/#/builders/123/builds/607

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy added inline comments. Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772 +void PerfReaderBase::emitAccumulatedWarnings() { + for (auto Address : InvalidReturnAddresses) { wenlei wrote: > nit: emitAccumulatedWarnings -> warnTruncatedStack Makes sense.

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372615. hoy added a comment. Updating D109638 : [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109638/new/

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm except two nits. Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:772 +void PerfReaderBase::emitAccumulatedWarnings() { + for (auto Address : InvalidReturnAddresses

[PATCH] D109799: [RISCV] add Half-precision test for load/store

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, HsiangKai. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, r

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG299b5d420df1: [CSSPGO] Enable pseudo probe instrumentation in O0 mode. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 299b5d4 - [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

Author: Hongtao Yu Date: 2021-09-14T18:13:29-07:00 New Revision: 299b5d420df15fafc9936bc24995f6cd6ad325be URL: https://github.com/llvm/llvm-project/commit/299b5d420df15fafc9936bc24995f6cd6ad325be DIFF: https://github.com/llvm/llvm-project/commit/299b5d420df15fafc9936bc24995f6cd6ad325be.diff LO

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy updated this revision to Diff 372604. hoy added a comment. Addressing Wenlei's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109638/new/ https://reviews.llvm.org/D109638 Files: llvm/test/tools/llvm-profgen/Inputs/cs-invalid-ret-addr

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

hoy added a comment. In D109638#3000682 , @wenlei wrote: >> It isn't common when the program is built with the frame pointer omission >> disabled, but can still happen with third-party static libs built with frame >> pointer omitted. > > Did you mean di

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz updated this revision to Diff 372598. rmaz added a comment. update to fix lint warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaC

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz updated this revision to Diff 372597. rmaz added a comment. Updated to use a GlobalMethods struct which contains the global method lists as well as the sets used to de-duplicate added methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10963

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

woodruffw updated this revision to Diff 372595. woodruffw added a comment. Increase the context for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 Files: clang/lib/Frontend/ASTConsumers.cpp

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wenlei accepted this revision. wenlei added a comment. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3000469 , @vsapsai wrote: > I'm a little bit confused here. Where is the speed-up coming from? Is it > because ObjCMethodList for `init` not being serialized? I'm asking because > right now I don't see how `seen` helps w

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added a comment. Great! This should work. Though we need actual tests ;) I also provided you with two minor edits below to make it easier to read, no functional change though. Comment at: clang/lib/Sema/SemaOpenMP.cpp:737-738 +if (ScopeEntry) + std::copy(Tr

[PATCH] D109638: [CSSPGO][llvm-profgen] Truncate stack samples with invalid return address.

wenlei added a comment. > It isn't common when the program is built with the frame pointer omission > disabled, but can still happen with third-party static libs built with frame > pointer omitted. Did you mean disabled -> enabled? > This could happen to frame-pointer-based unwinding and the c

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:746 +} + } + } jdoerfert wrote: > jdoerfert wrote: > > So, SmalVector has a pop_back_val which we could use to verify the > > properties are the ones we expect. However, we woul

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372584. cchen added a comment. Fix based on suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. In D108643#3000540 , @rjmccall wrote: > The question is whether you can rely on extension at places that receive an > arbitrary ABI-compatible value, like function parameters or loads. If nobody > who receives such a value c

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372570. daltenty added a comment. - Fix additional test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/li

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#3000223 , @erichkeane wrote: > In D108643#3000193 , @rjmccall > wrote: > >> In D108643#2999776 , @erichkeane >> wrote: >> ! In

[PATCH] D106876: Remove non-affecting module maps from PCM files.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please apply the lint suggestions; otherwise, looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 _

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372566. daltenty added a comment. - Update check patttern to allow windows directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files: clang/lib/Dr

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +// CHECK-INTERNAL-INC

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#3000374 , @vsapsai wrote: > In D109128#2999846 , @dexonsmith > wrote: > >> In D109128#2997588 , @JDevlieghere >> wrote: >> >>> Kei

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. I'm a little bit confused here. Where is the speed-up coming from? Is it because ObjCMethodList for `init` not being serialized? I'm asking because right now I don't see how `seen` helps with that. My current understanding is that `Sema::addMethodToGlobalList` is too ex

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 372563. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + ZarkoCA wrote: > sfertile wrote: > > The code-ge

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + sfertile wrote: > The code-gen for int and float

[PATCH] D109128: [VFS] Use original path when falling back to external FS

vsapsai added a comment. In D109128#2999846 , @dexonsmith wrote: > In D109128#2997588 , @JDevlieghere > wrote: > >> Keith and I discussed this offline. My suggestion was to do the following: >> >> 1. Check the o

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372548. vaibhav.y added a comment. Format clang/lib/Basic/Sarif.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h cla

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372543. vaibhav.y added a comment. Fixup name of class defined in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/S

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 372542. vaibhav.y added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h clang/includ

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:1 +#include "clang/Basic/Sarif.h" +#include "clang/Basic/LangOptions.h" lattner wrote: > THis nees the standard header boilerplate per the coding standards doc Ack, didn't grok the "all source

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372541. quinnp added a comment. Removing an extra space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h clang/lib/Sema/SemaChec

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds range checking for some Power10 altivec builtins. Range checking is done in SemaCheck

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. In D109362#2999688 , @uweigand wrote: > Looking at the common code parts, it seems the behavior of MM_GOFF is > actually identical to MM_ELF. Is this correct? If so, do we really need a > different format type here? At a f

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:746 +} + } + } jdoerfert wrote: > So, SmalVector has a pop_back_val which we could use to verify the properties > are the ones we expect. However, we would need to first put

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5069 // where aliases aren't supported. - if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases"); gandh

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 372528. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - set `GlobalOpt` parameter to false by default to disallow alias elimination when the options EarlyInlineAll and EnableFunctionCalls are true and false, respectively. R

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372531. cchen added a comment. Remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClaus

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added subscribers: craig.topper, andrew.w.kaylor. erichkeane added a comment. In D108643#3000193 , @rjmccall wrote: > In D108643#2999776 , @erichkeane > wrote: > >>> ! In D108643#2965852

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. Thanks for your reply and sorry about my very sluggish reply! I am looking into updating the docs as you suggested, and that got me looking at this doc page . Interestingly, that

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372529. cchen added a comment. Fix based on feedback (wait for comment about moving ConstructTrait to IRBuilder) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files:

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#3000157 , @JDevlieghere wrote: > Yes, Keith and I came to the same conclusion yesterday. I was worried about > tracking both paths at all times, but I like your suggestion of only changing > the path when requeste

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

MaskRay added a comment. 49992c04148e5327bef9bd2dff53a0d46004b4b4 relanded the change. It is useful to attach the original `Differential Revision: ` so that it is connected to this Differential. Repository: rG LLVM Github

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#2999776 , @erichkeane wrote: >> ! In D108643#2965852 , @rjmccall >> wrote: >> >> The choice that high bits are unspecified rather than extended is an >> interesting one. Ca

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:8188-8190 + for (auto *L = &List; L; L = L->getNext()) { +seen.insert(L->getMethod()); + } dexonsmith wrote: > I find quadratic algorithms a bit scary, even when current benchmark

[PATCH] D109128: [VFS] Use original path when falling back to external FS

JDevlieghere added a comment. Yes, Keith and I came to the same conclusion yesterday. I was worried about tracking both paths at all times, but I like your suggestion of only changing the path when requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D109557: Adds an AlignCloseBracket option

HazardyKnusperkeks added a comment. In D109557#2998727 , @csmulhern wrote: > In D109557#2998213 , > @HazardyKnusperkeks wrote: > >> With context he meant the diff context. >> https://llvm.org/docs/Phabricator.ht

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

HazardyKnusperkeks added a comment. If there are no new tests, what went wrong before? Said invalid code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109752/new/ https://reviews.llvm.org/D109752 ___ cf

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

sfertile added a comment. I suggest we separate the clang change and testing into a standalone patch, and the llvm backend tests into a standalone patch which we can commit separately. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4646 + if (const ComplexType *CTy = Ty->getAs(

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66c6bbe7ff56: Put code that avoids heapifying local blocks behind a flag (authored by waltl). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 66c6bbe - Put code that avoids heapifying local blocks behind a flag

Author: Walter Lee Date: 2021-09-14T14:06:05-04:00 New Revision: 66c6bbe7ff56441706d6cbb349fde9a02e248c9a URL: https://github.com/llvm/llvm-project/commit/66c6bbe7ff56441706d6cbb349fde9a02e248c9a DIFF: https://github.com/llvm/llvm-project/commit/66c6bbe7ff56441706d6cbb349fde9a02e248c9a.diff LO

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I've tried making an integration test in addition to the unit test, but I couldn't find a way to make lit ignore the crashed process exit status: FAIL: Clangd :: crash.test (1049 of 1049) TEST 'Clangd :: crash.test' FAILED S

[clang-tools-extra] 49992c0 - Revert "Revert "clang-tidy: introduce readability-containter-data-pointer check""

Author: Saleem Abdulrasool Date: 2021-09-14T10:52:35-07:00 New Revision: 49992c04148e5327bef9bd2dff53a0d46004b4b4 URL: https://github.com/llvm/llvm-project/commit/49992c04148e5327bef9bd2dff53a0d46004b4b4 DIFF: https://github.com/llvm/llvm-project/commit/49992c04148e5327bef9bd2dff53a0d46004b4b4.

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @thakis - thanks, seems that I had a part of the change sitting in my stash ... I had added a `-NOT` to verify the behaviour, and forgot to remove it. I'll revert the revert with the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 372515. 0x1eaf retitled this revision from "[RFC] Print current request context along with the stack trance in clangd" to "[clangd] Print current request context along with the stack trace". 0x1eaf edited the summary of this revision. 0x1eaf added a comment.

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added a reviewer: vsapsai. dexonsmith added a subscriber: vsapsai. dexonsmith added a comment. Thanks for looking at this! I have a couple of comments inline. @vsapsai, can you also take a look? Comment at: clang/lib/Serialization/ASTReader.cpp:8188-8190 + for (aut

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam updated this revision to Diff 372514. saiislam added a comment. Rebase and a minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp cla

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf updated this revision to Diff 372510. 0x1eaf added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 Files: clang-tools-extra/clangd/JSONTransport.cpp clang-t

[PATCH] D109772: [clangd] Print current request context along with the stack trace

0x1eaf created this revision. 0x1eaf added reviewers: sammccall, ilya-biryukov, nridge. 0x1eaf added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. 0x1eaf requested review of this revision. Herald added subscribers: cfe-commits, Mas

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra added a comment. In D108787#243 , @yaxunl wrote: > I am concerned that there may be more places which need handling, and passing > exec config expr by function arguments may not scale. > Is it possible to represent the kernel call expr by a deri

[PATCH] D109632: [clang] de-duplicate methods from AST files

manmanren added a comment. @dexonsmith @bruno: are you okay with this change? It looks good to me :] Thanks, Manman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632 ___

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2 -fprofil

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: David Blaikie > Date: 2021-09-13T19:17:05-07:00 > New Revision: 2bd84938470bf2e337801faafb8a67710f46429d > > URL: > https://github.com/llvm/llvm-project/commit/2bd84938470bf2e337801faafb8a

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl added a comment. I am concerned that there may be more places which need handling, and passing exec config expr by function arguments may not scale. Is it possible to represent the kernel call expr by a derived class of call expr and add the exec config expr as member to it? Repository

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. Reverted in 76dc8ac36d07 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 ___

[clang-tools-extra] 76dc8ac - Revert "clang-tidy: introduce readability-containter-data-pointer check"

Author: Nico Weber Date: 2021-09-14T12:37:10-04:00 New Revision: 76dc8ac36d07cebe8cfe8fe757323562bb36df94 URL: https://github.com/llvm/llvm-project/commit/76dc8ac36d07cebe8cfe8fe757323562bb36df94 DIFF: https://github.com/llvm/llvm-project/commit/76dc8ac36d07cebe8cfe8fe757323562bb36df94.diff LO

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict qualified pointers

saghir updated this revision to Diff 372505. saghir added a comment. update test case name to be consistent with existing ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/Sema

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Ah, nice! Thanks for the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109770/new/ https://reviews.llvm.org/D109770 _

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

jdoerfert created this revision. jdoerfert added reviewers: pdhaliwal, JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. A declare variant template is only

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. (BTW, does this problem affect OverlayFileSystem as well?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing l

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

jdoerfert added a comment. I'm fixing this, nothing to do with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 ___ cfe-commits mailing list cfe-commi

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru added a comment. Yes please land this. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#2997588 , @JDevlieghere wrote: > Keith and I discussed this offline. My suggestion was to do the following: > > 1. Check the overlay for the canonicalized path > 2. Check the fall-through for the canonicalized pat

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

yaxunl updated this revision to Diff 372495. yaxunl added a comment. revise diag message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109718/new/ https://reviews.llvm.org/D109718 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/Driver.cpp clang/test/Dri

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. This breaks tests: http://45.33.8.238/linux/55784/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:704 +C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) { + Diag(clang::diag::err_drv_unsupported_opt) << OMPTargetArg->getSpelling(); + return; yaxunl wrote: > t

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:704 +C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) { + Diag(clang::diag::err_drv_unsupported_opt) << OMPTargetArg->getSpelling(); + return; tra wrote: > I

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. > ! In D108643#2965852 , @rjmccall > wrote: > > The choice that high bits are unspecified rather than extended is an > interesting one. Can you speak to that? That's good for +, -, *, &, |, ^, > <<, and narrowing conversion

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999763 , @compnerd wrote: > @Eugene.Zelenko - sorry, I didn't see the additional comments before the > commit. I'm happy to do a follow up depending on the resolution. If there's a follow-up to add this to mod

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @Eugene.Zelenko - sorry, I didn't see the additional comments before the commit. I'm happy to do a follow up depending on the resolution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGd0d9e6f0849b: clang-tidy: introduce readability-containter-data-pointer check (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D108893

[clang-tools-extra] d0d9e6f - clang-tidy: introduce readability-containter-data-pointer check

Author: Saleem Abdulrasool Date: 2021-09-14T08:12:10-07:00 New Revision: d0d9e6f0849b2e76e980e2edf365302f47f4e35f URL: https://github.com/llvm/llvm-project/commit/d0d9e6f0849b2e76e980e2edf365302f47f4e35f DIFF: https://github.com/llvm/llvm-project/commit/d0d9e6f0849b2e76e980e2edf365302f47f4e35f.

[PATCH] D109721: [IR] Reduce max supported integer from 2^24-1 to 2^23.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd180bbb9a7: [IR] Reduce max supported integer from 2^24-1 to 2^2

[clang] 2fd180b - [IR] Reduce max supported integer from 2^24-1 to 2^23.

Author: Craig Topper Date: 2021-09-14T07:52:10-07:00 New Revision: 2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433 URL: https://github.com/llvm/llvm-project/commit/2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433 DIFF: https://github.com/llvm/llvm-project/commit/2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433.diff

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

hjl.tools added a comment. In D108643#2999724 , @aaron.ballman wrote: > In D108643#2991995 , @hjl.tools > wrote: > The choice that high bits are unspecified rather than extended is an interesting one.

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

arichardson added a comment. In D103835#2999731 , @yaxunl wrote: > In D103835#2999545 , @arichardson > wrote: > >> Merging this change broke our out-of-tree CHERI targets (and Arm Morello). >> We use addrspace(2

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

yaxunl added a comment. In D103835#2999545 , @arichardson wrote: > Merging this change broke our out-of-tree CHERI targets (and Arm Morello). We > use addrspace(200) for *all* globals (including vtables). It would have been > nice if I had been added t

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#2991995 , @hjl.tools wrote: >>> The choice that high bits are unspecified rather than extended is an >>> interesting one. Can you speak to that? That's good for +, -, *, &, |, ^, >>> <<, and narrowing conversi

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999698 , @Eugene.Zelenko wrote: >> So you'd like to see that extra functionality added now? (I don't think it >> makes sense to have the check as-is in both `readability` and `modernize`.) > > There are plenty

  1   2   >