[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c7291cb25f: [OpenMP] Codegen aggregate for outlined function captures (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

chh updated this revision to Diff 359532. chh retitled this revision from "[clang-tidy] New feature --skip-headers, part 1, (tested as default)" to "[clang-tidy] New feature --skip-headers, part 1, setTraversalScope". chh edited the summary of this revision. chh added a comment. --skip-headers i

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, skip Decls

chh updated this revision to Diff 359531. chh retitled this revision from "[clang-tidy] New feature --skip-headers, (tested as default)" to "[clang-tidy] New feature --skip-headers, part 1, skip Decls". chh edited the summary of this revision. chh added a comment. --skip-headers is set to false

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

lbenes added a comment. Still seeing the same failure on OpenSUSE. I'm still on gcc 10.3. Should I need to upgrade for this to work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106119/new/ https://reviews.llvm.org/D106119 __

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

namazso created this revision. namazso added a project: clang. namazso requested review of this revision. Herald added a subscriber: cfe-commits. fix for behavior reported in https://bugs.llvm.org/show_bug.cgi?id=51100 workaround for root cause https://bugs.llvm.org/show_bug.cgi?id=16830 Reposi

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

NoQ added a comment. Looks great now! Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:416 + + return "Assuming that stream reaches end-of-file here"; +}); The word "that" looks redundant, we don't use it in any other similar notes, eg.

[PATCH] D106152: [analyzer] Remove test file as duplicated.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I have no opinion here. There's nothing wrong with having more tests and they don't look like exact duplicates of each other(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359516. Conanap marked an inline comment as done. Conanap added a comment. Moved pattern to a more appropriate place, updated test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 359507. ggeorgakoudis added a comment. Herald added a subscriber: zzheng. Rebase, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/li

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, (tested as default)

chh updated this revision to Diff 359506. chh retitled this revision from "[clang-tidy] New feature --skip-headers, part 1" to "[clang-tidy] New feature --skip-headers, part 1, (tested as default)". chh edited the summary of this revision. chh added a comment. to test skip-headers as default, do

[PATCH] D106204: [Lex] Consider a PCH header-guarded even with #endif truncated

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This seems to be a more useful behavior for to

[PATCH] D106203: [clangd] Propagate header-guarded flag from preamble to main AST

sammccall updated this revision to Diff 359499. sammccall added a comment. revert unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106203/new/ https://reviews.llvm.org/D106203 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-

[PATCH] D106203: [clangd] Propagate header-guarded flag from preamble to main AST

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clan

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

MaskRay added a comment. In D106119#2884915 , @lbenes wrote: > This one should work. > https://controlc.com/505d58d3 > > Please let me know if there's anything else that could help. Thanks. I forgot to add two `.keep` files to retain two otherwise empty

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

MaskRay updated this revision to Diff 359496. MaskRay added a comment. Add two .keep files to keep two directories Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106119/new/ https://reviews.llvm.org/D106119 Files: clang/lib/Driver/ToolChains/Gnu.

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

lbenes added a comment. This one should work. https://controlc.com/505d58d3 Please let me know if there's anything else that could help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106119/new/ https://reviews.llvm.org/D106119 _

[PATCH] D106201: [clangd] Add tests covering existing header-guard behavior. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. A few different mechanisms he

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77aec978a911: [CSSPGO] Turn on unique linkage name by default for pseudo probe. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 77aec97 - [CSSPGO] Turn on unique linkage name by default for pseudo probe.

Author: Hongtao Yu Date: 2021-07-16T16:43:23-07:00 New Revision: 77aec978a911254299640f9b10bdf1933986b96e URL: https://github.com/llvm/llvm-project/commit/77aec978a911254299640f9b10bdf1933986b96e DIFF: https://github.com/llvm/llvm-project/commit/77aec978a911254299640f9b10bdf1933986b96e.diff LO

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 _

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 359467. NeHuang added a comment. Herald added subscribers: llvm-commits, hiraditya. Address review comment to rework 32 bit handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.ll

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Sorry, I always forget when these are necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 __

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 359463. samitolvanen added a comment. Added `REQUIRES: x86-registered-target` to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 Files: llvm/lib/Transfo

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

MaskRay added a comment. In D106119#2884412 , @lbenes wrote: > Thanks for looking into this. On OpenSUSE i686, the failing tests are now > fixed, but Driver/linux-cross.cpp fails with: > > https://pastebin.com/uHfi3KD1 "This page is no longer available

[PATCH] D98709: [clang-tidy] New feature --skip-headers, (tested as default)

chh updated this revision to Diff 359461. chh edited the summary of this revision. chh added a comment. only coding style changes in clang-tidy files, to match other alternative implementation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98709/new/ https://reviews.llvm.org/D98709 Fil

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

mbenfield added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:739 DiagID = diag::warn_fortify_source_size_mismatch; -SizeIndex = TheCall->getNumArgs() - 1; -ObjectIndex = 0; +SourceSize = ComputeCheckVariantSize(TheCall->getNumArgs() - 1); +Des

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:427 + bool DisableOptimization) { assert(!CompileKernel || Recover); + return new HWAddressSanitizerLegacyPass(CompileKernel, R

[PATCH] D106184: [BPF] Use elementtype attribute for preserve.array/struct.index intrinsics

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106184/new/ https://reviews.llvm.org/D106184 ___

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen reopened this revision. samitolvanen added a comment. This revision is now accepted and ready to land. The tests that now specify a target triple also need `; REQUIRES: x86-registered-target` or they will obviously fail. I'll upload another revision. Repository: rG LLVM Github M

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

stefanp marked an inline comment as not done. stefanp added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9732 "argument should be an 8-bit value shifted by a multiple of 8 bits, or in the form 0x??FF">; +def err_argument_not_contiguous_bit_fie

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

stefanp updated this revision to Diff 359459. stefanp added a comment. Addressed a number of comments. Replaced with Ops[0], Ops[1] where possible. Rebased on top of the patch that defines SemaValueIsRunOfOnes. That patch is now comitted anyway. Merged a number of the test files. I was not able

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-pref

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

hoy added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-name

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

hoy added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-name

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

wenlei added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-n

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e3b5cb39eef: ThinLTO: Fix inline assembly references to static functions with CFI (authored by samitolvanen). Repository: rG LLVM Github Monorepo

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

hoy added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-name

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei updated this revision to Diff 359454. masoud.ataei added a comment. Remove extra function deceleration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 Files: clang/include/clang/Driver/Opt

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

wenlei added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-n

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

hoy created this revision. Herald added subscribers: modimo, wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Turning on -funique-internal-linkage-names when -fpseudo-probe-for-profiling is on, unless -fno-unique-internal-linkag

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35a18a981f6b: [PowerPC] Implement intrinsics for mtfsf[i] (authored by nemanjai, committed by lei). Changed prior to commit: https://reviews.llvm.

[clang] 35a18a9 - [PowerPC] Implement intrinsics for mtfsf[i]

Author: Nemanja Ivanovic Date: 2021-07-16T16:26:11-05:00 New Revision: 35a18a981f6b0f67899baec46be0086dc1aad757 URL: https://github.com/llvm/llvm-project/commit/35a18a981f6b0f67899baec46be0086dc1aad757 DIFF: https://github.com/llvm/llvm-project/commit/35a18a981f6b0f67899baec46be0086dc1aad757.di

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei created this revision. masoud.ataei added reviewers: bmahjour, Whitney, nemanjai, shchenz. masoud.ataei added projects: clang, LLVM. Herald added subscribers: ormris, dang. masoud.ataei requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits. Proposing a

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

mbenfield added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15737 + +// Fall through to slow path. + } cjdb wrote: > This comment is slightly different to the RHS: does that mean that a > diagnostic might not be issued? I just didn't find th

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1223-1225 +template <> +RangeSet SymbolicRangeInferrer::VisitBinaryOperator(Range LHS, Range RHS, + QualType T) { -

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 359441. quinnp added a comment. Fixing a run line in a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 359437. quinnp added a comment. Adding a better comment for the handling of the ppc_fsels intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/inc

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

lbenes added a comment. Thanks for looking into this. On OpenSUSE i686, the failing tests are now fixed, but Driver/linux-cross.cpp fails with: https://pastebin.com/uHfi3KD1 Would you like any more debugging info? gcc --print-multiarch is also empty. Repository: rG LLVM Github Monorepo

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap marked 4 inline comments as done. Conanap added a comment. Addressed comments Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:15 + // CHECK-LABEL: @test_lwarx // CHECK: %0 = tail call i32 asm sideeffect "lwarx $0, ${1:y}", "=r,*Z,~{memor

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359433. Conanap marked an inline comment as done. Conanap added a comment. Updated test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 Files: clang/include/c

[PATCH] D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Looks good. I was only a little confused by the first sentence of the option description. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-unnecessary-cop

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

MaskRay added inline comments. Comment at: clang/test/Driver/clang_f_opts.c:603 +// RUN: %clang -### -fno-call-graph-section %s 2>&1 | FileCheck -check-prefix=CHECK-NO-CALL-GRAPH-SECTION %s +// RUN: %clang -### %s 2>&1 | FileCheck -check-prefix=CHECK-NO-CALL-GRAPH-SECTION %s +/

[PATCH] D106184: [BPF] Use elementtype attribute for preserve.array/struct.index intrinsics

nikic added inline comments. Comment at: llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp:303 CInfo.RecordAlignment = DL->getABITypeAlign(CInfo.Base->getType()->getPointerElementType()); return true; I noticed too late that this intrinsic also u

[PATCH] D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:178-183 + if (VarTmplType->getReplacedParameter()->desugar().getCanonical

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 359426. quinnp marked 8 inline comments as done. quinnp added a comment. Addressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clan

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap updated this revision to Diff 359424. Conanap added a comment. added an error test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106130 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Ba

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

morehouse added inline comments. Comment at: clang/test/Driver/clang_f_opts.c:603 +// RUN: %clang -### -fno-call-graph-section %s 2>&1 | FileCheck -check-prefix=CHECK-NO-CALL-GRAPH-SECTION %s +// RUN: %clang -### %s 2>&1 | FileCheck -check-prefix=CHECK-NO-CALL-GRAPH-SECTION %s

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:15 + // CHECK-LABEL: @test_lwarx // CHECK: %0 = tail call i32 asm sideeffect "lwarx $0, ${1:y}", "=r,*Z,~{memory}"(i32* %a) return __lwarx(a); where is

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

jdoerfert accepted this revision. jdoerfert added a comment. LG from my side Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif JonChesterfield wrote: > jdoerfert wrote: > > estewart08 wrote

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

dexonsmith added a comment. In D105491#2882549 , @tmatheson wrote: > @dexonsmith I don't think they need upgraded. Most of the places I can see > referencing `!srcloc` are copying it around and will preserve the i32 type. > Cases which actually read the

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added a comment. In D105703#2884056 , @vitalybuka wrote: > In D105703#2883666 , @eugenis wrote: > >> Btw Vitaly, will this work with LTO out of the box? I think we used to add >> pre-LTO StackSafety pass

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

HazardyKnusperkeks added a comment. In D106112#2883301 , @curdeius wrote: > Looks okay, but I was wondering if we don't want to guard all K&R-related > changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce > strange bugs in newer mod

[PATCH] D104536: [clang][deps] Avoid minimizing PCH input files

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104536/new/ https://reviews.llvm.org/D104536 ___ cfe-commits mailing list cfe-

[PATCH] D106146: [clang][deps] Separate filesystem caches for minimized and original files

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:165 - if (const CachedFileSystemEntry *Entry = getCachedEntry(Filename)) {

[PATCH] D106064: [clang][deps] Normalize paths in minimizing file system

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:161-162 +const StringRef RawFilename) { + llvm::SmallString<256> Filename; + llvm::sys::path::native(RawFilename, Filename); + I'm a bit ner

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2883666 , @eugenis wrote: > Btw Vitaly, will this work with LTO out of the box? I think we used to add > pre-LTO StackSafety pass explicitly for memtag only, but it looks like that > code is gone. What do you mean

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

jdoerfert accepted this revision. jdoerfert added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://reviews.llvm.org/D105221 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D106074: [AIX] Emit unsupported 128-bit long double option for AIX

anjankgk added a comment. Thanks for reviewing! Can someone with commit access help commit this pls? Thanks in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106074/new/ https://reviews.llvm.org/D106074

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

dexonsmith added a comment. In D105959#2883954 , @mehdi_amini wrote: > That's interesting! > > I'm not sure how to get there though: a complete solution should be able to > "degrade" to global constructor when the platform-specific logic isn't > availa

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

jrtc27 added a comment. It's just a standard linker set; the static linker combines all the input sections containing the array elements into a single output section. It's similar to init_array etc, just without the special meaning (i.e. you have to write the code to iterate over the array and

[PATCH] D106120: [PowerPC] Implement vector bool/pixel initialization under -faltivec-src-compat=xl

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM other than a minor nit about a comment. Comment at: clang/include/clang/Sema/Sema.h:6112-6115 + // Checks if we have a valid AltiVec vector type, and splats the +

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

nemanjai added a comment. Could you please add a check for constant arguments to `clang/test/CodeGen/builtins-ppc-xlcompat-error.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106130 __

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil added a comment. In D105909#2878378 , @morehouse wrote: > Also, have you looked into operand bundles > instead of metadata? I don't > know much about them, but they might help with the > optimi

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:4072 + +def : Pat<(int_ppc_stfiw ForceXForm:$dst, f64:$XT), + (STXSIWX f64:$XT, ForceXForm:$dst)>; I just realized this is in the wrong place. STXSIWX was added in Power8

[PATCH] D106172: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil abandoned this revision. necipfazil added a comment. Please disregard this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106172/new/ https://reviews.llvm.org/D106172 ___ cfe-commits

[PATCH] D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check.

flx created this revision. flx added reviewers: aaron.ballman, ymandel, gribozavr2. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add string list option of type names analagous to `All

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

mehdi_amini added a comment. Something else I'm not sure about is how it works across DSOs: when each LLVM library is linked into its own shared library, is the dynamic linker creating this array when loading the libraries? (I'm starting to doubt about how this would even work on windows) Repo

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

mehdi_amini added a comment. That's interesting! I'm not sure how to get there though: a complete solution should be able to "degrade" to global constructor when the platform-specific logic isn't available (unless we're confident that no such environment can exist?). Repository: rG LLVM Git

[PATCH] D106172: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil created this revision. Herald added subscribers: dexonsmith, hiraditya. necipfazil requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Create and add generalized type identifier metadata to indirect calls, and to fu

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil updated this revision to Diff 359401. necipfazil added a comment. Herald added subscribers: dexonsmith, hiraditya. Herald added a project: LLVM. Use operand bundles for callsite type ids - Use (unlossy) operand bundles for propagating indirect callsite type ids - No longer use type met

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15586 + case PPC::BI__builtin_ppc_mfspr: { +llvm::Type *RetType = CGM.getDataLayout().getTypeSizeInBits(VoidPtrTy) == 32 + ? Int32Ty nemanjai wrote: > Is

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

Conanap updated this revision to Diff 359400. Conanap marked 4 inline comments as done. Conanap added a comment. Changed `i32` to `timm` for patterns, some nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp updated this revision to Diff 359398. quinnp added a comment. Adding a `REQUIRES: powerpc-registered-target` to a testcase and removing checks for `entry:` in front end test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ ht

[PATCH] D105930: [PowerPC] Implement XL compact math builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8937b6cb975: [PowerPC] Implement XL compact math builtins (authored by lei). Changed prior to commit: https://reviews.llvm.org/D105930?vs=359070&

[clang] c8937b6 - [PowerPC] Implement XL compact math builtins

Author: Lei Huang Date: 2021-07-16T13:21:13-05:00 New Revision: c8937b6cb9751807de1e69f0f0f70a9a58f8f5dc URL: https://github.com/llvm/llvm-project/commit/c8937b6cb9751807de1e69f0f0f70a9a58f8f5dc DIFF: https://github.com/llvm/llvm-project/commit/c8937b6cb9751807de1e69f0f0f70a9a58f8f5dc.diff LOG

[PATCH] D105959: Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

dexonsmith added a comment. In D105959#2882136 , @mehdi_amini wrote: > In D105959#2882099 , @bondhugula > wrote: > >> This is a really welcome change! Multiple registration issues were really an >> inconvenienc

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

pcc accepted this revision. pcc added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked 9 inline comments as done. masoud.ataei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1370 + // to be consistent to PPCGenScalarMASSEntries pass + if (TM.Options.PPCGenScalarMASSEntries && TM.Options.ApproxFuncFPMath) { +

[PATCH] D105939: [OpenMP] Add IDs to OpenMP remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c31d5ebfbbb: [OpenMP] Add IDs to OpenMP remarks (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D105939?vs=358461&id=359

[clang] 2c31d5e - [OpenMP] Add IDs to OpenMP remarks

Author: Joseph Huber Date: 2021-07-16T14:07:03-04:00 New Revision: 2c31d5ebfbbb36de37d41b6945d0c45efa512790 URL: https://github.com/llvm/llvm-project/commit/2c31d5ebfbbb36de37d41b6945d0c45efa512790 DIFF: https://github.com/llvm/llvm-project/commit/2c31d5ebfbbb36de37d41b6945d0c45efa512790.diff

[PATCH] D105898: [OpenMP] Rework OpenMP remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeef6601b0fb6: [OpenMP] Rework OpenMP remarks (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D105898?vs=359319&id=359390#

[clang] eef6601 - [OpenMP] Rework OpenMP remarks

Author: Joseph Huber Date: 2021-07-16T14:07:00-04:00 New Revision: eef6601b0fb6d5fee32627e07be4acbf769e5c0f URL: https://github.com/llvm/llvm-project/commit/eef6601b0fb6d5fee32627e07be4acbf769e5c0f DIFF: https://github.com/llvm/llvm-project/commit/eef6601b0fb6d5fee32627e07be4acbf769e5c0f.diff

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei updated this revision to Diff 359385. masoud.ataei added a comment. Removed clang changes from this PR. Removed extra option for MASS pass. Now MASS pass is active with -O3 and approx-func option. Adding another PR for clang changes on approx-func option. Repository: rG LLVM Gith

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added a comment. In D104058#2883804 , @nickdesaulniers wrote: > In D104058#2878083 , @samitolvanen > wrote: > >> In D104058#2877631 , >> @nickdesaulniers w

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added a comment. In D104058#2878083 , @samitolvanen wrote: > In D104058#2877631 , > @nickdesaulniers wrote: > >> Change LGTM, but I don't understand why the following tests are modified: >> >> -

[PATCH] D106065: [Clang] Add an empty builtins.h file.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf4b81d57b0: [Clang] Add an empty builtins.h file. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 0bf4b81 - [Clang] Add an empty builtins.h file.

Author: Stefan Pintilie Date: 2021-07-16T12:50:04-05:00 New Revision: 0bf4b81d57b0b4d1ecc2752be3e4ad1504ee1eb3 URL: https://github.com/llvm/llvm-project/commit/0bf4b81d57b0b4d1ecc2752be3e4ad1504ee1eb3 DIFF: https://github.com/llvm/llvm-project/commit/0bf4b81d57b0b4d1ecc2752be3e4ad1504ee1eb3.dif

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 359380. Conanap added a comment. Updated a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Ba

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

vsavchenko added a comment. In D106136#2883100 , @martong wrote: > Thanks for taking your time to take a look. And I accept your statements. > Nevertheless, let me explain my motivation. > > I thought that a class is trivial if it has only one member. An

  1   2   >