NoQ added a comment. Looks great now!
================ Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:416 + + return "Assuming that stream reaches end-of-file here"; + }); ---------------- The word "that" looks redundant, we don't use it in any other similar notes, eg. "Assuming ~~that~~ 'ptr' is null" etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104925/new/ https://reviews.llvm.org/D104925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits