masoud.ataei marked 9 inline comments as done.
masoud.ataei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1370
+  // to be consistent to PPCGenScalarMASSEntries pass
+  if (TM.Options.PPCGenScalarMASSEntries && TM.Options.ApproxFuncFPMath) {
+    if (TM.Options.NoInfsFPMath && TM.Options.NoNaNsFPMath &&
----------------
bmahjour wrote:
> if someone compiles with -Ofast without any extra options, would 
> `TM.Options.ApproxFuncFPMath` be true here?
In clang changes, I had `Options.ApproxFuncFPMath = LangOpts.ApproxFunc;` in 
`clang/lib/CodeGen/BackendUtil.cpp`. That was responsible to update this TM 
option based on the clang approximate func option. And clang approximate func 
option will be set with -Ofast. 

Then, the answer for your question is yes. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101759/new/

https://reviews.llvm.org/D101759

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to