stefanp marked an inline comment as not done. stefanp added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9732 "argument should be an 8-bit value shifted by a multiple of 8 bits, or in the form 0x??FF">; +def err_argument_not_contiguous_bit_field : Error< + "argument %0 value should represent a contiguous bit field">; ---------------- nemanjai wrote: > I think this comes from another patch that is up for review. You should base > this patch on top of that patch and mark the review as a dependency. It makes > the review easier if the review only contains code that is meant to go in > this commit. Yes it does. That patch has actually already gone in so I've just rebased on top of it and solved this issue that way. ================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15257-15258 + const Expr *Ptr = E->getArg(1); + Value *PtrValue = EmitScalarExpr(Ptr); + Value *AlignmentValue = EmitScalarExpr(E->getArg(0)); + ConstantInt *AlignmentCI = cast<ConstantInt>(AlignmentValue); ---------------- nemanjai wrote: > Are these two just `Ops[0], Ops[1]`? Yes they are. I will replace where possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104386/new/ https://reviews.llvm.org/D104386 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
