ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.
Nice!
================
Comment at:
clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:178-183
+ if (VarTmplType->getReplacedParameter()->desugar().getCanonicalType() !=
+ InitializerTmplType->getReplacedParameter()
+ ->desugar()
+ .getCanonicalType()) {
+ return true;
+ }
----------------
nit: maybe just return the condition (instead of using if(...) return true)?
that is
return VarTmpType->... != ...
================
Comment at:
clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:271
+ // template instantiation where the substituted types are the same, but
+ // instantiations where the types differ and rely on implicit convertion
would
+ // no longer compile if we switched to a reference.
----------------
typo: conversion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106011/new/
https://reviews.llvm.org/D106011
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
