[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300451. tianshilei1992 added a comment. Reverted changes for target data. It will be in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: c

[clang] 74910cb - HeaderSearch: Simplify use of FileEntryRef in HeaderSearch::LookupFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T22:10:50-04:00 New Revision: 74910cbbd8d1df824ab1d5e742c50641d0fee907 URL: https://github.com/llvm/llvm-project/commit/74910cbbd8d1df824ab1d5e742c50641d0fee907 DIFF: https://github.com/llvm/llvm-project/commit/74910cbbd8d1df824ab1d5e742c50641d0fe

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added a comment. I missed adding to llvm/lib/Bitcode/Reader/BitcodeReader.cpp, so LTO is broken with this fn attribute...todo...fix diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index f8069b93103f..a99d6baa8d9d 100644 --

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

dexonsmith marked an inline comment as done. dexonsmith added a comment. Committed in 434f3774f629f5896614e9efb4eda82d813402ed . Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222 if (File)

[clang-tools-extra] 434f377 - clangd: Stop calling FileEntryRef::FileEntryRef

Author: Duncan P. N. Exon Smith Date: 2020-10-23T21:28:09-04:00 New Revision: 434f3774f629f5896614e9efb4eda82d813402ed URL: https://github.com/llvm/llvm-project/commit/434f3774f629f5896614e9efb4eda82d813402ed DIFF: https://github.com/llvm/llvm-project/commit/434f3774f629f5896614e9efb4eda82d8134

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

dexonsmith added a comment. Thanks for the review! @JDevlieghere, let me know if the updated patch looks good to you too (also the prep commit). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89580/new/ https://reviews.llvm.org/D89580 ___ cfe

[clang] 81ac81f - FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T20:47:15-04:00 New Revision: 81ac81f8644a7c6ed19bea95385794f7870d0fda URL: https://github.com/llvm/llvm-project/commit/81ac81f8644a7c6ed19bea95385794f7870d0fda DIFF: https://github.com/llvm/llvm-project/commit/81ac81f8644a7c6ed19bea95385794f7870d

[PATCH] D89521: FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG81ac81f8644a: FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300443. tianshilei1992 added a comment. Fixed the issue using a way that no need to change test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: cl

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 300438. akhuang added a comment. Fix test failures; remove assert for signed APSInts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files: clang/lib/CodeGen/CGDebug

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222 if (File) // FIXME: Use correctly named FileEntryRef. +Delegate->FileSkipp

[clang] ccca93b - Don't allow structured binding declarations to decompose a

Author: Richard Smith Date: 2020-10-23T16:28:25-07:00 New Revision: ccca93b5a2cb284dcdfecd34db1ca14632d6a1c1 URL: https://github.com/llvm/llvm-project/commit/ccca93b5a2cb284dcdfecd34db1ca14632d6a1c1 DIFF: https://github.com/llvm/llvm-project/commit/ccca93b5a2cb284dcdfecd34db1ca14632d6a1c1.diff

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added a comment. Whoops, forgot to check the tests. Apparently `mapEncodedInteger` asserts if a signed APInt is not less than 0. I just removed the assert because it doesn't seem necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D90079: CGLoopInfo: Avoid unnecessary uses of `MDNode::getTemporary`, NFC

dexonsmith added a comment. BTW, this is a long-delayed follow-up to 5e5b85098dbeaea2cfa5d01695b5d2982634d7dd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90079/new/ https://reviews.llvm.org/D90079 ___ cfe-commits mailing list cfe-commits@

[PATCH] D90079: CGLoopInfo: Avoid unnecessary uses of `MDNode::getTemporary`, NFC

dexonsmith added a comment. https://github.com/llvm/llvm-project/blob/master/llvm/lib/IR/Metadata.cpp#L716 is where the auto-detection of self-references is: // Drop uniquing for self-reference cycles and deleted constants. if (New == this || (!New && Old && isa(Old))) { if (!isResolved(

[PATCH] D90079: CGLoopInfo: Avoid unnecessary uses of `MDNode::getTemporary`, NFC

dexonsmith created this revision. dexonsmith added reviewers: dblaikie, aprantl. Herald added a reviewer: bollu. Herald added subscribers: ributzka, hiraditya, kristof.beyls. Herald added a project: LLVM. dexonsmith requested review of this revision. `TempMDNode` includes a bunch of machinery for

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 300421. DiggerLin added a comment. delete asm test case from clang/test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOpti

[clang] 71e1a56 - [CodeGen] Emit destructor calls to destruct non-trivial C struct

Author: Akira Hatanaka Date: 2020-10-23T14:46:17-07:00 New Revision: 71e1a56de153536b9ff655fe740ccbf3f6b1faf0 URL: https://github.com/llvm/llvm-project/commit/71e1a56de153536b9ff655fe740ccbf3f6b1faf0 DIFF: https://github.com/llvm/llvm-project/commit/71e1a56de153536b9ff655fe740ccbf3f6b1faf0.diff

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e1a56de153: [CodeGen] Emit destructor calls to destruct non-trivial C struct (authored by ahatanak, committed by --local ).

[clang] cb9b984 - PR47954 / DR2126: permit temporary objects that are lifetime-extended by

Author: Richard Smith Date: 2020-10-23T14:29:18-07:00 New Revision: cb9b9842d31d6082c6a2259a64eb5d47bd680d32 URL: https://github.com/llvm/llvm-project/commit/cb9b9842d31d6082c6a2259a64eb5d47bd680d32 DIFF: https://github.com/llvm/llvm-project/commit/cb9b9842d31d6082c6a2259a64eb5d47bd680d32.diff

[PATCH] D83812: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

leonardchan updated this revision to Diff 300410. leonardchan retitled this revision from "[clang][RelativeVTablesABI] Do not emit stubs for architectures that support a PLT relocation" to "[clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs". leonardchan edited the s

[PATCH] D81508: [PowerPC] Add __vector_pair and __vector_quad types

bsaleil updated this revision to Diff 300408. bsaleil added a comment. Herald added a subscriber: dexonsmith. Rebasing the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81508/new/ https://reviews.llvm.org/D81508 Files: clang/include/clang/

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes updated this revision to Diff 300402. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/unittests/clang-tidy/Inc

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane updated this revision to Diff 300396. erichkeane added a comment. Alright, I have the multi-emit dealt with, and the problems that come with that solved. This doesn't do the MSVC-emit-for-all-CCs thing, but I intend to do that in a separate patch with the same infrastructure. CHANG

[PATCH] D83088: Introduce CfgTraits abstraction

mehdi_amini added a comment. In D83088#2350287 , @nhaehnle wrote: > Hi Mehdi, this is not an appropriate place for this discussion. Yes, we have > a general rule that patches can be reverted if they're obviously broken (e.g. > build bot problems) or clea

[PATCH] D90073: [Clang][CodeGen] fix failed assertion

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4643 + D->getType().isConstQualified()); +else if (isa(GD.getDecl())) + LT = getFunctionLinkage(GD); I'd suggest making this just 'els

[clang] 2b7dfdd - Fix typo in diagnostic name.

Author: Richard Smith Date: 2020-10-23T13:21:21-07:00 New Revision: 2b7dfdd319c0e6e3a8934bcf4019f402d63f7539 URL: https://github.com/llvm/llvm-project/commit/2b7dfdd319c0e6e3a8934bcf4019f402d63f7539 DIFF: https://github.com/llvm/llvm-project/commit/2b7dfdd319c0e6e3a8934bcf4019f402d63f7539.diff

[PATCH] D90063: [AIX] Also error on -G for link-only step

Xiangling_L updated this revision to Diff 300391. Xiangling_L added a comment. Fixed the duplication in the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90063/new/ https://reviews.llvm.org/D90063 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers added a comment. In D66492#2350947 , @iajbar wrote: > Clang crashes when calling getLLVMLinkageVarDefinition() in > EmitAliasDefinition() when compiling this testcase: > enum a_type { a , b, c}; > typedef enum a_type b_type; > void foo(b_t

[PATCH] D90073: [Clang][CodeGen] fix failed assertion

nickdesaulniers created this revision. nickdesaulniers added reviewers: aaron.ballman, iajbar. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers requested review of this revision. Via bugreport: https://reviews.llvm.org/D66492#2350947 Repository: rG LLVM Gi

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:30-34 +// COMMON-ASM: mflr 0 +// COMMON-ASM-NEXT:stw 0, 8(1) +// COMMON-ASM-NEXT:stwu 1, -64(1) +// COMMON-ASM-NEXT:bl ._Z1fv +// NOP-ASM-NEXT: nop ---

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

DiggerLin updated this revision to Diff 300383. DiggerLin added a comment. Herald added a subscriber: dexonsmith. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

DiggerLin added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:30-34 +// COMMON-ASM: mflr 0 +// COMMON-ASM-NEXT:stw 0, 8(1) +// COMMON-ASM-NEXT:stwu 1, -64(1) +// COMMON-ASM-NEXT:bl ._Z1fv +// NOP-ASM-NEXT: nop

[PATCH] D90063: [AIX] Also error on -G for link-only step

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-err-options.c:14-15 + // RUN: %clang -target powerpc64-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \ // RUN: FileCheck --check-prefix=CHECK64 %s +// RUN: %clang -target powerpc64-ibm-aix-xcof

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added a comment. > Yes, there are no generically available libcalls for atomic float math -- but > that's okay -- let LLVM handle transform into a cmpxchg loop when required. I suspect Yaxun's target cannot provide libcalls at all, which is why he wants to diagnose up-front. But I agr

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes added a comment. In D89608#2336596 , @gribozavr2 wrote: > Any chance of adding a test? Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 __

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes updated this revision to Diff 300380. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/unittests/clang-tidy/Inc

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

dexonsmith updated this revision to Diff 300377. dexonsmith added a comment. Rebased on top of https://reviews.llvm.org/D89580, which implements @JDevlieghere's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89580/new/ https://reviews.llvm.org/D89580 Files: clang/include/

[PATCH] D90067: SourceManager: Return non-const references in getOrCreateContentCache and related, NFC

dexonsmith created this revision. dexonsmith added a reviewer: JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update a few APIs to return non-const references instead of pointers, and remove associated `const_cast`s and non-null assertions. https

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

rnk added a comment. It seems like there are related test failures according to the Phabricator/Jenkins automation. Is that a true positive? Please confirm either way before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https:

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300371. tianshilei1992 added a comment. Removed useless code and fixed some cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: clang/lib/CodeGen/CGSt

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers added a comment. In D66492#2350947 , @iajbar wrote: > Clang crashes when calling getLLVMLinkageVarDefinition() in > EmitAliasDefinition() when compiling this testcase: > enum a_type { a , b, c}; > typedef enum a_type b_type; > void foo(b_t

[clang] cf52a85 - SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T14:56:41-04:00 New Revision: cf52a85ddc9be165daca3d32521747c898f4ffd1 URL: https://github.com/llvm/llvm-project/commit/cf52a85ddc9be165daca3d32521747c898f4ffd1 DIFF: https://github.com/llvm/llvm-project/commit/cf52a85ddc9be165daca3d32521747c898f4

[PATCH] D89922: SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf52a85ddc9b: SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7926ce6d7a8: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch (authored by nickdesaulniers). Repository: rG LLVM Github Mono

[clang] b7926ce - [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

Author: Nick Desaulniers Date: 2020-10-23T11:55:39-07:00 New Revision: b7926ce6d7a83cdf70c68d82bc3389c04009b841 URL: https://github.com/llvm/llvm-project/commit/b7926ce6d7a83cdf70c68d82bc3389c04009b841 DIFF: https://github.com/llvm/llvm-project/commit/b7926ce6d7a83cdf70c68d82bc3389c04009b841.di

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG05bef88eb3ec: [AIX] Let alloca return 16 bytes alignment (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/ https://reviews

[clang] 05bef88 - [AIX] Let alloca return 16 bytes alignment

Author: Xiangling Liao Date: 2020-10-23T14:41:32-04:00 New Revision: 05bef88eb3ecb8519a871ca9aa53caeca5add555 URL: https://github.com/llvm/llvm-project/commit/05bef88eb3ecb8519a871ca9aa53caeca5add555 DIFF: https://github.com/llvm/llvm-project/commit/05bef88eb3ecb8519a871ca9aa53caeca5add555.diff

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

iajbar added a comment. Clang crashes when calling getLLVMLinkageVarDefinition() in EmitAliasDefinition() when compiling this testcase: enum a_type { a , b, c}; typedef enum a_type b_type; void foo(b_type x, enum a_type y){} void bar(b_type x, enum b_type y) __attribute__ ((alias ("foo"))); Decl

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. In D71726#2207700 , @yaxunl wrote: > clang does not always emit atomic instructions for atomic builtins. Clang may > emit lib calls for atomic builtins. Basically clang checks target info about > max atomic inline width and if t

[PATCH] D90063: [AIX] Also error on -G for link-only step

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, daltenty, jasonliu. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. Xiangling_L requested review of this revision. The change in [[ https://reviews.llvm.org/D89897 | [AI

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added inline comments. Comment at: clang/test/CodeGen/aarch64-v8.2a-neon-intrinsics-constrained.c:26 +// metadata from the AST instead of the global default from the command line. +// FIXME: All cases of "fpexcept.maytrap" in this test are wrong. + kpn wrote:

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:154-155 + OldRounding = CGF.Builder.getDefaultConstrainedRounding(); if (OldFPFeatures == FPFeatures) return; sepavloff wrote: > This check can be lifted to just after the def

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added a comment. In D71726#2207700 , @yaxunl wrote: > clang does not always emit atomic instructions for atomic builtins. Clang may > emit lib calls for atomic builtins. Basically clang checks target info about > max atomic inline width and if t

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

eduucaldas added a comment. Thanks Sam! I learned a lot from your patch ^^ Comment at: clang/include/clang/Tooling/Syntax/Tree.h:157-184 + /// Iterator over children (common base for const/non-const). + /// Not invalidated by tree mutations (holds a stable node pointer). + t

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

rjmccall added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:57 +Constant, // sycl_constant +Private, // sycl_private Generic, // ptr32_sptr I feel like we may be outgrowing these address-space map arrays. Comme

[PATCH] D89982: [analyzer] [NFC] Simplify SVal::getAsLocSymbol function using existing functions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks correct, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89982/new/ https://reviews.llvm.org/D89982 _

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

NoQ added a comment. Honestly i'd rather eliminate `SymExpr` and go with `Symbol` everywhere. It's an overloaded term but appending "Expr" to it doesn't really make it significantly less overloaded. We're also properly namespaced so there wouldn't be any linking issues with the rest of LLVM. "S

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83448/new/ https://reviews.llvm.org/D83448

[PATCH] D89914: SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG5431c37b55e2: SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache… (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89

[clang] 5431c37 - SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T13:22:47-04:00 New Revision: 5431c37b55e2c2952b6b56c9690bd1ce05b23c7e URL: https://github.com/llvm/llvm-project/commit/5431c37b55e2c2952b6b56c9690bd1ce05b23c7e DIFF: https://github.com/llvm/llvm-project/commit/5431c37b55e2c2952b6b56c9690bd1ce05b2

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

dexonsmith added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088 + ID.Add(Range.getEnd()); + ID.Add(static_cast(Loc)); } I'm surprised you need this `static_cast`, can you explain why it was necessary? Repository: rG LLVM Github Mon

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. IOW, the goal of formalizing would just be to: - error if the `.td` file defined options in the wrong order to get correct parsing - automatically generate the code for default value, instead of having to re-type the name of the keypath CHANGES SINCE LAST ACTION

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. In D82756#2350233 , @jansvoboda11 wrote: > Correct me if I'm wrong, but when generating the command line, all "implied" > flags would be hidden, even if they were explicit in the original comand line: > > - original command li

[clang] e7fe125 - [CUDA] Extract CUDA version from cuda.h if version.txt is not found

Author: Artem Belevich Date: 2020-10-23T10:03:30-07:00 New Revision: e7fe125b776bf08d95e60ff3354a5c836218a0e6 URL: https://github.com/llvm/llvm-project/commit/e7fe125b776bf08d95e60ff3354a5c836218a0e6 DIFF: https://github.com/llvm/llvm-project/commit/e7fe125b776bf08d95e60ff3354a5c836218a0e6.diff

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG65d206484c54: [CUDA] Improve clang's ability to detect recent CUDA versions. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ htt

[clang] 65d2064 - [CUDA] Improve clang's ability to detect recent CUDA versions.

Author: Artem Belevich Date: 2020-10-23T10:03:29-07:00 New Revision: 65d206484c54177641d4b11d42cab1f1acc8c0c7 URL: https://github.com/llvm/llvm-project/commit/65d206484c54177641d4b11d42cab1f1acc8c0c7 DIFF: https://github.com/llvm/llvm-project/commit/65d206484c54177641d4b11d42cab1f1acc8c0c7.diff

[clang] dbbc4f4 - SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

Author: Duncan P. N. Exon Smith Date: 2020-10-23T12:55:51-04:00 New Revision: dbbc4f4e226be44e484f448be2d308d205c81038 URL: https://github.com/llvm/llvm-project/commit/dbbc4f4e226be44e484f448be2d308d205c81038 DIFF: https://github.com/llvm/llvm-project/commit/dbbc4f4e226be44e484f448be2d308d205c8

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbbc4f4e226b: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:118 + private: +unsigned *Storage = nullptr; + }; JDevlieghere wrote: > I guess it's implicit in the implementation, but maybe it's worth adding a > comment describing

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

dexonsmith planned changes to this revision. dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:293 X.ContentAndKind.setInt(FileCharacter); - X.Filename = Filename; + const_cast(Con).Filename = Filename; return X; -

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG74a878348021: SourceManager: Clarify that FileInfo always has a ContentCache, NFC (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89554?vs=298

[clang] 74a8783 - SourceManager: Clarify that FileInfo always has a ContentCache, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T12:38:53-04:00 New Revision: 74a8783480219f5f0e5c4673a6d0e29b4ad99877 URL: https://github.com/llvm/llvm-project/commit/74a8783480219f5f0e5c4673a6d0e29b4ad99877 DIFF: https://github.com/llvm/llvm-project/commit/74a8783480219f5f0e5c4673a6d0e29b4ad9

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra added a comment. In D89832#2349915 , @emankov wrote: > I confirm that D89752 eliminates 47332 > on Windows. Tested against the > following CUDA versions: 7.0, 7,5, 9,2, 1

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

steakhal added a comment. In D89987#2349959 , @ASDenysPetrov wrote: > @OikawaKirie > >> Different from ProgramStateRef which is an alias to IntrusiveRefCntPtr, or >> StoreRef which is a wrapper object, an alias to a const SymExpr * makes no >> sense to

[PATCH] D90047: [clangd] Fix remote-server build and add it to check-clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dd39923a09e: [clangd] Fix remote-server build and add it to check-clangd (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90047/new/ h

[clang-tools-extra] 5dd3992 - [clangd] Fix remote-server build and add it to check-clangd

Author: Kadir Cetinkaya Date: 2020-10-23T18:08:02+02:00 New Revision: 5dd39923a09ec284d30083e5fadaa29e618d4446 URL: https://github.com/llvm/llvm-project/commit/5dd39923a09ec284d30083e5fadaa29e618d4446 DIFF: https://github.com/llvm/llvm-project/commit/5dd39923a09ec284d30083e5fadaa29e618d4446.dif

[PATCH] D90054: Added remotely ran compiler-rt tests.

aorlov created this revision. aorlov added reviewers: vvereschaka, broadwaylamb. aorlov added a project: LLVM. Herald added subscribers: cfe-commits, mgorny, dberris. Herald added a project: clang. aorlov requested review of this revision. Use LLVM/utils/remote-exec.py to run compiler-rt tests rem

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, teemperor. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Change the `InputFile` class to store a `MaybeFileEntryRef` instead of `FileEntry*`. This paged in a few API changes:

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2858 TransferMedium = new llvm::GlobalVariable( -M, Ty, /*isConstant=*/false, llvm::GlobalVariable::CommonLinkage, -llvm::Constant::getNullValue(Ty), TransferMediumName, +

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2858 TransferMedium = new llvm::GlobalVariable( -M, Ty, /*isConstant=*/false, llvm::GlobalVariable::CommonLinkage, -llvm::Constant::getNullValue(Ty), TransferMediumName, +

[PATCH] D83088: Introduce CfgTraits abstraction

arsenm added a comment. In D83088#2348641 , @mehdi_amini wrote: > In D83088#2347111 , @arsenm wrote: > >> In D83088#2346322 , @mehdi_amini >> wrote: >> >>> In D83088#2345540

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. Hi Mehdi, this is not an appropriate place for this discussion. Yes, we have a general rule that patches can be reverted if they're obviously broken (e.g. build bot problems) or clearly violate some other standard. This is a good rule, but it doesn't apply here. If you

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. @dexonsmith, thanks for sharing your idea. Overall, I like the simplicity. As you say, not every command line option has an associated `CodeGenOptions` or `LangOptions` field. For this patch only, we'd need to create the following fields: - `CLUnsafeOptimizations`

[PATCH] D90047: [clangd] Fix remote-server build and add it to check-clangd

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90047/new/ https://reviews.llvm.org/D90047 __

[PATCH] D89814: [TableGen] Change !getop and !setop to !getdagop and !setdagop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876af264c118: [TableGen] Change !getop and !setop to !getdagop and !setdagop. (authored by Paul-C-Anagnostopoulos). Changed prior to commit: https

[PATCH] D90047: [clangd] Fix remote-server build and add it to check-clangd

kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Gith

[clang] 876af26 - [TableGen] Change !getop and !setop to !getdagop and !setdagop.

Author: Paul C. Anagnostopoulos Date: 2020-10-23T10:36:05-04:00 New Revision: 876af264c118c6ebcb8d79ab1a25d061f98fde82 URL: https://github.com/llvm/llvm-project/commit/876af264c118c6ebcb8d79ab1a25d061f98fde82 DIFF: https://github.com/llvm/llvm-project/commit/876af264c118c6ebcb8d79ab1a25d061f98f

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf55eeea4024c: Export TemplateArgumentMatcher so clients defining custom matchers don't need… (authored by davidvancleve, committed by sammccall). R

[clang] f55eeea - Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

Author: David Van Cleve Date: 2020-10-23T16:13:56+02:00 New Revision: f55eeea4024cb05bff2c9f72968f23183e992a32 URL: https://github.com/llvm/llvm-project/commit/f55eeea4024cb05bff2c9f72968f23183e992a32 DIFF: https://github.com/llvm/llvm-project/commit/f55eeea4024cb05bff2c9f72968f23183e992a32.dif

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx added a comment. I should note that I was only able to reproduce the false positive with the actual implementation std::function and not our fake version here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 300276. flx added a comment. Revert -std=c++17 change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp c

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 300274. flx added a comment. Remove code comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp clang-

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx created this revision. flx added reviewers: aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. flx requested review of this revision. This fixes false positive cases where a non-const reference is passed to a std::function but interprete

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

ASDenysPetrov added a comment. @OikawaKirie > Different from ProgramStateRef which is an alias to IntrusiveRefCntPtr, or > StoreRef which is a wrapper object, an alias to a const SymExpr * makes no > sense to me. Yes. I omit this, because in such case we should go further and rename all those

[clang-tools-extra] ce63383 - [clangd] Drop version from remote index proto names, fix clangd-index-server

Author: Sam McCall Date: 2020-10-23T15:28:11+02:00 New Revision: ce63383e45f4c833dbff6a89b242bfd1d188786e URL: https://github.com/llvm/llvm-project/commit/ce63383e45f4c833dbff6a89b242bfd1d188786e DIFF: https://github.com/llvm/llvm-project/commit/ce63383e45f4c833dbff6a89b242bfd1d188786e.diff LO

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Hi @aaron.ballman, Thank you for the suggestion. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:237 +static void getHungarianNotationDefaultConfig( +std::shared_ptr HNOption) { + aaron.ballman wrot

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov added a comment. I confirm that D89752 eliminates 47332 on Windows. Tested against the following CUDA versions: 7.0, 7,5, 9,2, 10.0, 10,1, 10.2, 11.0 Update 1, 11.1. Repository: rG LLVM Github Monorepo C

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2858 TransferMedium = new llvm::GlobalVariable( -M, Ty, /*isConstant=*/false, llvm::GlobalVariable::CommonLinkage, -llvm::Constant::getNullValue(Ty), TransferMediumName, +

[clang-tools-extra] e6c1c3f - [clang] Split remote index service definition into a separate file.

Author: Sam McCall Date: 2020-10-23T15:20:51+02:00 New Revision: e6c1c3f97f13b7d973fa786a3f2da883fa31bdf6 URL: https://github.com/llvm/llvm-project/commit/e6c1c3f97f13b7d973fa786a3f2da883fa31bdf6 DIFF: https://github.com/llvm/llvm-project/commit/e6c1c3f97f13b7d973fa786a3f2da883fa31bdf6.diff LO

  1   2   >