arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222
       if (File)
         // FIXME: Use correctly named FileEntryRef.
+        Delegate->FileSkipped(*File, SynthesizedFilenameTok, Inc.FileKind);
----------------
You can drop the FIXME here now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89514/new/

https://reviews.llvm.org/D89514

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D89514: cl... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8951... Alex Lorenz via Phabricator via cfe-commits
    • [PATCH] D8951... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to