mehdi_amini added a comment. In D83088#2350287 <https://reviews.llvm.org/D83088#2350287>, @nhaehnle wrote:
> Hi Mehdi, this is not an appropriate place for this discussion. Yes, we have > a general rule that patches can be reverted if they're obviously broken (e.g. > build bot problems) or clearly violate some other standard. This is a good > rule, but it doesn't apply here. If you think it does, please state your case > in the email thread that I've started on llvm-dev for this very purpose. Just > one thing: I strongly disagree: the bar for post-review commit is not lower than pre-commit review. Again: please revert when someone has a concern, including a *design* concern with you patch. > P.S.: It's easy to miss on Phabricator, but there is already a long stack of > patches which build on this (this is part of my previous point). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83088/new/ https://reviews.llvm.org/D83088 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
