lebedev.ri added inline comments.
================ Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:30-34 +// COMMON-ASM: mflr 0 +// COMMON-ASM-NEXT: stw 0, 8(1) +// COMMON-ASM-NEXT: stwu 1, -64(1) +// COMMON-ASM-NEXT: bl ._Z1fv +// NOP-ASM-NEXT: nop ---------------- DiggerLin wrote: > nemanjai wrote: > > rsmith wrote: > > > Generally we strongly prefer for frontend tests to test only the > > > frontend; in this case, that means testing only the IR that Clang is > > > producing and not the assembly that comes out of LLVM for that IR. This > > > should also remove the need to require PPC as a registered target. > > +1 > > The asm test can go into `llvm/test/CodeGen/PowerPC`. > If I put the ASM test as separate test case in the llvm/test/CodeGen/PowerPC > .it will have error as : > > ine 1: %clang_cc1: command not found That's precisely the point. Clang codegen tests should only test clang IR generation. They should not invoke -O1/etc optimization pipelines. LLVM transform tests should only test IR->IR transforms, they should not invoke clang/llc LLVM codegen tests should only test IR->ASM codegen, they should not invoke clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
