erichkeane added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4643 + D->getType().isConstQualified()); + else if (isa<FunctionDecl>(GD.getDecl())) + LT = getFunctionLinkage(GD); ---------------- I'd suggest making this just 'else', that way you don't have to do the assert below. The first line of getFunctionLinkage does the cast to FunctionDecl, so that part is already taken care of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90073/new/ https://reviews.llvm.org/D90073 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
