dexonsmith added inline comments.

================
Comment at: clang/include/clang/Basic/SourceManager.h:118
+  private:
+    unsigned *Storage = nullptr;
+  };
----------------
JDevlieghere wrote:
> I guess it's implicit in the implementation, but maybe it's worth adding a 
> comment describing the layout (first element is the size, elements at index i 
> are at index i+1. 
Thanks, good idea; I'll have that in the commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89913/new/

https://reviews.llvm.org/D89913

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D89913: So... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8991... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8991... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8991... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8991... Jonas Devlieghere via Phabricator via cfe-commits
    • [PATCH] D8991... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8991... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to