Nokia announcement

2010-12-14 Thread Inge Wallin
I talked with Suresh Chande of Nokia today, and they want to "donate" FreOffice to the community and rename it into Calligra Mobile Suite. This means that it could be viewed as a reference UI for the handheld form factor. I think this is great news, and it will generate great PR for Calligra soo

Bugs for Calligra and Words

2010-12-18 Thread Inge Wallin
Just a note so that everybody knows: David Faure has helped us copying the bugs from the kword and koffice products in bugzilla. The new products are calligra-words and calligra-common. The exception to copying was the filter bugs for msdoc and msdocx that Thomas didn't want to keep so they are

Names of the binaries

2010-12-18 Thread Inge Wallin
I think it would be a good idea to prefix our binaries with cs. Examples would be cswords, cstables and so on. OOo does this with binaries like oowriter, oocalc, etc. I *think* Libreoffice does the same but I'm not sure. Reasons: - It follows the pattern - It helps the memory - It will b

Re: Developer Sprint

2010-12-21 Thread Inge Wallin
On Tuesday, December 21, 2010 11:51:25 Thorsten Zachmann wrote: > Hello all, > > I would like to organize the first calligra developer sprint. I have set up > doodle so everybody can give their prefered dates for a sprint. We had a > talk to Mirko from KDAB last week and they are willing to host t

Re: Review Request: calligra helper app

2010-12-30 Thread Inge Wallin
On Thursday, December 30, 2010 05:05:21 Thorsten Zachmann wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100267/#review665 > ---

Re: Review Request: KoAbstraction Library, iteration #3

2011-01-07 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100304/#review764 --- I understand that this patch is the minimum of what is required t

Re: Fwd: Will Calligra Suite join OpenDoc Society?

2011-01-12 Thread Inge Wallin
On Wednesday, January 12, 2011 10:19:40 Boudewijn Rempt wrote: > Hi! > > KOffice used to be a member of the Dutch OpenDoc society, and Calligra has > just been invited. The cost is negligable at a very fair 0 euros for open > source projects... And I would really like us to join! Any objections?

Re: 2.4 Release Plan

2011-01-13 Thread Inge Wallin
On Wednesday, January 12, 2011 16:41:55 Cyrille Berger Skott wrote: > Hi, > > Time to work on a release schedule for the first calligra release, aka 2.4 > (and not 1.0 :) ). > > If we were to strictly follow our schedule, we would have schedule that > looks like this: (with year+1, ie 2010->2011)

Re: 2.4 Release Plan

2011-01-13 Thread Inge Wallin
On Thursday, January 13, 2011 10:12:26 Cyrille Berger Skott wrote: > On Thursday 13 January 2011, Inge Wallin wrote: > > What we have to keep in mind is that a quick release that is not good > > enough is actually a delay. It's a delay until Calligra is relevant and > >

Re: 2.4 Release Plan

2011-01-13 Thread Inge Wallin
On Thursday, January 13, 2011 10:57:10 Cyrille Berger Skott wrote: > On Thursday 13 January 2011, Inge Wallin wrote: > > Now, if we instead prolong the initial release phase to, say, 7 months > > and by doing that make sure that the release is in fact good enough > > then t

Re: 2.4 Release Plan

2011-01-13 Thread Inge Wallin
On Thursday, January 13, 2011 14:15:01 Cyrille Berger Skott wrote: > On Thursday 13 January 2011, Tomas Mecir wrote: > > As a disclaimer, I'm not active in Calligra development currently, so > > my opinion may not be entirely relevant, but hopefully it will be > > useful anyway. > > > > Wouldn't i

Re: cstester - a tool for testing loading and painting of documents

2011-01-18 Thread Inge Wallin
On Tuesday, January 18, 2011 14:07:21 Thorsten Zachmann wrote: > Hello all, > > I'm currently working as part of my job for Nokia on cstester a tool to > test loading and painting for stage, tables and words. The aim of the tool > is to make sure there are no regressions added when features are mo

Re: cstester - a tool for testing loading and painting of documents

2011-01-19 Thread Inge Wallin
On Wednesday, January 19, 2011 05:37:40 Thorsten Zachmann wrote: > Hello, > > On Tuesday, January 18, 2011 14:17:00 Ganesh Paramasivam wrote: > > Just a thought ( If this tool development is still in a early phase ). > > > > Wouldn't this be easier with PDF instead of JPG. PDF ( If I'm right ) >

Re: cstester - a tool for testing loading and painting of documents

2011-01-19 Thread Inge Wallin
On Wednesday, January 19, 2011 05:46:04 Thorsten Zachmann wrote: > On Tuesday, January 18, 2011 14:24:38 Inge Wallin wrote: > > For Words, how about adding a dump of the text layout and compare > > that? That should be easier (and faster!) than generating and comparing > >

Cleaning up the paint API of KoShape

2011-01-23 Thread Inge Wallin
There is a big wart on the KoShape API and that is the one for painting. Currently we have these two functions: virtual void paint(QPainter &painter, const KoViewConverter &converter) = 0; virtual void paintDecorations(QPainter &painter, const KoViewConverter &co

Re: Cleaning up the paint API of KoShape

2011-01-23 Thread Inge Wallin
On Sunday, January 23, 2011 16:31:18 Yue Liu wrote: > On Sun, Jan 23, 2011 at 10:36 PM, Inge Wallin wrote: > > There is a big wart on the KoShape API and that is the one for painting. > > Currently we have these two functions: > > > > virtual void paint(QPainter &

Re: Cleaning up the paint API of KoShape

2011-01-23 Thread Inge Wallin
I'll reply to both Jan and Casper here instead of doing two separate mails. On Sunday, January 23, 2011 20:20:36 C. Boemann wrote: > On Sunday 23 January 2011 18:02:53 ja...@gmx.net wrote: > > On Sunday 23 January 2011 15:36:15 Inge Wallin wrote: > > > There is a big wart

Re: cstester - a tool for testing loading and painting of documents

2011-01-26 Thread Inge Wallin
On Wednesday, January 26, 2011 11:06:50 Cyrille Berger Skott wrote: > On Wednesday 26 January 2011, Thorsten Zachmann wrote: > > Hi all, > > > > I have improved cstester to also support words supported files and > > refactored it a bit to be more modular. I would like to merge it to > > master. An

Re: Review Request 111787: Page Layout improvements for Words

2014-06-22 Thread Inge Wallin
> On June 22, 2014, 8:13 p.m., Denis Kuplyakov wrote: > > test > > Denis Kuplyakov wrote: > Sorry, for this. Ignore it. Aw... I was hoping... :) - Inge --- This is an automatically generated e-mail. To reply, visit: https://git.rev

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-22 Thread Inge Wallin
32/#comment42332> same here words/part/dockers/KWDebugWidget.cpp <https://git.reviewboard.kde.org/r/118532/#comment42333> EBN will complain that you're using a string for one character. :) - Inge Wallin On June 22, 2014, 8 p.m., Denis Kuplyakov wrote: > > -

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-26 Thread Inge Wallin
days now and we have already gotten into the nitpick stage of the review, I will take the liberty to say "good job!" and "ship it!". I am sure that any remaining problems can be fixed post merge. Denis: don't forget to use --squash when you merge the branch. - Inge Wal

Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

2014-06-28 Thread Inge Wallin
18984/#comment42595> Not strictly necessary since DocBase::DocBase already has the same Q_ASSERT. If you want to keep it, I'm fine with that too. - Inge Wallin On June 27, 2014, 10:25 p.m., Jarosław Staniek wrote: > > -

Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

2014-06-29 Thread Inge Wallin
> On June 29, 2014, 4:45 a.m., Inge Wallin wrote: > > In general looks good. But shouldn't the same idea be used in the other > > apps too? > > Boudewijn Rempt wrote: > It's something that is going away in the mvc branch in any case. Ok. I would love to

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-07-06 Thread Inge Wallin
What is this variable for? I can understand the rest of the members without a comment but not this one. - Inge Wallin On July 4, 2014, 2:32 p.m., Denis Kuplyakov wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 110928: Always save the position of a shape

2014-07-06 Thread Inge Wallin
automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110928/#review61727 --- On June 10, 2013, 7:18 p.m., Inge Wallin wrote: > > --- > Thi

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Inge Wallin
> On July 6, 2014, 2:10 p.m., Friedrich W. H. Kossebau wrote: > > Was this ever committed? > > Camilla Boemann wrote: > Don't think so but I also don't think it belongs to calligra anymore. > Laurent, what do you think? Hmm, why not? What would be a better place? I agree that if all word p

Re: Review Request 119579: In docx import filter handle outline level of paragraphs

2014-08-10 Thread Inge Wallin
is correct (according to the comment, didn't read the spec), wouldn't it be clearer to use == instead of != ? - Inge Wallin On Aug. 3, 2014, 10:34 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically gen

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Inge Wallin
/WikiExport.cpp PRE-CREATION filters/words/wiki/export/words_wiki_export.desktop PRE-CREATION filters/words/wiki/wiki-format.xml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118643/diff/ Testing --- Lots of manual testing during development Thank

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Inge Wallin
wboard.kde.org/r/118643/#review64181 --- On Aug. 10, 2014, 4:02 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118643/ > --

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-11 Thread Inge Wallin
iff: https://git.reviewboard.kde.org/r/118643/diff/ Testing --- Lots of manual testing during development Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120116: Simplify (and avoid warning) KoOdfListStyle::readProperties

2014-09-09 Thread Inge Wallin
ment46146> I prefer FIXME before TODO since that is what I grep for. (As a side note I think we should unify the use of FIXME, TODO and @todo in Calligra.) - Inge Wallin On Sept. 9, 2014, 2:07 p.m., Friedrich W. H. Kossebau wrote: > > ---

I'm back

2015-01-13 Thread Inge Wallin
Hi everybody, Some of you know already that I have been very sick but perhaps not everybody. However, I am much better now and recovery has gone so far that I feel that I can come back into the KDE and Calligra families again and be active. The most lasting difference between now and before is

I'm back

2015-01-13 Thread Inge Wallin
[resent, since the ML apparently ate the first version. Apologies if this somehow turns up twice.] Hi everybody, Some of you know already that I have been very sick but perhaps not everybody. However, I am much better now and recovery has gone so far that I feel that I can come back into the K

Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-13 Thread Inge Wallin
https://git.reviewboard.kde.org/r/122035/diff/ Testing --- Tested with extensive traces and existing filters that use the library. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-13 Thread Inge Wallin
eader/OdtReaderBackend.cpp cdc59f1 Diff: https://git.reviewboard.kde.org/r/122035/diff/ Testing --- Tested with extensive traces and existing filters that use the library. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org

Re: I'm back

2015-01-13 Thread Inge Wallin
#x27;t work too hard if you are recovering! > > > > Adam > > > > On Tue Jan 13 2015 at 18:44:17 Inge Wallin wrote: > >> [resent, since the ML apparently ate the first version. Apologies if this > >> somehow turns up twice.] > >> > >> Hi ever

Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-13 Thread Inge Wallin
s.txt 1f992dd Diff: https://git.reviewboard.kde.org/r/122045/diff/ Testing --- There is no new code at all, only rearrangement. But all the filters work as expected. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org

Re: I'm back

2015-01-13 Thread Inge Wallin
On Tuesday, January 13, 2015 21:54:40 René J.V. Bertin wrote: > On Tuesday January 13 2015 21:43:35 Boudewijn Rempt wrote: > > That's a good question, and it depends on what is in them. They probably > > should not go in the 2.9 release, which is what is pre-occupying my mind > > I haven't yet loo

Re: I'm back

2015-01-13 Thread Inge Wallin
On Tuesday, January 13, 2015 21:58:49 René J.V. Bertin wrote: > Inge: did you post a link to a review request or something? If you did I > can't find it anymore. And if you didn't ... maybe you should! ;) https://git.reviewboard.kde.org/r/122035/ https://git.reviewboard.kde.org/r/122045/ > Oh, an

Re: Review Request 110928: Always save the position of a shape

2015-01-14 Thread Inge Wallin
states what default values are, and we try not to write out > > default values in other cases. > > Inge Wallin wrote: > 1. I don't remember anymore how relevant this was to the bug mentioned in > the description, but I will look at it again and come back. > 2.

Re: Two repos prepared for porting to Qt 5

2015-01-16 Thread Inge Wallin
On Friday, January 16, 2015 01:26:20 Jaroslaw Staniek wrote: > Hi, > For those willing to work on porting, two repos have been created: > > git clone kde:scratch/staniek/kproperty > git clone kde:scratch/staniek/kreport > > These are files cut off from calligra/2.9, with history. > It's best if y

Re: Two repos prepared for porting to Qt 5

2015-01-16 Thread Inge Wallin
On Friday, January 16, 2015 09:26:37 Jaroslaw Staniek wrote: > On 16 January 2015 at 09:14, Inge Wallin wrote: > > On Friday, January 16, 2015 01:26:20 Jaroslaw Staniek wrote: > >> Hi, > >> For those willing to work on porting, two repos have been created: > >>

Re: Two repos prepared for porting to Qt 5

2015-01-16 Thread Inge Wallin
o one after the other is finished. > Rejecting this workflow is another topic. There are just two workflows > the above being for special (short) time. > > On 16 January 2015 at 09:26, Inge Wallin wrote: > > On Friday, January 16, 2015 09:26:37 Jaroslaw Staniek wrote: > >>

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-17 Thread Inge Wallin
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122035/#review74201 --- On Jan. 13, 2015, 3:30 p.m., Inge Wallin wrote: > > ---

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-01-17 Thread Inge Wallin
> On Jan. 17, 2015, 10:42 p.m., René J.V. Bertin wrote: > > Applies without issues on OS X; any suggestions how to check/test the new > > functionality? > > Inge Wallin wrote: > This are two parts to the patch: > 1. Less code using smart macros to do the sam

Re: Review Request 122115: [OS X] source code adaptations to OS X

2015-01-17 Thread Inge Wallin
<https://git.reviewboard.kde.org/r/122115/#comment51536> But this define is for both plugins and actual libraries, isn't it? Is this safe? dded - Inge Wallin On Jan. 17, 2015, 11:17 p.m., René J.V. Bertin wrote: > > --- >

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
7;s generic chart stuff. The same class could be used for, say, Lotus 1-2-3 import, but then a specific reader for that format has to be written. See above for why it belongs in libodf2. - Inge Wallin On Jan. 13, 2015, 10:18 p.m., Inge Wallin wrote: > > ---

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
rts from anywhere. Note that the parsing code from various formats are in the filters, and not in libodf2. - Inge --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122045/#revi

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-01-17 Thread Inge Wallin
rs work as expected. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122115: [OS X] source code adaptations to OS X

2015-01-18 Thread Inge Wallin
On Sunday, January 18, 2015 09:57:30 René J.V. Bertin wrote: > > On Jan. 18, 2015, 4:01 a.m., Inge Wallin wrote: > > > karbon/ui/KarbonView.cpp, line 1214 > > > <https://git.reviewboard.kde.org/r/122115/diff/1/?file=342472#file342472 > > > line1214>> >

Re: I'm back

2015-01-18 Thread Inge Wallin
On Friday, January 16, 2015 22:23:42 Cyrille Berger wrote: > On Tuesday 13 January 2015 21:43:35 Boudewijn Rempt wrote: > > That's a good question, and it depends on what is in them. They probably > > should not go in the 2.9 release, which is what is pre-occupying my mind > > right now, but if you

Qt5/KF5 porting plan

2015-01-18 Thread Inge Wallin
I have probably missed something important but the fact is that I am unable to find any written plan for our porting effort anywhere on community.kde.org. Can somebody point me to where the plan is? Stranger is that I have also failed to find anything definite in the calligra- devel archives goi

Merging all fixes for 2.9

2015-01-19 Thread Inge Wallin
I talked with Boud today about various things and one thing that came up were all the fixes for 2.9. There are a lot of them and almost all of them are only on the 2.9 branch right now. This situation is potentially dangerous and will become worse as time goes by. I volunteered to merge 2.9 in

Re: Merging all fixes for 2.9

2015-01-19 Thread Inge Wallin
On Monday, January 19, 2015 17:26:45 Boudewijn Rempt wrote: > If you do, I think it should be an ordinary merge, not a squash. yes, agree. > On Mon, 19 Jan 2015, Inge Wallin wrote: > > I talked with Boud today about various things and one thing that came up > > were all

Re: Merging all fixes for 2.9

2015-01-19 Thread Inge Wallin
On Monday, January 19, 2015 17:25:33 Inge Wallin wrote: > On Monday, January 19, 2015 17:26:45 Boudewijn Rempt wrote: > > If you do, I think it should be an ordinary merge, not a squash. > > yes, agree. Done. It went totally without problems. I think we should do this every 3-

Re: Merging all fixes for 2.9

2015-01-22 Thread Inge Wallin
On Thursday, January 22, 2015 12:02:47 Cyrille Berger wrote: > On 2015-01-19 22:35, Inge Wallin wrote: > > On Monday, January 19, 2015 17:25:33 Inge Wallin wrote: > >> On Monday, January 19, 2015 17:26:45 Boudewijn Rempt wrote: > >> > If you do, I think it should be a

Re: Merging all fixes for 2.9

2015-01-22 Thread Inge Wallin
why don't you revert it in 2.9 already? -Inge > On Thursday, 22 January 2015, Inge Wallin wrote: > > On Thursday, January 22, 2015 12:02:47 Cyrille Berger wrote: > >> On 2015-01-19 22:35, Inge Wallin wrote: > >> > On Monday, January 19, 2015 17:25:33 Inge

Re: Merging all fixes for 2.9

2015-01-23 Thread Inge Wallin
d or discussed. Frankly it sounds strange to me. If nothing else comes up, I will do a normal merge tonight around 9pm. -Inge > On Thursday, 22 January 2015, Inge Wallin wrote: > > On Thursday, January 22, 2015 14:34:07 Jaroslaw Staniek wrote:

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-24 Thread Inge Wallin
explanation what this struct is good for? libs/kotext/commands/ChangeStylesMacroCommand.cpp <https://git.reviewboard.kde.org/r/122238/#comment51762> This should be commented out - Inge Wallin On Jan. 24, 2015, 8:27 p.m., Camilla Boemann wrote: > > --

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-25 Thread Inge Wallin
d. Update: I learned later that there is macro that takes care of this, so maybe just document that a bit and it's fine. - Inge Wallin On Jan. 25, 2015, 1:40 a.m., Camilla Boemann wrote: > > --- > This

Merge window before the port starts

2015-01-25 Thread Inge Wallin
Hi, As you have probably seen I have two patches that I deem mature on the review board right now. These are branches that have been Ok'ed and are ready to merge. And I know that there are others with similar branches laying around. It would be a pity to let them bitrot more than necessary. I

Re: Merge window before the port starts

2015-01-25 Thread Inge Wallin
On Sunday, January 25, 2015 13:59:57 Boudewijn Rempt wrote: > On Sun, 25 Jan 2015, Inge Wallin wrote: > > I, myself, see no reason why we cannot open master for patches of this > > type > > already now, but I will let you decide whether opening master now or wait > >

Re: Merge window before the port starts

2015-01-25 Thread Inge Wallin
res that are ready to merge to master right now or within the next few days. > On 25 January 2015 at 17:42, C. Boemann wrote: > > On Sunday 25 January 2015 14:26:01 Inge Wallin wrote: > >> So let's have a short window before the porting starts then. > > > > Could

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-26 Thread Inge Wallin
I think instead that all layout should be in shape coordinates, i.e. from (0, 0) to (sizeX, sizeY). This handling of world coordinates inside a shape is an abomination to all that is good in linear algebra. But I understand that this is perhaps not the time and place to change tha

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Inge Wallin
x27;m satisfied. - Inge Wallin On Jan. 27, 2015, 10:48 a.m., Camilla Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 122278: Additional changes in section handling

2015-01-29 Thread Inge Wallin
has many things like own > style, name and so on (and I can't say that delimiter could have style). > And KoSectionEnd is a simple helper class that links to corresponding > KoSection. > > > - Denis > > > ------

Re: Review Request 122278: Additional changes in section handling

2015-01-29 Thread Inge Wallin
On Thursday, January 29, 2015 14:11:39 Inge Wallin wrote: > On Thursday, January 29, 2015 12:57:35 Denis Kuplyakov wrote: > > > On Янв. 27, 2015, 7:34 п.п., Camilla Boemann wrote: > > > > libs/kotext/KoSectionManager.cpp, line 120 > > > > <https://git.re

Review Request 122306: Fix bug 260088 - assert when ungrouping group

2015-01-29 Thread Inge Wallin
ix first, though and then estan can fix the strange behaviour since it's in his new code. Diffs - words/part/KWView.cpp f20199a Diff: https://git.reviewboard.kde.org/r/122306/diff/ Testing --- manual testing according to the bug repor

Re: Review Request 122306: Fix bug 260088 - assert when ungrouping group

2015-01-29 Thread Inge Wallin
Testing --- manual testing according to the bug report. Thanks, Inge Wallin ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Flake event handling changes - draft proposal

2015-02-02 Thread Inge Wallin
Hi Tomas, It is obvious that you have really thought this through. But although your technical solution seems solid, I think you are missing one aspect: how the user interaction should work. The problem, as you say, right now is that the user can edit shapes but then has no easy way to get ba

Re: Review Request 122584: Use shared pointers for markers.

2015-02-16 Thread Inge Wallin
class of the KoMarker shared? If so, we could have the collection store KoMarkers instead of a collection of KoMarker*s. Making KoMarker itself a QSharedData feels very strange and is different than anything else in Calligra. - Inge Wallin On Feb. 16, 2015, 2:26 a.m., Sven Langkamp

Re: Review Request 122584: Use shared pointers for markers.

2015-02-16 Thread Inge Wallin
> On Feb. 16, 2015, 11:11 a.m., Inge Wallin wrote: > > Wouldn't a much better solution be to make the Private class of the > > KoMarker shared? If so, we could have the collection store KoMarkers > > instead of a collection of KoMarker*s. Making KoMarker itself a Q

Re: Review Request 122584: Use shared pointers for markers.

2015-02-16 Thread Inge Wallin
> On Feb. 16, 2015, 11:11 a.m., Inge Wallin wrote: > > Wouldn't a much better solution be to make the Private class of the > > KoMarker shared? If so, we could have the collection store KoMarkers > > instead of a collection of KoMarker*s. Making KoMarker itself a Q

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Inge Wallin
is Author only so far, right? Can we leave it as it is for now and then discuss how we want to proceed with this during the porting effort? - Inge Wallin On Feb. 12, 2015, 9:22 p.m., Denis Kuplyakov wrote: > > --- > This is an aut

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-24 Thread Inge Wallin
> On Feb. 24, 2015, 8:40 p.m., Inge Wallin wrote: > > libs/rdf/KoDocumentRdf.cpp, line 57 > > <https://git.reviewboard.kde.org/r/122546/diff/1/?file=348543#file348543line57> > > > > Probably so that the #define can be commented out quickly when you want

Re: Review Request 122035: Calligra filters: Enhance the odf reader library significantly

2015-03-02 Thread Inge Wallin
eader/OdtReaderBackend.h ae321ab filters/libodfreader/OdtReaderBackend.cpp cdc59f1 Diff: https://git.reviewboard.kde.org/r/122035/diff/ Testing --- Tested with extensive traces and existing filters that use the library. Thanks, Inge W

Re: Review Request 122045: Calligra filters: refactor chart handling and make it sane

2015-03-02 Thread Inge Wallin
e3 filters/sheets/xlsx/XlsxXmlDrawingReader.h 69c75ac filters/sheets/xlsx/XlsxXmlDrawingReader.cpp def1ff6 Diff: https://git.reviewboard.kde.org/r/122045/diff/ Testing --- There is no new code at all, only rearrangement. But all the filters work as expected.

Re: GSoC participating with Calligra

2015-03-14 Thread Inge Wallin
On Saturday, March 14, 2015 11:28:06 Станислав Долганов wrote: > Hello, > > I'm student of Moscow State University, Faculty of Computation Mathematics > and Cybernetics. > > I want to participate in Summer of Code with Calligra. There is only one > Calligra's project idea on the KDE ideas page an

Re: Review Request 123039: Porting of KReport to Qt5/KF5

2015-03-18 Thread Inge Wallin
diff into the review request like is normally done? - Inge Wallin On March 18, 2015, 7:34 p.m., Adam Pigg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 122546: Core changes to implement outliner for Author

2015-03-24 Thread Inge Wallin
Kuplyakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122546/ > --- > > (Updated March 24, 2015, 5:53 p.m.) > > > Review request for Calligra, Camill

Re: Review Request 123165: Compile error fix for libmsooxml

2015-03-28 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123165/#review78155 --- Ship it! Looks ok to me. - Inge Wallin On March 28, 2015

Re: Review Request 123195: fix various bugs related to footnotes

2015-03-31 Thread Inge Wallin
lt styles for footnotes etc? And regarding the anchors, shouldn't they be superscript by default? - Inge Wallin On March 31, 2015, 1:25 p.m., Camilla Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-05 Thread Inge Wallin
On Sunday, April 05, 2015 12:00:35 PM Boudewijn Rempt wrote: > > On March 10, 2015, 4:35 a.m., Thorsten Zachmann wrote: > > > The patch looks good to me. > > > > Robert Mathias Marmorstein wrote: > > I downloaded the tests from calligratests, but haven't been able to > > get the QPro plugi

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-05 Thread Inge Wallin
On Sunday, April 05, 2015 18:01:02 Robert Mathias Marmorstein wrote: > > On March 10, 2015, 4:35 a.m., Thorsten Zachmann wrote: > > > The patch looks good to me. > > > > Robert Mathias Marmorstein wrote: > > I downloaded the tests from calligratests, but haven't been able to > > get the QP

Re: Rewriting Flow & formulashape for 3.0? (Re: Qt5 Port Status)

2015-04-08 Thread Inge Wallin
On Wednesday, April 08, 2015 22:07:46 Friedrich W. H. Kossebau wrote: > Hi Yue, > > good to see that you among other things have already turned Karbon back to > life in the Qt5/KF5 spheres :) Rock on! > > Now, the plan for Calligra 3.0 was to focus on porting all code to Qt5 and > KF5. > > No re

Re: release schedule proposal

2011-02-02 Thread Inge Wallin
On Wednesday, February 02, 2011 09:35:00 Boudewijn Rempt wrote: > Hi, > > With the removal of kexi, krita and kplato from the koffice.org website, > I'm reluctant to continue having krita released as part of KOffice 2.3.x. > In fact, even though I'm fairly sure that giving up maintainance of > KOf

Re: release schedule proposal

2011-02-02 Thread Inge Wallin
On Wednesday, February 02, 2011 10:34:30 Pierre Stirnweiss wrote: > On Wed, Feb 2, 2011 at 10:18 AM, Boudewijn Rempt wrote: > > On Wednesday 02 February 2011, Inge Wallin wrote: > > > Do you plan to make real, i.e. not previews, of Krita in the mean time? > > > >

Re: release schedule proposal

2011-02-02 Thread Inge Wallin
On Wednesday, February 02, 2011 11:26:10 Boudewijn Rempt wrote: > On Wednesday 02 February 2011, Inge Wallin wrote: > > I may have misunderstood, but if I understood correctly I'm very sorry to > > have to say that I hate this. The reason is that it is a > > developer-

Re: linuxtag presentations

2011-02-07 Thread Inge Wallin
On Monday, February 07, 2011 15:04:48 Boudewijn Rempt wrote: > On Monday 07 February 2011, Boudewijn Rempt wrote: > > Hi, > > > > Claudia just told me that the Linuxtag (http://www.linuxtag.org/2011/) > > organizers would _love_ a calligra talk or two. I'm probably in Montreal > > then for the Lib

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-12 Thread Inge Wallin
just above it. You have to tell Cyrille to stop putting them there. The code above has since been fixed by somebody to make it compile on Solaris, I think. All this said, of course I'll remove it. - Inge ------- Thi

Re: Review Request: Implement saving for the KoUnavailShape

2011-02-13 Thread Inge Wallin
> On Feb. 13, 2011, 5:09 a.m., Thorsten Zachmann wrote: > > libs/odf/KoEmbeddedFileSaver.h, line 56 > > <http://git.reviewboard.kde.org/r/100629/diff/1/?file=8941#file8941line56> > > > > Please pass contents as a const & > > Inge Wallin wrote: >

Review Request: Implement saving for the KoUnavailShape

2011-02-18 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/ --- Review request for Calligra. Changes --- Updated to fix nearly all is

Re: Review Request: Implement saving for the KoUnavailShape

2011-04-01 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100629/ --- (Updated April 1, 2011, 3:44 p.m.) Review request for Calligra. Changes

Re: Progress on OOo GDI Metafile

2011-04-07 Thread Inge Wallin
On Wednesday, April 06, 2011 01:12:51 Pierre wrote: > Hi > > Since a long time, people have been complaining about the OpenOffice GDI > Metafile picture format being undocumented, hence impossible to implement. > In the plane sunday, I decided to just jump in the OpenOffice.org code and > write bo

Re: Review Request: Implement saving for the KoUnavailShape

2011-04-14 Thread Inge Wallin
vectorshape/VectorShape.cpp <http://git.reviewboard.kde.org/r/100629/#comment2296> Good question. What's your suggestion? - Inge On April 1, 2011, 3:44 p.m., Inge Wallin wrote: > > --- > This is an automati

Plasma Active

2011-04-18 Thread Inge Wallin
I guess most of you have read about the new initiative Plasma Active on the dot or on Planet KDE by now. If not, take a moment to read up because it's really exciting stuff. It turns out that Calligra is regarded as a core application by them. So Aaron contacted me and we had a long talk. Calli

Re: +1 for the community

2011-04-18 Thread Inge Wallin
On Sunday, April 17, 2011 09:56:21 Sriram wrote: > Hello Team, > > My name is Sriram. I am introducing myself to the entire community with > this mail. I started contributing to Fedora since 2008 and also involved > in few open source projects. A month back, I've met a few geeks in > conf.kde.in a

Re: Branding Calligra's QML UI as Calligra Active

2011-04-20 Thread Inge Wallin
On Wednesday, April 20, 2011 18:59:01 Shantanu Tushar Jha wrote: > Hi all, > > I'm not a very talkative person, so there aren't many mails to the ML, or > posts on my blog/planet about stuff I've been doing lately, so here's a > little intro (again ;) ) - > I started developing a QML UI for Callig

Re: Branding Calligra's QML UI as Calligra Active

2011-04-21 Thread Inge Wallin
On Thursday, April 21, 2011 09:35:37 Cyrille Berger Skott wrote: > On Thursday 21 April 2011, Shantanu Tushar Jha wrote: > > Right now my code is not that modular, and I plan to do that once I > > understand how to properly use Calligra libs. > > Once that is done, we can have different UIs for dif

Announcement draft

2011-04-26 Thread Inge Wallin
Here is a first draft of the announcement of snapshot 1. I have already had some feedback from Cyrille that I incorporated. Please comment on the overall structure (is this what we want to focus on?) as well as the actual content. Also remember that this is a first draft that will be polished

  1   2   3   4   5   6   7   >