Question about ownership of KoShape

2016-11-17 Thread Dmitry Kazakov
, the management is not reference counted. How can I solve the thing? [1] - https://www.w3.org/TR/SVG/struct.html#UseElement -- Dmitry Kazakov

Re: Calligra development wiki migrated and cleaned up, plus one proposal

2010-12-19 Thread Dmitry Kazakov
What is the blinking advertisement on the top-right corner? Is it about calligra? And how costs and commits history is calculated? I guess, Krita has more than 5 years history ;) -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org

Re: Calligra development wiki migrated and cleaned up, plus one proposal

2010-12-19 Thread Dmitry Kazakov
On Sun, Dec 19, 2010 at 2:56 PM, Jaroslaw Staniek wrote: > On 19 December 2010 12:37, Dmitry Kazakov wrote: > > What is the blinking advertisement on the top-right corner? Is it about > > calligra? And how costs and commits history is calculated? > > See https://www.ohlo

Re: Developer Sprint

2010-12-26 Thread Dmitry Kazakov
4.02 through 05.04". I'm not sure about the exact wording, but that's the idea. And one more point. The snail-mail letter should be sent as Registered letter, otherwise it'll be lost somewhere on the border :( -- Dmitry Kazakov __

Re: 2.8.x maintenance plan and 2.9 ?

2014-07-03 Thread Dmitry Kazakov
iling list >> > calligra-devel@kde.org >> > https://mail.kde.org/mailman/listinfo/calligra-devel >> >> >> >> -- >> regards / pozdrawiam, Jaroslaw Staniek >> Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org >> Qt for Tizen | http://qt-project.org/wiki/Tizen >> Qt Certified Specialist | http://www.linkedin.com/in/jstaniek >> > > > > -- > regards / pozdrawiam, Jaroslaw Staniek > Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org > Qt for Tizen | http://qt-project.org/wiki/Tizen > Qt Certified Specialist | http://www.linkedin.com/in/jstaniek > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 119224: Fix Krita speed sensor

2014-07-11 Thread Dmitry Kazakov
not needed. Everything can be implemented inside KisPaintInformation. - Dmitry Kazakov On Июль 11, 2014, 3:30 д.п., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Dmitry Kazakov
the patch into master or we should do it on bahalf you you? - Dmitry Kazakov On Июль 12, 2014, 11:54 д.п., Vadim Zhukov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Dmitry Kazakov
> On Июль 13, 2014, 8:40 д.п., Dmitry Kazakov wrote: > > Hi, Vadim! > > > > Thanks for a nice catch! Can you push the patch into master or we should do > > it on bahalf you you? Oh, I read till the end. I

Review Request 119569: Fixed recognition of the Wacom Stylus serial id

2014-08-01 Thread Dmitry Kazakov
lake/KoToolManager.h 17b718e libs/flake/KoToolManager.cpp 2990b62 Diff: https://git.reviewboard.kde.org/r/119569/diff/ Testing --- Tested in Krita Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.

Re: Review Request 119569: Fixed recognition of the Wacom Stylus serial id

2014-08-04 Thread Dmitry Kazakov
i/input/wintab/wacom-properties.h PRE-CREATION krita/ui/input/wintab/wacomcfg.h 03528df libs/flake/KoToolManager.h 17b718e libs/flake/KoToolManager.cpp 2990b62 Diff: https://git.reviewboard.kde.org/r/119569/diff/ Testing --- Tested in Krita Tha

Re: Review Request 119609: Animation support in Krita

2014-08-08 Thread Dmitry Kazakov
g/r/119609/#comment44691> This variable looks suspicious. Do you really need to store any layer here? - Dmitry Kazakov On Авг. 8, 2014, 11:02 д.п., Somsubhra Bairi wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 119609: Animation support in Krita

2014-08-08 Thread Dmitry Kazakov
> On Авг. 8, 2014, 11:27 д.п., Dmitry Kazakov wrote: > > krita/ui/kis_doc2.h, line 187 > > <https://git.reviewboard.kde.org/r/119609/diff/2/?file=302163#file302163line187> > > > > This variable looks suspicious. Do you really need to store any layer >

Re: Review Request 119677: Show the Cursor Pos and FG Color in statusbar

2014-08-10 Thread Dmitry Kazakov
icies/Kdelibs_Coding_Style - Dmitry Kazakov On Авг. 9, 2014, 11:22 д.п., Latte OfCode wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Normalizing connections in calligra

2014-09-03 Thread Dmitry Kazakov
st > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 119183: A HSV color slider docker.

2014-09-14 Thread Dmitry Kazakov
: 1) Set color to H:300, S:100, L:90, then try to use mouse wheel on any of the sliders 2) Mouse Wheel over H set to 360 looks weird :) (minor bug) - Dmitry Kazakov On Сен. 13, 2014, 9:04 п.п., Wolthera van Hövell wrote: > > --- >

Re: Review Request 120191: Allow to have more than one zoom widget

2014-09-14 Thread Dmitry Kazakov
it works in Krita. - Dmitry Kazakov On Сен. 14, 2014, 1:02 д.п., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119183: A HSV color slider docker.

2014-09-14 Thread Dmitry Kazakov
atting krita/plugins/extensions/dockers/colorslider/kis_color_slider_widget.cpp <https://git.reviewboard.kde.org/r/119183/#comment46348> The same as previous comment - Dmitry Kazakov On Сен. 13, 2014, 9:04 п.п., Wolthera van Hövell wrote: > > -

Re: Review Request 119183: A HSV color slider docker.

2014-09-15 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119183/#review66582 --- Ship it! Ship It! - Dmitry Kazakov On Sept. 15, 2014, 2

Re: Review Request 120610: Fix for Krita Bug 339870

2014-10-17 Thread Dmitry Kazakov
rounding bug. I'm ok with comming it, but you should fix the Tab<->Space issue to conform KDE code style policies first :) https://techbase.kde.org/Policies/Kdelibs_Coding_Style - Dmitry Kazakov On Окт. 17, 2014, 2:53 д.п., Gerald

Re: Review Request 121064: Krita - KisPaintInformation::time should be qreal

2014-11-08 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121064/#review70077 --- Ship it! Looks good to me! :) - Dmitry Kazakov On Ноя. 8

Re: Review Request 121226: Krita - Clean global origin workaround

2014-11-24 Thread Dmitry Kazakov
;m ok with pushing it into master - Dmitry Kazakov On Ноя. 23, 2014, 9:23 п.п., Damien de Lemeny wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Review Request 121336: Fix vector sapes resolution in Krita

2014-12-03 Thread Dmitry Kazakov
Here is the full list of changes. commit 5efa5b4e9205632e1945d5fb467bc37836a582c4 Author: Dmitry Kazakov Date: Tue Dec 2 14:07:35 2014 +0300 Fix width of the Pencil Tool stroke after changing resolution There were two things needed: 1) Deselect shapes when a shape-based tool is activated. T

Re: Review Request 121336: Fix vector sapes resolution in Krita

2014-12-04 Thread Dmitry Kazakov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121336/#review71339 ------- On Дек. 3, 2014, 10:53 д.п., Dmitry Kazakov wrote: > > -

Re: Review Request 121336: Fix vector sapes resolution in Krita

2014-12-05 Thread Dmitry Kazakov
a bit ugly, but I'm not sure we can do anything else here. Here is the full list of changes. commit 5efa5b4e9205632e1945d5fb467bc37836a582c4 Author: Dmitry Kazakov Date: Tue Dec 2 14:07:35 2014 +0300 Fix width of the Pencil Tool stroke after changing resolution There wer

Review Request 121388: Remove rounding for pixels in KoUnit

2014-12-08 Thread Dmitry Kazakov
about rounding. Diffs - libs/odf/KoUnit.cpp 191ae0c libs/widgets/KoUnitDoubleSpinBox.cpp 9c8af44 Diff: https://git.reviewboard.kde.org/r/121388/diff/ Testing --- Tested in Krita Thanks, Dmitry Kazakov ___ calligra-devel mailing list cal

Re: Review Request 121388: Remove rounding for pixels in KoUnit

2014-12-08 Thread Dmitry Kazakov
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121388/#review71547 ------- On Дек. 8, 2014, 1:17 п.п., Dmitry Kazakov wrote: > > ---

Re: Review Request 121388: Remove rounding for pixels in KoUnit

2014-12-08 Thread Dmitry Kazakov
edabe. The rest of the functions like ptToUnit() and convertFromUnitToUnit() know nothing about rounding. Diffs - libs/odf/KoUnit.cpp 191ae0c libs/widgets/KoUnitDoubleSpinBox.cpp 9c8af44 Diff: https://git.reviewboard.kde.org/r/121388/diff/ Testing --- Tested in Krita Thanks, D

Re: Review Request 121572: Bug Fix 331791 wish: Add toggle mode or shortcut for brush snap to assistant

2014-12-18 Thread Dmitry Kazakov
Shortcut(Qt::Key_BracketRight); collection->addAction("increase_brush_size", increaseBrushSize); ``` - Dmitry Kazakov On Dec. 18, 2014, 7:11 p.m., Rishabh Saxena wrote: > > --- > This is an auto

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-19 Thread Dmitry Kazakov
est approach is to disbale action when a non-layer node is selected. You can follow an example of "Transparency Mask" action. It is also disabled when a maks is selected. - Dmitry Kazakov On Dec. 19, 2014, 6:44 p.m., Rishabh Saxena wrote: > > ---

Re: Review Request 121572: Bug Fix 331791 wish: Add toggle mode or shortcut for brush snap to assistant

2014-12-22 Thread Dmitry Kazakov
> On Дек. 18, 2014, 7:35 п.п., Dmitry Kazakov wrote: > > krita/plugins/tools/defaulttools/kis_tool_brush.cc, line 399 > > <https://git.reviewboard.kde.org/r/121572/diff/3/?file=333824#file333824line399> > > > > addAction() accepts the 'id'

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-24 Thread Dmitry Kazakov
> On Dec. 23, 2014, 10:14 p.m., Sven Langkamp wrote: > > Excluding the transparency mask from flatten isn't needed as it would > > automatically flatten the parent layer. There are also many other mask type > > that are not covered by this. I would expect this option would be available for lay

Re: Review Request 121656: Krita - Fix weak shared pointer copy constructor and assignment

2014-12-24 Thread Dmitry Kazakov
n just fix it and push the patch without another round of review. - Dmitry Kazakov On Dec. 24, 2014, 12:34 a.m., Stefano Bonicatti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 121733: Fix crash reported in bug 342222

2014-12-28 Thread Dmitry Kazakov
sure the shape controller is deleted somewhere? As far as I understood, the ownership of it is not passed to the document resource manager. It just stores a pointer insize QVariant, so it seems like the shape controller is leaking :( - Dmitry Kazakov On Dec. 29, 2014, 3:59 a.m., Thorsten

Re: Review Request 121944: Krita - Fix crash when switching off OpenGL

2015-01-12 Thread Dmitry Kazakov
GPUs. Works fine, except that I didn't test OCIO support (I don't have it built here). Looks ok to commit. - Dmitry Kazakov On Янв. 12, 2015, 10:59 д.п., Stefano Bonicatti wrote: > > --- > This is an automatically generat

Re: Review Request 122042: Fix crash after attempt to change alignment in a text field

2015-01-15 Thread Dmitry Kazakov
a fix. - Dmitry Kazakov On Янв. 14, 2015, 8:55 д.п., Roman Shtemberko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-23 Thread Dmitry Kazakov
oad their shapes) and the > special use is done "only" by Krita. > > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Merging all fixes for 2.9

2015-01-23 Thread Dmitry Kazakov
vel mailing list > >> > calligra-devel@kde.org > >> > https://mail.kde.org/mailman/listinfo/calligra-devel > > ___ > > calligra-devel mailing list > > calligra-devel@kde.org > > https://mai

Re: Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

2015-01-27 Thread Dmitry Kazakov
perfect, especially setntence-casing the checkboxes to fit KDE capitalization policy! :) - Dmitry Kazakov On Jan. 28, 2015, 4:59 a.m., Aleksander Demko wrote: > > --- > This is an automatically generated e-m

Re: Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

2015-01-28 Thread Dmitry Kazakov
> On Jan. 28, 2015, 9:04 a.m., Boudewijn Rempt wrote: > > krita/ui/forms/wdgdisplaysettings.ui, line 274 > > > > > > One note: I don't think that changing the string here was necessary (or > > correct). Accordi

Re: 2.9 final release date

2015-02-03 Thread Dmitry Kazakov
- http://kde.org > Calligra Suite: > : A graphic art and office suite - http://calligra.org > Kexi: > : A visual database apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > _______

Re: Getting to 100 % succedding tests (for 2.9), or, simply dropping them all?

2015-02-04 Thread Dmitry Kazakov
deployed could enforce rejection of commits > that > break tests, but ideally people simply feel responsible for breaking tests, > like they feel responsible for breaking the normal build. > > Personally I see tasks T2 and T3 as something to be done first, best before > 2.9 release. See me subscribed to making

Re: Getting to 100 % succedding tests (for 2.9), or, simply dropping them all?

2015-02-05 Thread Dmitry Kazakov
em. > Do you happen to have a list of the tests where such external deps influence > the result? Or could the list be created from checking for > checkQImageExternal()? Everything that uses TestUtil::checkQImageImpl(). It includes almost all tests written for last couple of years. --

Re: Getting to 100 % succedding tests (for 2.9), or, simply dropping them all?

2015-02-11 Thread Dmitry Kazakov
ategory. Probably, we could start some wiki page to document it right from the beginning? -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Welcome to KDE e.V., Dmitry!

2015-02-21 Thread Dmitry Kazakov
Thank you, Jaroslaw, for nice words! :) On Sat, Feb 21, 2015 at 10:58 AM, Jaroslaw Staniek wrote: > I'd like to especially welcome long time Calligra/Krita contributor > and great colleague Dmitry Kazakov who just joined the KDE e.V. > non-profit. [1] > Dmitry, I trust it'

Bugs in Krita which should be fixed before the release

2015-02-21 Thread Dmitry Kazakov
And I will write here when these tasks are done. -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[calligra/calligra/2.9] libs/pigment: Change the license of Vc-optimized composite ops from GPL 2 to LGPL 2.1

2015-02-21 Thread Dmitry Kazakov
Git commit d78fac93164ca4e6588a35d4fef7b7adb8223898 by Dmitry Kazakov. Committed on 22/02/2015 at 06:18. Pushed by dkazakov into branch 'calligra/2.9'. Change the license of Vc-optimized composite ops from GPL 2 to LGPL 2.1 This is a requirement of calligra libs, and I am fully agree

Re: Bugs in Krita which should be fixed before the release

2015-02-23 Thread Dmitry Kazakov
he release is the 26th. Not > next > > week. I really don't want to delay the release into March! > > > > > > On Sun, 22 Feb 2015, Cyrille Berger wrote: > > > >> No need for hurry, the translations are not quiet in place, so I should > >> probably t

Re: Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port

2015-02-25 Thread Dmitry Kazakov
David's notes in kde-dev-scripts, please. That's what I was > referring to. And sure I'll be careful. > > Boudewijn > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-05 Thread Dmitry Kazakov
jn > > _______ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122858: Krita - UI fixes and improvements

2015-03-09 Thread Dmitry Kazakov
tps://git.reviewboard.kde.org/r/122858/#comment53028> Is this commented-out code intentional? Probably it should go? krita/ui/widgets/kis_filter_selector_widget.cc <https://git.reviewboard.kde.org/r/122858/#comment53029> Should this also be deleted? - Dmitry Kazakov On Март 8, 20

Re: Review Request 123179: workaround Vc cmake issue

2015-04-11 Thread Dmitry Kazakov
/CMakeLists.txt? It also uses build_per_arch macro, so it might also be affected - Dmitry Kazakov On March 30, 2015, 7:54 a.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

[calligra/krita-psd-rempt] /: Removed explicit memory leak when dealing with gradients

2015-04-12 Thread Dmitry Kazakov
Git commit 6df0b34f17b742359c197493396e7840f1c5f837 by Dmitry Kazakov. Committed on 12/04/2015 at 17:46. Pushed by dkazakov into branch 'krita-psd-rempt'. Removed explicit memory leak when dealing with gradients The changes in the patch: 1) Now KoResource has a copy-ctor. 2) KoAbstra

Review Request 123486: Fix a bug when KoResourceItemChooser's current resource was resent on resize

2015-04-24 Thread Dmitry Kazakov
9568d3b Diff: https://git.reviewboard.kde.org/r/123486/diff/ Testing --- Tested in Krita only Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123486: Fix a bug when KoResourceItemChooser's current resource was resent on resize

2015-04-25 Thread Dmitry Kazakov
marked as submitted. Review request for Calligra. Changes --- Submitted with commit 0616ea1f9bf958bcce5703a1bd65f4bfe11edce3 by Dmitry Kazakov to branch calligra/2.9. Repository: calligra Description --- This patch fixes numerous bugs in KoResourceItemChooser 1) Resizing the

Re: 2.9.3 reminder

2015-04-28 Thread Dmitry Kazakov
abase apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Cancelled release of Calligra 2.9.3, expect fixes within a week

2015-04-29 Thread Dmitry Kazakov
database apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel >

Re: Phabricator instead of reviewboard

2015-04-30 Thread Dmitry Kazakov
; Please take a look at https://phabricator.kde.org! > > Boudewijn > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

2015-05-25 Thread Dmitry Kazakov
e action because they are shown in "Alternate" group already. - Dmitry Kazakov On May 25, 2015, 1:57 a.m., Michael Abrahams wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 124257: advancedcolorselector: Fix UI layout

2015-07-05 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124257/#review82090 --- Ship it! Looks ok to me :) - Dmitry Kazakov On July 5

Re: Review Request 124278: Improve Krita input device switching for Surface Pro 3

2015-07-07 Thread Dmitry Kazakov
. Especially the patch with readability changesm which makes review quite complicated. Anyway, even after I review this, we need to ask our users to test it on various tablet devices, which can behave quite insanely. - Dmitry Kazakov On Июль 7, 2015, 6:31 д.п., Michael Abrahams wrote

[calligra/calligra/2.9] krita/libpsd: Finish proper renaming of the libpsd library

2015-07-07 Thread Dmitry Kazakov
Git commit 04dac642dab567fafbce117fe536053d403a3159 by Dmitry Kazakov. Committed on 07/07/2015 at 09:30. Pushed by dkazakov into branch 'calligra/2.9'. Finish proper renaming of the libpsd library When renaming a library, please don't forget to modify the export header accordin

Re: release blocker

2015-07-09 Thread Dmitry Kazakov
n > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: 2.9.7

2015-08-04 Thread Dmitry Kazakov
gt; Kexi: > : A visual database apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > ___ > calligra-devel mailing list > calligra-devel@kd

Re: Increasing Calligra minimum CMake version required

2015-08-17 Thread Dmitry Kazakov
t might get > deprecated (shown by the fact that they're adding specific macros to add > flags etc). > Moreover do we really still have people testing the builds with CMake > 2.8.0? > > > > ___ > ca

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

2015-08-31 Thread Dmitry Kazakov
Hi, Stefano! Now Dmitry, what are the situations where you really need it? Because it's > weird that someone else didn't find/write a ready to use solution for it. > Emacs has a feature to autocomplete parts of the filename in non-sequential order if they are split with underscores. I got really

Re: Git policy: git merge or git cherry-pick

2011-01-31 Thread Dmitry Kazakov
me, i'm almost agree with sebsauer. If you have a small local branch that will never be published, just rebase it. If you have once published your branch, you should do no rebasing, cherry-picking or other rewriting of history. -- Dmitry Kazakov ___

Review Request: Fixed autoscrolling bug in Krita

2011-03-13 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100851/ --- Review request for Calligra. Summary --- This patch fixes an autoscro

Re: Sprint

2011-03-30 Thread Dmitry Kazakov
I'm arriving at 8:55 at Schonefeld. We could meet with someone =) -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[calligra] /: Revert "Fixed autoscrolling bug in Krita"

2011-04-16 Thread Dmitry Kazakov
Git commit 044aa71e9fd5374044d2cb9d4baedeebe244cf6c by Dmitry Kazakov. Committed on 17/04/2011 at 08:00. Pushed by dkazakov into branch 'master'. Revert "Fixed autoscrolling bug in Krita" This reverts commit a1bc54466caf7066db145d8bab989c1d620084b6. (Breaks Stage as

Proposal for new modifiers/shortcuts system

2011-06-12 Thread Dmitry Kazakov
it in the future, but this is not mandatory as there are wrappers for old tools left. So i would really like to hear your opinion about this system. Especially, about naming of the classes =) -- Dmitry Kazakov ___ calligra-devel mailing list call

Re: Proposal for new modifiers/shortcuts system

2011-06-12 Thread Dmitry Kazakov
ight take much time to implement this abstraction and make it kde-wide-usable But we can discuss variants, maybe, there is some optimal work/abstraction tradeoff =) Do you have any idea? -- Dmitry Kazakov ___ calligra-devel mailing list calligra-deve

Re: Proposal for new modifiers/shortcuts system

2011-06-14 Thread Dmitry Kazakov
; I'd say it's better to have these canvas tools implemented as interaction > strategies every tool can use, and not as separate tools. > Yep, excatly! -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Proposal for new modifiers/shortcuts system

2011-06-14 Thread Dmitry Kazakov
o interrupt the action in all the applications (except of emacs, of course). =) Well, maybe your question means how the manager solves the conflicts. It doesn't solve them. And it doesn't do any assignment of shortcuts. They are hardcoded currently. I think there should be a separate sy

Re: Proposal for new modifiers/shortcuts system

2011-06-14 Thread Dmitry Kazakov
Add static functions to KoInteractionStrategy (quite weird). 3) Do not use KoInteractionTool, but implement a new one with good strategies those are not created again on every stroke and have a long lifetime. -- Dmitry Kazakov ___ calligra-devel mailing list call

Design proposal for the tool actions scheduler for Krita

2011-06-14 Thread Dmitry Kazakov
e node was locked are completely lost. And here is the new design itself: http://community.kde.org/Krita/Strokes_Framework As usual, all the ideas are welcome! =) -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://ma

Raising the dependency of libffi.so

2011-06-17 Thread Dmitry Kazakov
like added one dependency. Is it a bug? Or I just should install it? -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Return support for clone layers of group layers

2011-07-12 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101928/#review4650 --- There is one old problem in KisNodeManager (will be revealed by

Review Request: Added an undo stack parameter to KoDocument

2011-08-03 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102196/ --- Review request for Calligra. Summary --- The clients should be able t

Re: 2. Calligra Sprint

2011-09-08 Thread Dmitry Kazakov
;t what cyrille meant > > I'm added to the sprint to but because my account is not validated either > neithe me nor cyrille shows up in the list of participants > Your accounts are shown, but only if you click on some switches like "Name", "Food", "Sponsorship". I guess it is a bug of sprints.kde.org. ;) -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Dmitry Kazakov
play a negative role in a long-term plan =) - Dmitry Kazakov On Oct. 16, 2011, 4:59 p.m., Torio Mlshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Fix loading/saving clone layers

2011-10-16 Thread Dmitry Kazakov
play a negative role in a long-term plan =) - Dmitry Kazakov On Oct. 16, 2011, 4:59 p.m., Torio Mlshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Fix loading/saving clone layers

2011-10-17 Thread Dmitry Kazakov
> On Oct. 16, 2011, 6:04 p.m., Dmitry Kazakov wrote: > > Hi! > > > > It's a really cool idea to use uuids here! I think the patch is very good, > > but i have one small concern. Is it possible to remove old code like > > copyFromName(), setCopyFromName

Re: Review Request: Fix loading/saving clone layers

2011-10-20 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102896/#review7512 --- Ship it! Great work! =) - Dmitry Kazakov On Oct. 20, 2011

Re: Unit tests failures

2011-10-30 Thread Dmitry Kazakov
* Finished testing of KisProcessingsTest * > kDebugStream called after destruction (from > KisMemoryLeakTracker::~KisMemoryLeakTracker() file > /home/cyrille/src/calligra/krita/image/kis_memory_leak_tracker.cpp line 128) > No leak detected. > > > But that test h

Re: Review Request: Fix crashing when using tools on empty image

2011-10-31 Thread Dmitry Kazakov
.org/Policies/Kdelibs_Coding_Style - Dmitry Kazakov On Oct. 31, 2011, 7:26 p.m., Torio Mlshi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.rev

Re: Review Request: Fix clone layers updating

2011-11-01 Thread Dmitry Kazakov
the latter method is called asynchronously from several non-UI threads. I will check whether it is possible, but not earlier than Thursday. - Dmitry Kazakov On Nov. 1, 2011, 7:25 p.m., Torio Mlshi wrote: > > --- > This is an automatica

Re: hello!

2011-12-06 Thread Dmitry Kazakov
in with as well. For example, this one: [2] [1] - https://bugs.kde.org/show_bug.cgi?id=268212 [2] - https://bugs.kde.org/show_bug.cgi?id=282549 -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Fix bug with zero scale of the brush in krita

2011-12-18 Thread Dmitry Kazakov
krita/plugins/paintops/sketch/kis_sketch_paintop.cpp 0a86895 krita/plugins/paintops/spray/kis_spray_paintop.cpp 4d8a6f2 Diff: http://git.reviewboard.kde.org/r/103445/diff/diff Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing

Review Request: Fixed a tool activation when the current layer is not enabled (KoToolManager)

2012-02-25 Thread Dmitry Kazakov
77047 Diffs - libs/flake/KoToolManager.cpp 855d3ea libs/flake/KoToolManager_p.h ca7e0d2 Diff: http://git.reviewboard.kde.org/r/104075/diff/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org

Review Request: Backport 2.4: "Fixed rotation of layers"

2012-03-03 Thread Dmitry Kazakov
/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Backport 2.4: Fixed Pipe Brush mask generation

2012-03-03 Thread Dmitry Kazakov
/kis_imagepipe_brush.cpp ca1a5cc Diff: http://git.reviewboard.kde.org/r/104146/diff/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Backport 2.4: Fixed Pipe Brush mask generation

2012-03-07 Thread Dmitry Kazakov
is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104146/#review11137 --- On March 3, 2012, 2:46 p.m., Dmitry Kazakov wrote: > > --- &

Re: Review Request: Replace all old-style iterators with NG iterators

2012-04-28 Thread Dmitry Kazakov
be a good idea, but I won't argue on this point. 3) Did you intend to remove the files for with old iterators and accessors? It looks like they are still in the tree. - Dmitry Kazakov On April 28, 2012, 9:49 a.m., Boudewijn Rempt

Re: Review Request: Replace all old-style iterators with NG iterators

2012-04-28 Thread Dmitry Kazakov
be a good idea, but I won't argue on this point. 3) Did you intend to remove the files for with old iterators and accessors? It looks like they are still in the tree. - Dmitry Kazakov On April 28, 2012, 9:49 a.m., Boudewijn Rempt

Need review and testing for 'zoom-pan-testing-kazakov' branch

2012-09-02 Thread Dmitry Kazakov
ng-kazakov'. So to check you need to switch to it: git fetch git checkout origin/zoom-pan-testing-kazakov To switch back to master: git checkout master -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/m

Review Request: The dab cache for Krita

2012-10-04 Thread Dmitry Kazakov
/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: The dab cache for Krita

2012-10-05 Thread Dmitry Kazakov
----------- On Oct. 4, 2012, 2:30 p.m., Dmitry Kazakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106724/ > ---

Review Request: Fixed deactivation of the tools when input device is switched

2012-11-04 Thread Dmitry Kazakov
/KoToolManager.cpp c121d0f libs/flake/KoToolManager_p.h 85985df Diff: http://git.reviewboard.kde.org/r/107205/diff/ Testing --- Tested in Krita and Karbon. Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org

Need help with reviewing and testing the KoToolManager changes

2012-11-12 Thread Dmitry Kazakov
https://git.reviewboard.kde.org/r/107205/ [1] - https://bugs.kde.org/show_bug.cgi?id=298584 -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

New PACKAGERS_BUILD option for building Calligra

2012-12-03 Thread Dmitry Kazakov
message I told about the growth 11->17MiB. I was wrong because measured it on the wrong binary. -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

  1   2   >