-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104075/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
Way to reproduce:
1) Open new document
2) Disable a layer with a mouse
3) Enable a layer with a tablet
You will not be able to paint with the tablet.
What actually happened was that a new CanvasData was created, but the previous
tool could not be activated in the new data, because of an explicit check in
switchTool. So that we ended up in a state with no tool at all.
This patch brings a bit more consistency there. Now you can always switch the
tool in the KoToolManager, even when active layer is disabled, but the
KoToolProxy will get information about the new tool only when the layer gets
enabled back. This is what the code in currentLayerChanged() and
toolCanBeUsed() has been doing before. There was inconsistency in
postSwitchTool(), because it didn't check for the availability of the active
layer, now it does.
This addresses bug 277047.
http://bugs.kde.org/show_bug.cgi?id=277047
Diffs
-----
libs/flake/KoToolManager.cpp 855d3ea
libs/flake/KoToolManager_p.h ca7e0d2
Diff: http://git.reviewboard.kde.org/r/104075/diff/
Testing
-------
Thanks,
Dmitry Kazakov
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
