----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120191/#review66463 -----------------------------------------------------------
Ship it! The patch looks fine to me. Both codewise and how it works in Krita. - Dmitry Kazakov On Сен. 14, 2014, 1:02 д.п., Sven Langkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120191/ > ----------------------------------------------------------- > > (Updated Сен. 14, 2014, 1:02 д.п.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > The patch splits the zoom widget out of the zoom action and connects with via > signals and slots. That allows to have more than one zoom widget. > > > Diffs > ----- > > krita/plugins/extensions/dockers/overview/overviewdocker_dock.h e24a5e7 > krita/plugins/extensions/dockers/overview/overviewdocker_dock.cpp 1eeec3a > libs/widgets/CMakeLists.txt f825569 > libs/widgets/KoZoomAction.h eba88ad > libs/widgets/KoZoomAction.cpp 3035a74 > libs/widgets/KoZoomWidget.h PRE-CREATION > libs/widgets/KoZoomWidget.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120191/diff/ > > > Testing > ------- > > Tested with an additional zoom widget in the Krita overview docker. > > > Thanks, > > Sven Langkamp > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
