----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121226/#review70844 -----------------------------------------------------------
Ship it! If the tablet still works correctly, then I'm ok with pushing it into master - Dmitry Kazakov On Ноя. 23, 2014, 9:23 п.п., Damien de Lemeny wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121226/ > ----------------------------------------------------------- > > (Updated Ноя. 23, 2014, 9:23 п.п.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > KisToolProxy::forwardEvent had an ugly workaround parameter to get the origin > coordinates of the canvas converted to global coordinates. Better have > KisToolProxy creating that origin instead of passing it around. > > > Diffs > ----- > > krita/ui/canvas/kis_tool_proxy.h 307e627 > krita/ui/canvas/kis_tool_proxy.cpp 0545ea0 > krita/ui/input/kis_alternate_invocation_action.cpp ce61a84 > krita/ui/input/kis_change_primary_setting_action.cpp aeade2c > krita/ui/input/kis_input_manager.cpp 89919dc > krita/ui/input/kis_tool_invocation_action.cpp 33e2640 > > Diff: https://git.reviewboard.kde.org/r/121226/diff/ > > > Testing > ------- > > Compiles OK > Primary tool invocation OK > Alternate tool invocation OK > Change primary settings OK > > > Thanks, > > Damien de Lemeny > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
