----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119677/#review64141 -----------------------------------------------------------
Hi, Latte! Your patch is really cool, but there is one issue that we should fix before we can allow it to go to master. We had the cursor position in the status bar before, but we disabled it due to performance issues. The point is, wacom tablet devices have quite a high resolution, so the application gets too many mouse move events, and, therefore eats too much CPU power if we try to display the coordinate on every event. The same applies to displaying current color. If we try to update the color on every event, the UI will choke when the user starts color picking with a tablet device. Now we have a canned solution for that. You just need to connect the signal not directly to the slot, but using KisSignalCompressor object. This object will ensure that the signal is delivered not more often than, say, once in 100ms. The user will not see any delay, but the system will not choke with the events. You can find an example of how KisSignalCompressor will be used in KisColorSelector class. You will probably want to use higher delay values, e.g. 100ms, because you don't need real-time feedback here. PS: And just to add to what Sven said about coding style, here is a nice document about it: https://techbase.kde.org/Policies/Kdelibs_Coding_Style - Dmitry Kazakov On Авг. 9, 2014, 11:22 д.п., Latte OfCode wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119677/ > ----------------------------------------------------------- > > (Updated Авг. 9, 2014, 11:22 д.п.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Two changes to statusbar: 1) Show cursor location, 2) Show foreground color > > > Diffs > ----- > > krita/ui/kis_statusbar.h 5b5c74e > krita/ui/kis_statusbar.cc 7f57007 > > Diff: https://git.reviewboard.kde.org/r/119677/diff/ > > > Testing > ------- > > Built Krita successfully after making changes. Tested added functionality. > > > Thanks, > > Latte OfCode > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
