----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124278/#review82159 -----------------------------------------------------------
I would really love it if it were several separate patches. Especially the patch with readability changesm which makes review quite complicated. Anyway, even after I review this, we need to ask our users to test it on various tablet devices, which can behave quite insanely. - Dmitry Kazakov On Июль 7, 2015, 6:31 д.п., Michael Abrahams wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124278/ > ----------------------------------------------------------- > > (Updated Июль 7, 2015, 6:31 д.п.) > > > Review request for Calligra. > > > Bugs: 341899 > http://bugs.kde.org/show_bug.cgi?id=341899 > > > Repository: calligra > > > Description > ------- > > This patch rewrites most of kis_tablet_support_win.cpp to support basic > use of the eraser key on the Surface Pro 3. The basic issue is that the > SP3 eraser button does not register being held until the stylus is > touched to the screen. A secondary issue is that the eraser button might > be pressed in the middle of the stroke, disrupting the ordinary > schedule of press and release events. > > This patch attempts to handle those issues by watching for "inline" > cursor changes. If a packet pops up with a different cursor ID, we will > dispatch a release event and a tool switch signal. This breaks some > layers of abstraction but it seems to work. > > The rest of the rewrite mostly focuses on readability, but adds a few > assorted fixes elsewhere, in particular allowing the current tool to be > changed by hovering over the dockers (necessary to allow the SP3 to > set an alternate alternate tool with the eraser button), an addition to > the x11 tablet code to give the same functionality, a prescaling feature > for QTabletEvent, preventing multiple instances of the Qt/Wintab dialog, > and a few typo corrections. > > > Diffs > ----- > > krita/ui/input/wintab/kis_screen_size_choice_dialog.cpp 364419b > krita/ui/input/wintab/kis_tablet_support.h 8c1b279 > krita/ui/input/wintab/kis_tablet_support_win.cpp 5e5d82f > krita/ui/input/wintab/kis_tablet_support_x11.cpp 0e28671 > libs/flake/KoToolManager.cpp 731faed > > Diff: https://git.reviewboard.kde.org/r/124278/diff/ > > > Testing > ------- > > > Thanks, > > Michael Abrahams > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
