D7946: CSV characters should not be translated

2019-09-14 Thread Camilla Boemann
boemann accepted this revision. boemann added a comment. Looks simple enough to me too - someone please push REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D7946 To: guoyunhe, #calligra:_3.0, danders, mecir, boemann Cc: boemann, Calligra-Devel-list, anthonyfieroni, dc

D24830: Add support for strikeout text in RTF documents

2019-10-21 Thread Camilla Boemann
boemann added a comment. As far as I'm concerned you may push to rtf importer at your own discretion REVISION DETAIL https://phabricator.kde.org/D24830 To: akomakhin, pvuorela, #calligra:_3.0 Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

2019-10-22 Thread Camilla Boemann
boemann added a comment. I think this will break those headings that actually should have numbering, so i think further investigation is needed with such cases REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0 Cc: boemann,

D24852: Remove list style from headings

2019-10-22 Thread Camilla Boemann
boemann added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D24852: Remove list style from headings

2019-10-25 Thread Camilla Boemann
boemann added a comment. All I'm saying is removing it completely is probably just as wrong as leaving it in. Maybe you could come up with some if case REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D24852 To: akomakhin, pvuorela, #calligra:_3.0, boemann Cc: boemann,

D24852: Remove list style from headings

2019-11-08 Thread Camilla Boemann
boemann added a comment. This looks scarily generic What happens when the user via gui adds a numbered lists, and what is the impact in the other applications You are definitely on to something with formatSpecification, but maybe not setting is for all but only when loading headers

D24852: Remove list style from headings

2019-11-08 Thread Camilla Boemann
boemann added a comment. Not strange for a normal list - but yes for headings it sounds wrong - and I think this is where you need to make the changes. So if in load odf you are loading a heading and it doesn't specify numbering set it formatspecification to empty. But please make s

D25254: Remove flow, not needed since karbon can do it all

2019-11-11 Thread Camilla Boemann
boemann added a comment. To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be maintaining flow. So I'm okay with it REPOSITORY R8 Calligra REVISION DETAIL https:

T12815: Create Calligra Framework by separating out applications and libraries

2020-03-13 Thread Camilla Boemann
boemann added a comment. It is a no from me for exactly the reasons pino and ngraham bring up. Now if there was a thriving community, I'd be happy to step down and let the community do this if there was a big consensus, but as it stands it will just kill this project even more than it a

D29242: WIP: redesign sidebar

2020-04-27 Thread Camilla Boemann
boemann added a comment. My immidiate reaction is no. Do you mind sharing a screenshot / drawing of what the end goal is here ? REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29242 To: ognarb Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognar

D29242: WIP: redesign sidebar

2020-04-27 Thread Camilla Boemann
boemann added a reviewer: boemann. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D29242 To: ognarb, boemann Cc: boemann, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, vandenoever

D29242: WIP: redesign sidebar

2020-04-28 Thread Camilla Boemann
boemann added a comment. Well you are definitely in the right class to make such changes. The thing is the current code was made to adopt to many different user wishes - so the user could choose What you are doing is to throw all that away - would it be impossible to have this new

D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Camilla Boemann
boemann added a comment. And that is why this proposal should be rejected as is pixels is not a unit unless assigned a ppi on a case by case basis and thus it needs to be something requested and not EVER something that is always available ! REPOSITORY R8 Calligra REVISION DETAIL

D15111: [KoUnit] Let's show pixel units

2020-05-15 Thread Camilla Boemann
boemann added a comment. Nothing prevents Karbon from having a m_pixelUnit with ppi collected from a widget for user control and the use that unit like inkscape does. But what this patch does is enable it in general with an arbitrary chosen ppi value Why not measure in apples t

D15111: [KoUnit] Let's show pixel units

2020-05-16 Thread Camilla Boemann
boemann added a comment. Even for line thickness it doesn't make sense to enable it in general. the image will change if you zoom in and out. If you want to have line thickness expressed as pixels based on a destination rendering, then you make a separate dialog, where you (in this speci

D15111: [KoUnit] Let's show pixel units

2020-05-16 Thread Camilla Boemann
boemann added a comment. All painting of documents is done in points the purpose of KoUnit is to allow the user to specify some size in any unit so that it internally can be converted to points. Pixels are very special in that they are not a unit at all, but for special cases like k

Re: Minimum dependency versions

2021-02-10 Thread Camilla Boemann
Hi Pierre Long time no see indeed I myself is only reading mails and answering some reviews now and then. Camilla On 10/02/2021 08.45.13, Pierre wrote: Hello friends Long time no see, how are you all? Life and health have kept me away from this project for too long, but as you may have seen f

Re: Minimum dependency versions

2021-02-10 Thread Camilla Boemann
I agree let's move ahead. We can't be defined by what Jolla does and needs However let's only do it if development is going to pick up. No need to annoy Jolla and then for everything to stall. On 10/02/2021 20.39.59, Carl Schwan wrote: Le mercredi, février 10, 2021 7:45 PM, Pierre a écrit : >

Re: Next release schedule/plans

2021-02-13 Thread Camilla Boemann
It has always been the rule that minor changes that you feel confident about is just pushed. Changes to architecture or user experience should be put up for review, and possibly even discussion. We have never required complete approval, but should carefully listen to objections and not do chang

Re: Clazy fixes and CI…

2021-02-13 Thread Camilla Boemann
I'd say just do it. The code i work on at work uses the new style too, and apart from a few places with overloaded signals or slots it is really easy to work with On 13/02/2021 14.43.59, Pierre wrote: Hi In order to rejuvenate a bit some parts of the code base, I am looking into Clazy, especia

Re: Krita donation proposal

2021-11-16 Thread Camilla Boemann
I'm fine with Krita and Plan taking everything. The money needs to work and not gather dust. And Krita seems a worthy candidate. If the donor agrees I don't know, but I would certainly support it. Camilla Boemann Calligra Words maintainer (by name mostly) On 16/11/2021 11.35.31, H

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-23 Thread Camilla Boemann
icon words/part/KWView.cpp <https://git.reviewboard.kde.org/r/118532/#comment42384> "section bounds" - Camilla Boemann On June 23, 2014, 9:07 a.m., Denis Kuplyakov wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 119138: Fix Bug 334832

2014-07-05 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119138/#review61673 --- Ship it! Ship It! - Camilla Boemann On July 5, 2014, 7:38

Re: Review Request 110928: Always save the position of a shape

2014-07-06 Thread Camilla Boemann
dismissing, based on the following: 1) It is not done as a result of a bug 2) It produces more output xml 3) The spec states what default values are, and we try not to write out default values in other cases. - Camilla Boemann On June 10, 2013, 7:18 p.m., Inge Wallin wrote

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Camilla Boemann
an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/108924/ > --- > > (Updated Feb. 18, 2013, 6:30 a.m.) > > > Review request for Calligra, Camilla Boemann and Laurent Montel.

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Camilla Boemann
> On July 6, 2014, 2:10 p.m., Friedrich W. H. Kossebau wrote: > > Was this ever committed? > > Camilla Boemann wrote: > Don't think so but I also don't think it belongs to calligra anymore. > Laurent, what do you think? > > Inge Wallin wrote: >

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-07-24 Thread Camilla Boemann
ng in kotext I also don't think it matters for an initial commit Great work - let's hope the users like it :) - Camilla Boemann On July 24, 2014, 1:42 p.m., Denis Kuplyakov wrote: > > --- > This is an automatically ge

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Camilla Boemann
the gui strings) I am fine with it getting merged. This is not a review though. I'll let someone else do that if they want to. - Camilla Boemann On Aug. 10, 2014, 4:02 p.m., Inge Wallin wrote: > > --- > This is an automatical

Re: Review Request 118643: Create an export filter for Wiki pages

2014-08-10 Thread Camilla Boemann
> On Aug. 10, 2014, 4:07 p.m., Camilla Boemann wrote: > > As long as it builds and and is marked as experimental (in the gui strings) > > I am fine with it getting merged. This is not a review though. I'll let > > someone else do that if they want to. > > I

Re: Review Request 120250: Change blockLayout return to be more explicit

2014-09-18 Thread Camilla Boemann
ch right now it should only have two possible values: OK and DONTFIT (which makes it kind of pointless right now but I am not going prevent it if you want it more than the bool) The real fix however is to fix the backtrack to not backtrack at all if it means removing everything on the page. -

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Camilla Boemann
too much - can you please check But it correctly doesn't back track at all if all blocks have keep with next - Camilla Boemann On Sept. 18, 2014, 6:01 p.m., Pierre Ducroquet wrote: > > --- > This is an automatically genera

Re: Review Request 120250: Don't infinitely loop when backtracking keepWithNext with a page break

2014-09-18 Thread Camilla Boemann
- great work - Camilla Boemann On Sept. 18, 2014, 7:41 p.m., Pierre Ducroquet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120375: Don't look further than what we are currently layouting

2014-09-25 Thread Camilla Boemann
- Camilla Boemann On Sept. 25, 2014, 10:11 p.m., Pierre Ducroquet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120468: Check cell size constraints before aborting layout

2014-10-02 Thread Camilla Boemann
ingCell tobe true then this change is pointless - Camilla Boemann On Oct. 2, 2014, 8:09 p.m., Pierre Ducroquet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 120468: Check cell size constraints before aborting layout

2014-10-03 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120468/#review67838 --- Ship it! Ship It! - Camilla Boemann On Oct. 3, 2014, 6:23

Re: Review Request 120645: Msword filter - Fix the page borders when there is a header/footer included in margin

2014-10-18 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120645/#review68663 --- Ship it! Ship It! - Camilla Boemann On Oct. 18, 2014, 2

Re: Review Request 115512: added add text popup menu to calligra

2014-10-21 Thread Camilla Boemann
undo/redo - why create new shape after undo redo - commands further down the stack will probably expect the same shape pointer to still be valid (just like you expect the containers to still be valid on the second call to redo I think this should be fixed - Camilla Boemann On Oct. 21, 2014, 5

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-23 Thread Camilla Boemann
of pages possibly this could be even smarter - Camilla Boemann On Oct. 23, 2014, 7:15 a.m., Pierre Ducroquet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 120756: Fix for bug 306097 - find does not work on the full document (Stage)

2014-10-23 Thread Camilla Boemann
org/r/120756/#comment48283> chane -> change libs/kotext/KoFind_p.cpp <https://git.reviewboard.kde.org/r/120756/#comment48284> so if there is no docment and the application doesn't do as kopa doeswe get into an edless loop ? - Camilla Boemann On Oct. 23, 2014, 4:16

Re: Review Request 120766: Remove no longer used widget classes KoUniColorDialog & KoOpacityConfigWidget

2014-10-23 Thread Camilla Boemann
se if they are no longer needed - Camilla Boemann On Oct. 23, 2014, 9:05 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-10-29 Thread Camilla Boemann
a bit uneasy about this - but at least it's in gui this time - Camilla Boemann On Oct. 29, 2014, 3:07 p.m., Dan Leinir Turthra Jensen wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-10-30 Thread Camilla Boemann
> On Oct. 29, 2014, 4:41 p.m., Camilla Boemann wrote: > > words/part/dockers/KWStatisticsWidget.cpp, line 295 > > <https://git.reviewboard.kde.org/r/120890/diff/1/?file=323538#file323538line295> > > > > a bit uneasy about this - but at least it's in

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-10-30 Thread Camilla Boemann
apidox for this method now - Camilla Boemann On Oct. 28, 2014, 8:29 a.m., Pierre Ducroquet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-07 Thread Camilla Boemann
> On Nov. 7, 2014, 12:13 p.m., Friedrich W. H. Kossebau wrote: > > Zagge and Boemann, your turn again :) At least I guess everyone is looking > > at you to give this a "Ship it", given it touches (and extends) mainly > > Words and Stage. Thorsten, I have no problem with words part - so if you

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-08 Thread Camilla Boemann
tAreaProvider.cpp <https://git.reviewboard.kde.org/r/120733/#comment48981> also it should be: type *var not: type* var plugins/textshape/SimpleRootAreaProvider.cpp <https://git.reviewboard.kde.org/r/120733/#comment48980> same - Camilla Boemann On Nov. 7, 2014, 11:38

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-08 Thread Camilla Boemann
non continous layout. That is - if the layout process is intererrupted and restarted we forget about the flowlayout being true - so we need to come up with a more robust way - or will we have releasedAllAfter in that case ??? - Camilla Boemann On Nov. 8, 2014, 12:20 p.m., Pierre Ducroquet

Re: Review Request 121214: Fix rendering of draw:g with a path with z commands & sync marker paths with LO

2014-11-23 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121214/#review70804 --- Ship it! Ship It! - Camilla Boemann On Nov. 23, 2014, 5

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-27 Thread Camilla Boemann
Also this line looks very weird libs/textlayout/KoTextDocumentLayout.cpp <https://git.reviewboard.kde.org/r/120733/#comment49595> same - Camilla Boemann On Nov. 26, 2014, 10:08 p.m., Pierre Ducroquet wrote: > > ---

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-27 Thread Camilla Boemann
tps://git.reviewboard.kde.org/r/120733/#comment49607> but doing nothing and not incrmenting ?? - Camilla Boemann On Nov. 27, 2014, 9:05 p.m., Pierre Ducroquet wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-27 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120733/#review71040 --- Ship it! Ship It! - Camilla Boemann On Nov. 27, 2014, 9

Re: Review Request 121336: Fix vector sapes resolution in Krita

2014-12-04 Thread Camilla Boemann
g/r/121336/#comment49816> since you call this at all times in the widget, and the equal operator checks this value even if type is not PIXEL, then this shouldn't be done if type is != PIXEL OR the equal oper should be changed - Camilla Boemann On Dec. 3, 2014, 10:53 a.m., Dmi

Re: Review Request 121336: Fix vector sapes resolution in Krita

2014-12-04 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121336/#review71349 --- Ship it! Ship It! - Camilla Boemann On Dec. 3, 2014, 10

Re: Review Request 121388: Remove rounding for pixels in KoUnit

2014-12-08 Thread Camilla Boemann
ve no objection from global pov. but (in krita) are you sure dialogs that give fractional pixel values makes sense to a user? - Camilla Boemann On Dec. 8, 2014, 1:17 p.m., Dmitry Kazakov wrote: > > --- > This is an automatically genera

Re: Review Request 119612: Implement an MDI interface for Krita

2014-12-08 Thread Camilla Boemann
curious as to why this change was needed? - Camilla Boemann On Dec. 8, 2014, 1:31 p.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 121753: Remove the shadowdocker

2014-12-31 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121753/#review72835 --- Ship it! Ship It! - Camilla Boemann On Dec. 30, 2014, 10

Re: Review Request 121752: Remove the ColorDocker and the KoUniColorChooser

2014-12-31 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121752/#review72836 --- fine with me - Camilla Boemann On Dec. 30, 2014, 10:32 a.m

Review Request 122238: KoStyleManager independence from kotext

2015-01-24 Thread Camilla Boemann
/r/122238/diff/ Testing --- only basic editing and seeing that undo/redo works and that changes are now actually appied to the document Thanks, Camilla Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-24 Thread Camilla Boemann
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122238/#review74674 ------- On Jan. 24, 2015, 7:27 p.m., Camilla Boemann wrote: > > ---

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-24 Thread Camilla Boemann
/KoTextShapeData.cpp c51ec6e sheets/Map.cpp a4fcc7c Diff: https://git.reviewboard.kde.org/r/122238/diff/ Testing --- only basic editing and seeing that undo/redo works and that changes are now actually appied to the document Thanks, Camilla Boemann

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-24 Thread Camilla Boemann
/KoTextShapeData.cpp c51ec6e sheets/Map.cpp a4fcc7c Diff: https://git.reviewboard.kde.org/r/122238/diff/ Testing --- only basic editing and seeing that undo/redo works and that changes are now actually appied to the document Thanks, Camilla Boemann

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-25 Thread Camilla Boemann
- Camilla --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122238/#review74689 --- On Jan. 25, 2015, 12:40 a.m., Camilla Boemann wro

Re: Review Request 122238: KoStyleManager independence from kotext

2015-01-25 Thread Camilla Boemann
/textlayout/KoTextShapeData.cpp c51ec6e sheets/Map.cpp a4fcc7c Diff: https://git.reviewboard.kde.org/r/122238/diff/ Testing --- only basic editing and seeing that undo/redo works and that changes are now actually appied to the document Thanks, Camilla Boemann

Re: Review Request 122254: Remove inline objects from manager in DeleteCommand

2015-01-25 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122254/#review74728 --- Ship it! Ship It! - Camilla Boemann On Jan. 25, 2015, 10

Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-26 Thread Camilla Boemann
: https://git.reviewboard.kde.org/r/122266/diff/ Testing --- ran cstester and did some manual testing, but should eally do it again Thanks, Camilla Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Camilla Boemann
it.reviewboard.kde.org/r/122266/#review74799 ------- On Jan. 26, 2015, 11:17 p.m., Camilla Boemann wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Camilla Boemann
ds specific stuff so yes they should be here. The library should in a perfect world not even know about shapes - Camilla --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122266/#review74

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Camilla Boemann
ot > > enough, is it? I see you take care about padding below, but you also need > > to take into account margin, right? > > Camilla Boemann wrote: > a utility method in KoBorder would be nice yes, but this is okay for me > though. > > Margin

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-27 Thread Camilla Boemann
words/part/KWRootAreaProvider.cpp d26f519 words/part/KWRootAreaProviderBase.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122266/diff/ Testing --- ran cstester and did some manual testing, but should eally do it again Thanks, Camilla Boemann

Re: Review Request 122278: Additional changes in section handling

2015-01-27 Thread Camilla Boemann
kDebu with area please libs/kotext/tests/TestKoTextEditor.cpp <https://git.reviewboard.kde.org/r/122278/#comment51876> same lot's of spaces - Camilla Boemann On Jan. 27, 2015, 5:56 p.m., Denis Kuplyakov wrote: > > ---

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-28 Thread Camilla Boemann
words/part/KWRootAreaProvider.cpp d26f519 words/part/KWRootAreaProviderBase.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122266/diff/ Testing --- ran cstester and did some manual testing, but should eally do it again Thanks, Camilla Boemann

Re: Review Request 122278: Additional changes in section handling

2015-01-28 Thread Camilla Boemann
> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > <https://git.reviewboard.kde.org/r/122278/diff/1/?file=345390#file345390line120> > > > > why no long const ? > > Denis Kuplyakov wrote: >

Re: Review Request 122278: Additional changes in section handling

2015-01-28 Thread Camilla Boemann
> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/commands/DeleteCommand.cpp, line 321 > > <https://git.reviewboard.kde.org/r/122278/diff/1/?file=345394#file345394line321> > > > > yikes > > Denis Kuplyakov wrote: > QVarian

Re: Review Request 122278: Additional changes in section handling

2015-01-29 Thread Camilla Boemann
> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > <https://git.reviewboard.kde.org/r/122278/diff/1/?file=345390#file345390line120> > > > > why no long const ? > > Denis Kuplyakov wrote: >

Re: Review Request 122278: Additional changes in section handling

2015-01-29 Thread Camilla Boemann
> On Jan. 27, 2015, 7:34 p.m., Camilla Boemann wrote: > > libs/kotext/commands/DeleteCommand.cpp, line 321 > > <https://git.reviewboard.kde.org/r/122278/diff/1/?file=345394#file345394line321> > > > > yikes > > Denis Kuplyakov wrote: > QVarian

Re: Review Request 122306: Fix bug 260088 - assert when ungrouping group

2015-01-29 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122306/#review74986 --- Ship it! Ship It! - Camilla Boemann On Jan. 29, 2015, 3

Re: Review Request 122278: Additional changes in section handling

2015-01-31 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122278/#review75077 --- Ship it! Ship It! - Camilla Boemann On Jan. 31, 2015, 4

Re: Review Request 122546: Core changes to implement outliner for Author

2015-02-12 Thread Camilla Boemann
g/r/122546/#comment52404> not that i care much but author files in wordsprivate library ? will this not be something we would have to clean up in the future if we let it slip in now? - Camilla Boemann On Feb. 12, 2015, 8:22 p.m., Denis Kuplyakov

Re: Review Request 122753: [Krita] add the option to show/hide the title bars of the dockers to the settings menu

2015-02-28 Thread Camilla Boemann
said we are closed for features until 3.0 is released libs/widgets/KoDockWidgetTitleBar.cpp <https://git.reviewboard.kde.org/r/122753/#comment52839> {} even on one liner - Camilla Boemann On Feb. 28, 2015, 1:01 p.m., Moritz

Re: Review Request 122753: [Krita] add the option to show/hide the title bars of the dockers to the settings menu

2015-03-02 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122753/#review76876 --- Ship it! Ship It! - Camilla Boemann On March 2, 2015, 10

Re: Review Request 122546: Core changes to implement outliner for Author

2015-03-24 Thread Camilla Boemann
in your on branch until 3.0 is out please - Camilla Boemann On March 24, 2015, 4:53 p.m., Denis Kuplyakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 122546: Core changes to implement outliner for Author

2015-03-24 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122546/#review78010 --- ah cool :) - Camilla Boemann On March 24, 2015, 4:53 p.m

Review Request 123195: fix various bugs related to footnotes

2015-03-31 Thread Camilla Boemann
ugins/textshape/dialogs/NotesConfigurationDialog.cpp 96aae3c Diff: https://git.reviewboard.kde.org/r/123195/diff/ Testing --- only manual testing Thanks, Camilla Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/ma

Re: Review Request 123195: fix various bugs related to footnotes

2015-03-31 Thread Camilla Boemann
the first point - Camilla --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123195/#review78299 --- On March 31, 2015, 11:25 a.m.,

Re: Review Request 123195: fix various bugs related to footnotes

2015-03-31 Thread Camilla Boemann
ese that check if there > > already are default styles for footnotes etc? And regarding the anchors, > > shouldn't they be superscript by default? > > Camilla Boemann wrote: > for anchors i've just done like LO > and well i guess you are right about the first p

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-05 Thread Camilla Boemann
> On March 10, 2015, 4:35 a.m., Thorsten Zachmann wrote: > > The patch looks good to me. > > Robert Mathias Marmorstein wrote: > I downloaded the tests from calligratests, but haven't been able to get > the QPro plugin to work well enough to test this at all. I'm really hesitant > to comm

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-04-16 Thread Camilla Boemann
I'm really hesitant > to commit without further testing. To be completely frank, this plugin seems > to be in pretty bad shape. Someone with more experience than me should > probably look it over and decide if it's worth keeping. > > Camilla Boemann wrote: > I d

Re: Review Request 123195: fix various bugs related to footnotes

2015-04-16 Thread Camilla Boemann
https://git.reviewboard.kde.org/r/123195/diff/ Testing --- only manual testing Thanks, Camilla Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123391: Remove broken and not-build-for-1-1/2-years googledocs plugin

2015-04-16 Thread Camilla Boemann
plugin asap - Camilla Boemann On April 16, 2015, 8:03 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 123660: Improve KoFindToolbar

2015-05-06 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123660/#review79972 --- Ship it! Ship It! - Camilla Boemann On May 6, 2015, 2:07

Re: Review Request 123670: Less complicated look up of template locations, fix referencing templates in Author & Krita Sketch/Gemini

2015-05-06 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123670/#review80010 --- non krita parts has my blessing - Camilla Boemann On May 7

Re: Review Request 123981: Port words page settings dialog to KF5

2015-06-02 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123981/#review81068 --- Ship it! Ship It! - Camilla Boemann On June 1, 2015, 7:28

Re: Review Request 123977: Make words configure dialog work in KF5

2015-06-02 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123977/#review81069 --- Ship it! Ship It! - Camilla Boemann On June 1, 2015, 5:20

Re: Review Request 124036: a bit more porting to writeodf

2015-06-07 Thread Camilla Boemann
like this before 3.2 besides i would prefer no use of namespace and also that we dn't end up with a mix of two different writing frameworks in our code That said the framework in itself looks like a good idea - Camilla Boemann On June 7, 2015, 6:12 p.m., Jos van

Re: Review Request 124036: a bit more porting to writeodf

2015-06-07 Thread Camilla Boemann
> On June 8, 2015, 5:49 a.m., Camilla Boemann wrote: > > I'd prefer that we don't do any kind of porting like this before 3.2 > > > > besides i would prefer no use of namespace and also that we dn't end up > > with a mix of two different writing fra

Re: Review Request 124508: Extending KoTextVisitor to handle table and cell visiting customly

2015-07-28 Thread Camilla Boemann
) <https://git.reviewboard.kde.org/r/124508/#comment57371> partly argument should be true in this case I think - Camilla Boemann On July 28, 2015, 1:30 p.m., Soma Schliszka wrote: > > --- > This is an automatically g

Re: Review Request 124508: Extending KoTextVisitor to handle table and cell visiting customly

2015-07-28 Thread Camilla Boemann
isit: > https://git.reviewboard.kde.org/r/124508/ > --- > > (Updated July 28, 2015, 1:30 p.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > The KoTextVisitor is extended w

Re: Review Request 124508: Extending KoTextVisitor to handle table and cell visiting customly

2015-07-29 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124508/#review83140 --- Ship it! Ship It! - Camilla Boemann On July 29, 2015, 10

Re: Review Request 124641: Refactoring KoTextEditor::recursivelyVisitSelection() to make it cleaner and easier to understand

2015-08-06 Thread Camilla Boemann
when it can't possobly build ? libs/kotext/KoTextEditor.cpp (line 401) <https://git.reviewboard.kde.org/r/124641/#comment57702> how can this compile when the variables are defined after ? - Camilla Boemann On Aug. 6, 2015, 10:14 a.m., Soma Schl

RE: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

2015-08-28 Thread Camilla Boemann
-Original Message- Camilla, you also looked into that reformatting, no? Could you collect further experiences how to do that? I looked into a small program that could format the initializer list - but forgot all about it - I can look at it again on Tuesday - but it was meant to be ru

RE: After 2.9.7

2015-08-29 Thread Camilla Boemann
can only hope splitting libs will not produce the same fate Best regards Camilla Boemann -Original Message- From: calligra-devel [mailto:calligra-devel-boun...@kde.org] On Behalf Of Boudewijn Rempt Sent: 29. august 2015 09:38 To: Calligra Suite developers and users mailing list Subject

<    1   2   3   >