----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123391/#review79084 -----------------------------------------------------------
Ship it! has my blessing unless someone offers to fix the plugin asap - Camilla Boemann On April 16, 2015, 8:03 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123391/ > ----------------------------------------------------------- > > (Updated April 16, 2015, 8:03 p.m.) > > > Review request for Calligra and Mani Chandrasekar. > > > Repository: calligra > > > Description > ------- > > When Calligra was switched from KParts to the own KoPart system, the > googledocs plugin suffered from being based on KPart::Plugin. Since it was > disabled due to that from build in October 2013, noone has cared about it, > and given it has been in staging for 3 years before that, without leaving > that, also does not make me much hope this will change anytime soon :( > > So, given no maintainer, spring cleaning time and also the platform port, I > propose to remove the plugin now, noting it like the other stuff removed > before in the OBSOLETE.txt. So when somebody has time and interest one day > again, they know where to find something to start from :) > > For keeping 2.9 close to frameworks, I propose to remove the plugin already > in 2.9. > > I would commit this April 30th, unless someone objects (and IMHO only some > again working plugin would be a real objection :) ) > > > Diffs > ----- > > CalligraProducts.cmake d63f2f1 > OBSOLETE.TXT 930252f > doc/stage/menus.docbook 2044bbe > plugins/staging/CMakeLists.txt 16f36d7 > plugins/staging/googledocs/CMakeLists.txt 07a9569 > plugins/staging/googledocs/Messages.sh d6dd433 > plugins/staging/googledocs/authenticationdialog.ui b1c1853 > plugins/staging/googledocs/documentlist.ui 7354879 > plugins/staging/googledocs/documentlistwindow.h 149598d > plugins/staging/googledocs/documentlistwindow.cpp f72fbe1 > plugins/staging/googledocs/googlecontenthandler.h 6bcce67 > plugins/staging/googledocs/googlecontenthandler.cpp fe27cdf > plugins/staging/googledocs/googledocs-sheets.rc 209c84a > plugins/staging/googledocs/googledocs-stage.rc 209c84a > plugins/staging/googledocs/googledocs-words.rc 209c84a > plugins/staging/googledocs/googledocument.h 88b4aaa > plugins/staging/googledocs/googledocument.cpp 6b0bc42 > plugins/staging/googledocs/googledocumentlist.h a929914 > plugins/staging/googledocs/googledocumentlist.cpp 40b7ece > plugins/staging/googledocs/googledocumentservice.h db1f918 > plugins/staging/googledocs/googledocumentservice.cpp e8d377a > plugins/staging/googledocs/images/dialog-cancel.png edc89a8 > plugins/staging/googledocs/images/document-import.png 0453157 > plugins/staging/googledocs/images/document.png 8d7b377 > plugins/staging/googledocs/images/presentation.png d2a21d9 > plugins/staging/googledocs/images/spreadsheet.png 9f8c807 > plugins/staging/googledocs/loginwindow.h a96abbf > plugins/staging/googledocs/loginwindow.cpp d1bf866 > plugins/staging/googledocs/onlinedocument.h bdf7666 > plugins/staging/googledocs/onlinedocument.cpp d6d0872 > plugins/staging/googledocs/onlineservices.qrc 9c32924 > > Diff: https://git.reviewboard.kde.org/r/123391/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
