----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120468/#review67828 -----------------------------------------------------------
Ship it! I like the solution - it's much more explicit than what I had in mind You have a ship-it in theory however there is just too many small issues that I've pointed out so I suggest one more review iteration just to be sure if you please libs/textlayout/KoTextLayoutTableArea.cpp <https://git.reviewboard.kde.org/r/120468/#comment47233> { } even for single lines also i think we can just as well move this down where we have similar code 10 lines below libs/textlayout/KoTextLayoutTableArea.cpp <https://git.reviewboard.kde.org/r/120468/#comment47232> since rowHasExactHeight in order for ignoreMisFittingCell tobe true then this change is pointless - Camilla Boemann On Oct. 2, 2014, 8:09 p.m., Pierre Ducroquet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120468/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 8:09 p.m.) > > > Review request for Calligra and Camilla Boemann. > > > Bugs: 293337 > http://bugs.kde.org/show_bug.cgi?id=293337 > > > Repository: calligra > > > Description > ------- > > Check cell size constraints regarding requested row height to prevent > infinite looking for space. > When fixed row height < padding + borders, things go really bad : we are > starving for space, but we can never get past this demand. > My current solution is to acknowledge that we are in an impossible situation > and, instead of asking for space, layout knowing that nothing fits in there. > > > Diffs > ----- > > libs/textlayout/KoTextLayoutTableArea.cpp > 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a > > Diff: https://git.reviewboard.kde.org/r/120468/diff/ > > > Testing > ------- > > Document from bug report 293337 is now working, so both regular tables and > weird too-small cells work. > > > Thanks, > > Pierre Ducroquet > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
