> On Aug. 10, 2014, 4:07 p.m., Camilla Boemann wrote: > > As long as it builds and and is marked as experimental (in the gui strings) > > I am fine with it getting merged. This is not a review though. I'll let > > someone else do that if they want to. > > Inge Wallin wrote: > It's not really experimental. It's just not complete. The things that > are in there work well.
well incomplete then - just so we warn the user that we know there is still work to do - Camilla ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118643/#review64181 ----------------------------------------------------------- On Aug. 10, 2014, 4:02 p.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118643/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2014, 4:02 p.m.) > > > Review request for Calligra, Camilla Boemann, Lassi Nieminen, mojtaba shahi, > and Thorsten Zachmann. > > > Repository: calligra > > > Description > ------- > > This patch contains an export filter for wiki pages from odt files. It's done > by request of the KDE documentation people, mainly mamarok. > > Note that not all of the wiki spec is supported yet. Most notably, tables are > not supported yet but that is the main priority for the next feature > inclusion. Also links needs more work. But there is support for lists, > headers, some general formatting and of course text in general. > > (Originally moji was going to put up this review but he got a pain in his > hands so I offered to do it instead. I may have missed some important comment > but I'm sure he will add to the comments then.) > > > Diffs > ----- > > filters/libodf2/CMakeLists.txt 8829a3c > filters/libodf2/KoOdfListLevelProperties.h PRE-CREATION > filters/libodf2/KoOdfListLevelProperties.cpp PRE-CREATION > filters/libodf2/KoOdfListStyle.h PRE-CREATION > filters/libodf2/KoOdfListStyle.cpp PRE-CREATION > filters/libodf2/KoOdfStyleManager.h 9bc51f4 > filters/libodf2/KoOdfStyleManager.cpp 7e558c7 > filters/libodf2/KoOdfStyleProperties.cpp f9d6d10 > filters/libodfreader/OdfTextReader.h f5636e4 > filters/libodfreader/OdfTextReader.cpp 31dfba5 > filters/libodfreader/OdfTextReaderBackend.h 4c82a02 > filters/libodfreader/OdfTextReaderBackend.cpp b6beb7d > filters/words/CMakeLists.txt 805ca28 > filters/words/wiki/CMakeLists.txt PRE-CREATION > filters/words/wiki/export/CMakeLists.txt PRE-CREATION > filters/words/wiki/export/OdfReaderWikiContext.h PRE-CREATION > filters/words/wiki/export/OdfReaderWikiContext.cpp PRE-CREATION > filters/words/wiki/export/OdtReaderWikiBackend.h PRE-CREATION > filters/words/wiki/export/OdtReaderWikiBackend.cpp PRE-CREATION > filters/words/wiki/export/WikiExport.h PRE-CREATION > filters/words/wiki/export/WikiExport.cpp PRE-CREATION > filters/words/wiki/export/words_wiki_export.desktop PRE-CREATION > filters/words/wiki/wiki-format.xml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118643/diff/ > > > Testing > ------- > > Lots of manual testing during development > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
