----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120766/#review69066 -----------------------------------------------------------
As far as I'm concerned it makes sense to remove those if they are no longer needed - Camilla Boemann On Oct. 23, 2014, 9:05 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120766/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 9:05 p.m.) > > > Review request for Calligra, Camilla Boemann and Boudewijn Rempt. > > > Repository: calligra > > > Description > ------- > > While checking the includes for classes from libkowidgets I found those two > classes are no longer used by any code, so I propose to remove them as dead > code. > > Last usage of KoUniColorDialog was removed in > 53356cb20f1100edf716beba8c407953b3c692ec (by rempt) > Last usage of KoOpacityConfigWidget was removed in > 76242efb3bd5a116f034ef785c0a2e9e3608fc64 (by boemann) > > > Diffs > ----- > > libs/widgets/CMakeLists.txt 324b762 > libs/widgets/KoOpacityConfigWidget.h 6fc81ef > libs/widgets/KoOpacityConfigWidget.cpp 48d6395 > libs/widgets/KoUniColorDialog.h 4cce042 > libs/widgets/KoUniColorDialog.cpp 935b644 > plugins/defaultTools/defaulttool/DefaultTool.cpp f26d4bf > > Diff: https://git.reviewboard.kde.org/r/120766/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
