Re: Review Request 130196: Add a seed parameter to make the qHash used

2017-07-22 Thread Camilla Boemann
ated July 22, 2017, 7:50 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > --- > > Without the seed parameter, the default qHash for QPair is used. > The seed argument in qHash was introduced in Qt 5.0. The qHa

Re: Review Request 130196: Add a seed parameter to make the qHash used

2017-07-22 Thread Jos van den Oever
discarded. Review request for Calligra. Repository: calligra Description --- Without the seed parameter, the default qHash for QPair is used. The seed argument in qHash was introduced in Qt 5.0. The qHash for KoXmlStringPair did not have it and hence it was an unused function. Diffs

Review Request 130196: Add a seed parameter to make the qHash used

2017-07-22 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130196/ --- Review request for Calligra. Repository: calligra Description

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-17 Thread René J . V . Bertin
anywhere in Calligra's code. But without a Windows dev system to verify this I cannot propose to drop setting XDG_DATA_DIRS. - René J.V. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129800/#review101926

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-17 Thread Dag Andersen
moved but I don't know if any other app depends on this, so... - Dag --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129800/#review101926 -----

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-16 Thread René J . V . Bertin
4 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129800/ > --- > > (Updated

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-16 Thread Dag Andersen
- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129800/ > --- > > (Updated Jan. 10, 2017, 4:34 p.m.) > > > Review request for Calligra and Camilla Boemann. &g

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-14 Thread René J . V . Bertin
> > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129800/ > --- > > (Updated Jan. 10, 2017, 5:34 p.m.) >

Re: Review Request 129804: [Mac] enable app icon generation from the SVG icon (potentially for MS Windows too)

2017-01-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129804/ --- (Updated Jan. 14, 2017, 8:19 p.m.) Review request for Calligra and KDE

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-14 Thread Anthony Fieroni
; --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129800/ > --- > > (Updated Ян. 10, 2017, 6:34 след обяд) > > > Review request for Calligra and Cami

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-14 Thread René J . V . Bertin
wboard.kde.org/r/129800/#review101926 --- On Jan. 10, 2017, 5:34 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 129682: calligra: Update Czech Republic to Czechia

2017-01-11 Thread Jiri Bohac
marked as submitted. Review request for Calligra and Albert Astals Cid. Changes --- Submitted with commit 0108ade94d1e4055d86fe7eba6398868980b480b by Albert Astals Cid on behalf of Jiri Bohac to branch master. Repository: calligra Description --- This year the country has

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-11 Thread René J . V . Bertin
17, 5:34 p.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129800/ > --- > > (Updated

Re: Review Request 129804: [Mac] enable app icon generation from the SVG icon (potentially for MS Windows too)

2017-01-11 Thread René J . V . Bertin
This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129804/ > ------- > > (Updated Jan. 11, 2017, 4:30 p.m.) > > > Review request for Calligra and KDE Software on Mac OS X. >

Re: Review Request 129804: [Mac] enable app icon generation from the SVG icon (potentially for MS Windows too)

2017-01-11 Thread Anthony Fieroni
eply, visit: > https://git.reviewboard.kde.org/r/129804/ > --- > > (Updated Jan. 11, 2017, 5:30 p.m.) > > > Review request for Calligra and KDE Software on Mac OS X. > > > Repository: calligra > > > D

Re: Review Request 129804: [Mac] enable app icon generation from the SVG icon (potentially for MS Windows too)

2017-01-11 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129804/ --- (Updated Jan. 11, 2017, 4:30 p.m.) Review request for Calligra

Review Request 129804: [Mac] enable app icon generation from the SVG icon (potentially for MS Windows too)

2017-01-11 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129804/ --- Review request for Calligra. Repository: calligra Description

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-10 Thread René J . V . Bertin
-- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129800/ > ----------- > > (Updated Jan. 10, 2017, 5:34 p.m.) > > > Review request for Calligra and

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-10 Thread Anthony Fieroni
.kde.org/r/129800/ > --- > > (Updated Ян. 10, 2017, 6:34 след обяд) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > This proposal is an initial

Re: Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-10 Thread Anthony Fieroni
enerated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129800/ > --- > > (Updated Ян. 10, 2017, 6:34 след обяд) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra >

Review Request 129800: [Mac] : prepare for "linuxy" vs. standalone app bundle builds

2017-01-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129800/ --- Review request for Calligra. Repository: calligra Description

Re: Review Request 129782: [calligra] Buildsystem improvements

2017-01-06 Thread Andreas Sturmlechner
marked as submitted. Review request for Calligra. Changes --- Submitted with commit fa570206a99ed8293cf80977adbedc4c6436efbd by Andreas Sturmlechner to branch master. Repository: calligra Description --- 3 commits: - Make Activities and KF5Html really optional. Before, trying to

Re: Review Request 129782: [calligra] Buildsystem improvements

2017-01-06 Thread Camilla Boemann
(Updated Jan. 6, 2017, 10:58 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > --- > > 3 commits: > > - Make Activities and KF5Html really optional. > Before, trying to use CMAKE_DISABLE_FIND_PACKAGE_

Review Request 129782: [calligra] Buildsystem improvements

2017-01-06 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129782/ --- Review request for Calligra. Repository: calligra Description

Re: Review Request 129682: calligra: Update Czech Republic to Czechia

2016-12-21 Thread Camilla Boemann
c. 20, 2016, 9:09 p.m.) > > > Review request for Calligra and Albert Astals Cid. > > > Repository: calligra > > > Description > --- > > This year the country has oficially adopted the short name Czechia. > The short name has been entered to the UNTER

Review Request 129682: calligra: Update Czech Republic to Czechia

2016-12-20 Thread Jiri Bohac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129682/ --- Review request for Calligra and Albert Astals Cid. Repository: calligra

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-26 Thread Camilla Boemann
karbon you can just commit without review request - we will review when we see the commit mails - just don't break build or push big stuff without some kind of warning etc - Camilla Boemann On Nov. 26, 2016, 6:12 a.m., Anthony Fieroni

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-25 Thread Anthony Fieroni
been marked as submitted. Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau. Repository: calligra Description --- As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so i can be Co-Maintainer, i'm missing experience with graphics nor v

Re: Review Request 129514: [connectionTool] Check dynamic_cast return type

2016-11-25 Thread Anthony Fieroni
marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit f3f26b78c7b792e9f5de480d2fd00c98a48d8ba2 by Anthony Fieroni to branch master. Bugs: 326258 http://bugs.kde.org/show_bug.cgi?id=326258 Repository: calligra Description

Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

2016-11-25 Thread Anthony Fieroni
marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit d5c8f3d4690f4e7223b11442bf1e4ef3b1f0d10a by Anthony Fieroni to branch master. Repository: calligra Description --- Still has icons who are drown incorrect, i blame factory, but

Re: Review Request 129514: [connectionTool] Check dynamic_cast return type

2016-11-25 Thread Camilla Boemann
ated Nov. 21, 2016, 5:42 a.m.) > > > Review request for Calligra and Camilla Boemann. > > > Bugs: 326258 > http://bugs.kde.org/show_bug.cgi?id=326258 > > > Repository: calligra > > > Description > --- > > I can't reproduce these da

Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

2016-11-24 Thread Dag Andersen
d Nov. 21, 2016, 4:54 a.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > Still has icons who are drown incorrect, i blame factory, but need more > invetigates. > > &g

Re: Review Request 129514: [connectionTool] Check dynamic_cast return type

2016-11-24 Thread Anthony Fieroni
org/r/129514/ > --- > > (Updated Ноев. 21, 2016, 7:42 преди обяд) > > > Review request for Calligra and Camilla Boemann. > > > Bugs: 326258 > http://bugs.kde.org/show_bug.cgi?id=326258 > > > Repository: calligra > > > Description > --- > > I ca

Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

2016-11-24 Thread Anthony Fieroni
; > (Updated Ноев. 21, 2016, 6:54 преди обяд) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > Still has icons who are drown incorrect, i blame factory, but need more > inve

Re: Review Request 129531: [flake] Serialize / deserialize svg conicalGradient

2016-11-23 Thread Anthony Fieroni
marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit 823fed356b2ca0052428a5aa98240f318e586268 by Anthony Fieroni to branch master. Repository: calligra Description --- Enable write / parse conicalGradient Diffs - libs

Re: Review Request 129531: [flake] Serialize / deserialize svg conicalGradient

2016-11-23 Thread Camilla Boemann
board.kde.org/r/129531/ > --- > > (Updated Nov. 22, 2016, 9:07 p.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > Enable write

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

2016-11-23 Thread Camilla Boemann
ated Nov. 23, 2016, 5:36 a.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > + fullscreen action provide warning on runtime "Use > actionCollection->setDefaultShortcut in

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

2016-11-22 Thread Anthony Fieroni
marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit 4fb2711afc1125efdcc009d9e20ca05a4405b735 by Anthony Fieroni to branch master. Repository: calligra Description --- + fullscreen action provide warning on runtime &quo

Re: Review Request 129531: [flake] Serialize / deserialize svg conicalGradient

2016-11-22 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129531/ --- (Updated Ноев. 22, 2016, 11:07 след обяд) Review request for Calligra

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

2016-11-22 Thread Camilla Boemann
org/r/129532/ > --- > > (Updated Nov. 22, 2016, 8:30 p.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > + fullscreen action provide warning on runtime "Use > act

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

2016-11-22 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129532/ --- (Updated Ноев. 22, 2016, 10:30 след обяд) Review request for Calligra

Re: Review Request 129532: [shortcuts] Undo / Redo shortkeys

2016-11-22 Thread Camilla Boemann
eply, visit: > https://git.reviewboard.kde.org/r/129532/ > --- > > (Updated Nov. 22, 2016, 7:27 p.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description &g

Review Request 129532: [shortcuts] Undo / Redo shortkeys

2016-11-22 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129532/ --- Review request for Calligra and Camilla Boemann. Repository: calligra

Re: Review Request 129531: [flake] Serialize / deserialize svg canonicalGradient

2016-11-22 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129531/ --- (Updated Ноев. 22, 2016, 8:53 след обяд) Review request for Calligra and

Review Request 129531: [flake] Serialize / deserialize svg canonicalGradient

2016-11-22 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129531/ --- Review request for Calligra and Camilla Boemann. Repository: calligra

Review Request 129514: [connectionTool] Check dynamic_cast return type

2016-11-20 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129514/ --- Review request for Calligra and Camilla Boemann. Bugs: 326258 http

Re: Review Request 129512: [stencil] Follow system color for stencilsdocker icons

2016-11-20 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129512/ --- (Updated Ноев. 21, 2016, 6:54 преди обяд) Review request for Calligra

Review Request 129512: [stencil] Follow system color for stencilsdocker icons

2016-11-20 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129512/ --- Review request for Calligra and Camilla Boemann. Repository: calligra

Re: Review Request 129437: [widgets] Make sure destination xml file path exist

2016-11-20 Thread Anthony Fieroni
marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit 6657dac8e5f14e89586790e2f51a5c858432b05b by Anthony Fieroni to branch master. Repository: calligra Description --- Otherwise it shown warning message ""Cannot

Re: Review Request 129438: [karbon] Correct usage of KPageDialog in KarbonConfigureDialog.cpp

2016-11-20 Thread Anthony Fieroni
marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit 64c64378f1eb2cfaf6ba51c18387af099583396d by Anthony Fieroni to branch master. Repository: calligra Description --- Now config dialog saves changes correct, it's a porting s

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-20 Thread Camilla Boemann
reply, visit: https://git.reviewboard.kde.org/r/129421/#review100920 --- On Nov. 19, 2016, 7:38 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/

Re: Review Request 129438: [karbon] Correct usage of KPageDialog in KarbonConfigureDialog.cpp

2016-11-20 Thread Camilla Boemann
ated Nov. 20, 2016, 9:42 a.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > Now config dialog saves changes correct, it's a porting script bug > > > Diffs > - &g

Re: Review Request 129437: [widgets] Make sure destination xml file path exist

2016-11-20 Thread Camilla Boemann
ated Nov. 20, 2016, 9:37 a.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > Otherwise it shown warning message ""Cannot write meta information to..." > > &g

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-20 Thread Anthony Fieroni
wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129421/ > --- > > (Updated Ноев. 19, 2016, 9

Review Request 129438: [karbon] Correct usage of KPageDialog in KarbonConfigureDialog.cpp

2016-11-20 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129438/ --- Review request for Calligra and Camilla Boemann. Repository: calligra

Review Request 129437: [widgets] Make sure destination xml file path exist

2016-11-20 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129437/ --- Review request for Calligra and Camilla Boemann. Repository: calligra

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-20 Thread René J . V . Bertin
On Saturday November 19 2016 21:52:21 Camilla Boemann wrote: >> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, >> so i can be Co-Maintainer, i'm missing experience with graphics nor vector >> graphics software but i will try to help and fixing bugs. Let me just say t

Re: Review Request 129435: [shapefiltereffects] Update ConvolveMatrixEffect kernel accordingly to order

2016-11-19 Thread Anthony Fieroni
marked as submitted. Review request for Calligra, Camilla Boemann, Friedrich W. H. Kossebau, and Yue Liu. Changes --- Submitted with commit 9d8146e05b96ba8245816a06e087f1cc88af2a2e by Anthony Fieroni to branch master. Bugs: 353816 http://bugs.kde.org/show_bug.cgi?id=353816

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Camilla Boemann
t.reviewboard.kde.org/r/129421/#review100920 --- On Nov. 19, 2016, 7:38 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 129435: [shapefiltereffects] Update ConvolveMatrixEffect kernel accordingly to order

2016-11-19 Thread Camilla Boemann
ated Nov. 19, 2016, 4:33 p.m.) > > > Review request for Calligra, Camilla Boemann, Friedrich W. H. Kossebau, and > Yue Liu. > > > Bugs: 353816 > http://bugs.kde.org/show_bug.cgi?id=353816 > > > Repository: calligra > > > Description > -

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Anthony Fieroni
ieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129421/ > --- > > (Updated Ноев. 19, 2016, 9:

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Camilla Boemann
ail. To reply, visit: > https://git.reviewboard.kde.org/r/129421/ > --- > > (Updated Nov. 19, 2016, 7:38 p.m.) > > > Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau. > > > Repository: c

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129421/ --- (Updated Ноев. 19, 2016, 9:38 след обяд) Review request for Calligra

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Anthony Fieroni
лед обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129421/ > --- > > (Updated

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Camilla Boemann
--- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129421/ > --- > > (Updated Nov. 17, 2016, 8:09 p.m.) > > > Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau. > > > Repository: calligr

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Anthony Fieroni
atically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129421/ > ----------- > > (Updated Ноев. 17, 2016, 10:09 след обяд) > > > Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau. > > > Repository: calli

Review Request 129435: [shapefiltereffects] Update ConvolveMatrixEffect kernel accordingly to order

2016-11-19 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129435/ --- Review request for Calligra, Camilla Boemann, Friedrich W. H. Kossebau

Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-17 Thread Camilla Boemann
nthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129421/ > --- > > (Updated Nov. 17, 2016, 8:09 p.m.) > > > Review request for Call

Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-17 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129421/ --- Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau

Re: Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7

2016-11-17 Thread Anthony Fieroni
marked as submitted. Review request for Calligra and Friedrich W. H. Kossebau. Changes --- Submitted with commit 821f1048d5ff74d996dbb7cdcfca5405f5ab5b57 by Anthony Fieroni to branch master. Repository: calligra Description --- ^^ Diffs - braindump/plugins/stateshape

Re: Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7

2016-11-17 Thread Camilla Boemann
ated Nov. 17, 2016, 6:54 p.m.) > > > Review request for Calligra and Friedrich W. H. Kossebau. > > > Repository: calligra > > > Description > --- > > ^^ > > > Diffs > - > > braindump/plugins/stateshape/CategorizedItemDelegat

Review Request 129420: [calligra] Remove obsolete typedefs, deprecated since Qt 5.7

2016-11-17 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129420/ --- Review request for Calligra and Friedrich W. H. Kossebau. Repository

Fwd: Review Request 7183: Add trunk l10n-kf5/[lang]/data/global/autocorrect files

2016-09-14 Thread Burkhard Lück
Forwarding to Laurent Montel and calligra-devel, both not on svn.reviewboard.kde.org -- Weitergeleitete Nachricht -- Betreff: Review Request 7183: Add trunk l10n-kf5/[lang]/data/global/ autocorrect files Datum: Mittwoch, 14. September 2016, 11:47:12 CEST Von: Burkhard Lück An

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

2016-03-27 Thread Friedrich W. H. Kossebau
marked as submitted. Review request for Calligra and Camilla Boemann. Changes --- Submitted with commit ad8223ed1097f3ecc959a6f1bd5e3a0c7f7d0e8e by Friedrich W. H. Kossebau to branch master. Repository: calligra Description --- A first approach to collect chars and their positions

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

2016-03-27 Thread Friedrich W. H. Kossebau
- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127371/ > --- > > (Updated March 18, 2016, 12:56 a.m.) > > > Review request for Calligra and

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

2016-03-26 Thread Camilla Boemann
gt; (Updated March 18, 2016, 12:56 a.m.) > > > Review request for Calligra and Camilla Boemann. > > > Repository: calligra > > > Description > --- > > A first approach to collect chars and their positions on a given page, as > needed by Okular. &

Re: Review Request 127338: Fix loading documents containing nested tables

2016-03-25 Thread Laszlo Pasztor
discarded. Review request for Calligra and Camilla Boemann. Bugs: https://bugs.kde.org/show_bug.cgi?id=359700 http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=359700 Repository: calligra Description --- Fix: in Calligra Words inserting a table to the first

Re: Review Request 124641: Refactoring KoTextEditor::recursivelyVisitSelection() to make it cleaner and easier to understand

2016-03-25 Thread Soma Schliszka
discarded. Review request for Calligra, Camilla Boemann and Thorsten Zachmann. Repository: calligra Description --- The KoTextEditor::recursivelyVisitSelection() function had a bit complex conditional expression when there is a table inside the selection. This change is following the

Re: Review Request 124641: Refactoring KoTextEditor::recursivelyVisitSelection() to make it cleaner and easier to understand

2016-03-24 Thread Camilla Boemann
ply, visit: > https://git.reviewboard.kde.org/r/124641/ > --- > > (Updated Aug. 6, 2015, 11:48 a.m.) > > > Review request for Calligra, Camilla Boemann and Thorsten Zachmann. > > > Repository: calligra &g

Re: Review Request 127338: Fix loading documents containing nested tables

2016-03-24 Thread Camilla Boemann
o reply, visit: > https://git.reviewboard.kde.org/r/127338/ > --- > > (Updated March 11, 2016, 12:08 a.m.) > > > Review request for Calligra and Camilla Boemann. > > > Bugs: https://bugs.kde.org/show_bu

Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

2016-03-19 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127371/ --- Review request for Calligra and Camilla Boemann. Repository: calligra

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

2016-03-18 Thread Camilla Boemann
H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127371/ > --- > > (Updated March 18, 2016, 12:56 a.m.) > > >

Re: Review Request 127347: Fix build with glibc >= 2.23 by using qIsNaN

2016-03-11 Thread Heiko Becker
marked as submitted. Review request for Calligra. Changes --- Submitted with commit 7634b8827778e8f5462e2b8fbcd7008499ae1b13 by Heiko Becker to branch master. Repository: calligra Description --- Otherwise I get "libs/widgets/KoUnitDoubleSpinBox.cpp:104:21: error: 'isna

Re: Review Request 127347: Fix build with glibc >= 2.23 by using qIsNaN

2016-03-11 Thread Jarosław Staniek
ed March 12, 2016, 12:17 a.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > --- > > Otherwise I get "libs/widgets/KoUnitDoubleSpinBox.cpp:104:21: error: > 'isnan' was not declared in thi

Re: Review Request 127347: Fix build with glibc >= 2.23 by using qIsNaN

2016-03-11 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127347/ --- (Updated März 11, 2016, 11:17 nachm.) Review request for Calligra

Re: Review Request 127347: Fix build with glibc >= 2.23 by using std namespace

2016-03-11 Thread Jarosław Staniek
ecker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127347/ > --- > > (Updated March 11, 2016, 10:05 p.m.) > > > Review request f

Review Request 127347: Fix build with glibc >= 2.23 by using std namespace

2016-03-11 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127347/ --- Review request for Calligra. Repository: calligra Description

Re: Review Request 127338: Fix loading documents containing nested tables

2016-03-10 Thread Laszlo Pasztor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127338/ --- (Updated márc. 11, 2016, 12:01 de) Review request for Calligra. Bugs

Review Request 127338: Fix loading documents containing nested tables

2016-03-10 Thread Laszlo Pasztor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127338/ --- Review request for Calligra. Bugs: https://bugs.kde.org/show_bug.cgi?id

Re: Review Request 127220: Fix loading documents containing tables

2016-03-10 Thread Laszlo Pasztor
discarded. Review request for Calligra. Repository: calligra Description --- Fix: loading documents containing tables https://bugs.kde.org/show_bug.cgi?id=359700 Diffs - libs/kotext/opendocument/KoTextWriter_p.cpp def4d68 Diff: https://git.reviewboard.kde.org/r/127220/diff

Re: Review Request 127220: Fix loading documents containing tables

2016-03-10 Thread Laszlo Pasztor
marked as submitted. Review request for Calligra. Repository: calligra Description --- Fix: loading documents containing tables https://bugs.kde.org/show_bug.cgi?id=359700 Diffs - libs/kotext/opendocument/KoTextWriter_p.cpp def4d68 Diff: https://git.reviewboard.kde.org/r/127220

Re: Review Request 127220: Fix loading documents containing tables

2016-03-10 Thread Laszlo Pasztor
discarded. Review request for Calligra. Repository: calligra Description --- Fix: loading documents containing tables https://bugs.kde.org/show_bug.cgi?id=359700 Diffs - libs/kotext/opendocument/KoTextWriter_p.cpp def4d68 Diff: https://git.reviewboard.kde.org/r/127220/diff

Re: Review Request 127220: Fix loading documents containing tables

2016-03-10 Thread Laszlo Pasztor
marked as submitted. Review request for Calligra. Repository: calligra Description --- Fix: loading documents containing tables https://bugs.kde.org/show_bug.cgi?id=359700 Diffs - libs/kotext/opendocument/KoTextWriter_p.cpp def4d68 Diff: https://git.reviewboard.kde.org/r/127220

Re: Review Request 127220: Fix loading documents containing tables

2016-03-10 Thread Laszlo Pasztor
discarded. Review request for Calligra. Repository: calligra Description --- Fix: loading documents containing tables https://bugs.kde.org/show_bug.cgi?id=359700 Diffs - libs/kotext/opendocument/KoTextWriter_p.cpp def4d68 Diff: https://git.reviewboard.kde.org/r/127220/diff

Re: Review Request 127220: Fix loading documents containing tables

2016-03-10 Thread Laszlo Pasztor
marked as submitted. Review request for Calligra. Repository: calligra Description --- Fix: loading documents containing tables https://bugs.kde.org/show_bug.cgi?id=359700 Diffs - libs/kotext/opendocument/KoTextWriter_p.cpp def4d68 Diff: https://git.reviewboard.kde.org/r/127220

Re: Review Request 127220: Fix loading documents containing tables

2016-03-10 Thread Laszlo Pasztor
febr. 29, 2016, 1:33 du) > > > Review request for Calligra. > > > Repository: calligra > > > Description > --- > > Fix: loading documents containing tables > https://bugs.kde.org/show_bug.cgi?id=359700 > > > Diffs > - >

Re: Review Request 127220: Fix loading documents containing tables

2016-02-29 Thread Laszlo Pasztor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127220/ --- (Updated Feb. 29, 2016, 1:33 p.m.) Review request for Calligra

Review Request 127220: Loading documents containing tables

2016-02-29 Thread Laszlo Pasztor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127220/ --- Review request for Calligra. Repository: calligra Description

Re: Review Request 125485: Unselect text when the text tool is deactivated.

2016-02-28 Thread Camilla Boemann
ps://git.reviewboard.kde.org/r/125485/ > --- > > (Updated Oct. 3, 2015, 9:56 a.m.) > > > Review request for Calligra and Thorsten Zachmann. > > > Repository: calligra > > > Description > --- > > Otherwise text remains selected in Stage after switching

Re: Review Request 125485: Unselect text when the text tool is deactivated.

2016-02-28 Thread David Faure
m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125485/ > --- > > (Updated Oct. 3, 2015, 9:56 a.m.) > > >

  1   2   3   4   5   6   7   8   9   10   >