----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127347/#review93420 -----------------------------------------------------------
libs/widgets/KoUnitDoubleSpinBox.cpp (line 30) <https://git.reviewboard.kde.org/r/127347/#comment63684> I propose that you remove the ifdef completely and also don't use cmath; instead use qIsNaN(). We use it in a few places already. - Jarosław Staniek On March 11, 2016, 10:05 p.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127347/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 10:05 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Otherwise I get "libs/widgets/KoUnitDoubleSpinBox.cpp:104:21: error: > 'isnan' was not declared in this scope". > > > Diffs > ----- > > libs/widgets/KoUnitDoubleSpinBox.cpp > 37f5415966e91ed543b22e5f50d04d7039f43f7d > > Diff: https://git.reviewboard.kde.org/r/127347/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Heiko Becker > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
