----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130196/#review103464 -----------------------------------------------------------
Ship it! Ship It! - Camilla Boemann On July 22, 2017, 7:50 p.m., Jos van den Oever wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130196/ > ----------------------------------------------------------- > > (Updated July 22, 2017, 7:50 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Without the seed parameter, the default qHash for QPair is used. > The seed argument in qHash was introduced in Qt 5.0. The qHash for > KoXmlStringPair did not have it and hence it was an unused function. > > > Diffs > ----- > > libs/store/KoXmlReader.cpp 4c7f434 > > Diff: https://git.reviewboard.kde.org/r/130196/diff/ > > > Testing > ------- > > All unit tests in kostore still pass. > > > Thanks, > > Jos van den Oever > >