----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125485/#review92851 -----------------------------------------------------------
I'd prefer if this doesn't go in In words at least it's on purpose that we keep the text selection. 1) because we wan't it to be selected so other tools can work with it 2) we want it to be there when the text tool is reactivated some other solution might eventually work like not render the selection if the current tool doesn't want it to be rendered - Camilla Boemann On Oct. 3, 2015, 9:56 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125485/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2015, 9:56 a.m.) > > > Review request for Calligra and Thorsten Zachmann. > > > Repository: calligra > > > Description > ------- > > Otherwise text remains selected in Stage after switching to another > shape, which is very unexpected. > > > Diffs > ----- > > plugins/textshape/TextTool.cpp dd9e0df252bb6ab6bcd25bb27c20fb8af29839cc > > Diff: https://git.reviewboard.kde.org/r/125485/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > text-selection-bug.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/d7bcacc1-e0c0-4021-9055-aa2b77f39a71__text-selection-bug.png > > > Thanks, > > David Faure > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
