Re: Review Request 123659: Align lines in tabular view

horizontal/vertical border lines alignment in KexiTableScrollArea Diffs - kexi/widget/tableview/KexiTableScrollArea.cpp 536e0ea Diff: https://git.reviewboard.kde.org/r/123659/diff/ Testing ---  Thanks, Roman Shtemberko

Re: Review Request 123732: Replace obsolete QStyleOption::init()

marked as submitted. Review request for Calligra and Jarosław Staniek. Changes --- Submitted with commit f6fe910e4064ba5fc6dda20e4e526d28d68e09ae by Roman Shtemberko to branch calligra/2.9. Repository: calligra Description --- This function appears to be [obsolete](http://doc.qt.io

Re: Review Request 123732: Replace obsolete QStyleOption::init()

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123732/#review80235 --- On Май 12, 2015, 3:28 п.п., Roman Shtemberko wrote: > > --- &

Re: Review Request 123732: Replace obsolete QStyleOption::init()

kexi/widget/tableview/KexiTableScrollArea.cpp 536e0ea libs/widgets/KoDockWidgetTitleBarButton.cpp 2892882 libs/widgets/KoResourceSelector.cpp c16e0a2 libs/widgets/KoSliderCombo.cpp 03506b8 Diff: https://git.reviewboard.kde.org/r/123732/diff/ Testing --- Thanks, Roman Shtemberko

Review Request 123732: Replace obsolete QStyleOption::init()

Description --- This function appears to be [obsolete](http://doc.qt.io/qt-5/qstyleoption-obsolete.html). Diffs - kexi/widget/tableview/KexiTableScrollArea.cpp 536e0ea Diff: https://git.reviewboard.kde.org/r/123732/diff/ Testing --- Thanks, Roman Shtemberko

Review Request 123659: Align lines in tabular view

allignment](https://i.imgur.com/o83oV3a.png) Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123623: Use "activated" signal instead of "clicked" in "Welcome" and "New Project" assistants

marked as submitted. Review request for Calligra and Jarosław Staniek. Changes --- Submitted with commit f6819cd19dfcdee02af3c9ec535163d2c30166a4 by Roman Shtemberko to branch calligra/2.9. Bugs: 346902 http://bugs.kde.org/show_bug.cgi?id=346902 Repository: calligra Description

Review Request 123623: Use "activated" signal instead of "clicked" in "Welcome" and "New Project" assistants

gs.kde.org/show_bug.cgi?id=346902) Diffs - kexi/main/startup/KexiNewProjectAssistant.cpp 20eced7 kexi/main/startup/KexiWelcomeAssistant.cpp 43a36a5 Diff: https://git.reviewboard.kde.org/r/123623/diff/ Testing --- Thanks, Roman

Re: Review Request 123536: Always select design tab on entering to design mode.

marked as submitted. Review request for Calligra and Jarosław Staniek. Changes --- Submitted with commit 020a0918b1f0dc2846ac8ffe26bc3975710e0cd9 by Jaroslaw Staniek on behalf of Roman Shtemberko to branch calligra/2.9. Bugs: 335900 http://bugs.kde.org/show_bug.cgi?id=335900

Re: Review Request 123536: Always select design tab on entering to design mode.

/diff/ Testing --- Design tab is activated on switching to design mode, if no other tab was explicitly selected for this window & mode. Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mai

Re: Review Request 123536: Always select design tab on entering to design mode.

.org/show_bug.cgi?id=335900 > > Roman Shtemberko wrote: > Design tab is activated properly (without this patch) if, in example, you > leave report in design mode (with design tab activated), go to table in data > mode and return to report (please, confirm if you have same behavior). &

Re: Review Request 123536: Always select design tab on entering to design mode.

eviewboard.kde.org/r/123536/#review79596 --- On Апрель 27, 2015, 3:57 п.п., Roman Shtemberko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Review Request 123536: Always select design tab on entering to design mode.

on switching to design mode, if no other tab was explicitly selected for this window & mode. Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten

marked as submitted. Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz. Changes --- Submitted with commit a76adc679e97a26c67d5ae852b4cc0cb77714356 by Jaroslaw Staniek on behalf of Roman Shtemberko to branch calligra/2.9. Bugs: 344656

Re: Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten

) - kexi/main/KexiMainWindow.cpp 532d3fb Diff: https://git.reviewboard.kde.org/r/123383/diff/ Testing --- Window to be overwrited closes before actual overwriting. Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel

Re: Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten

) - kexi/main/KexiMainWindow.cpp 532d3fb Diff: https://git.reviewboard.kde.org/r/123383/diff/ Testing --- Window to be overwrited closes before actual overwriting. Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org

Re: Review Request 123295: Kexi find dialog size improvements.

marked as submitted. Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz. Changes --- Submitted with commit 1d20b1b39e6c64db175a496376958bd8e1262390 by Jaroslaw Staniek on behalf of Roman Shtemberko to branch calligra/2.9. Bugs: 345689

Re: Review Request 123357: Saving-as modified Kexi object does not remove its "dirty" flag

marked as submitted. Review request for Calligra, Adam Pigg, Jarosław Staniek, and Radosław Wicik. Changes --- Submitted with commit bd4ab9a91ad288f7be54472d12181c6ba005e4b0 by Jaroslaw Staniek on behalf of Roman Shtemberko to branch calligra/2.9. Bugs: 344653 http://bugs.kde.org

Re: Review Request 123357: Saving-as modified Kexi object does not remove its "dirty" flag

gs.kde.org/show_bug.cgi?id=344653) Diffs - kexi/core/KexiWindow.cpp 8c50141 Diff: https://git.reviewboard.kde.org/r/123357/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.o

Review Request 123383: Saving-as Kexi object should close window of object that will be overwritten

/widget/KexiNameDialog.cpp 09355d0 Diff: https://git.reviewboard.kde.org/r/123383/diff/ Testing --- Window to be overwrited closes before actual overwriting. Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request 123295: Kexi find dialog size improvements.

it to take less space. Diffs (updated) - kexi/main/kexifinddialog.cpp ffa6a8e kexi/main/kexifinddialog.ui 7a4c38f Diff: https://git.reviewboard.kde.org/r/123295/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing

Review Request 123357: Saving-as Kexi object should close window of object that will be overwritten

--- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123295: Kexi find dialog size improvements.

it to take less space. Diffs (updated) - kexi/main/kexifinddialog.cpp ffa6a8e kexi/main/kexifinddialog.ui 7a4c38f Diff: https://git.reviewboard.kde.org/r/123295/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing

Re: Review Request 123295: Kexi find dialog size improvements.

reply, visit: https://git.reviewboard.kde.org/r/123295/#review78669 ------- On Апрель 9, 2015, 12:52 п.п., Roman Shtemberko wrote: > > --- > This is an automatically generated e-m

Review Request 123295: Kexi find dialog size improvements.

kexi/main/kexifinddialog.h 4f400ba kexi/main/kexifinddialog.cpp ffa6a8e kexi/main/kexifinddialog.ui 7a4c38f Diff: https://git.reviewboard.kde.org/r/123295/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-

Re: Review Request 122559: Kexi. Display message for the query export when its design is "dirty".

marked as submitted. Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz. Changes --- Submitted with commit d365faf0ccf5f70b68d237c9017e69d0dc070045 by Jaroslaw Staniek on behalf of Roman Shtemberko to branch master. Repository: calligra

Re: Review Request 122559: Kexi. Display message for the query export when its design is "dirty".

/ Testing --- Work with both exports (to file/clipboard). Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122559: Kexi. Display message for the query export when its design is "dirty".

/ Testing --- Work with both exports (to file/clipboard). Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122720: Fix crash on backward search

. Diffs - kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 5b108b6 Diff: https://git.reviewboard.kde.org/r/122720/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request 122720: Fix crash on backward search

) - kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 5b108b6 Diff: https://git.reviewboard.kde.org/r/122720/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122720: Fix crash on backward search

/kexidataawareobjectiface.cpp 5b108b6 Diff: https://git.reviewboard.kde.org/r/122720/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 122720: Fix crash on backward search

--- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122707: Fix bad "undo changes" icon scaling in Kexi Property Editor

Editor). Resolves 337424. Diffs - libs/koproperty/EditorView.cpp 8d48485 Diff: https://git.reviewboard.kde.org/r/122707/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request 122559: Kexi. Display message for the query export when its design is "dirty".

/ Testing --- Work with both exports (to file/clipboard). Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122559: Kexi. Display message for the query export when its design is "dirty".

xt 9d40ce6 > kexi/plugins/importexport/csv/kexicsvexport.h 280b33f > kexi/plugins/importexport/csv/kexicsvexport.cpp dfe107d > kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 096ea71 > > Diff: https://git.reviewboard.kde.org/r/122559/diff/ > > > Testing >

Re: Review Request 122559: Kexi. Display message for the query export when its design is "dirty".

/ Testing --- Work with both exports (to file/clipboard). Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122559: Kexi. Display message for the query export when its design is "dirty".

/ Testing --- Work with both exports (to file/clipboard). Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122519: Kexi table view: update vertical header sections and fix cursor movement issues

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122519/#review76172 --- Ship it! Ship It! - Roman Shtemberko On Фев. 16, 2015, 10

Re: Review Request 122197: Fixes to .ods import

/migration/importtablewizard.cpp f3d02b9 kexi/plugins/migration/keximigrationpart.cpp 03c674e kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e Diff: https://git.reviewboard.kde.org/r/122197/diff/ Testing --- Thanks, Roman Shtemberko ___ call

Review Request 122559: Kexi. Display message for the query export when its design is "dirty".

/kexicsvexport.cpp dfe107d Diff: https://git.reviewboard.kde.org/r/122559/diff/ Testing --- Work with both exports (to file/clipboard). Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122197: Fixes to .ods import

/migration/keximigrationpart.cpp 03c674e kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e Diff: https://git.reviewboard.kde.org/r/122197/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde

Re: Review Request 122042: Fix crash after attempt to change alignment in a text field

://git.reviewboard.kde.org/r/122042/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122197: Fixes to .ods import

/migration/keximigrationpart.cpp 03c674e kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e Diff: https://git.reviewboard.kde.org/r/122197/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde

Re: Review Request 122197: Fixes to .ods import

please revert and see ctor. do you mean dtor, not a ctor? - Roman --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122197/#review75550 -------

Re: Review Request 122197: Fixes to .ods import

exi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e kexi/main/KexiMainWindow.cpp f499951 kexi/migration/AlterSchemaTableModel.h 2090b35 kexi/migration/AlterSchemaTableModel.cpp 86ef62e kexi/migration/AlterSchemaWidget.h b29e7f9 Diff: https://git.reviewboard.kde.org/r/122197/diff/ Testing --- Than

Re: Review Request 122197: Fixes to .ods import

Widget.cpp ea7fedd kexi/migration/importtablewizard.h a0b4dca kexi/migration/importtablewizard.cpp f3d02b9 kexi/plugins/migration/keximigrationpart.cpp 03c674e kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e Diff: https://git.reviewboard.kde.org/r/122197/diff/ Testing --- Than

Re: Review Request 122197: Fixes to .ods import

s line though. - Roman --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122197/#review75359 --- On Фев. 5, 2015, 12:10 п.п., Roma

Re: Review Request 122197: Fixes to .ods import

/migration/importtablewizard.cpp f3d02b9 kexi/plugins/migration/keximigrationpart.cpp 03c674e kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e Diff: https://git.reviewboard.kde.org/r/122197/diff/ Testing --- Thanks, Roman Shtemberko ___ call

Re: Review Request 122395: Update geometry value in Kexi form designer when resize handles are moved

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122395/#review75310 --- Ship it! Ship It! - Roman Shtemberko On Фев. 2, 2015, 10

Re: Review Request 122380: Improve undo/redo in Kexi form designer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122380/#review75308 --- Ship it! Ship It! - Roman Shtemberko On Фев. 2, 2015, 2

Re: Review Request 122197: Fixes to .ods import

Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122197: Fixes to .ods import

t; > more natural feedback instead. I've added KexiNameWidget, but can't position it well on layout. Any advice? https://i.imgur.com/mD3M1S7.png - Roman --- This is an automatically generated e-mail. To reply, visit: https://git

Re: Review Request 122389: Delete --skip-startup-dialog related code

/main/startup/KexiStartup.cpp 1939e25 kexi/main/startup/KexiStartupDialog.h 387b7a9 kexi/main/startup/KexiStartupDialog.cpp f2b5102 kexi/tests/altertable/altertable.cpp da09a04 Diff: https://git.reviewboard.kde.org/r/122389/diff/ Testing --- Thanks, Roman Shtemberko

Re: Review Request 122389: Delete --skip-startup-dialog related code

/startup/KexiStartupDialog.h 387b7a9 kexi/main/startup/KexiStartupDialog.cpp f2b5102 kexi/tests/altertable/altertable.cpp da09a04 Diff: https://git.reviewboard.kde.org/r/122389/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel

Review Request 122389: Delete --skip-startup-dialog related code

://bugs.kde.org/show_bug.cgi?id=338247 Repository: calligra Description --- Proposed to be deleted as no longer is needed after Kexi 2. Diffs - kexi/main/startup/KexiStartup.cpp 1939e25 Diff: https://git.reviewboard.kde.org/r/122389/diff/ Testing --- Thanks, Roman

Re: Review Request 122042: Fix crash after attempt to change alignment in a text field

/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 122197: Fixes to .ods import

/migration/AlterSchemaWidget.h b29e7f9 kexi/migration/AlterSchemaWidget.cpp ea7fedd kexi/migration/importtablewizard.cpp f3d02b9 kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e Diff: https://git.reviewboard.kde.org/r/122197/diff/ Testing --- Thanks, Roman

Re: Review Request 122042: Fix crash after attempt to change alignment in a text field

--- https://bugs.kde.org/show_bug.cgi?id=342371 Diffs (updated) - kexi/formeditor/commands.cpp f9c1b58 Diff: https://git.reviewboard.kde.org/r/122042/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-dev

Re: Review Request 122051: Add Ctrl+F5 shortcut for Check Query of SQL query in Query Design view SQL

/plugins/queries/kexiquerydesignersql.cpp c3b4223 Diff: https://git.reviewboard.kde.org/r/122051/diff/ Testing --- Ctrl+F5 shortcut acts the same as the 'Check Query' icon. Thanks, Roman Shtemberko ___ calligra-devel mailing list call

Re: Review Request 122036: Fix crash during elements deletion in forms

elements in Forms. Diffs - kexi/formeditor/WidgetTreeWidget.cpp 3eb0910 Diff: https://git.reviewboard.kde.org/r/122036/diff/ Testing --- Labels are removed without crush. Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra

Review Request 122053: Fix Ctl+Shift+Insert shortcut for Table/Query Design Views

: https://git.reviewboard.kde.org/r/122053/diff/ Testing --- Shortcut works as expected in both Table and Query Design views. However, shortcut tip is not showed in the right-click menu. Thanks, Roman Shtemberko ___ calligra-devel mailing list

Review Request 122051: Add Ctrl+F5 shortcut for Check Query of SQL query in Query Design view SQL

/ Testing --- Ctrl+F5 shortcut acts the same as the 'Check Query' icon. Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122042: Fix crash after attempt to change alignment in a text field

Diff: https://git.reviewboard.kde.org/r/122042/diff/ Testing --- Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122042: Fix crash after attempt to change alignment in a text field

not needed to be called. What do you think? - Roman --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122042/#review73959 ------

Review Request 122042: Fix crash after attempt to change alignment in a text field

: 342371 http://bugs.kde.org/show_bug.cgi?id=342371 Repository: calligra Description --- https://bugs.kde.org/show_bug.cgi?id=342371 Diffs - kexi/formeditor/form.cpp 8ccb428 Diff: https://git.reviewboard.kde.org/r/122042/diff/ Testing --- Thanks, Roman Shtemberko

Review Request 122036: Fix crash during elements deletion in forms

://git.reviewboard.kde.org/r/122036/diff/ Testing --- Labels are removed without crush. Thanks, Roman Shtemberko ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 121655: Add overloads (non-raw queries and params) for convenience KexiDB functions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121655/#review72820 --- Ship it! Ship It! - Roman Shtemberko On Дек. 23, 2014, 9

Re: Review Request 121420: Make the project navigator more modern - towards Plasma 5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121420/#review72814 --- Ship it! Ship It! - Roman Shtemberko On Дек. 12, 2014, 12

Re: Review Request 121174: Fix checking for file overwriting on file creation

> On Ноя. 20, 2014, 2:37 п.п., Roman Shtemberko wrote: > > Ship It! Works nice. - Roman --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121174/#re

Re: Review Request 121174: Fix checking for file overwriting on file creation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121174/#review70691 --- Ship it! Ship It! - Roman Shtemberko On Ноя. 19, 2014, 12