> On Янв. 13, 2015, 8:14 п.п., Jarosław Staniek wrote: > > kexi/formeditor/form.cpp, line 2242 > > <https://git.reviewboard.kde.org/r/122042/diff/1/?file=341644#file341644line2242> > > > > The original code at 2242 looks like command compression. Could you > > explain what happens after your change?
It's more like workaround rather than fix. Crush was caused by calling d->lastCommand()->propertyName() here, but I can't really find why. After my change functionality will be the same (right?), while the function is not needed to be called. What do you think? - Roman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122042/#review73959 ----------------------------------------------------------- On Янв. 13, 2015, 8:06 п.п., Roman Shtemberko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122042/ > ----------------------------------------------------------- > > (Updated Янв. 13, 2015, 8:06 п.п.) > > > Review request for Calligra, Adam Pigg and Jarosław Staniek. > > > Bugs: 342371 > http://bugs.kde.org/show_bug.cgi?id=342371 > > > Repository: calligra > > > Description > ------- > > https://bugs.kde.org/show_bug.cgi?id=342371 > > > Diffs > ----- > > kexi/formeditor/form.cpp 8ccb428 > > Diff: https://git.reviewboard.kde.org/r/122042/diff/ > > > Testing > ------- > > > Thanks, > > Roman Shtemberko > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
