----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122519/#review76172 -----------------------------------------------------------
Ship it! Ship It! - Roman Shtemberko On Фев. 16, 2015, 10:35 д.п., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122519/ > ----------------------------------------------------------- > > (Updated Фев. 16, 2015, 10:35 д.п.) > > > Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. > Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz. > > > Repository: calligra > > > Description > ------- > > Kexi table view: update vertical header sections and fix cursor movement > issues > > Details: > * On row inserting and deleting, update the vertical header's model (instead > of manually adding header sections) > Major defect #3 at > https://community.kde.org/Kexi/Porting_to_Qt%26KDE_4#Table_View > "Update vertical header sections when # of records change" > * "select last row" works on when there are zero records > * on new row edit accepting do not jump to first row (fix regression) > * usability++: when editing is started, scroll a bit up to show next row if > present > * usability++: when editing is started, ensure the very bottom of empty > scroll area is displayed to help the user see what's there > * set internal margin of half of the horizontal scroll bar's height only when > not in spreadsheet mode > * simplify "move to Nth row" and "move to last row" code > * internal logic change for vertical header: when new row editing starts, the > new row data is added to the list of records, on Cancel it's removed so no > need to check the newRowEditing flag > > > Diffs > ----- > > kexi/plugins/forms/kexiformscrollview.cpp > eed4676d2bdd72a0d50f76725fff5317d1209707 > kexi/widget/dataviewcommon/kexidataawareobjectiface.h > 4b412ac0d8c74036553300408f76cea946c216e8 > kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp > e260ac40041f0c2711071e6f96b69671bbbdf242 > kexi/widget/tableview/KexiTableScrollArea.h > c0090041ccf3b6369145f584590f1821d657363e > kexi/widget/tableview/KexiTableScrollArea.cpp > 0f83338e076859294e2412a627083fbd561f70a6 > kexi/widget/tableview/KexiTableScrollAreaHeaderModel.h > da6a89165b9f896d4b0cd2759827f51c47b61ac4 > kexi/widget/tableview/KexiTableScrollAreaHeaderModel.cpp > 99a524fa233297b8ca5a3001dae3f8f86192d548 > kexi/widget/tableview/KexiTableScrollArea_p.h > 753f08eb22e03b141a0ec43bfe463e89f4530353 > kexi/widget/tableview/KexiTableScrollArea_p.cpp > 582146bb1a78e5e4b3bcb98cc01a6919508aef65 > > Diff: https://git.reviewboard.kde.org/r/122519/diff/ > > > Testing > ------- > > Tested for small and large tables in data mode, tables in design mode > (spreadsheet tv mode), query data and design views > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
