> On Апрель 27, 2015, 8:18 п.п., Jarosław Staniek wrote: > > Thanks for the efffort. > > I need more info to undestand the patch. The original code works the same > > way as after your change when it comes to the steps 1..4 explained at > > https://bugs.kde.org/show_bug.cgi?id=335900 > > Roman Shtemberko wrote: > Design tab is activated properly (without this patch) if, in example, you > leave report in design mode (with design tab activated), go to table in data > mode and return to report (please, confirm if you have same behavior). > However, the problem appears on swtiching design mode to data mode and > returning back. Patch will make design tab being activated each time you > switch to design mode (unless other tab was choosen on leaving). > > Jarosław Staniek wrote: > Thanks for the explanation Roman. I see what you mean. The first case > works without the patch, yes. > > After some mad clicking... I see the second case is a tricky thing. It > works when both preconditions are met: > 1. When the object was stored already (so not when it was not stored so > far) - this may be related to the fact that identifiers of unsaved objects > are < 0, and > 2. When the object's window was in its design view already since the last > opening > > Summing up, for now I think a proper fix would be more subtle and complex > and would not be just limited to removing some existing code.
Okay, but we want to activate design tab each time user goes to design mode which supports it, right? - Roman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123536/#review79596 ----------------------------------------------------------- On Апрель 27, 2015, 3:57 п.п., Roman Shtemberko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123536/ > ----------------------------------------------------------- > > (Updated Апрель 27, 2015, 3:57 п.п.) > > > Review request for Calligra and Jarosław Staniek. > > > Bugs: 335900 > http://bugs.kde.org/show_bug.cgi?id=335900 > > > Repository: calligra > > > Description > ------- > > Fix for the [bug](https://bugs.kde.org/show_bug.cgi?id=335900) > > > Diffs > ----- > > kexi/main/KexiMainWindow.cpp 532d3fb > > Diff: https://git.reviewboard.kde.org/r/123536/diff/ > > > Testing > ------- > > Design tab is activated on switching to design mode, if no other tab was > explicitly selected for this window & mode. > > > Thanks, > > Roman Shtemberko > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
