> On Фев. 4, 2015, 10:22 д.п., Jarosław Staniek wrote: > > kexi/migration/AlterSchemaWidget.cpp, line 100 > > <https://git.reviewboard.kde.org/r/122197/diff/1-2/?file=344091#file344091line100> > > > > No longer needed since m_tableName performs the conversion, am I right?
Yes, you are :) > On Фев. 4, 2015, 10:22 д.п., Jarosław Staniek wrote: > > kexi/migration/AlterSchemaWidget.cpp, line 127 > > <https://git.reviewboard.kde.org/r/122197/diff/1-2/?file=344091#file344091line127> > > > > When importing e.g. an empty ODS file > > m_newSchema->field(m_selectedColumn) can be NULL --> crash Maybe we should show error message in case of an empty ODS? > On Фев. 4, 2015, 10:22 д.п., Jarosław Staniek wrote: > > kexi/migration/AlterSchemaWidget.cpp, line 53 > > <https://git.reviewboard.kde.org/r/122197/diff/2/?file=346591#file346591line53> > > > > Why this? We want to give user possibility to enter name caption > > explicitly. When entering name explicitly via "name" field, caption is not updated and kinda confusing IMO. I've deleted this line though. - Roman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122197/#review75359 ----------------------------------------------------------- On Фев. 5, 2015, 12:10 п.п., Roman Shtemberko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122197/ > ----------------------------------------------------------- > > (Updated Фев. 5, 2015, 12:10 п.п.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and > Wojciech Kosowicz. > > > Bugs: 336815 > http://bugs.kde.org/show_bug.cgi?id=336815 > > > Repository: calligra > > > Description > ------- > > Fix 336815 (path issue) > Also have fixed with this patch: > Check for an empty name. > Names are no more converted to the lower case (there is some conflicts with > this behavior, imported tables can not be opened after this (only after > restarting an app (!?))) > Check if name is not starting with a digit (conflicts with '_' at the > begining as well). > Default name is added based on sheet selected. > > > Diffs > ----- > > kexi/main/KexiMainWindow.cpp f499951 > kexi/migration/AlterSchemaTableModel.h 2090b35 > kexi/migration/AlterSchemaTableModel.cpp 86ef62e > kexi/migration/AlterSchemaWidget.h b29e7f9 > kexi/migration/AlterSchemaWidget.cpp ea7fedd > kexi/migration/importtablewizard.h a0b4dca > kexi/migration/importtablewizard.cpp f3d02b9 > kexi/plugins/migration/keximigrationpart.cpp 03c674e > kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e > > Diff: https://git.reviewboard.kde.org/r/122197/diff/ > > > Testing > ------- > > > Thanks, > > Roman Shtemberko > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
