> On Янв. 24, 2015, 9:04 п.п., Jarosław Staniek wrote: > > kexi/migration/importtablewizard.cpp, line 113 > > <https://git.reviewboard.kde.org/r/122197/diff/1/?file=344092#file344092line113> > > > > 1. We could rather perform single check using KexiDB::isIdentifier(), > > if fails, show > > > > i18nc("@info", > > "Entered name <resource>%1</resource> is not a valid identifier.<nl/>" > > "<nl/><note>Identifiers cannot be empty, should start with a latin > > letter or '_' character, should contain only latin letters, numbers and '_' > > characters.</note>", ...) > > > > 2. BUT IDEAL solution is to use a KexiNameWidget instance embedded here > > instead of line edit, like used on table creation: > > http://i.imgur.com/ko7WTPi.png > > > > 3. Thus we'd use a principle of allowing users to enter only valid > > data, and have full control over caption _and_ name. > > > > 4. And like in the table caption/name dialog, in this approach one > > thing still needs to be handled: empty indentifiers. Instead of displaying > > error messages as below I'd propose to use react on > > KexiNameWIdget::textChanged() and depending the result of > > KexiNameWIdget::checkValidity() enable/disable the Next button of the > > assistant. > > > > 5. So the only message that we needed is the one about name already > > used by another table. > > > > 6. Based on the new behaviour of the Next button, the OK/Cancel icon > > and updating it in nameChanged() wouldn't be needed - user will be given a > > more natural feedback instead.
I've added KexiNameWidget, but can't position it well on layout. Any advice? https://i.imgur.com/mD3M1S7.png - Roman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122197/#review74673 ----------------------------------------------------------- On Фев. 3, 2015, 12:26 п.п., Roman Shtemberko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122197/ > ----------------------------------------------------------- > > (Updated Фев. 3, 2015, 12:26 п.п.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and > Wojciech Kosowicz. > > > Bugs: 336815 > http://bugs.kde.org/show_bug.cgi?id=336815 > > > Repository: calligra > > > Description > ------- > > Fix 336815 (path issue) > Also have fixed with this patch: > Check for an empty name. > Names are no more converted to the lower case (there is some conflicts with > this behavior, imported tables can not be opened after this (only after > restarting an app (!?))) > Check if name is not starting with a digit (conflicts with '_' at the > begining as well). > Default name is added based on sheet selected. > > > Diffs > ----- > > kexi/migration/AlterSchemaWidget.cpp ea7fedd > kexi/migration/importtablewizard.h a0b4dca > kexi/migration/importtablewizard.cpp f3d02b9 > kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e > kexi/migration/AlterSchemaWidget.h b29e7f9 > > Diff: https://git.reviewboard.kde.org/r/122197/diff/ > > > Testing > ------- > > > Thanks, > > Roman Shtemberko > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
