Question about ownership of KoShape

2016-11-17 Thread Dmitry Kazakov
, the management is not reference counted. How can I solve the thing? [1] - https://www.w3.org/TR/SVG/struct.html#UseElement -- Dmitry Kazakov

[Differential] [Closed] D125: Implement a relative zooming shortcuts

2016-07-18 Thread dkazakov (Dmitry Kazakov)
This revision was automatically updated to reflect the committed changes. Closed by commit rKRITAf42833ca9774: Implement relative zooming shortcuts (authored by dkazakov). REPOSITORY rKRITA Krita CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D125?vs=5256&id=5257 REVISION DETAIL ht

[Differential] [Updated, 97 lines] D125: Implement a relative zooming shortcuts

2016-07-18 Thread dkazakov (Dmitry Kazakov)
dkazakov updated this revision to Diff 5256. dkazakov updated the summary for this revision. dkazakov added a comment. Fixed wheel-zoom and changed the shortcut to Ctrl+Middle-button REPOSITORY rKRITA Krita CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D125?vs=276&id=5256 BRANCH

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

2015-08-31 Thread Dmitry Kazakov
Hi, Stefano! Now Dmitry, what are the situations where you really need it? Because it's > weird that someone else didn't find/write a ready to use solution for it. > Emacs has a feature to autocomplete parts of the filename in non-sequential order if they are split with underscores. I got really

Re: Increasing Calligra minimum CMake version required

2015-08-17 Thread Dmitry Kazakov
t might get > deprecated (shown by the fact that they're adding specific macros to add > flags etc). > Moreover do we really still have people testing the builds with CMake > 2.8.0? > > > > ___ > ca

Re: 2.9.7

2015-08-04 Thread Dmitry Kazakov
gt; Kexi: > : A visual database apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > ___ > calligra-devel mailing list > calligra-devel@kd

Re: release blocker

2015-07-09 Thread Dmitry Kazakov
n > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[calligra/calligra/2.9] krita/libpsd: Finish proper renaming of the libpsd library

2015-07-07 Thread Dmitry Kazakov
Git commit 04dac642dab567fafbce117fe536053d403a3159 by Dmitry Kazakov. Committed on 07/07/2015 at 09:30. Pushed by dkazakov into branch 'calligra/2.9'. Finish proper renaming of the libpsd library When renaming a library, please don't forget to modify the export header accordin

Re: Review Request 124278: Improve Krita input device switching for Surface Pro 3

2015-07-07 Thread Dmitry Kazakov
. Especially the patch with readability changesm which makes review quite complicated. Anyway, even after I review this, we need to ask our users to test it on various tablet devices, which can behave quite insanely. - Dmitry Kazakov On Июль 7, 2015, 6:31 д.п., Michael Abrahams wrote

Re: Review Request 124257: advancedcolorselector: Fix UI layout

2015-07-05 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124257/#review82090 --- Ship it! Looks ok to me :) - Dmitry Kazakov On July 5

[Differential] [Updated, 103 lines] D125: Implement a relative zooming shortcuts

2015-06-21 Thread dkazakov (Dmitry Kazakov)
dkazakov updated the summary for this revision. dkazakov updated this revision to Diff 276. dkazakov added a comment. Updated the patch. Now there is a default shortcuts set to the right mouse/stylus button. REPOSITORY rCALLIGRA Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.or

[Differential] [Request, 81 lines] D125: Implement a relative zooming shortcuts

2015-06-21 Thread dkazakov (Dmitry Kazakov)
dkazakov created this revision. dkazakov added reviewers: Calligra-Devel-list, woltherav, timotheegiet, Deevad. dkazakov set the repository for this revision to rCALLIGRA Calligra. dkazakov added a project: Krita: PSD layer styles. REVISION SUMMARY This patch needs testing. # Go to Settin

Re: Review Request 123833: Krita: Add basic modifier key support to selection tools.

2015-05-25 Thread Dmitry Kazakov
e action because they are shown in "Alternate" group already. - Dmitry Kazakov On May 25, 2015, 1:57 a.m., Michael Abrahams wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Phabricator instead of reviewboard

2015-04-30 Thread Dmitry Kazakov
; Please take a look at https://phabricator.kde.org! > > Boudewijn > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___

Re: Cancelled release of Calligra 2.9.3, expect fixes within a week

2015-04-29 Thread Dmitry Kazakov
database apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel >

Re: 2.9.3 reminder

2015-04-28 Thread Dmitry Kazakov
abase apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123486: Fix a bug when KoResourceItemChooser's current resource was resent on resize

2015-04-25 Thread Dmitry Kazakov
marked as submitted. Review request for Calligra. Changes --- Submitted with commit 0616ea1f9bf958bcce5703a1bd65f4bfe11edce3 by Dmitry Kazakov to branch calligra/2.9. Repository: calligra Description --- This patch fixes numerous bugs in KoResourceItemChooser 1) Resizing the

Review Request 123486: Fix a bug when KoResourceItemChooser's current resource was resent on resize

2015-04-24 Thread Dmitry Kazakov
9568d3b Diff: https://git.reviewboard.kde.org/r/123486/diff/ Testing --- Tested in Krita only Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

[calligra/krita-psd-rempt] /: Removed explicit memory leak when dealing with gradients

2015-04-12 Thread Dmitry Kazakov
Git commit 6df0b34f17b742359c197493396e7840f1c5f837 by Dmitry Kazakov. Committed on 12/04/2015 at 17:46. Pushed by dkazakov into branch 'krita-psd-rempt'. Removed explicit memory leak when dealing with gradients The changes in the patch: 1) Now KoResource has a copy-ctor. 2) KoAbstra

Re: Review Request 123179: workaround Vc cmake issue

2015-04-11 Thread Dmitry Kazakov
/CMakeLists.txt? It also uses build_per_arch macro, so it might also be affected - Dmitry Kazakov On March 30, 2015, 7:54 a.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 122858: Krita - UI fixes and improvements

2015-03-09 Thread Dmitry Kazakov
tps://git.reviewboard.kde.org/r/122858/#comment53028> Is this commented-out code intentional? Probably it should go? krita/ui/widgets/kis_filter_selector_widget.cc <https://git.reviewboard.kde.org/r/122858/#comment53029> Should this also be deleted? - Dmitry Kazakov On Март 8, 20

Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-05 Thread Dmitry Kazakov
jn > > _______ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port

2015-02-25 Thread Dmitry Kazakov
David's notes in kde-dev-scripts, please. That's what I was > referring to. And sure I'll be careful. > > Boudewijn > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Bugs in Krita which should be fixed before the release

2015-02-23 Thread Dmitry Kazakov
he release is the 26th. Not > next > > week. I really don't want to delay the release into March! > > > > > > On Sun, 22 Feb 2015, Cyrille Berger wrote: > > > >> No need for hurry, the translations are not quiet in place, so I should > >> probably t

[calligra/calligra/2.9] libs/pigment: Change the license of Vc-optimized composite ops from GPL 2 to LGPL 2.1

2015-02-21 Thread Dmitry Kazakov
Git commit d78fac93164ca4e6588a35d4fef7b7adb8223898 by Dmitry Kazakov. Committed on 22/02/2015 at 06:18. Pushed by dkazakov into branch 'calligra/2.9'. Change the license of Vc-optimized composite ops from GPL 2 to LGPL 2.1 This is a requirement of calligra libs, and I am fully agree

Bugs in Krita which should be fixed before the release

2015-02-21 Thread Dmitry Kazakov
And I will write here when these tasks are done. -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Welcome to KDE e.V., Dmitry!

2015-02-21 Thread Dmitry Kazakov
Thank you, Jaroslaw, for nice words! :) On Sat, Feb 21, 2015 at 10:58 AM, Jaroslaw Staniek wrote: > I'd like to especially welcome long time Calligra/Krita contributor > and great colleague Dmitry Kazakov who just joined the KDE e.V. > non-profit. [1] > Dmitry, I trust it'

Re: Getting to 100 % succedding tests (for 2.9), or, simply dropping them all?

2015-02-11 Thread Dmitry Kazakov
ategory. Probably, we could start some wiki page to document it right from the beginning? -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Getting to 100 % succedding tests (for 2.9), or, simply dropping them all?

2015-02-05 Thread Dmitry Kazakov
em. > Do you happen to have a list of the tests where such external deps influence > the result? Or could the list be created from checking for > checkQImageExternal()? Everything that uses TestUtil::checkQImageImpl(). It includes almost all tests written for last couple of years. --

Re: Getting to 100 % succedding tests (for 2.9), or, simply dropping them all?

2015-02-04 Thread Dmitry Kazakov
deployed could enforce rejection of commits > that > break tests, but ideally people simply feel responsible for breaking tests, > like they feel responsible for breaking the normal build. > > Personally I see tasks T2 and T3 as something to be done first, best before > 2.9 release. See me subscribed to making

Re: 2.9 final release date

2015-02-03 Thread Dmitry Kazakov
- http://kde.org > Calligra Suite: > : A graphic art and office suite - http://calligra.org > Kexi: > : A visual database apps builder - http://calligra.org/kexi > Qt Certified Specialist: > : http://www.linkedin.com/in/jstaniek > _______

Re: Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

2015-01-28 Thread Dmitry Kazakov
> On Jan. 28, 2015, 9:04 a.m., Boudewijn Rempt wrote: > > krita/ui/forms/wdgdisplaysettings.ui, line 274 > > > > > > One note: I don't think that changing the string here was necessary (or > > correct). Accordi

Re: Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

2015-01-27 Thread Dmitry Kazakov
perfect, especially setntence-casing the checkboxes to fit KDE capitalization policy! :) - Dmitry Kazakov On Jan. 28, 2015, 4:59 a.m., Aleksander Demko wrote: > > --- > This is an automatically generated e-m

Re: Merging all fixes for 2.9

2015-01-23 Thread Dmitry Kazakov
vel mailing list > >> > calligra-devel@kde.org > >> > https://mail.kde.org/mailman/listinfo/calligra-devel > > ___ > > calligra-devel mailing list > > calligra-devel@kde.org > > https://mai

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-23 Thread Dmitry Kazakov
oad their shapes) and the > special use is done "only" by Krita. > > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122042: Fix crash after attempt to change alignment in a text field

2015-01-15 Thread Dmitry Kazakov
a fix. - Dmitry Kazakov On Янв. 14, 2015, 8:55 д.п., Roman Shtemberko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 121944: Krita - Fix crash when switching off OpenGL

2015-01-12 Thread Dmitry Kazakov
GPUs. Works fine, except that I didn't test OCIO support (I don't have it built here). Looks ok to commit. - Dmitry Kazakov On Янв. 12, 2015, 10:59 д.п., Stefano Bonicatti wrote: > > --- > This is an automatically generat

Re: Review Request 121733: Fix crash reported in bug 342222

2014-12-28 Thread Dmitry Kazakov
sure the shape controller is deleted somewhere? As far as I understood, the ownership of it is not passed to the document resource manager. It just stores a pointer insize QVariant, so it seems like the shape controller is leaking :( - Dmitry Kazakov On Dec. 29, 2014, 3:59 a.m., Thorsten

Re: Review Request 121656: Krita - Fix weak shared pointer copy constructor and assignment

2014-12-24 Thread Dmitry Kazakov
n just fix it and push the patch without another round of review. - Dmitry Kazakov On Dec. 24, 2014, 12:34 a.m., Stefano Bonicatti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-24 Thread Dmitry Kazakov
> On Dec. 23, 2014, 10:14 p.m., Sven Langkamp wrote: > > Excluding the transparency mask from flatten isn't needed as it would > > automatically flatten the parent layer. There are also many other mask type > > that are not covered by this. I would expect this option would be available for lay

Re: Review Request 121572: Bug Fix 331791 wish: Add toggle mode or shortcut for brush snap to assistant

2014-12-22 Thread Dmitry Kazakov
> On Дек. 18, 2014, 7:35 п.п., Dmitry Kazakov wrote: > > krita/plugins/tools/defaulttools/kis_tool_brush.cc, line 399 > > <https://git.reviewboard.kde.org/r/121572/diff/3/?file=333824#file333824line399> > > > > addAction() accepts the 'id'

Re: Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

2014-12-19 Thread Dmitry Kazakov
est approach is to disbale action when a non-layer node is selected. You can follow an example of "Transparency Mask" action. It is also disabled when a maks is selected. - Dmitry Kazakov On Dec. 19, 2014, 6:44 p.m., Rishabh Saxena wrote: > > ---

Re: Review Request 121572: Bug Fix 331791 wish: Add toggle mode or shortcut for brush snap to assistant

2014-12-18 Thread Dmitry Kazakov
Shortcut(Qt::Key_BracketRight); collection->addAction("increase_brush_size", increaseBrushSize); ``` - Dmitry Kazakov On Dec. 18, 2014, 7:11 p.m., Rishabh Saxena wrote: > > --- > This is an auto

Re: Review Request 121388: Remove rounding for pixels in KoUnit

2014-12-08 Thread Dmitry Kazakov
edabe. The rest of the functions like ptToUnit() and convertFromUnitToUnit() know nothing about rounding. Diffs - libs/odf/KoUnit.cpp 191ae0c libs/widgets/KoUnitDoubleSpinBox.cpp 9c8af44 Diff: https://git.reviewboard.kde.org/r/121388/diff/ Testing --- Tested in Krita Thanks, D

Re: Review Request 121388: Remove rounding for pixels in KoUnit

2014-12-08 Thread Dmitry Kazakov
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121388/#review71547 ------- On Дек. 8, 2014, 1:17 п.п., Dmitry Kazakov wrote: > > ---

Review Request 121388: Remove rounding for pixels in KoUnit

2014-12-08 Thread Dmitry Kazakov
about rounding. Diffs - libs/odf/KoUnit.cpp 191ae0c libs/widgets/KoUnitDoubleSpinBox.cpp 9c8af44 Diff: https://git.reviewboard.kde.org/r/121388/diff/ Testing --- Tested in Krita Thanks, Dmitry Kazakov ___ calligra-devel mailing list cal

Re: Review Request 121336: Fix vector sapes resolution in Krita

2014-12-05 Thread Dmitry Kazakov
a bit ugly, but I'm not sure we can do anything else here. Here is the full list of changes. commit 5efa5b4e9205632e1945d5fb467bc37836a582c4 Author: Dmitry Kazakov Date: Tue Dec 2 14:07:35 2014 +0300 Fix width of the Pencil Tool stroke after changing resolution There wer

Re: Review Request 121336: Fix vector sapes resolution in Krita

2014-12-04 Thread Dmitry Kazakov
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121336/#review71339 ------- On Дек. 3, 2014, 10:53 д.п., Dmitry Kazakov wrote: > > -

Review Request 121336: Fix vector sapes resolution in Krita

2014-12-03 Thread Dmitry Kazakov
Here is the full list of changes. commit 5efa5b4e9205632e1945d5fb467bc37836a582c4 Author: Dmitry Kazakov Date: Tue Dec 2 14:07:35 2014 +0300 Fix width of the Pencil Tool stroke after changing resolution There were two things needed: 1) Deselect shapes when a shape-based tool is activated. T

Re: Review Request 121226: Krita - Clean global origin workaround

2014-11-24 Thread Dmitry Kazakov
;m ok with pushing it into master - Dmitry Kazakov On Ноя. 23, 2014, 9:23 п.п., Damien de Lemeny wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 121064: Krita - KisPaintInformation::time should be qreal

2014-11-08 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121064/#review70077 --- Ship it! Looks good to me! :) - Dmitry Kazakov On Ноя. 8

Re: Review Request 120610: Fix for Krita Bug 339870

2014-10-17 Thread Dmitry Kazakov
rounding bug. I'm ok with comming it, but you should fix the Tab<->Space issue to conform KDE code style policies first :) https://techbase.kde.org/Policies/Kdelibs_Coding_Style - Dmitry Kazakov On Окт. 17, 2014, 2:53 д.п., Gerald

Re: Review Request 119183: A HSV color slider docker.

2014-09-15 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119183/#review66582 --- Ship it! Ship It! - Dmitry Kazakov On Sept. 15, 2014, 2

Re: Review Request 119183: A HSV color slider docker.

2014-09-14 Thread Dmitry Kazakov
atting krita/plugins/extensions/dockers/colorslider/kis_color_slider_widget.cpp <https://git.reviewboard.kde.org/r/119183/#comment46348> The same as previous comment - Dmitry Kazakov On Сен. 13, 2014, 9:04 п.п., Wolthera van Hövell wrote: > > -

Re: Review Request 120191: Allow to have more than one zoom widget

2014-09-14 Thread Dmitry Kazakov
it works in Krita. - Dmitry Kazakov On Сен. 14, 2014, 1:02 д.п., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119183: A HSV color slider docker.

2014-09-14 Thread Dmitry Kazakov
: 1) Set color to H:300, S:100, L:90, then try to use mouse wheel on any of the sliders 2) Mouse Wheel over H set to 360 looks weird :) (minor bug) - Dmitry Kazakov On Сен. 13, 2014, 9:04 п.п., Wolthera van Hövell wrote: > > --- >

Re: Normalizing connections in calligra

2014-09-03 Thread Dmitry Kazakov
st > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 119677: Show the Cursor Pos and FG Color in statusbar

2014-08-10 Thread Dmitry Kazakov
icies/Kdelibs_Coding_Style - Dmitry Kazakov On Авг. 9, 2014, 11:22 д.п., Latte OfCode wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 119609: Animation support in Krita

2014-08-08 Thread Dmitry Kazakov
> On Авг. 8, 2014, 11:27 д.п., Dmitry Kazakov wrote: > > krita/ui/kis_doc2.h, line 187 > > <https://git.reviewboard.kde.org/r/119609/diff/2/?file=302163#file302163line187> > > > > This variable looks suspicious. Do you really need to store any layer >

Re: Review Request 119609: Animation support in Krita

2014-08-08 Thread Dmitry Kazakov
g/r/119609/#comment44691> This variable looks suspicious. Do you really need to store any layer here? - Dmitry Kazakov On Авг. 8, 2014, 11:02 д.п., Somsubhra Bairi wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 119569: Fixed recognition of the Wacom Stylus serial id

2014-08-04 Thread Dmitry Kazakov
i/input/wintab/wacom-properties.h PRE-CREATION krita/ui/input/wintab/wacomcfg.h 03528df libs/flake/KoToolManager.h 17b718e libs/flake/KoToolManager.cpp 2990b62 Diff: https://git.reviewboard.kde.org/r/119569/diff/ Testing --- Tested in Krita Tha

Review Request 119569: Fixed recognition of the Wacom Stylus serial id

2014-08-01 Thread Dmitry Kazakov
lake/KoToolManager.h 17b718e libs/flake/KoToolManager.cpp 2990b62 Diff: https://git.reviewboard.kde.org/r/119569/diff/ Testing --- Tested in Krita Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Dmitry Kazakov
> On Июль 13, 2014, 8:40 д.п., Dmitry Kazakov wrote: > > Hi, Vadim! > > > > Thanks for a nice catch! Can you push the patch into master or we should do > > it on bahalf you you? Oh, I read till the end. I

Re: Review Request 119244: _C symbol breaks compilation on OpenBSD

2014-07-13 Thread Dmitry Kazakov
the patch into master or we should do it on bahalf you you? - Dmitry Kazakov On Июль 12, 2014, 11:54 д.п., Vadim Zhukov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 119224: Fix Krita speed sensor

2014-07-11 Thread Dmitry Kazakov
not needed. Everything can be implemented inside KisPaintInformation. - Dmitry Kazakov On Июль 11, 2014, 3:30 д.п., Sven Langkamp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: 2.8.x maintenance plan and 2.9 ?

2014-07-03 Thread Dmitry Kazakov
iling list >> > calligra-devel@kde.org >> > https://mail.kde.org/mailman/listinfo/calligra-devel >> >> >> >> -- >> regards / pozdrawiam, Jaroslaw Staniek >> Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org >> Qt for Tizen | http://qt-project.org/wiki/Tizen >> Qt Certified Specialist | http://www.linkedin.com/in/jstaniek >> > > > > -- > regards / pozdrawiam, Jaroslaw Staniek > Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org > Qt for Tizen | http://qt-project.org/wiki/Tizen > Qt Certified Specialist | http://www.linkedin.com/in/jstaniek > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 118517: New brush stabilizer

2014-06-15 Thread Dmitry Kazakov
aster! http://commits.kde.org/calligra/58e452c466505aa44c0208bd649d0c8facf0194f - Dmitry Kazakov On June 9, 2014, 10:22 a.m., Juan Luis Boya García wrote: > > --- > This is an automatically generated e-mail. To reply,

Last call for reviewers of "Typesafe strings for KUndo2Command" review request

2014-06-06 Thread Dmitry Kazakov
ere anyone else planning to make a review or I can already push it to calligra-master? -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 118517: New brush stabilizer

2014-06-04 Thread Dmitry Kazakov
-- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118517/ > --- > > (Updated June 4, 2014, 11:13 a.m.) > > > Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewi

Re: Review Request 118517: New brush stabilizer

2014-06-04 Thread Dmitry Kazakov
. You can also see it in the attached screenshot. - Dmitry Kazakov On June 4, 2014, 11:13 a.m., Juan Luis Boya García wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: 2.8.1 Changelogs

2014-03-27 Thread Dmitry Kazakov
el mailing list > > calligra-devel@kde.org > > https://mail.kde.org/mailman/listinfo/calligra-devel > > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov _

Re: Review Request 115529: Allow the user not to merge the last point in KoCreatePathTool

2014-03-15 Thread Dmitry Kazakov
, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: A hint: commits that are not cherry-picked between branches

2014-03-04 Thread Dmitry Kazakov
dev/null; then mv $TMP $TMP.diff; TMP=$TMP.diff; fi emacs-x11 $TMP rm $TMP On Tue, Mar 4, 2014 at 1:43 AM, Jaroslaw Staniek wrote: > And the script... > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https

Re: Final release date?

2014-02-27 Thread Dmitry Kazakov
t? > > > > > > -- > Boudewijn Rempt > http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Dmitry Kazakov
________ > Kde-soc-mentor mailing list > kde-soc-men...@kde.org > https://mail.kde.org/mailman/listinfo/kde-soc-mentor > -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 115529: Allow the user not to merge the last point in KoCreatePathTool

2014-02-07 Thread Dmitry Kazakov
/tools/KoCreatePathTool_p.h ee94c4f libs/basicflakes/tools/KoCreatePathTool.cpp fbda308 Diff: https://git.reviewboard.kde.org/r/115529/diff/ Testing --- Tested in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list

Re: Review Request 115529: Allow the user not to merge the last point in KoCreatePathTool

2014-02-07 Thread Dmitry Kazakov
--- Tested in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 115529: Allow the user not to merge the last point in KoCreatePathTool

2014-02-07 Thread Dmitry Kazakov
/basicflakes/tools/KoCreatePathTool.cpp fbda308 libs/basicflakes/tools/KoCreatePathTool_p.h ee94c4f Diff: https://git.reviewboard.kde.org/r/115529/diff/ Testing --- Tested in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list

[calligra] libs/main: Add a warning about weird shortcut context initialization in the KoView

2014-01-30 Thread Dmitry Kazakov
Git commit 818245e7f0b387abe0244a2d65017914ee75fc8c by Dmitry Kazakov. Committed on 31/01/2014 at 07:12. Pushed by dkazakov into branch 'master'. Add a warning about weird shortcut context initialization in the KoView I don't know why this is done, this code was added back in 20

Re: Release Blockers for Krita 2.8

2014-01-28 Thread Dmitry Kazakov
d=329026 >> Bug 313494 " [ sensor / dynamics ] Hue / Saturation / Value sensors are >> broken " https://bugs.kde.org/show_bug.cgi?id=313494 >> >> Good luck ! >> -David >> >> _ >> http://www.davidrevoy.com >>

Re: Review Request 115352: Fix the Stroke and Shape Id of the Pencil Tool

2014-01-28 Thread Dmitry Kazakov
/KoStrokeConfigWidget.cpp 3a0dc84 Diff: https://git.reviewboard.kde.org/r/115352/diff/ Testing --- Tested in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 115352: Fix the Stroke and Shape Id of the Pencil Tool

2014-01-28 Thread Dmitry Kazakov
in Krita and Karbon Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Release Blockers for Krita 2.8

2014-01-28 Thread Dmitry Kazakov
iate krita sketch with .kra files" Bug 301443 <https://bugs.kde.org/show_bug.cgi?id=301443> - CandleGlass.exr is not loaded correctly Bug 325423 <https://bugs.kde.org/show_bug.cgi?id=325423> - speed dynamic doesn't work -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 115149: Quick fix of BUG:322951

2014-01-20 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115149/#review47798 --- Ship it! Ship It! - Dmitry Kazakov On Jan. 20, 2014, 3:13

Re: Review Request 114890: Fix calculation of the shape's insets when it has Miter joining

2014-01-06 Thread Dmitry Kazakov
Diff: https://git.reviewboard.kde.org/r/114890/diff/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 114890: Fix calculation of the shape's insets when it has Miter joining

2014-01-06 Thread Dmitry Kazakov
/ Testing --- Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 114890: Fix calculation of the shape's insets when it has Miter joining

2014-01-06 Thread Dmitry Kazakov
--- The insets should be not smaller than the limit of the Miter joining. This patch fixes the update bug. Tested in Krita and Karbon with Arrow shapes. Diffs - libs/flake/KoShapeStroke.cpp 6edcc26 Diff: https://git.reviewboard.kde.org/r/114890/diff/ Testing --- Thanks, Dmitry

Re: Review Request 114468: fix linking error on FillProcessingVisitorTest

2013-12-17 Thread Dmitry Kazakov
in the test, because it is not needed anymore :) It was just a copy-paste error I guess. - Dmitry Kazakov On Dec. 14, 2013, 9:19 p.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To rep

[calligra/calligra/2.8] plugins/textshape: Fix a crash in Krita due to accessing to an unsupported action in TextTool

2013-12-07 Thread Dmitry Kazakov
Git commit a957d083cdc1d586ccbd2ba4a972c7eac3dd1e11 by Dmitry Kazakov. Committed on 07/12/2013 at 07:23. Pushed by dkazakov into branch 'calligra/2.8'. Fix a crash in Krita due to accessing to an unsupported action in TextTool The action "insert_table" (as well as other table

[calligra] plugins/textshape: Fix a crash in Krita due to accessing to an unsupported action in TextTool

2013-12-07 Thread Dmitry Kazakov
Git commit fad45bd4002c1417f8b9f0e9fc0743812a2ff787 by Dmitry Kazakov. Committed on 07/12/2013 at 07:23. Pushed by dkazakov into branch 'master'. Fix a crash in Krita due to accessing to an unsupported action in TextTool The action "insert_table" (as well as other table-relat

Re: Review Request 112883: Workaround for flickering in OpenGL 2 canvas on AMD graphic cards

2013-09-22 Thread Dmitry Kazakov
no regressions. Although I thing the patch really needs an extended comment in the code, explaining why this workaround was added. - Dmitry Kazakov On Sept. 22, 2013, 11:01 a.m., Sven Langkamp wrote: > > --- > This is an auto

Re: How to merge rebased branch properly?

2013-09-08 Thread Dmitry Kazakov
devel mailing list >> calligra-devel@kde.org >> https://mail.kde.org/mailman/**listinfo/calligra-devel<https://mail.kde.org/mailman/listinfo/calligra-devel> >> > > > ___ > calligra-

Re: Review Request 112405: Added three protected methods to KoCreatePathTool

2013-08-31 Thread Dmitry Kazakov
ttp://git.reviewboard.kde.org/r/112405/#comment28788> addPathShape() now has its own check for the existence of 'shape' (see line KoCreatePathTool_p.h:386). This check is added to the method directly, because there are a few places where it is called from. It it ok? - Dmitry Kaza

Review Request 112405: Added three protected methods to KoCreatePathTool

2013-08-31 Thread Dmitry Kazakov
51f4a8f Diff: http://git.reviewboard.kde.org/r/112405/diff/ Testing --- Tested in Krita Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 112405: Added three protected methods to KoCreatePathTool

2013-08-31 Thread Dmitry Kazakov
/basicflakes/tools/KoCreatePathTool_p.h 51f4a8f Diff: http://git.reviewboard.kde.org/r/112405/diff/ Testing --- Tested in Krita Thanks, Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
ble to release bugfixes for Qt4 version this way. -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
t of them are not ready for switching to Linux just because of a single application. They have too much to lose in the Windows world. Although I agree that we should at least try to keep some of the KDE capabilities/integration when working on Linux and disable it on Windows. But we need working power t

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
> > > Btw, do the File Layers in Krita check that the file is changed on disk? > Do > > they use some KIO thing for that? > > kdirnotify, as fast as I remember -- it's in kio: > ./staging/kio/src/core/kdirnotify.cpp > What is the difference with QFil

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
ell, the problem is that you needn't D&D a http-based URL for that. You just drag an *image* and it is passed as an URL. Chromium works a bit differently and it passes an image as a real image, which is handled without KIO. -- Dmitry Kazakov ___ cal

Re: Calligra 3.0 for Qt 5.1?

2013-07-29 Thread Dmitry Kazakov
Or at least make it configurable by cmake. -- Dmitry Kazakov ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

  1   2   >