----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118517/#review59241 -----------------------------------------------------------
Hi, Juan! Your patch gives quite interesting results, I like the effect! But there are at least two bugs right now: http://wstaw.org/m/2014/06/04/plasma-desktopdI1303.png 1) When you release the mouse button, the curve jumps to a random direction. Well, it might be not random, it is just tracing the trajectory which the mouse did in the background. In the attached screenshot, I painted a circle and the curve at the top appeared when I released the button. 2) With four smoothing algorithms the Tool Options docker became too wide to fit usual panel size and scrollbars appeared. We need to invent a better UI for switching the smoothing engines. You can also see it in the attached screenshot. - Dmitry Kazakov On June 4, 2014, 11:13 a.m., Juan Luis Boya García wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118517/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 11:13 a.m.) > > > Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewijn > Rempt. > > > Repository: calligra > > > Description > ------- > > This commit adds to calligra a new stabilizer feature as an alternative > to the current "Weigthed smoothing". > > This stabilizer is very simple, calculating an arithmetic mean of the > last N values (position, pressure and tilt) each millisecond and drawing > a line from the previous point to there. > > This takes into account both the length of the strokes and the speed > they are made with. > > Fast and small movements are considered erratic and are likely to be > ignored yielding a mostly straight line. > > On the other hand, slower and bigger movements are assumed to be > deliberated and will follow the shape the user draws. The slower and > bigger, the more accurate. > > This process makes the strokes draw 'slowly'. The user sees how the line > pursues their cursor. The effect is harder or softer depending on the N > chosen (sample size), which is user-customizable. > > Starting and end points are forced by the algorithm to be drawn exactly > where the user began and ended the line. > > > Diffs > ----- > > krita/plugins/tools/defaulttools/kis_tool_brush.cc ceab3d8 > krita/ui/tool/kis_smoothing_options.h f2d5388 > krita/ui/tool/kis_tool_freehand_helper.h ee49086 > krita/ui/tool/kis_tool_freehand_helper.cpp aae08f1 > > Diff: https://git.reviewboard.kde.org/r/118517/diff/ > > > Testing > ------- > > > Thanks, > > Juan Luis Boya García > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
