gnulib/m4/getcwd-path-max.m4 fails on Mac OS X 10.5.8

It appears that the test in gnulib/m4/getcwd-path-max.m4 fails on Mac OS X 10.5.8, leaving behind a deep directory tree that $ac_clean_files doesn't properly clean up. Is there any way to get "configure" to succeed on such a platform? Is Mac OS X 10.5.8 still a supported target for gnulib? If a

Non-capturing groups in Emacs-dialect regexes

Findutils has a bug report about non-capturing ("shy") groups \(? in Emacs-dialect regular expressions ( https://savannah.gnu.org/bugs/index.php?65770). >From the Emacs Texinfo manual: ‘\(?: ... \)’ specifies a “shy group” that does not record the matched substring; you can’t refer back

[PATCH 2/2] Make it possible to call opendir_safer from C++.

* lib/dirent-safer.h: use extern "C". --- lib/dirent-safer.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/dirent-safer.h b/lib/dirent-safer.h index 4d8e5ee92..6f6288e61 100644 --- a/lib/dirent-safer.h +++ b/lib/dirent-safer.h @@ -19,4 +19,12 @@ #include +# ifdef __cplusplu

[PATCH] Make it possible to call canonicalize_filename_mode from C++.

* lib/canonicalize.h: use extern "C". --- lib/canonicalize.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/canonicalize.h b/lib/canonicalize.h index 2ffa1f681..d21b5b203 100644 --- a/lib/canonicalize.h +++ b/lib/canonicalize.h @@ -21,6 +21,10 @@ #define CAN_MODE_MASK (CAN_EXIS

fts: find -xdev, FTS_XDEV and POSIX issue http://austingroupbugs.net/view.php?id=1133

Eric mailed the findutils list a while back to point out that POSIX will standardise a new -mount option for find which is similar to -xdev but differs in the way the mount point itself is handled. I believe that the POSIX nftw() library function also gets a new option FTW_XDEV, Somewhat confusi

Re: [bug #33724] Find command is changing the access time of directory

pecially helpful. > (and may not work over NFS or other remote filesystems where root is squashed). On Sat, Sep 29, 2018 at 8:30 AM James Youngman wrote: > Having a "don't update atime" option that only works sometimes (when I > own the directory) seems problematic to me. >

Re: [bug #33724] Find command is changing the access time of directory

t; [CC-ing gnulib, in the hope they see the attachment as well.] > > On Sun 01 Nov 2015 11:19:53 PM CET, James Youngman wrote: > > It looks like the FTS_NOATIME flag does what's needed. > > Not quite: openat() returns with EPERM if: > > $ man openat | grep EPERM.*NOATIME

Re: Why is `find -name '*.txt'` much slower than '*.txt' on glusterfs?

On Sun, Jan 28, 2018 at 6:57 PM Bernhard Voelker wrote: > On 01/27/2018 06:45 PM, Peng Yu wrote: > >> glusterfs doesn't provide D_TYPE information: > >> > >> getdents(4, {{d_ino=10054722685526780333, ..., d_type=DT_UNKNOWN} ... > >> > >> Nevertheless, it is strange that find calls newfstatat() al

Re: [PATCH 5/6] fts: three levels of leaf optimization

On Thu, Apr 5, 2018 at 4:49 PM, Paul Eggert wrote: > > On 04/05/2018 05:44 AM, Kamil Dudka wrote: >> >> Does this change (intentionally?) enable leaf optimization for CIFS? > > > No, I wasn't thinking about CIFS when I wrote that. Thanks for reporting it. I installed the attached to try to fix thi

Re: SIGSEGV in partial_quotearg_n()

On Fri, Aug 18, 2017 at 3:23 PM, Kamil Dudka wrote: > > We have multiple occurrences of automated crash reports: > > https://retrace.fedoraproject.org/faf/reports/1209278/ > > ... about SIGSEGV in partial_quotearg_n() at this location in the source code: > > http://git.savannah.gnu.org/cgit/findut

Re: findutils 4.6.0 v. Tru64 (strftime() v. "%F"?)

On Thu, May 25, 2017 at 10:04 PM, Paul Eggert wrote: > On 05/25/2017 07:54 AM, Eric Blake wrote: >> >> So yes, either findutils should be using nstrftime() and not strftime() >> (which will guarantee that these sequences work), or it is indeed time >> to patch gnulib to provide a replacement strft

Re: [bug #48055] Regex ranges and locales in gnu-awk regextype

Findutils uses the regular expression implementation from gnulib. So this problem likely also exists there, or perhaps has already been fixed there. On Mon, May 30, 2016 at 7:12 AM, Piotr Jurkiewicz wrote: > URL: > > > Summary: Regex rang

Re: Automatically-generated regexp documentation

On Tue, Oct 25, 2016 at 3:26 PM, Eric Blake wrote: > On 10/21/2016 03:17 PM, Eric Blake wrote: > > At any rate, I'll post the commands I used to make the conversion, once > > it is complete; here's my starting point. > > > > $ git fsck 2>&1 | sed -n 's/error in tag \([^:]*\).*/\1/p' > broken > >

Re: [Bug 984910] rm fails to detect errors in readdir(3)

I'm a bit late coming to this thread, sorry. The "oldfind" (i.e. not-fts) implementation of find iterates over a directory like this: while (1) { const char *namep; const struct dirent *dp; /* We reset errno here to distinguish between end-of-director

Re: [PATCH 1/2] fts: introduce the FTS_NOLEAF flag

Coming to this thread late, but this patch should be included now in current findutils git. On Mon, Jan 18, 2016 at 4:10 PM, Kamil Dudka wrote: > On Monday 21 December 2015 15:01:56 Kamil Dudka wrote: > > On Monday 21 December 2015 00:05:51 Pádraig Brady wrote: > > > On the other hand we've had

Re: Multiple issues on GNU/hurd

On Sat, Jan 2, 2016 at 1:51 PM, Pádraig Brady wrote: > On 02/01/16 13:38, Andreas Metzler wrote: >> Hello, >> >> when trying to build GNU findutils on GNU/hurd multiple gnulib >> testsuite errors have come up: >> >> (sid_hurd-i386-dchroot)ametzler@exodar:~/FIND/findutils-4.6.0/tests$ >> ./test-fa

Re: Multiple issues on GNU/hurd

On Sun, Jan 3, 2016 at 12:29 AM, Pádraig Brady wrote: > Well I suppose we could warn in that case. I'd like a slightly stronger option, somehow. Obviously there are tests which are Windows-only, which I therefore can't run. But if I can get better test coverage by just installing something or

Re: Multiple issues on GNU/hurd

I've updated the findutils git tree to current head, so that should pass. Opinions on precisely what gnulib commit to use for an updated findutils stable release are invited :) But this test failed on a stable findutils release, which is a concern. Looking quickly at the test it seems that the

Re: a minor bug

e attached the patch I used. Thanks for the help, and please consider contributing further! James. From 175862af7b0e111d3360b1fedaa13df55d9f5d61 Mon Sep 17 00:00:00 2001 From: James Youngman Date: Wed, 23 Dec 2015 22:45:18 + Subject: [PATCH] xargs: Don't leak file descriptors over an ex

[PATCH] regexprops-generic: udpate from regex.h

* doc/regexprops-generic.texi: update by running the regexprops binary from findutils (the command line is 'regexprops "Regular Expressions" generic'). The recent (ish) change (5a5a9388e93d00a7bcb97700a7a552bef20343fd) to regex.h aligning gnulib with GNU grep had made this document out-of-date. T

Re: New "was expanded before it was required" warnings after gnulib update

It looks like updating to gnulib 0.19.x fixes this.

Re: [bug #45445] AIX make check test-getdelim.c:72: assertion failed Abort(coredump)

On Mon, Aug 31, 2015 at 10:27 PM, Eric Blake wrote: > That means that gnulib should be testing whether the system > getdelim/getline matches the POSIX and GNU version, or whether it is an > unrelated symbol (as appears to be the case on AIX), so that configure > can get the right result from the b

Using gitlog-to-changelog with VPATH builds

I just started using gitlog-to-changelog for a project which I maintain using VPATH builds -- that is, I run "configure" somewhere other than in $(srcdir). I found that gitlog-to-changelog didn't work as well as I had hoped because there is no ./.git. The gen-ChangeLog rule in coreutils checks f

Re: license request for mgetgroups

LGPL code. > > > > For my own contributions to these modules, I'm okay with relaxing to > > LGPLv2+. I've cc'd all other contributors as tracked by gnulib.git's > > history (I'm not sure if coreutils.git would turn up any earlier authors > &g

Style question on choosing shell variable names to use with the manywarnings module

Hi, I'm using gnulib's manywarnings module in findutils. I have an --enable-compiler-warning configure option which turns on the warnings. Since most people won't use this option, I call gl_MANYWARN_ALL_GCC unconditionally to help discover systems on which this doesn't work (none found yet!).

Re: Test failure

This test is part of gnulib if I recall correctly. On 9 Jan 2014 19:00, "Perry Smith" wrote: > > PASS: test-ftello.sh > /usr/work/src/findutils-4.4.2/tests/test-getdelim.c:72: assertion failed > /gsa/ausgsa/projects/r/ruby/bin/bash: line 4: 10551374 IOT/Abort trap > (core dumped) EXEEXT='' E

New "was expanded before it was required" warnings after gnulib update

I just updated my local copy of gnulib (which I use as a submodule) and am seeing "was expanded before it was required" warnings from Autoconf. $ git diff master~..master gnulib diff --git a/gnulib b/gnulib index fd9f1ac..fb884a0 16 --- a/gnulib +++ b/gnulib @@ -1 +1 @@ -Subproject commit fd9f

Re: ls-mntd-fs.m4 fails to detect how to read list of mounted filesystems on Minix

According to http://minix1.woodhull.com/manpages/man5/fstab.5.html ... /etc/mtab contains lines of four fields. The layout is: devicedirectorytypeoptions These fields may be explained as follows: device A block special device. directory

Re: gnulib/README -> gnulib.texi

On Sun, Apr 22, 2012 at 12:20 PM, Bruno Haible wrote: > Hi Paul, > > Thanks for looking into this doc improvement. > > I like the added text to "Target Platforms". > > However, I don't agree to putting the contributor's guide into the manual, > simply because that's not the target audience of the

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

On Fri, Nov 16, 2012 at 10:33 PM, Paul Eggert wrote: > On 11/16/12 14:10, Dmitry V. Levin wrote: >> As I said, my proposal is to introduce a new FTS_ flag that would make >> fts_open behave as before that change, and use this flag in findutils. >> I haven't heard yet neither from Jim nor from othe

Re: [PATCH] fts: reduce two or more trailing spaces to just one, usually

Did anybody do any further work on whether it worked best to fix this in gnulib or in findutils?

Re: request to relax license of 'stat-time'

Fine for me too, for any officially published issue of the LGPL.

Re: fts: do not exhaust memory when processing million-entry directory

2011/8/19 Pádraig Brady : > file descriptors a usually more constrained so I'd > lean towards using more memory. Of course for fts, it's possible to take an adaptive strategy also. If at any time, fts fails to open a directory with ENFILE, it can check the parent directories; examining only the di

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

On Mon, Jul 11, 2011 at 1:11 AM, Paul Eggert wrote: > On 07/10/11 02:16, James Youngman wrote: >> A function-level pragma would probably be ideal here, but >> unfortunately they can only be used to tweak optimisation and function >> attributes. > > Can you do "#pr

Moving (initially function) attribute macros into a separate gnulib module

I just went to use some function attributes in findutils and noticed that information about which versions of GCC support various attributes is spread throughout gnulib. While a number of headers define convenience macros (usually starting _GL_ATTRIBUTE_) there are a couple of naming inconsistenci

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

On Sun, Jul 10, 2011 at 5:47 AM, Paul Eggert wrote: > On 07/09/11 15:32, James Youngman wrote: >> Is there a way of eliminating this false positive which doesn't force >> me to give up -Wvla? > > You can use a pragma in the module that you've audited. > The prag

Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

To be clear before we start, gnulib is doing the right thing here. It contains this code in lib/gettext.h:- static const char * dcpgettext_expr (const char *domain, const char *msgctxt, const char *msgid, int category) { size_t msgctxt_len = strlen (msgctxt) +

Re: [PATCH] fts: introduce FTS_NOATIME

ftware: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Eric B. Decker, James Youngman, and Kevin Dalley. Built using GNU gnulib version e5573b1bad88bfabcda181b9e0125fb0c52b7d3b Features enabled: D_TYPE O_NOFOLLOW(enabled) LEAF_OPTIMISATI

Re: [bug #33724] Find command is changing the access time of directory

I think that would also need a change to ftw(). That's in gnulib. On Thu, Jul 7, 2011 at 2:10 PM, Eric Blake wrote: > Follow-up Comment #1, bug #33724 (project findutils): > > POSIX requires this behavior.  However, Linux provides the O_NOATIME flag to > open() to work around this behavior - so

Re: good place for blogging on C/POSIX programming?

On Sun, Jul 3, 2011 at 2:31 PM, Bruno Haible wrote: > There are currently 3 pieces of documentation that deal with C programming: >  - The glibc manual, >  - The Autoconf manual's section "Portable C and C++ Programming", >  - The gnulib manual. Also: https://savannah.gnu.org/projects/gnu-c-manu

Re: PATH_MAX constant expression

On Mon, Jun 20, 2011 at 11:34 PM, Bruno Haible wrote: > I find it reasonable to use "#ifdef PATH_MAX" in front of every use of > PATH_MAX, like POSIX requires. I agree. I think it would be helpful if there were some automated way of reminding people to do that though. Many people develop on sys

Re: PATH_MAX and test-stat.h

On Sun, Jun 19, 2011 at 7:49 AM, Ralf Wildenhues wrote: > Hello, > > * James Youngman wrote on Sun, Jun 19, 2011 at 12:57:01AM CEST: >> On Sat, Jun 18, 2011 at 11:24 PM, Karl Berry wrote: >> >    I suspect that the most useful thing we can do in gnulib is define &

Re: PATH_MAX and test-stat.h

On Sat, Jun 18, 2011 at 11:24 PM, Karl Berry wrote: > IMHO ... > >    I suspect that the most useful thing we can do in gnulib is define >    PATH_MAX to a non-constant expression on all platforms, > > And intentionally break loads of existing code? > I am highly doubtful that that is "useful"; "p

Re: PATH_MAX and test-stat.h

On Sat, Jun 18, 2011 at 8:33 PM, Bruno Haible wrote: > Hi Eric, > > In pathmax.h one of the possible replacement values for PATH_MAX on systems > that don't define it (currently HP-UX and GNU/Hurd) is an expression > involving pathconf(). > > But tests/test-stat.h line 20 declares an array of size

Re: [PATCH] bootstrap: obey --no-git.

On Sat, Jun 11, 2011 at 2:17 PM, Bruno Haible wrote: > Hi James, > >> +     * build-aux/bootstrap: obey the --no-git option. > > The --no-git option already has a certain effect; it's not entirely unused. > How does your change relate to the previously posted patches? Without this patch, at HEAD,

[PATCH] bootstrap: obey --no-git.

+++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-06-11 James Youngman + + bootstrap: obey --no-git. + * build-aux/bootstrap: obey the --no-git option. + 2011-06-09 Bruno Haible thread: Support pthreads-win32. diff --git a/build-aux/bootstrap b/build-aux/bootstrap index 522ac70

Re: STDERR_FILENO on HP-UX

On Thu, Jun 9, 2011 at 11:01 AM, Jim Meyering wrote: > Bruno Haible wrote: >> Apparently, although fd 2 was closed in the parent process, it is open again >> in the child process. This must happen in the exec* calls, since posix_spawn > > This is a security (mis)feature of HP-UX. > I noticed it w

[PATCH] New module 'stat-size'.

ize.h create mode 100644 m4/stat-size.m4 create mode 100644 modules/stat-size diff --git a/ChangeLog b/ChangeLog index 69e4e03..6df3b4d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,16 @@ +2011-06-11 James Youngman + + New module 'stat-size'. + * modules/stat-size: New mo

Re: [PATCH] New module 'stat-size'.

On Thu, Jun 9, 2011 at 2:08 AM, Bruno Haible wrote: > Actually AC_STRUCT_ST_BLOCKS is already invoked from the module 'fileblocks', > and this module is among the dependencies of your new module. So, I think > you can just drop this invocation here. Thanks for the advice, I'll send an updated pat

fileblocks: missing declaration of st_blocks?

I notice that the fileblocks module defines st_blocks, but there's no declaration for it. Is that deliberate? James.

[PATCH] New module 'stat-size'.

af040..153ba96 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2011-06-09 James Youngman + + New module 'stat-size'. + * modules/stat-size: New module. Provides macros for accessing + file size informaiton in instances of struct stat. Depends on the +

Re: [PATCH 1/2] stat-macros: Enhance to provide block-related information.

On Wed, Jun 8, 2011 at 1:43 AM, Paul Eggert wrote: >>  Depends-on: >> +sys_stat >> +stdint > > We can break the dependency on the stdint module > by using (size_t) -1 instead of SIZE_MAX. Thanks for the tip. > Why does stat-macros need to depend on sys_stat? Because ST_NBLOCKS uses S_ISREG, for

[PATCH 1/2] stat-macros: Enhance to provide block-related information.

posed of an extract from coreutils system.h, which findutils shares, change the maintainer to James Youngman, Jim Meyering. * m4/stat-macros.m4: Check for sys/param.h. * modules/stat-macros-tests: New test module for stat-macros. * tests/test-stat-macros.c: New test, verifies very basic behaviour of

[PATCH 2/2] stat-macros: document the stat-macros module.

100644 doc/stat-macros.texi diff --git a/ChangeLog b/ChangeLog index c7ddc06..3f74eea 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2011-06-07 James Youngman + + stat-macros: document the stat-macros module. + * doc/gnulib.texi: Include stat-macros.texi. + * doc/stat

[PATCH 0/2] stat-macros: shared code from coreutils & findutils

GNU findutils uses a section of code shared with coreutils' system.h to implement the -ls action. This particular section of code deals with figuring out the number of blocks in a file, and the units of st_nblocks. Rather than continue to try to keep these bits of code in sync, I propose to move

Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities.

On Sat, Jun 4, 2011 at 2:34 PM, Bruno Haible wrote: > Another nit is that "gcc -Wall" gives a warning (seen on OpenBSD 4.9): > >  getopt.c: In function '_getopt_internal_r': >  getopt.c:491: warning: unused variable 'ambig' > > I'm fixing it like this: Thanks for spotting (and fixing) that. Jame

Re: Syntax check prohibit_doubled_word: false positives on non-English text

Thanks for your comments. I had fixed the Texinfo problems substantially as you suggested, but I opted to entirely exempt the .po files from the check. More generally, the sntax-check rules discovered a number of potential improvements for findutils, including unused headers, opportunities to us

Syntax check prohibit_doubled_word: false positives on non-English text

I had an interesting failure from the prohibit_doubled_word syntax check: prohibit_doubled_word_RE_ ?= \ /\b(then?|[iao]n|i[fst]|but|f?or|at|and|[dt]o)\s+\1\b/gims prohibit_doubled_word_ =\ -e 'while ($(prohibit_doubled_word_RE_))'

Re: Using /proc/mounts in mountlist.c for linux

2011/5/31 Karel Zak : > On Tue, May 31, 2011 at 10:31:17AM +0100, Pádraig Brady wrote: >> On 31/05/11 01:14, James Youngman wrote: >> > On Tue, Apr 5, 2011 at 1:36 PM, Philipp Thomas wrote: >> >> GNU find will not recognize file systems of type autofs on newer

Re: Using /proc/mounts in mountlist.c for linux

2011/5/31 Pádraig Brady : > On 31/05/11 01:14, James Youngman wrote: >> On Tue, Apr 5, 2011 at 1:36 PM, Philipp Thomas wrote: >>> GNU find will not recognize file systems of type autofs on newer Linux >>> kernels as autofs entries are only listed in /proc/mounts and mou

Tweaking xargs to keep cores busier without needing -n

Oops, now really with a different subject. 2011/5/31 James Youngman : > [ CC += bug-findutils, += Paolo, -= bug-coreutils ] > > 2009/11/3 Pádraig Brady : >> Pádraig Brady wrote: >>> Paolo Bonzini wrote: >>>> Maybe we want a --parallel option (too bad -p is t

Re: [PATCH] core-count: A new program to count the number of cpu cores

[ CC += bug-findutils, += Paolo, -= bug-coreutils ] 2009/11/3 Pádraig Brady : > Pádraig Brady wrote: >> Paolo Bonzini wrote: >>> Maybe we want a --parallel option (too bad -p is taken) for xargs that >>> forces the creation of the number of processes passed with -P or taken >>> from nproc (for exa

Re: Using /proc/mounts in mountlist.c for linux

On Tue, Apr 5, 2011 at 1:36 PM, Philipp Thomas wrote: > GNU find will not recognize file systems of type autofs on newer Linux > kernels as autofs entries are only listed in /proc/mounts and mountlist.c > includes glibc mntent.h which takes the _PATH_MOUNTED from paths.h and that > is /etc/mtab. >

Moving findutils to a common build-from-source-tree system: bootstrap

[ I'm copying bug-gnulib mostly in case someone over there would like to warn us that the grass on the bootstrap side of the river is not quite as green as it first appeared. ] I just tried building GNU emacs from its bzr checkout instead of a tarball.This I made hard for myself by using "mak

Re: remove 'exit'?

On Sun, May 1, 2011 at 8:47 PM, Simon Josefsson wrote: > How about just removing the module?  If something breaks, the maintainer > can track it down, and will notice that the module disappeared, and fix > the package.  If nothing breaks, it is normally just a portability > problem that will be no

[PATCH] getopt: for ambiguous options, enumerate the possibilities.

James Youngman + + getopt: for ambiguous options, enumerate the possibilities. + * lib/getopt.c (_getopt_internal_r): Merge glibc change printing + the ambiguous options when an ambiguous prefix is given. This was + http://sourceware.org/bugzilla/show_bug.cgi?id=7101. The

[PATCH] getopt: for ambiguous options, enumerate the possibilities.

insertions(+), 18 deletions(-) diff --git a/ChangeLog b/ChangeLog index c2a67da..02809c5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2011-05-15 James Youngman + + getopt: for ambiguous options, enumerate the possibilities. + * lib/getopt.c (_getopt_internal_r): Merge

[PATCH] getopt: for ambiguous options, enumerate the possibilities.

insertions(+), 25 deletions(-) diff --git a/ChangeLog b/ChangeLog index c2a67da..02809c5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2011-05-15 James Youngman + + getopt: for ambiguous options, enumerate the possibilities. + * lib/getopt.c (_getopt_internal_r): Merge

[PATCH 2/2] Add a test for glibc's Bugzilla bug #12378.

From: James Youngman * m4/fnmatch.m4: Use gnulib's fnmatch if the system fnmatch doesn't allow the literal matching of a lone "[" (which is required by POSIX). * tests/test-fnmatch.c (main): Check that "[/b" matches itself. --- ChangeLog|8 +++

[PATCH 1/2] Sync glibc change fixing Bugzilla bug #12378.

From: James Youngman * lib/fnmatch_loop.c (FCT): When matching '[' keep track of beginning and fall back to matching as normal character if the string ends before the matching ']' is found. This is what POSIX requires. --- ChangeLog |8 lib/f

Re: [PATCH 1/2] Backport glibc change fixing Bugzilla bug #12378.

On Thu, May 12, 2011 at 1:57 AM, Bruno Haible wrote: > No tabs in gnulib source code. Can you please untabify the file before > committing it in gnulib? I'll resend the patch with the fixes you indicated, but I can't submit directly (perhaps my use of "git commit -s" was misleading, sorry). Jame

[PATCH 1/2] Backport glibc change fixing Bugzilla bug #12378.

From: James Youngman * lib/fnmatch_loop.c (FCT): When matching '[' keep track of beginning and fall back to matching as normal character if the string ends before the matching ']' is found. This is what POSIX requires. Signed-off-by: James Youngman --- ChangeLog

[PATCH 2/2] Add a test for glibc's Bugzilla bug #12378.

From: James Youngman * m4/fnmatch.m4: Use gnulib's fnmatch if the system fnmatch doesn't allow the literal matching of a lone "[" (which is required by POSIX). * tests/test-fnmatch.c (main): Check that "[/b" matches itself. Signed-off-by: James Youngman --

Re: A bug in findutils?

On Mon, Mar 28, 2011 at 11:25 AM, Cao, Da-Shi (EB-Presales-ZTE/HW-GZ) wrote: > I've get the most recent version of gunlib by "git clone" and it seems that > the issue is resolved here. > How should I proceed with my findutils? There are 3 main options: 1. Wait for a new stable release (4.4.3 or

Re: Interix list of mounted file systems.

On Thu, Jan 20, 2011 at 7:31 AM, Markus Duft wrote: > On 10/21/2010 12:35 PM, Jim Meyering wrote: >> Markus Duft wrote: >>> On 10/21/2010 11:59 AM, James Youngman wrote: >>>> On Thu, Oct 21, 2010 at 10:05 AM, Markus Duft wrote: >>>>> Hi! >

Re: Interix list of mounted file systems.

On Thu, Oct 21, 2010 at 10:05 AM, Markus Duft wrote: > Hi! > > I just created the attached patch for findutils to build. Any chance to > get this in your git repo? :) The code is as good as it can get with > interix, i think - improvement suggestions welcome! To make things very clear here to gnu

Re: Documentation question

On Sat, Aug 14, 2010 at 4:51 PM, Reuben Thomas wrote: > On 14 August 2010 16:46, Reuben Thomas wrote: >> On 4 August 2010 09:54, James Youngman wrote: >>> I'm not sure the two options need to be exclusive. >> >> Fair enough, especially as it's machine ge

Re: stat-time -> LGPLv3+

On Tue, Jul 27, 2010 at 12:32 AM, Bruno Haible wrote: > [Adding James to the CC] > >> > We’d like to use ‘stat-time’ in libguile, but libguile is LGPLv3+. >> > Could you make the license change? >> >> Or LGPL v2.1+ too. >> >> Anyway, CCed the other contributors (Bruno and Eric). > > According to '

[PATCH] users.txt: add GNU CSSC

--- users.txt |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/users.txt b/users.txt index 9f76a5f..e3c8f83 100644 --- a/users.txt +++ b/users.txt @@ -1,5 +1,6 @@ The following packages appear to be using gnulib and gnulib-tool: + CSSChttp://git.savannah.gnu

Minor bug in sc_program_name of maintainer-makefile.

Minor bug: sc_program_name complains about programs not calling set_program_name even if they're not linked with gnulib and the progname module wasn't imported. James.

Re: const local variables

On Sun, Apr 11, 2010 at 1:08 PM, Bruno Haible wrote: > James Youngman wrote: >> * lib/close-stream.c (close_stream): Make boolean variables const >> to document the fact that we set but do not change them. >> --- a/lib/close-stream.c >> +++ b/lib/close-stream.c &

Re: [PATCH] Don't error out if stdin/stdout/stderr was already closed.

On Sun, Apr 11, 2010 at 1:06 PM, Jim Meyering wrote: > James Youngman wrote: >> * lib/closeout.c (close_stdout): Don't signal an error closing >> stdout or stderr if it was already closed. >> * lib/closein.c (close_stdin): Don't signal an error closing stdin >&g

[PATCH] Don't error out if stdin/stdout/stderr was already closed.

hat we set but do not change them. Signed-off-by: James Youngman --- ChangeLog | 10 ++ lib/close-stream.c |6 +++--- lib/closein.c |4 +++- lib/closeout.c |9 +++-- 4 files changed, 23 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/Chang

Re: [PATCH] fprintftime: avoid a warning about ignored fwrite return value

I think strftime also needs to depend on ignore-value, since ignore-value.h is included in strftime.c. See the attached patch which I forgot to send at the time. From 5a84f1d36bbfbd1bcc1adc7c90819b82cb201768 Mon Sep 17 00:00:00 2001 From: James Youngman Date: Sun, 8 Nov 2009 20:17:09 +

[PATCH] Add missing parenthesis in manywarnings example

--- ChangeLog |5 + doc/manywarnings.texi |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6ff91cb..be00156 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2010-04-08 James Youngman + + * doc

Re: [PATCH] save-cwd: don't leak a file descriptor when the caller execs.

On Mon, Mar 29, 2010 at 11:23 AM, Paolo Bonzini wrote: > On 03/29/2010 11:49 AM, James Youngman wrote: >> >> Signed-off-by: James Youngman > > Good catch, thanks!  Do you have commit access? I don't. Thanks, James.

[PATCH] save-cwd: don't leak a file descriptor when the caller execs.

Signed-off-by: James Youngman --- ChangeLog|7 +++ lib/save-cwd.c |2 ++ modules/save-cwd |1 + 3 files changed, 10 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index dca5a12..f9bd220 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-03

MKDIR_P discovered by configure but not substituted in the Makefile

If I check out gnulib at e190c6630d13363e72ec421e4734ae255c70fbc5 and run ... ./gnulib-tool --create-testdir --dir=/tmp/testdir456 sys_stat cd /tmp/testdir456 ./configure make I get this result :- $ make make all-recursive make[1]: Entering directory `/tmp/testdir456' Making all in gllib make[2

Re: stat-time LGPL

On Sat, Jan 16, 2010 at 11:48 PM, Bruno Haible wrote: > Hi James, > > The lib/stat-time.h file in gnulib to which you contributed on 2007-03-27 > is under GPL. Guile would like to use it (see attached mail), but Guile is > LGPL. Can you agree to relicensing this file under LGPL? Paul Eggert has >

Re: stat-time LGPL

On Fri, Jan 8, 2010 at 7:34 PM, Bruno Haible wrote: > Hi Paul and James, > > The lib/stat-time.h file that you contributed to gnulib is under GPL. > Guile would like to use it (see attached mail), but Guile is LGPL. Can you > agree to relicensing this file under LGPL? Of course. James.

Re: Port findutil to z/OS

On Wed, Dec 30, 2009 at 2:42 PM, Boris Moskalev wrote: > Hello, James > > Dont know did you got my previous email. > > I took findutils version 4.4.2. On z/OS running USS (UNIX system service) > where I try to compile findutils. > > I attach arhiv with file config.log with some results. Can you t

Re: [PATCH] Fix Savannah bug #26868: compilation error on Solaris x86_64.

On Fri, Dec 4, 2009 at 7:48 PM, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to James Youngman on 12/4/2009 11:36 AM: >> * find/pred.c (file_sparseness): Use -1.0*HUGE_VAL rather than >> -HUGE_VAL to avoid compilation error on Solaris x

Re: [PATCH] fprintftime: avoid a warning about ignored fwrite return value

On Wed, Oct 28, 2009 at 9:34 AM, Jim Meyering wrote: > Here's hoping that POSIX (or ISO C) will eventually fix fputc/fwrite/etc. > so that we don't have to add caveats like what I wrote in the comment below. > > As far as I know, date, du --time and uptime are the only clients that > use fprintfti

Re: [PATCH] modules/strftime (Depends-on): Add ignore-value.

On Sun, Nov 8, 2009 at 9:27 PM, Jim Meyering wrote: > James Youngman wrote: >> The attached patch simply makes the strftime module depend on >> ignore-value, since lib/strftime.c includes "ignore-value.h". > > Hi James, > > Thanks for the patch, but as far a

Re: need opendir_safer, dirent--.h

On Tue, Sep 1, 2009 at 6:26 PM, Eric Blake wrote: > Eric Blake byu.net> writes: > >> > I think we need to implement opendir_safer, alongside all the other >> > *_safer modules.  Otherwise, opendir can end up placing an open directory >> > fd in one of the standard slots, and end up interfering wi

[PATCH] modules/strftime (Depends-on): Add ignore-value.

The attached patch simply makes the strftime module depend on ignore-value, since lib/strftime.c includes "ignore-value.h". From 3f89bf8a271833d1f854d427db3df928915d9d82 Mon Sep 17 00:00:00 2001 From: James Youngman Date: Sun, 8 Nov 2009 20:17:09 + Subject: [PATCH] modules/strftim

Re: O_CLOEXEC support

On Fri, Aug 21, 2009 at 12:42 AM, Eric Blake wrote: > Interesting.  What happens if you pass the bit value of O_CLOEXEC to an > older kernel that doesn't understand it - does the open fail with ENOSYS, > or does it cause a kernel panic (requiring a reboot for recovery)? I haven't tested this parti

Re: [PATCH] fts: avoid false-positive cycle-detection

On Sun, Jul 19, 2009 at 9:35 PM, Jim Meyering wrote: > I'm considering a rewrite of rm that uses fts.c, > and see that the resulting rm fails coreutils' rm/cycle test > because it incorrectly reports a cycle for that unusual case. > > The following patch fixes fts so that it properly reinitializes

Re: [PATCH] argv-iter: new module

On Sun, Jul 5, 2009 at 11:19 AM, Bruno Haible wrote: > About the unit test: > >> +#define STREQ(s1, s2) ((strcmp (s1, s2) == 0)) > > What is the reason for the extra parentheses? Is some gcc warning avoided > by this? Well, that technique does protect you against bugs resulting from various odd us

Re: dropping setuid/setgid privileges

On Fri, Jun 12, 2009 at 12:29 AM, Bruno Haible wrote: >> That is usually necessary but not always sufficient, for example see >> http://blogs.sun.com/peteh/date/20050614 > > What do you mean by "not always sufficient", other than kernel bugs and > implementation limits? Assuming a small number of

  1   2   3   4   >