On Fri, Dec 4, 2009 at 7:48 PM, Eric Blake <e...@byu.net> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > According to James Youngman on 12/4/2009 11:36 AM: >> * find/pred.c (file_sparseness): Use -1.0*HUGE_VAL rather than >> -HUGE_VAL to avoid compilation error on Solaris x86_64. This >> avoids a "wrong type argument to unary minus" compiler error. >> * NEWS: Mention this change. > > Is this something that gnulib's math.h could work around?
Yes, it looks like it is. Good call. So I just pushed the attached patch instead of the one I posted earlier. James.
From 8ba9443ed5006c4031399c114a8fdfb0421ed5df Mon Sep 17 00:00:00 2001 From: James Youngman <j...@gnu.org> Date: Fri, 4 Dec 2009 22:24:47 +0000 Subject: [PATCH] Fix Savannah bug #26868: compilation error in pred.c on Solaris x86_64. To: findutils-patc...@gnu.org * import-gnulib.config (modules): Include gnulib's math module, to avoid a compilation error for "-HUGE_VAL" on Solaris x86_64. * NEWS: Mention this change. Signed-off-by: James Youngman <j...@gnu.org> --- ChangeLog | 8 ++++++++ NEWS | 2 ++ import-gnulib.config | 1 + 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3deeb07..89a4075 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2009-12-04 James Youngman <j...@gnu.org> + + Fix Savannah bug #26868: compilation error in pred.c on Solaris + x86_64. + * import-gnulib.config (modules): Include gnulib's math module, to + avoid a compilation error for "-HUGE_VAL" on Solaris x86_64. + * NEWS: Mention this change. + 2009-11-29 James Youngman <j...@gnu.org> * find/testsuite/find.posix/exec-nogaps.exp: New test for find diff --git a/NEWS b/NEWS index c99faa6..d78d1d6 100644 --- a/NEWS +++ b/NEWS @@ -10,6 +10,8 @@ GNU findutils NEWS - User visible changes. -*- outline -*- (allout) #27017: find -D opt / -fstype ext3 -print , -quit coredumps. +#26868: compilation error in pred.c on Solaris x86_64 + #24873: Duplicate fprint option corrupts output #23920: warn about un-matchable -path arguments ending in /. diff --git a/import-gnulib.config b/import-gnulib.config index 10d85ac..44e6b02 100644 --- a/import-gnulib.config +++ b/import-gnulib.config @@ -52,6 +52,7 @@ inline inttypes lstat malloc +math mbrtowc mbscasestr mbsstr -- 1.5.6.5
