On Sun, Nov 8, 2009 at 9:27 PM, Jim Meyering <j...@meyering.net> wrote: > James Youngman wrote: >> The attached patch simply makes the strftime module depend on >> ignore-value, since lib/strftime.c includes "ignore-value.h". > > Hi James, > > Thanks for the patch, but as far as I can tell it's not needed, > since the only uses are protected by "#if FPRINTFTIME". > The fprintftime module *does* depend on ignore-value, > since it's the one that defines FPRINTFTIME.
At 26c5fd742f9136e2ddbd4695a9172c3fa30ea260 we have this in lib/strftime.c: # if FPRINTFTIME # include "fprintftime.h" # else # include "strftime.h" # endif # include "ignore-value.h" ... so perhaps the correct fix is to move the third #include into the first arm of the #if. James.
