Re: Review Request: Support for equalizer scripts and plugins. WIP.

> On Aug. 16, 2012, 10:18 a.m., Ralf Engels wrote: > > Is this still WIP? Well it's been a work in progress in the same sense that I'm learning to play the harmonica that has been sitting idly on my desk for a month or two. Now that I'm getting emails about it however I'll start afresh. - Ry

Amarok startup blocks when NFS mounts are not accessible

first on: NfsDeviceHandlerFactory::canHandle() NfsDeviceHandler.cpp:153 KMountPoint::Ptr m = KMountPoint::currentMountPoints().findByPath( access->filePath() ); Then after forcefully unmounting the shares, m is valid and canHandle() returns true, then it blocks on the next call to NfsDeviceHandl

Re: environment for amarok at build.kde.org

On Thursday 16 August 2012 17.55.14 Edward Toroshchin wrote: > Hey, > > We've been wondering, why the SQL tests have been failing at > build.kde.org, and it turned out, that it's something to do with SQL > server at the build host. > > It looks like this bug: [1]. Note that Amarok tests output th

Re: Review Request: Restore heuristics to guess whether album is a compilation

> On Aug. 16, 2012, 12:15 p.m., Ralf Engels wrote: > > Just going through all the review requests again. > > > > With your patch the following auto test is failing: > > testIdentifyCompilationInMultipleDirectories Which is, I guess, expected - since it was the purpose of this patch to detect

Re: Review Request: GSoC : Nepomuk plugin for Amarok

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/ --- (Updated Aug. 16, 2012, 3:52 p.m.) Review request for Amarok, Edward Hades

Re: Review Request: Proof of concept for the 2012 GSoC project idea 'Semantic Collection for Amarok'.

Like Edward said it was not meant to be shipped. "How about a real Nepumuk backed collection not using sql at all?" It is done and have submitted the request for the same. Sorry for not closing it earlier. Closed it now. Thanks Ralf. On Thu, Aug 16, 2012 at 5:57 PM, Ralf Engels wrote: >Th

environment for amarok at build.kde.org

Hey, We've been wondering, why the SQL tests have been failing at build.kde.org, and it turned out, that it's something to do with SQL server at the build host. It looks like this bug: [1]. Note that Amarok tests output the "MySQL library initialization failed" line, which bodes no good :). Coul

Re: [Tomahawk Integration] GSoC Final Report

Hi everyone, ... > > > Although the tomahawk service core is ready, there still some work to do > in > > order for it to be even more awesome. So, here goes my plans for 2.7: > > > > A new context view applet to see what your friends have been listening > > to(playback history). > > You might wan

Jenkins build is still unstable: amarok_master #231

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

> On April 22, 2012, 5:28 p.m., Matěj Laitl wrote: > > This makes sense, give me some time to test it and think about it. > > Ralf Engels wrote: > Thought about it? > Should we ship it? The #include fixes are definitly right, including completely circumvents CMake taglib detection. In

Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

> On April 22, 2012, 5:28 p.m., Matěj Laitl wrote: > > This makes sense, give me some time to test it and think about it. Thought about it? Should we ship it? - Ralf --- This is an automatically generated e-mail. To reply, visit: http:/

Re: Review Request: Proof of Concepts implementation for the Amarok Current Track Model

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104598/#review17539 --- The reason for submitting a "Proof of Concept" review request i

Re: Review Request: KWallet for Magnatune credentials

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104480/#review17537 --- Several small issues, but in principle I support this patch. C

Re: Review Request: GPodder Improvements Patch Rev2

> On Aug. 16, 2012, 12:30 p.m., Ralf Engels wrote: > > Since the last comment is quite old, is this patch still ok? > > If yes, I would commit it. Rebased it with master, built it and there was no conflict at all. This patch still fully functional. - Lucas ---

Jenkins build is still unstable: amarok_master #230

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Proof of concept for the 2012 GSoC project idea 'Semantic Collection for Amarok'.

> On Aug. 16, 2012, 12:28 p.m., Ralf Engels wrote: > > I wouldn't ship it. > > Ratings will not longer be written back to the files. Search would not work > > (since the search is done in the sql database and the rating is not longer > > written there) and so on. > > How about a real Nepumuk ba

Re: Review Request: GPodder Improvements Patch Rev2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104335/#review17525 --- Since the last comment is quite old, is this patch still ok? If

Re: Review Request: Proof of concept for the 2012 GSoC project idea 'Semantic Collection for Amarok'.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104369/#review17524 --- I wouldn't ship it. Ratings will not longer be written back to

Jenkins build is still unstable: amarok_master #229

See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Restore heuristics to guess whether album is a compilation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104294/#review17521 --- Just going through all the review requests again. With your pa

Re: Review Request: Restore heuristics to guess whether album is a compilation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104294/#review17522 --- Just going through all the review requests again. With your pa

[amarok] src: Fix typo in plugin query string. Missing space.

Git commit 66d5746e5086ac6667ebc8ad255cf6d6df9f6aab by Bart Cerneels. Committed on 16/08/2012 at 08:57. Pushed by shanachie into branch 'master'. Fix typo in plugin query string. Missing space. Not sure how/why this worked before. Can anyone familiar with KDE plugin explain. Are we even doing it

Re: Review Request: Playing albums (adding delay)

> On Feb. 28, 2012, 9:12 a.m., Myriam Schweingruber wrote: > > Any news on this? Please update the patch or remove it. Could you make this an option / setting? There is place in the settings dialog -> playback -> general. Why exactly 8 seconds? Configurable? I can't currently see a wish for tha

Re: Review Request: mysql embedded default options

> On May 25, 2011, 7:30 p.m., Ralf Engels wrote: > > A summary of this discussion. Please check the correct answer. > > A: this patch is still fine and should be shipped > > B: this patch is working around a known bug and should be shipped > > C: this patch is working around a known bug, which is

Re: Review Request: Fetch cover for DAAP Albums #240060

> On May 18, 2011, 9:37 p.m., Ralf Engels wrote: > > Just wanted to apply the patch (finally, sorry) but it doesn't apply > > cleanly any more. > > > > Also I noticed that there is not much magic in it, just implementing the > > virtual members, and I am wondering if that couldn't be done in t

Re: Review Request: Preview of live scanning feature

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104049/#review17517 --- Can you explain a little more what "live scanning" means? Curr

Re: Review Request: Extend the scope of the playground

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review17516 --- The autor says he doesn't intend to see this merged, to I presu

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100998/#review17515 --- Looks good to me to. I'll test it later, even though not even I

Re: Review Request: Extend the scope of the playground

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103999/#review17514 --- Personally I don't see the reason for a playground. If somebody

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100998/#review17512 --- I can't see any problems with it but I would like somebody who

Re: Review Request: Support for equalizer scripts and plugins. WIP.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102798/#review17511 --- Is this still WIP? src/ActionClasses.cpp

Re: Review Request: Partial Rewrite of ID3v2TagHelper.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102055/#review17510 --- Since we just released 2.6 I go though all the review requests.