----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100998/#review17515 -----------------------------------------------------------
Looks good to me to. I'll test it later, even though not even I am using podcasting in Amarok except for development testing :/ - Bart Cerneels On Feb. 8, 2012, 11:15 p.m., Lucas Gomes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100998/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2012, 11:15 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Now downloaded episodes are kept in HD, if "keep episode" checkbox is checked. > These "kept" episodes are shown in the list regardless of the purgecount. > > BUG Description: > > Currently downloaded files are not kept when the episode is no longer shown in > the Podcast section. This behavior can not be configured but is tied to the > purge settings of each channel. > > It's possible to add a "keep downloaded file" checkbox to episodes to prevent > the deletion from happening. We should perhaps also show these "kept" episodes > in the list regardless of the purgecount. So even if a channel has purgecount > 5 > and 3 episodes marked to keep it will show 5 + maximum 3 older kept episodes. > > Reproducible: Always > > > This addresses bug 261062. > https://bugs.kde.org/show_bug.cgi?id=261062 > > > Diffs > ----- > > src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 > src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 > src/core-impl/podcasts/sql/SqlPodcastProvider.h c3d5e56 > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f > src/core/podcasts/PodcastMeta.h 679f7ac > src/playlistmanager/SyncedPodcast.h c186df2 > > Diff: http://git.reviewboard.kde.org/r/100998/diff/ > > > Testing > ------- > > > Thanks, > > Lucas Gomes > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
