[GitHub] [maven-parent] gnodet closed pull request #136: Upgrade palantir to 2.38.0 to fix JDK 21 support
gnodet closed pull request #136: Upgrade palantir to 2.38.0 to fix JDK 21 support URL: https://github.com/apache/maven-parent/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #1262: [MNG-7895] Support ${project.basedir} in file profile activation
slawekjaranowski commented on PR #1262: URL: https://github.com/apache/maven/pull/1262#issuecomment-1734996131 > > > Hm, now by reading this PR and seeing several places where comment explains why NOT `project.basedir`... it makes me worried, but is LGTM > > > > > > But in other place we deprecated short properties like `basedir` so it can consusing users also. We should be consistent. > > Then should we deprecate the `basedir` ? i.e. add a warning when non prefixed properties are used ? I can add here a warning about using deprecated `basedir` in profile activation We can also check other places where `basedir` is used .. but should be done in separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7895) Support ${project.basedir} in file profile activation
[
https://issues.apache.org/jira/browse/MNG-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769047#comment-17769047
]
ASF GitHub Bot commented on MNG-7895:
-
slawekjaranowski commented on PR #1262:
URL: https://github.com/apache/maven/pull/1262#issuecomment-1734996131
> > > Hm, now by reading this PR and seeing several places where comment
explains why NOT `project.basedir`... it makes me worried, but is LGTM
> >
> >
> > But in other place we deprecated short properties like `basedir` so it
can consusing users also. We should be consistent.
>
> Then should we deprecate the `basedir` ? i.e. add a warning when non
prefixed properties are used ?
I can add here a warning about using deprecated `basedir` in profile
activation
We can also check other places where `basedir` is used .. but should be done
in separate PR
> Support ${project.basedir} in file profile activation
> --
>
> Key: MNG-7895
> URL: https://issues.apache.org/jira/browse/MNG-7895
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0-alpha-8, 3.9.5
>
>
> Profile activation by file exists or missing should allow to use
> ${project.basedir}
> Currently only {{${basedir}}} can be used ... but short properties are
> deprecated
> It can confusing users.
> Documentation to fix:
> https://maven.apache.org/pom.html#activation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1263: Use the same branch name for ITs on Jenkins
slawekjaranowski commented on code in PR #1263:
URL: https://github.com/apache/maven/pull/1263#discussion_r1336766409
##
Jenkinsfile:
##
@@ -84,10 +84,21 @@ for (String os in runITsOses) {
// will not trample each other plus workaround for
JENKINS-52657
dir(isUnix() ? 'test' :
"c:\\mvn-it-${EXECUTOR_NUMBER}.tmp") {
def WORK_DIR=pwd()
-checkout([$class: 'GitSCM',
-branches: [[name: "*/master"]],
-extensions: [[$class: 'CloneOption', depth: 1,
noTags: true, shallow: true]],
-userRemoteConfigs: [[url:
'https://github.com/apache/maven-integration-testing.git']]])
+def ITS_BRANCH = env.CHANGE_BRANCH != null ?
env.CHANGE_BRANCH : env.BRANCH_NAME;
+try {
+ echo "Checkout ITs from branch: ${ITS_BRANCH}"
+ checkout([$class: 'GitSCM',
+ branches: [[name: ITS_BRANCH]],
+ extensions: [[$class: 'CloneOption', depth:
1, noTags: true, shallow: true]],
+ userRemoteConfigs: [[url:
'https://github.com/apache/maven-integration-testing.git']]])
Review Comment:
We also have a
https://github.com/apache/maven-integration-testing/tree/maven-3.8.x branch in
ITs - so this branch should be used for testing maven-3.8.x and so on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #291: [MENFORCER-492] Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0
slawekjaranowski merged PR #291: URL: https://github.com/apache/maven-enforcer/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-492) Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0
[ https://issues.apache.org/jira/browse/MENFORCER-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769050#comment-17769050 ] ASF GitHub Bot commented on MENFORCER-492: -- slawekjaranowski merged PR #291: URL: https://github.com/apache/maven-enforcer/pull/291 > Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0 > -- > > Key: MENFORCER-492 > URL: https://issues.apache.org/jira/browse/MENFORCER-492 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MENFORCER-492) Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0
[ https://issues.apache.org/jira/browse/MENFORCER-492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-492. - Resolution: Fixed > Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0 > -- > > Key: MENFORCER-492 > URL: https://issues.apache.org/jira/browse/MENFORCER-492 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] timtebeek commented on pull request #882: Removed superfluous public for tests
timtebeek commented on PR #882: URL: https://github.com/apache/maven-mvnd/pull/882#issuecomment-1735047823 Chiming in to say that if this is something you'd want removed across the board we have a ready made recipe for that at https://docs.openrewrite.org/recipes/java/testing/cleanup/testsshouldnotbepublic It gets things [_mostly right_](https://github.com/search?q=org%3Aopenrewrite+TestsShouldNotBePublic&type=issues), but should be able to run that against 91 repositories quite easily through https://app.moderne.io/recipes/org.openrewrite.java.testing.cleanup.TestsShouldNotBePublic Let me know if you'd want me to add that to the list! :) And would it need a Jira issue if I do? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] slawekjaranowski merged pull request #449: Improvements to release procedure
slawekjaranowski merged PR #449: URL: https://github.com/apache/maven-site/pull/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga merged pull request #886: [MNG-6847] Use diamond operator
ppalaga merged PR #886: URL: https://github.com/apache/maven-mvnd/pull/886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] ppalaga commented on pull request #886: [MNG-6847] Use diamond operator
ppalaga commented on PR #886: URL: https://github.com/apache/maven-mvnd/pull/886#issuecomment-1735316270 Thanks @timtebeek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769112#comment-17769112 ] ASF GitHub Bot commented on MNG-6847: - ppalaga merged PR #886: URL: https://github.com/apache/maven-mvnd/pull/886 > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769113#comment-17769113 ] ASF GitHub Bot commented on MNG-6847: - ppalaga commented on PR #886: URL: https://github.com/apache/maven-mvnd/pull/886#issuecomment-1735316270 Thanks @timtebeek > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] timtebeek commented on pull request #886: [MNG-6847] Use diamond operator
timtebeek commented on PR #886: URL: https://github.com/apache/maven-mvnd/pull/886#issuecomment-173539 Thanks for the merge and good seeing you here; it's been a while since BaselOne last year. Hope you're well! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769115#comment-17769115 ] ASF GitHub Bot commented on MNG-6847: - timtebeek commented on PR #886: URL: https://github.com/apache/maven-mvnd/pull/886#issuecomment-173539 Thanks for the merge and good seeing you here; it's been a while since BaselOne last year. Hope you're well! :) > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] elharo commented on a diff in pull request #881: Code improvements.
elharo commented on code in PR #881:
URL: https://github.com/apache/maven-mvnd/pull/881#discussion_r1337093736
##
integration-tests/src/test/java/org/mvndaemon/mvnd/it/ResidentExtensionsTest.java:
##
@@ -69,8 +69,8 @@ void verify() throws IOException, InterruptedException {
}
private void assertDaemonRegistrySize(int size) {
-Assertions.assertThat(registry.getAll().size())
-.as("Daemon registry size should be " + size)
-.isEqualTo(size);
+Assertions.assertThat(registry.getAll())
+.as("Daemon registry size should be %d actually
containing:(%s)", size, registry.getAll())
Review Comment:
not sure what "actually containing" means here. It's a tad awkward phrasing.
Is this a UI message somewhere or just a test failure message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7416) Simplify conditional expression.
[
https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769139#comment-17769139
]
ASF GitHub Bot commented on MNG-7416:
-
elharo commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337100795
##
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##
@@ -510,7 +510,7 @@ private Map
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
-rawParams = new TreeMap();
+rawParams = new TreeMap<>();
Review Comment:
Looking at this one, I realize the diamond operator with no params is more
useful for the case where it's declared on the same line.
TreeMap rawParams = new TreeMap();
does seem redundant
rawParams = new TreeMap();
is not. Haven't noticed that before.
> Simplify conditional expression.
>
>
> Key: MNG-7416
> URL: https://issues.apache.org/jira/browse/MNG-7416
> Project: Maven
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Minor
>
> Simplify conditional expression and avoid extra computations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia-linkcheck] timtebeek commented on a diff in pull request #10: [MNG-6847] Use diamond operator
timtebeek commented on code in PR #10:
URL:
https://github.com/apache/maven-doxia-linkcheck/pull/10#discussion_r1337108391
##
src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationItem.java:
##
@@ -91,12 +91,7 @@ public boolean equals( Object obj )
return false;
}
-if ( !lvi.source.equals( this.source ) )
-{
-return false;
-}
-
-return true;
+return lvi.source.equals(this.source);
Review Comment:
```suggestion
return lvi.source.equals( this.source );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] elharo merged pull request #333: [MNG-7416] Simplify Boolean expressions and returns
elharo merged PR #333: URL: https://github.com/apache/maven-resolver/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[
https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769144#comment-17769144
]
ASF GitHub Bot commented on MNG-6847:
-
timtebeek commented on code in PR #10:
URL:
https://github.com/apache/maven-doxia-linkcheck/pull/10#discussion_r1337108391
##
src/main/java/org/apache/maven/doxia/linkcheck/validation/LinkValidationItem.java:
##
@@ -91,12 +91,7 @@ public boolean equals( Object obj )
return false;
}
-if ( !lvi.source.equals( this.source ) )
-{
-return false;
-}
-
-return true;
+return lvi.source.equals(this.source);
Review Comment:
```suggestion
return lvi.source.equals( this.source );
```
> Explicit type can be replaced by the diamond operator
> -
>
> Key: MNG-6847
> URL: https://issues.apache.org/jira/browse/MNG-6847
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.6.3
>Reporter: Krosheninnikov Artem
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 4.0.0-alpha-2, 4.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As the title says. It's a small change to reduce unneeded verbosity in the
> code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7416) Simplify conditional expression.
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769145#comment-17769145 ] ASF GitHub Bot commented on MNG-7416: - elharo merged PR #333: URL: https://github.com/apache/maven-resolver/pull/333 > Simplify conditional expression. > > > Key: MNG-7416 > URL: https://issues.apache.org/jira/browse/MNG-7416 > Project: Maven > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > > Simplify conditional expression and avoid extra computations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] vivkong commented on a diff in pull request #1239: [MNG-7864] Fix the S390x to use IT branches
vivkong commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1337113488
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
+ }
+ stages {
+stage("Build Maven Core") {
+ steps {
+withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }",
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {
Review Comment:
Thanks @olamy. Does this mean I can close this PR for
`Jenkinsfile.s390x.its` as PR checks won't run on s390x?
I will create another PR to bring back `Jenkinsfile.s390x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7864) Fix the S390x to use IT branches
[
https://issues.apache.org/jira/browse/MNG-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769148#comment-17769148
]
ASF GitHub Bot commented on MNG-7864:
-
vivkong commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1337113488
##
Jenkinsfile.s390x.its:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+ agent { node { 's390x' } }
+ options {
+durabilityHint('PERFORMANCE_OPTIMIZED')
+buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+timeout(time: 180, unit: 'MINUTES')
+ }
+ parameters {
+string( defaultValue: 'master', description: 'Core Its branch (default
master)',
+name: 'ITS_BRANCH' )
+ }
+ stages {
+stage("Build Maven Core") {
+ steps {
+withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }",
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {
Review Comment:
Thanks @olamy. Does this mean I can close this PR for
`Jenkinsfile.s390x.its` as PR checks won't run on s390x?
I will create another PR to bring back `Jenkinsfile.s390x`.
> Fix the S390x to use IT branches
>
>
> Key: MNG-7864
> URL: https://issues.apache.org/jira/browse/MNG-7864
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Priority: Major
>
> When testing a PR, the maven-integration-testing branch with the same name
> should be used instead of master if it exists.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] elharo commented on pull request #1264: [MNG-6847] Use diamond operator
elharo commented on PR #1264: URL: https://github.com/apache/maven/pull/1264#issuecomment-1735427163 Tests might be broken at head. I don't think the failures are caused by this PR but we'll need to resolve that before merging this: Error: Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.327 s <<< FAILURE! - in org.apache.maven.it.MavenITmng7038RootdirTest Error: org.apache.maven.it.MavenITmng7038RootdirTest.testRootdirWithTopdirAndRoot Time elapsed: 0.097 s <<< ERROR! org.apache.maven.shared.verifier.VerificationException: Exit code was non-zero: 1; command line and log = /home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn -e --batch-mode -Dmaven.repo.local=/home/runner/.m2/repository --global-settings /home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/test-classes/settings.xml validate [INFO] Error stacktraces are turned on. [INFO] Making this build non-interactive, because the environment variable CI equals "true". Disable this detection by removing that variable or adding --force-interactive. [INFO] Scanning for projects... Error: Some problems were encountered while processing the POMs Error: The build could not read 1 project -> [Help 1] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769149#comment-17769149 ] ASF GitHub Bot commented on MNG-6847: - elharo commented on PR #1264: URL: https://github.com/apache/maven/pull/1264#issuecomment-1735427163 Tests might be broken at head. I don't think the failures are caused by this PR but we'll need to resolve that before merging this: Error: Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.327 s <<< FAILURE! - in org.apache.maven.it.MavenITmng7038RootdirTest Error: org.apache.maven.it.MavenITmng7038RootdirTest.testRootdirWithTopdirAndRoot Time elapsed: 0.097 s <<< ERROR! org.apache.maven.shared.verifier.VerificationException: Exit code was non-zero: 1; command line and log = /home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn -e --batch-mode -Dmaven.repo.local=/home/runner/.m2/repository --global-settings /home/runner/work/maven/maven/maven-integration-testing/core-it-suite/target/test-classes/settings.xml validate [INFO] Error stacktraces are turned on. [INFO] Making this build non-interactive, because the environment variable CI equals "true". Disable this detection by removing that variable or adding --force-interactive. [INFO] Scanning for projects... Error: Some problems were encountered while processing the POMs Error: The build could not read 1 project -> [Help 1] > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-project-info-reports-plugin] elharo merged pull request #63: [MNG-7416] Simplify Boolean expressions and returns
elharo merged PR #63: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7416) Simplify conditional expression.
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769151#comment-17769151 ] ASF GitHub Bot commented on MNG-7416: - elharo merged PR #63: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/63 > Simplify conditional expression. > > > Key: MNG-7416 > URL: https://issues.apache.org/jira/browse/MNG-7416 > Project: Maven > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > > Simplify conditional expression and avoid extra computations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-site] slawekjaranowski merged pull request #448: Refresh Making GPG Keys page
slawekjaranowski merged PR #448: URL: https://github.com/apache/maven-site/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-734) javadoc drops copying doc-files when module-info.java file present
[ https://issues.apache.org/jira/browse/MJAVADOC-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769170#comment-17769170 ] Elliotte Rusty Harold commented on MJAVADOC-734: Do you have a reproducible test case? On what environment did you observe this? > javadoc drops copying doc-files when module-info.java file present > -- > > Key: MJAVADOC-734 > URL: https://issues.apache.org/jira/browse/MJAVADOC-734 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.4.1 >Reporter: Pieter van den Hombergh >Priority: Major > Labels: jpms > > the javadoc no longer copies the files found under doc-files to the > appropriate spot in the apidoc tree. > > The files should be present at the relative location near the html files > generated from the java files. e.g. in the module com.example the file > src/main/java/hello/doc-files/Hi.png should land under > target/apidocs/com.example/hello/doc-files/Hi.png > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJAVADOC-734) javadoc drops copying doc-files when module-info.java file present
[ https://issues.apache.org/jira/browse/MJAVADOC-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MJAVADOC-734: --- Issue Type: Bug (was: Improvement) > javadoc drops copying doc-files when module-info.java file present > -- > > Key: MJAVADOC-734 > URL: https://issues.apache.org/jira/browse/MJAVADOC-734 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.4.1 >Reporter: Pieter van den Hombergh >Priority: Major > Labels: jpms > > the javadoc no longer copies the files found under doc-files to the > appropriate spot in the apidoc tree. > > The files should be present at the relative location near the html files > generated from the java files. e.g. in the module com.example the file > src/main/java/hello/doc-files/Hi.png should land under > target/apidocs/com.example/hello/doc-files/Hi.png > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] slawekjaranowski commented on pull request #1258: Fix unneeded/wrong substring calls in expression evaluation and put back weak references in cache
slawekjaranowski commented on PR #1258: URL: https://github.com/apache/maven/pull/1258#issuecomment-1735514757 Is it worth doing in 3.9.x also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #242: Use Maven 3.9.0 on GitHub
slawekjaranowski commented on PR #242: URL: https://github.com/apache/maven-integration-testing/pull/242#issuecomment-1735520283 > I wouldn't do this before at least 3.9.1, .0 contains too many open issues for now. I hope that 3.9.4 is better than 3.9.1 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769182#comment-17769182
]
Vlad Galuska commented on MCOMPILER-546:
[~michael-o] Any update here?
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #242: Use Maven 3.9.4 on GitHub
slawekjaranowski commented on PR #242: URL: https://github.com/apache/maven-integration-testing/pull/242#issuecomment-1735525166 current test are not compatible with 4.0.0-alpha-7, as is alpha version we can change something so 3.9.4 should be ok now We can think about 4.0.0-alpha-8 after release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7898) Missing .mvn directory should not be reported in quiet mode
Slawomir Jaranowski created MNG-7898:
Summary: Missing .mvn directory should not be reported in quiet
mode
Key: MNG-7898
URL: https://issues.apache.org/jira/browse/MNG-7898
Project: Maven
Issue Type: Bug
Affects Versions: 4.0.0-alpha-7
Reporter: Slawomir Jaranowski
Fix For: 4.0.0-alpha-8
To reproduce
{code}
mvn help:evaluate -q -DforceStdout -Dexpression=project.version
{code}
output is:
{code}
Unable to find the root directory. Create a .mvn directory in the root
directory or add the root="true" attribute on the root project's model to
identify it.
211-SNAPSHOT
{code}
should be only:
{code}
211-SNAPSHOT
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] timtebeek commented on a diff in pull request #227: [MNG-7416] Simplify Boolean expressions and returns
timtebeek commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337254040
##
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##
@@ -510,7 +510,7 @@ private Map
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
-rawParams = new TreeMap();
+rawParams = new TreeMap<>();
Review Comment:
Hmm, yes I guess that's true; would you want me to revert it here? Or keep
it since the variable is still mostly in view?
Alternatively we can pull down the variable declaration to just above the if
statement, as that would also clear up any ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7416) Simplify conditional expression.
[
https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769192#comment-17769192
]
ASF GitHub Bot commented on MNG-7416:
-
timtebeek commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337254040
##
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##
@@ -510,7 +510,7 @@ private Map
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
-rawParams = new TreeMap();
+rawParams = new TreeMap<>();
Review Comment:
Hmm, yes I guess that's true; would you want me to revert it here? Or keep
it since the variable is still mostly in view?
Alternatively we can pull down the variable declaration to just above the if
statement, as that would also clear up any ambiguity.
> Simplify conditional expression.
>
>
> Key: MNG-7416
> URL: https://issues.apache.org/jira/browse/MNG-7416
> Project: Maven
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Minor
>
> Simplify conditional expression and avoid extra computations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #1258: Fix unneeded/wrong substring calls in expression evaluation and put back weak references in cache
gnodet commented on PR #1258: URL: https://github.com/apache/maven/pull/1258#issuecomment-1735598461 > Is it worth doing in 3.9.x also? I don't think so. The substrings have been there since ages and are harmless (because the first part of the string is completely ignored), and the weak ref in cache could be backported, but it would be in `maven-shared-utils`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769194#comment-17769194
]
Michael Osipov commented on MCOMPILER-546:
--
Should there be one, by whom?
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] elharo commented on a diff in pull request #227: [MNG-7416] Simplify Boolean expressions and returns
elharo commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337283480
##
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##
@@ -510,7 +510,7 @@ private Map
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
-rawParams = new TreeMap();
+rawParams = new TreeMap<>();
Review Comment:
Doesn't matter that much. The variable declaration wasn't in view by default
in Github code review. I do think there's a real tendency for devs to argue
that, "In my tool it's obvious" when advocating for more compact, less
redundant syntax without really considering how it looks in other environments.
I often hear folks claim that IDEs make certain constructs unnecessary. We can
be really myopic about that, even to the point of saving a few milliseconds of
typing right now at the cost of hours of debugging to our future selves. The
real cost here is in lambdas and method chaining, which are extremely opaque
and hard to read, all to save the trivial effort of typing a few more local
variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7416) Simplify conditional expression.
[
https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769204#comment-17769204
]
ASF GitHub Bot commented on MNG-7416:
-
elharo commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337283480
##
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##
@@ -510,7 +510,7 @@ private Map
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
-rawParams = new TreeMap();
+rawParams = new TreeMap<>();
Review Comment:
Doesn't matter that much. The variable declaration wasn't in view by default
in Github code review. I do think there's a real tendency for devs to argue
that, "In my tool it's obvious" when advocating for more compact, less
redundant syntax without really considering how it looks in other environments.
I often hear folks claim that IDEs make certain constructs unnecessary. We can
be really myopic about that, even to the point of saving a few milliseconds of
typing right now at the cost of hours of debugging to our future selves. The
real cost here is in lambdas and method chaining, which are extremely opaque
and hard to read, all to save the trivial effort of typing a few more local
variables.
> Simplify conditional expression.
>
>
> Key: MNG-7416
> URL: https://issues.apache.org/jira/browse/MNG-7416
> Project: Maven
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Minor
>
> Simplify conditional expression and avoid extra computations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7416) Simplify conditional expression.
[ https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769203#comment-17769203 ] ASF GitHub Bot commented on MNG-7416: - elharo merged PR #227: URL: https://github.com/apache/maven-plugin-tools/pull/227 > Simplify conditional expression. > > > Key: MNG-7416 > URL: https://issues.apache.org/jira/browse/MNG-7416 > Project: Maven > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > > Simplify conditional expression and avoid extra computations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7899) Various memory usage improvements
sebastien created MNG-7899:
--
Summary: Various memory usage improvements
Key: MNG-7899
URL: https://issues.apache.org/jira/browse/MNG-7899
Project: Maven
Issue Type: Improvement
Components: Design, Patterns & Best Practices, Embedding,
General, Logging
Affects Versions: 4.0.0-alpha-2
Reporter: sebastien
Some optimisations can be applied to the code to reduce the use of temporary
objects.
Typical improvements identified are:
* reduce scope of temporary objects creation to avoid creating when not
needed. Example :
{code:java}
public String toString() {
StringBuilder sb = new StringBuilder(512);
if (isEmpty()) {
return "empty";
}
for (MetadataGraphVertex v : vertices) {
.{code}
can be replaced by
{code:java}
public String toString() {
if (isEmpty()) {
return "empty";
}
StringBuilder sb = new StringBuilder(512);
for (MetadataGraphVertex v : vertices) {
.{code}
* Reuse StringBuilder objects in loops by setting its length to zero
* Use the StringBuilder.append() with index to avoid String.substring().
Example:
{code:java}
int idx = resourceName.lastIndexOf('/');
buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1)); {code}
can be replaced by
{code:java}
int idx = resourceName.lastIndexOf('/');
if (idx < 0) {
buffer.append(resourceName);
} else {
buffer.append(resourceName, idx + 1, resourceName.length());
} {code}
* Replace dynamic string creation static constants when possible
* Avoid creating temporary strings with + operator when the final destination
can be used instead, like PrintStream.print() method
* Avoir using StringBuilder.append() method and util method MessageUtils.a()
when the final destination can be used instead, like PrintStream.print() method
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769235#comment-17769235
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon opened a new pull request, #1265:
URL: https://github.com/apache/maven/pull/1265
Remove unneeded StringBuilder to reduce temporary objects creation
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns & Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] vivkong opened a new pull request, #1266: [MNG-7848] Add Jenkinsfile.s390x for Jenkins CI on s390x
vivkong opened a new pull request, #1266: URL: https://github.com/apache/maven/pull/1266 As discussed on https://github.com/apache/maven/pull/1239, we would like to add `Jenkinsfile.s390x` back and re-enable the s390x pipeline on Jenkins CI (https://ci-maven.apache.org/job/Maven/job/Maven%20Core%20s390x/). The s390x build will run on `master` branch only with no PR checks so we won't encounter issues with custom IT branch. @olamy @elharo @gnodet I appreciate your help in reviewing this and getting Jenkins CI setup to use the Jenkinsfile once it's merged. Thank you! --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7848) Add s390x pipeline to Jenkins CI
[ https://issues.apache.org/jira/browse/MNG-7848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769237#comment-17769237 ] ASF GitHub Bot commented on MNG-7848: - vivkong opened a new pull request, #1266: URL: https://github.com/apache/maven/pull/1266 As discussed on https://github.com/apache/maven/pull/1239, we would like to add `Jenkinsfile.s390x` back and re-enable the s390x pipeline on Jenkins CI (https://ci-maven.apache.org/job/Maven/job/Maven%20Core%20s390x/). The s390x build will run on `master` branch only with no PR checks so we won't encounter issues with custom IT branch. @olamy @elharo @gnodet I appreciate your help in reviewing this and getting Jenkins CI setup to use the Jenkinsfile once it's merged. Thank you! --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Add s390x pipeline to Jenkins CI > > > Key: MNG-7848 > URL: https://issues.apache.org/jira/browse/MNG-7848 > Project: Maven > Issue Type: New Feature > Components: Bootstrap & Build, Integration Tests >Reporter: Kun Lu >Priority: Major > Labels: pull-request-available > > Apache INFRA team has installed necessary JDK flavours on all s390x nodes > (Please check issue > [https://issues.apache.org/jira/projects/INFRA/issues/INFRA-24781]). We’d > like to add the s390x pipeline to Jenkins CI by raising a PR to add ` > Jenkinsfile.s390x` to the Maven code base. > Can anyone from Maven team help us review the PR and create the s390x > pipeline on Jenkins? Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769238#comment-17769238
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon opened a new pull request, #1267:
URL: https://github.com/apache/maven/pull/1267
Avoid creating a StringBuilder instance when not needed to reduce
temporary objects creation
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns & Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] sebastien-doyon opened a new pull request, #1268: [MNG-7899] Various memory usage improvements
sebastien-doyon opened a new pull request, #1268: URL: https://github.com/apache/maven/pull/1268 Reuse a StringBuilder in a for loop by setting its lenght to zero. Help reduce temporary objects creation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769243#comment-17769243
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon opened a new pull request, #1268:
URL: https://github.com/apache/maven/pull/1268
Reuse a StringBuilder in a for loop by setting its lenght to zero.
Help reduce temporary objects creation.
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns & Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] sebastien-doyon opened a new pull request, #1269: [MNG-7899] Various memory usage improvements 4
sebastien-doyon opened a new pull request, #1269: URL: https://github.com/apache/maven/pull/1269 Merging the getStatus() method to optimize : - Use the main StringBuilder to append string instead of using a separate one - Use the StringBuilder.append() with index to avoid String.substring(), less temporary strings - Reuse the FileSizeFormat object in the while loop avoiding multiple temporary instances creation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769248#comment-17769248
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon opened a new pull request, #1269:
URL: https://github.com/apache/maven/pull/1269
Merging the getStatus() method to optimize :
- Use the main StringBuilder to append string instead of using a
separate one
- Use the StringBuilder.append() with index to avoid String.substring(),
less temporary strings
- Reuse the FileSizeFormat object in the while loop avoiding multiple
temporary instances creation
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns & Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #293: Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.2
dependabot[bot] opened a new pull request, #293: URL: https://github.com/apache/maven-enforcer/pull/293 Bumps [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) from 3.0.0 to 4.0.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-xml/releases";>org.codehaus.plexus:plexus-xml's releases. Plexus XML 4.0.2 What's Changed Cleanup after parent pom upgrade by https://github.com/slachiewicz";>@slachiewicz in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22 Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17) by https://github.com/gnodet";>@gnodet in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/23";>codehaus-plexus/plexus-xml#23 New Contributors https://github.com/slachiewicz";>@slachiewicz made their first contribution in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22 Full Changelog: https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2";>https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2 4.0.0 Use spotless (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/8";>#8) https://github.com/gnodet";>@gnodet Fix site generation (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/15";>#15) https://github.com/gnodet";>@gnodet Switch build ci workflow to master branch (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/14";>#14) https://github.com/gnodet";>@gnodet Fix SCM urls (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/13";>#13) https://github.com/gnodet";>@gnodet MXParser tokenization fails when PI is before first tag (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/7";>#7) (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/12";>#12) https://github.com/gnodet";>@gnodet Deprecate Xpp3DomUtils (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/6";>#6) (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/9";>#9) https://github.com/gnodet";>@gnodet Use a ArrayDeque (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/5";>#5) https://github.com/gnodet";>@gnodet Upgrade plugins and clean build warnings (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/4";>#4) https://github.com/gnodet";>@gnodet Switch to junit 5 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/2";>#2) https://github.com/gnodet";>@gnodet Fix parsing an UTF-8 file without BOM and ISO-8859-1 encoding (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/1";>#1) https://github.com/gnodet";>@gnodet Commits https://github.com/codehaus-plexus/plexus-xml/commit/944197c74386b199857a003160d840fb5593ac29";>944197c [maven-release-plugin] prepare release plexus-xml-4.0.2 https://github.com/codehaus-plexus/plexus-xml/commit/c3d99b433a272d8eb1cc7c799410799e8c16ace3";>c3d99b4 Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17) (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/23";>#23) https://github.com/codehaus-plexus/plexus-xml/commit/a83cefa086c9a5bb8b6674a409016f378b19891e";>a83cefa Cleanup after parent pom upgrade https://github.com/codehaus-plexus/plexus-xml/commit/25a00cd9d04ff3ab7acdcebdefdbb19ec5c4560d";>25a00cd [maven-release-plugin] prepare for next development iteration https://github.com/codehaus-plexus/plexus-xml/commit/bcb6981e2a9c635d024e0422de2a997a00ffdd8e";>bcb6981 [maven-release-plugin] prepare release plexus-xml-4.0.1 https://github.com/codehaus-plexus/plexus-xml/commit/d227a49f0f9b552a61b2aaac3bbe2c722ce06fea";>d227a49 Fix detection of invalid spaces in prolog (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/20";>#20) https://github.com/codehaus-plexus/plexus-xml/commit/27d6127d3196d09263d8fe0f445b9d83f6ccfb75";>27d6127 pom.mxl and site.xml cleanup https://github.com/codehaus-plexus/plexus-xml/commit/62f50bc46c7b51d51a25541dfe0a502063dc1fc3";>62f50bc [maven-release-plugin] prepare for next development iteration https://github.com/codehaus-plexus/plexus-xml/commit/cac55e8c167b168c6c36dd4a057dedfadec03c0e";>cac55e8 [maven-release-plugin] prepare release plexus-xml-4.0.0 https://github.com/codehaus-plexus/plexus-xml/commit/17787e5ff7dea8acf347fd3f92bd855e110d6dfe";>17787e5 Reformat using spotless Additional commits viewable in https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-3.0.0...plexus-xml-4.0.2";>compare view [ method use static constants instead of rebuilding the strings on each call - replace + operator usage with more PrintStream.print() calls to reduce temporary strings creation - reduce usage of MessageBuilder.a() method usage with more PrintStream.print() calls to reduce temporary strings creation - replace the builder() method with a static import -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7899) Various memory usage improvements
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769252#comment-17769252
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon opened a new pull request, #1270:
URL: https://github.com/apache/maven/pull/1270
Multiple optimizations :
- renderLevel() method use static constants instead of rebuilding the
strings on each call
- replace + operator usage with more PrintStream.print() calls to reduce
temporary strings creation
- reduce usage of MessageBuilder.a() method usage with more
PrintStream.print() calls to reduce temporary strings creation
- replace the builder() method with a static import
> Various memory usage improvements
> -
>
> Key: MNG-7899
> URL: https://issues.apache.org/jira/browse/MNG-7899
> Project: Maven
> Issue Type: Improvement
> Components: Design, Patterns & Best Practices, Embedding,
> General, Logging
>Affects Versions: 4.0.0-alpha-2
>Reporter: sebastien
>Priority: Major
>
> Some optimisations can be applied to the code to reduce the use of temporary
> objects.
> Typical improvements identified are:
> * reduce scope of temporary objects creation to avoid creating when not
> needed. Example :
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder(512);
> if (isEmpty()) {
> return "empty";
> }
> for (MetadataGraphVertex v : vertices) {
> .{code}
> can be replaced by
> {code:java}
> public String toString() {
> if (isEmpty()) {
> return "empty";
> }
> StringBuilder sb = new StringBuilder(512);
> for (MetadataGraphVertex v : vertices) {
> .{code}
> * Reuse StringBuilder objects in loops by setting its length to zero
> * Use the StringBuilder.append() with index to avoid String.substring().
> Example:
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> buffer.append(idx < 0 ? resourceName : resourceName.substring(idx + 1));
> {code}
> can be replaced by
>
> {code:java}
> int idx = resourceName.lastIndexOf('/');
> if (idx < 0) {
> buffer.append(resourceName);
> } else {
> buffer.append(resourceName, idx + 1, resourceName.length());
> } {code}
>
>
> * Replace dynamic string creation static constants when possible
> * Avoid creating temporary strings with + operator when the final
> destination can be used instead, like PrintStream.print() method
> * Avoir using StringBuilder.append() method and util method MessageUtils.a()
> when the final destination can be used instead, like PrintStream.print()
> method
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-build-cache-extension] kbuntrock commented on pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly
kbuntrock commented on PR #92: URL: https://github.com/apache/maven-build-cache-extension/pull/92#issuecomment-1735759678 Hello there, A little up on this old-timer PR. If I'm correct I fixed every mandatory request. Any other thought? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-67) Any error in restoring from the cache should resume the non cache build
[
https://issues.apache.org/jira/browse/MBUILDCACHE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769253#comment-17769253
]
ASF GitHub Bot commented on MBUILDCACHE-67:
---
kbuntrock commented on PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#issuecomment-1735759678
Hello there,
A little up on this old-timer PR. If I'm correct I fixed every mandatory
request.
Any other thought?
> Any error in restoring from the cache should resume the non cache build
> ---
>
> Key: MBUILDCACHE-67
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-67
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.1
>Reporter: Kevin Buntrock
>Priority: Major
> Labels: pull-request-available
>
> If any error arise during the restoration of artefacts from the cache, the
> build should continue as it would usually do without the cache. In fact, it's
> even what the extension says "Cannot restore cache, continuing with normal
> build."
> But it's a lie, the build goes straight to the phase where it saves the
> generated artefact in cache. ;)
> {code:java}
> [DEBUG] Hash calculated, item: dependency, hash: 14eab0591a006938
> [INFO] Project inputs calculated in 97 ms. XX checksum [a0d7876d9bceb494]
> calculated in 50 ms.
> [INFO] Attempting to restore project
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from build cache
> [DEBUG] Checking local build info:
> C:\Users\kbuntrock\.m2\build-cache\v1\io.github.kbuntrock.sample\openapi-plugin-sample-backend\a0d7876d9bceb494\local\buildinfo.xml
> [INFO] Local build found by checksum a0d7876d9bceb494
> [INFO] Found cached build, restoring
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from cache by
> checksum a0d7876d9bceb494
> [DEBUG] Cached build details:
> Build{dto=org.apache.maven.buildcache.xml.build.Build@63cf9de0}
> [DEBUG] Cannot restore cache, continuing with normal build.
> java.lang.RuntimeException: Made-up error : restoring artefact is impossible.
> at
> org.apache.maven.buildcache.CacheControllerImpl.restoreProjectArtifacts
> (CacheControllerImpl.java:312)
> at
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject
> (BuildCacheMojosExecutionStrategy.java:171)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:124)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> [INFO] Cannot restore project artifacts, continuing with non cached build
> [INFO] Saved Build to local file:
> C:\Users\kbuntrock\.m2\build-cache\v1\io.github.kbuntrock.sample\openapi-plugin-sample-backend\a0d7876d9bceb494\local\buildinfo.xml
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 0.629 s
> [INFO] Finished at: 2023-08-02T23:21:36+02:00
> [INFO]
>
> [DEBUG] Save cache-report to local
[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769277#comment-17769277
]
Vlad Galuska commented on MCOMPILER-546:
My bad, assumed for some reason you were the assignee
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #299: [MNG-7895] Support ${project.basedir} in file profile activation - fix ITs
slawekjaranowski merged PR #299: URL: https://github.com/apache/maven-integration-testing/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski merged pull request #1262: [MNG-7895] Support ${project.basedir} in file profile activation
slawekjaranowski merged PR #1262: URL: https://github.com/apache/maven/pull/1262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7895) Support ${project.basedir} in file profile activation
[
https://issues.apache.org/jira/browse/MNG-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769300#comment-17769300
]
ASF GitHub Bot commented on MNG-7895:
-
slawekjaranowski merged PR #1262:
URL: https://github.com/apache/maven/pull/1262
> Support ${project.basedir} in file profile activation
> --
>
> Key: MNG-7895
> URL: https://issues.apache.org/jira/browse/MNG-7895
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0-alpha-8, 3.9.5
>
>
> Profile activation by file exists or missing should allow to use
> ${project.basedir}
> Currently only {{${basedir}}} can be used ... but short properties are
> deprecated
> It can confusing users.
> Documentation to fix:
> https://maven.apache.org/pom.html#activation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769303#comment-17769303
]
Tamas Cservenak commented on MCOMPILER-546:
---
Vlad, this seems JDK bug.
Try without maven, just to compile the class manually as you did but add
"debug" flag:
{noformat}
javac --enable-preview --release 21 -g org/example/Main.java {noformat}
And resulting class file will behave same as Maven compiled one.
Reason: {{-g}} is by default appended to javac flags by m-compiler-p.
OR, disable debug:
{noformat}
diff --git a/pom.xml b/pom.xml
index 5c8ee26..b15c4b4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,6 +22,7 @@
21
21
+ false
--enable-preview
@@ -44,4 +45,4 @@
-
\ No newline at end of file
+
{noformat}
Still, this seems JDK bug, please report it.
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769303#comment-17769303
]
Tamas Cservenak edited comment on MCOMPILER-546 at 9/26/23 6:15 PM:
[~vlad.galuska] , this seems JDK bug.
Try without maven, just to compile the class manually as you did but add
"debug" flag:
{noformat}
javac --enable-preview --release 21 -g org/example/Main.java {noformat}
And resulting class file will behave same as Maven compiled one.
Reason: {{-g}} is by default appended to javac flags by m-compiler-p.
OR, disable debug:
{noformat}
diff --git a/pom.xml b/pom.xml
index 5c8ee26..b15c4b4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,6 +22,7 @@
21
21
+ false
--enable-preview
@@ -44,4 +45,4 @@
-
\ No newline at end of file
+
{noformat}
Still, this seems JDK bug, please report it.
was (Author: cstamas):
Vlad, this seems JDK bug.
Try without maven, just to compile the class manually as you did but add
"debug" flag:
{noformat}
javac --enable-preview --release 21 -g org/example/Main.java {noformat}
And resulting class file will behave same as Maven compiled one.
Reason: {{-g}} is by default appended to javac flags by m-compiler-p.
OR, disable debug:
{noformat}
diff --git a/pom.xml b/pom.xml
index 5c8ee26..b15c4b4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,6 +22,7 @@
21
21
+ false
--enable-preview
@@ -44,4 +45,4 @@
-
\ No newline at end of file
+
{noformat}
Still, this seems JDK bug, please report it.
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769304#comment-17769304
]
Tamas Cservenak commented on MCOMPILER-546:
---
Funny, here it is reported, and "they cannot reproduce" (manually) but did it
with Maven https://bugs.openjdk.org/browse/JDK-8307618
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769304#comment-17769304
]
Tamas Cservenak edited comment on MCOMPILER-546 at 9/26/23 6:28 PM:
Funny, here it is reported, and "they cannot reproduce" (manually) but did it
with Maven [https://bugs.openjdk.org/browse/JDK-8307618]
I bet manually they did not combine {{-g}} with {{--enable-preview}}
was (Author: cstamas):
Funny, here it is reported, and "they cannot reproduce" (manually) but did it
with Maven https://bugs.openjdk.org/browse/JDK-8307618
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769304#comment-17769304
]
Tamas Cservenak edited comment on MCOMPILER-546 at 9/26/23 6:29 PM:
Funny, here it is reported, and "they cannot reproduce" (manually) but did it
with Maven [https://bugs.openjdk.org/browse/JDK-8307618]
I bet manually they did not combine \{{-g}} with {{-enable-preview}}
was (Author: cstamas):
Funny, here it is reported, and "they cannot reproduce" (manually) but did it
with Maven [https://bugs.openjdk.org/browse/JDK-8307618]
I bet manually they did not combine {{-g}} with {{--enable-preview}}
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769316#comment-17769316
]
Tamas Cservenak commented on MCOMPILER-546:
---
Reproducer https://gist.github.com/cstamas/db7fd2083d6a87ec17ed3d5a103bebc2
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #301: [MNG-7895] Support ${project.basedir} in file profile activation - fix ITs 3.9.5
slawekjaranowski opened a new pull request, #301: URL: https://github.com/apache/maven-integration-testing/pull/301 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski opened a new pull request, #1271: [MNG-7895] Support ${project.basedir} in file profile activation
slawekjaranowski opened a new pull request, #1271: URL: https://github.com/apache/maven/pull/1271 (cherry picked from commit 5c2e671a06721fe07cf414a9377a63652d512be0) --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [x] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7895) Support ${project.basedir} in file profile activation
[
https://issues.apache.org/jira/browse/MNG-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769320#comment-17769320
]
ASF GitHub Bot commented on MNG-7895:
-
slawekjaranowski opened a new pull request, #1271:
URL: https://github.com/apache/maven/pull/1271
(cherry picked from commit 5c2e671a06721fe07cf414a9377a63652d512be0)
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [x] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Support ${project.basedir} in file profile activation
> --
>
> Key: MNG-7895
> URL: https://issues.apache.org/jira/browse/MNG-7895
> Project: Maven
> Issue Type: Improvement
> Components: Profiles
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 4.0.0-alpha-8, 3.9.5
>
>
> Profile activation by file exists or missing should allow to use
> ${project.basedir}
> Currently only {{${basedir}}} can be used ... but short properties are
> deprecated
> It can confusing users.
> Documentation to fix:
> https://maven.apache.org/pom.html#activation
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7416) Simplify conditional expression.
[
https://issues.apache.org/jira/browse/MNG-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769323#comment-17769323
]
ASF GitHub Bot commented on MNG-7416:
-
timtebeek commented on code in PR #227:
URL:
https://github.com/apache/maven-plugin-tools/pull/227#discussion_r1337690988
##
maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java:
##
@@ -510,7 +510,7 @@ private Map
extractFieldParameterTags(JavaClass javaClass) {
if (superClass != null) {
rawParams = extractFieldParameterTags(superClass);
} else {
-rawParams = new TreeMap();
+rawParams = new TreeMap<>();
Review Comment:
I'll keep an eye out of future PRs for this pattern, although I think we've
gone through the vast majority by now. There's a couple projects left with one
or two cases, which I hope to pick up along with other more meaningful changes.
> Simplify conditional expression.
>
>
> Key: MNG-7416
> URL: https://issues.apache.org/jira/browse/MNG-7416
> Project: Maven
> Issue Type: Improvement
>Reporter: Arturo Bernal
>Priority: Minor
>
> Simplify conditional expression and avoid extra computations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #302: Bump org.codehaus.plexus:plexus-utils from 0.1-mng2892 to 3.0.24 in /core-it-suite/src/test/resources/mng-2892
dependabot[bot] opened a new pull request, #302: URL: https://github.com/apache/maven-integration-testing/pull/302 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 0.1-mng2892 to 3.0.24. Commits See full diff in https://github.com/codehaus-plexus/plexus-utils/commits/plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-integration-testing/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #197: Bump org.codehaus.plexus:plexus-utils from 1.1 to 3.0.24 in /src/it/script-class-loading
dependabot[bot] opened a new pull request, #197: URL: https://github.com/apache/maven-invoker-plugin/pull/197 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 1.1 to 3.0.24. Commits See full diff in https://github.com/codehaus-plexus/plexus-utils/commits/plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-invoker-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #303: Bump org.codehaus.plexus:plexus-utils from 0.1-mng3012 to 3.0.24 in /core-it-suite/src/test/resources/mng-3012
dependabot[bot] opened a new pull request, #303: URL: https://github.com/apache/maven-integration-testing/pull/303 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 0.1-mng3012 to 3.0.24. Commits See full diff in https://github.com/codehaus-plexus/plexus-utils/commits/plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-integration-testing/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #304: Bump org.codehaus.plexus:plexus-utils from 0.1-stub to 3.0.24 in /core-it-suite/src/test/resources/mng-4666
dependabot[bot] opened a new pull request, #304: URL: https://github.com/apache/maven-integration-testing/pull/304 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 0.1-stub to 3.0.24. Commits See full diff in https://github.com/codehaus-plexus/plexus-utils/commits/plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-integration-testing/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #305: Bump org.codehaus.plexus:plexus-utils from 1.1 to 3.0.24 in /core-it-support/core-it-plugins/maven-it-plugin-plexu
dependabot[bot] opened a new pull request, #305: URL: https://github.com/apache/maven-integration-testing/pull/305 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 1.1 to 3.0.24. Commits See full diff in https://github.com/codehaus-plexus/plexus-utils/commits/plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-integration-testing/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] dependabot[bot] opened a new pull request, #154: Bump org.codehaus.plexus:plexus-utils from 1.4.2 to 3.0.24 in /maven-archetype-plugin/src/test/projects/simple-inheritence/e
dependabot[bot] opened a new pull request, #154: URL: https://github.com/apache/maven-archetype/pull/154 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 1.4.2 to 3.0.24. Commits https://github.com/codehaus-plexus/plexus-utils/commit/fd36d8b80ba10955ef065230571ce2be2d4c1bbb";>fd36d8b [maven-release-plugin] prepare release plexus-utils-3.0.24 https://github.com/codehaus-plexus/plexus-utils/commit/33a2853df8185b4519b1b8bfae284f03392618ef";>33a2853 o Updated to guard against directory traversal issues. https://github.com/codehaus-plexus/plexus-utils/commit/f933e5e78dc2637e485447ed821fe14904f110de";>f933e5e o Updated to remove '' from XML comments to guard against XML https://github.com/codehaus-plexus/plexus-utils/commit/fcd94e57a05474cf0db0a34e5a2f3e8c49fb2c29";>fcd94e5 o Updated to stop detecting Windows systems as family DOS. https://github.com/codehaus-plexus/plexus-utils/commit/2644af5a8a51bbaf2cc307386b81d63069954e46";>2644af5 o Updated to guard against 'NullPointerException's. https://github.com/codehaus-plexus/plexus-utils/commit/ba1c194dc0d57b49ffb2220b7571e68caf09f18b";>ba1c194 o Updated class 'PropertyUtils' to stop silently dropping exceptions. https://github.com/codehaus-plexus/plexus-utils/commit/8399a27c2ba90cc090c2b5589ff0579e8960";>8399a2e [maven-release-plugin] prepare for next development iteration https://github.com/codehaus-plexus/plexus-utils/commit/6176f91bb843eecddac857591ed20bda38e01470";>6176f91 [maven-release-plugin] prepare release plexus-utils-3.0.23 https://github.com/codehaus-plexus/plexus-utils/commit/5d94a602392cbf3f9f6175bee42fee1c1b97d128";>5d94a60 Merge pull request https://redirect.github.com/codehaus-plexus/plexus-utils/issues/9";>#9 from ChristianSchulte/master https://github.com/codehaus-plexus/plexus-utils/commit/05df14eb6bc5304f1370baebe6d46368bafa9f9d";>05df14e o Updated to stop suppressing exception's thrown when closing streams. Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-1.4.2...plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-archetype/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] dependabot[bot] commented on pull request #115: Bump plexus-utils from 1.4.2 to 3.0.16 in /maven-archetype-plugin/src/test/projects/simple-inheritence/enforcer-rules
dependabot[bot] commented on PR #115: URL: https://github.com/apache/maven-archetype/pull/115#issuecomment-1736178492 Superseded by #154. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-archetype] dependabot[bot] closed pull request #115: Bump plexus-utils from 1.4.2 to 3.0.16 in /maven-archetype-plugin/src/test/projects/simple-inheritence/enforcer-rules
dependabot[bot] closed pull request #115: Bump plexus-utils from 1.4.2 to 3.0.16 in /maven-archetype-plugin/src/test/projects/simple-inheritence/enforcer-rules URL: https://github.com/apache/maven-archetype/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-toolchains-plugin] dependabot[bot] opened a new pull request, #16: Bump org.codehaus.plexus:plexus-utils from 3.0.16 to 3.0.24 in /src/it/setup-custom-toolchain
dependabot[bot] opened a new pull request, #16: URL: https://github.com/apache/maven-toolchains-plugin/pull/16 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.0.16 to 3.0.24. Commits https://github.com/codehaus-plexus/plexus-utils/commit/fd36d8b80ba10955ef065230571ce2be2d4c1bbb";>fd36d8b [maven-release-plugin] prepare release plexus-utils-3.0.24 https://github.com/codehaus-plexus/plexus-utils/commit/33a2853df8185b4519b1b8bfae284f03392618ef";>33a2853 o Updated to guard against directory traversal issues. https://github.com/codehaus-plexus/plexus-utils/commit/f933e5e78dc2637e485447ed821fe14904f110de";>f933e5e o Updated to remove '' from XML comments to guard against XML https://github.com/codehaus-plexus/plexus-utils/commit/fcd94e57a05474cf0db0a34e5a2f3e8c49fb2c29";>fcd94e5 o Updated to stop detecting Windows systems as family DOS. https://github.com/codehaus-plexus/plexus-utils/commit/2644af5a8a51bbaf2cc307386b81d63069954e46";>2644af5 o Updated to guard against 'NullPointerException's. https://github.com/codehaus-plexus/plexus-utils/commit/ba1c194dc0d57b49ffb2220b7571e68caf09f18b";>ba1c194 o Updated class 'PropertyUtils' to stop silently dropping exceptions. https://github.com/codehaus-plexus/plexus-utils/commit/8399a27c2ba90cc090c2b5589ff0579e8960";>8399a2e [maven-release-plugin] prepare for next development iteration https://github.com/codehaus-plexus/plexus-utils/commit/6176f91bb843eecddac857591ed20bda38e01470";>6176f91 [maven-release-plugin] prepare release plexus-utils-3.0.23 https://github.com/codehaus-plexus/plexus-utils/commit/5d94a602392cbf3f9f6175bee42fee1c1b97d128";>5d94a60 Merge pull request https://redirect.github.com/codehaus-plexus/plexus-utils/issues/9";>#9 from ChristianSchulte/master https://github.com/codehaus-plexus/plexus-utils/commit/05df14eb6bc5304f1370baebe6d46368bafa9f9d";>05df14e o Updated to stop suppressing exception's thrown when closing streams. Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.0.16...plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-toolchains-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] dependabot[bot] opened a new pull request, #80: Bump org.codehaus.plexus:plexus-utils from 3.0.16 to 3.0.24 in /src/test/resources
dependabot[bot] opened a new pull request, #80: URL: https://github.com/apache/maven-filtering/pull/80 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.0.16 to 3.0.24. Commits https://github.com/codehaus-plexus/plexus-utils/commit/fd36d8b80ba10955ef065230571ce2be2d4c1bbb";>fd36d8b [maven-release-plugin] prepare release plexus-utils-3.0.24 https://github.com/codehaus-plexus/plexus-utils/commit/33a2853df8185b4519b1b8bfae284f03392618ef";>33a2853 o Updated to guard against directory traversal issues. https://github.com/codehaus-plexus/plexus-utils/commit/f933e5e78dc2637e485447ed821fe14904f110de";>f933e5e o Updated to remove '' from XML comments to guard against XML https://github.com/codehaus-plexus/plexus-utils/commit/fcd94e57a05474cf0db0a34e5a2f3e8c49fb2c29";>fcd94e5 o Updated to stop detecting Windows systems as family DOS. https://github.com/codehaus-plexus/plexus-utils/commit/2644af5a8a51bbaf2cc307386b81d63069954e46";>2644af5 o Updated to guard against 'NullPointerException's. https://github.com/codehaus-plexus/plexus-utils/commit/ba1c194dc0d57b49ffb2220b7571e68caf09f18b";>ba1c194 o Updated class 'PropertyUtils' to stop silently dropping exceptions. https://github.com/codehaus-plexus/plexus-utils/commit/8399a27c2ba90cc090c2b5589ff0579e8960";>8399a2e [maven-release-plugin] prepare for next development iteration https://github.com/codehaus-plexus/plexus-utils/commit/6176f91bb843eecddac857591ed20bda38e01470";>6176f91 [maven-release-plugin] prepare release plexus-utils-3.0.23 https://github.com/codehaus-plexus/plexus-utils/commit/5d94a602392cbf3f9f6175bee42fee1c1b97d128";>5d94a60 Merge pull request https://redirect.github.com/codehaus-plexus/plexus-utils/issues/9";>#9 from ChristianSchulte/master https://github.com/codehaus-plexus/plexus-utils/commit/05df14eb6bc5304f1370baebe6d46368bafa9f9d";>05df14e o Updated to stop suppressing exception's thrown when closing streams. Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.0.16...plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-filtering/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] dependabot[bot] opened a new pull request, #306: Bump org.codehaus.plexus:plexus-utils from 3.0.9 to 3.0.24 in /core-it-suite/src/test/resources/mng-7160-extension
dependabot[bot] opened a new pull request, #306: URL: https://github.com/apache/maven-integration-testing/pull/306 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.0.9 to 3.0.24. Commits https://github.com/codehaus-plexus/plexus-utils/commit/fd36d8b80ba10955ef065230571ce2be2d4c1bbb";>fd36d8b [maven-release-plugin] prepare release plexus-utils-3.0.24 https://github.com/codehaus-plexus/plexus-utils/commit/33a2853df8185b4519b1b8bfae284f03392618ef";>33a2853 o Updated to guard against directory traversal issues. https://github.com/codehaus-plexus/plexus-utils/commit/f933e5e78dc2637e485447ed821fe14904f110de";>f933e5e o Updated to remove '' from XML comments to guard against XML https://github.com/codehaus-plexus/plexus-utils/commit/fcd94e57a05474cf0db0a34e5a2f3e8c49fb2c29";>fcd94e5 o Updated to stop detecting Windows systems as family DOS. https://github.com/codehaus-plexus/plexus-utils/commit/2644af5a8a51bbaf2cc307386b81d63069954e46";>2644af5 o Updated to guard against 'NullPointerException's. https://github.com/codehaus-plexus/plexus-utils/commit/ba1c194dc0d57b49ffb2220b7571e68caf09f18b";>ba1c194 o Updated class 'PropertyUtils' to stop silently dropping exceptions. https://github.com/codehaus-plexus/plexus-utils/commit/8399a27c2ba90cc090c2b5589ff0579e8960";>8399a2e [maven-release-plugin] prepare for next development iteration https://github.com/codehaus-plexus/plexus-utils/commit/6176f91bb843eecddac857591ed20bda38e01470";>6176f91 [maven-release-plugin] prepare release plexus-utils-3.0.23 https://github.com/codehaus-plexus/plexus-utils/commit/5d94a602392cbf3f9f6175bee42fee1c1b97d128";>5d94a60 Merge pull request https://redirect.github.com/codehaus-plexus/plexus-utils/issues/9";>#9 from ChristianSchulte/master https://github.com/codehaus-plexus/plexus-utils/commit/05df14eb6bc5304f1370baebe6d46368bafa9f9d";>05df14e o Updated to stop suppressing exception's thrown when closing streams. Additional commits viewable in https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.0.9...plexus-utils-3.0.24";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-integration-testing/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769346#comment-17769346
]
Vlad Galuska commented on MCOMPILER-546:
Debug false works for the project I encountered this with (with which I was
running preview unit tests). I'll report this to the JDK team then.
Thanks for the stellar support!
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #307: Try to fix MavenITmng7836AlternativePomSyntaxTest
slawekjaranowski opened a new pull request, #307: URL: https://github.com/apache/maven-integration-testing/pull/307 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest
slawekjaranowski commented on code in PR #307:
URL:
https://github.com/apache/maven-integration-testing/pull/307#discussion_r1337825137
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7836AlternativePomSyntaxTest.java:
##
@@ -64,8 +66,11 @@ void testAlternativeSyntax() throws Exception {
assertTrue(Files.isRegularFile(consumerPom));
List consumerPomLines = Files.readAllLines(consumerPom,
StandardCharsets.UTF_8);
-assertFalse(consumerPomLines.stream().anyMatch(l ->
l.contains("Apache-2.0")));
-assertTrue(consumerPomLines.stream().anyMatch(l ->
l.contains("")));
+
+// looks like consumerPom is an effective pom
+// both assertions will fail
+// assertFalse(consumerPomLines.stream().anyMatch(l ->
l.contains("Apache-2.0")));
+// assertTrue(consumerPomLines.stream().anyMatch(l ->
l.contains("")));
Review Comment:
When I made a test to build and execute - this assertions don't pass
It can be cause that the feature is not working as expected ... or we have
wrong assumptions here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest
slawekjaranowski commented on code in PR #307:
URL:
https://github.com/apache/maven-integration-testing/pull/307#discussion_r1337826109
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7836AlternativePomSyntaxTest.java:
##
@@ -64,8 +66,11 @@ void testAlternativeSyntax() throws Exception {
assertTrue(Files.isRegularFile(consumerPom));
List consumerPomLines = Files.readAllLines(consumerPom,
StandardCharsets.UTF_8);
-assertFalse(consumerPomLines.stream().anyMatch(l ->
l.contains("Apache-2.0")));
-assertTrue(consumerPomLines.stream().anyMatch(l ->
l.contains("")));
+
+// looks like consumerPom is an effective pom
+// both assertions will fail
+// assertFalse(consumerPomLines.stream().anyMatch(l ->
l.contains("Apache-2.0")));
+// assertTrue(consumerPomLines.stream().anyMatch(l ->
l.contains("")));
Review Comment:
@gnodet can you look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski closed pull request #302: Bump org.codehaus.plexus:plexus-utils from 0.1-mng2892 to 3.0.24 in /core-it-suite/src/test/resources/mng-2892
slawekjaranowski closed pull request #302: Bump org.codehaus.plexus:plexus-utils from 0.1-mng2892 to 3.0.24 in /core-it-suite/src/test/resources/mng-2892 URL: https://github.com/apache/maven-integration-testing/pull/302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] dependabot[bot] commented on pull request #302: Bump org.codehaus.plexus:plexus-utils from 0.1-mng2892 to 3.0.24 in /core-it-suite/src/test/resources/mng-2892
dependabot[bot] commented on PR #302: URL: https://github.com/apache/maven-integration-testing/pull/302#issuecomment-1736380354 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MCOMPILER-546) Maven compiling fails when using JEP 443
[
https://issues.apache.org/jira/browse/MCOMPILER-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MCOMPILER-546.
Assignee: Tamas Cservenak
Resolution: Information Provided
> Maven compiling fails when using JEP 443
>
>
> Key: MCOMPILER-546
> URL: https://issues.apache.org/jira/browse/MCOMPILER-546
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.11.0
> Environment: Both MacOS and Windows.
> Maven 3.9.4
> Maven Compiler 3.11
> Java 21 Preview
>Reporter: Vlad Galuska
>Assignee: Tamas Cservenak
>Priority: Major
> Attachments: mvn-compile-1.log, pom.xml
>
>
> I'm trying to test out the preview feature described in JEP 443: Unnamed
> patterns and variables [https://openjdk.org/jeps/443] . I have the following:
> {code:java}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
> 21
> 21
>
> --enable-preview
>
>
> {code}
> I then run `mvn -X compile`, the result of which has been attached as
> mvn-compile.log.
> The target just contains the Main.class file and the `createdFiles.lst` with:
> `org/example/Main.class` and `inputFiles.lst` with:
> `/Users/vlad.galuska/IdeaProjects/preview/Java21Preview/src/main/java/org/example/Main.java`
> {*}Note{*}: The picture is from IntelIJ but all the commands have been run
> from the command line.
> When running the generated .class file:
> `cd target/classes `
> `java --enable-preview org.example.Main`
> I get the following message:
> ```
> Error: LinkageError occurred while loading main class org.example.Main
> java.lang.ClassFormatError: Illegal field name "" in class
> org/example/Main
> ```
> This only happens when using the maven compiler plugin as when compiling
> manually from the command line:
> `javac --enable-preview --release 21 org/example/Main.java `
> `java --enable-preview org.example.Main `
> I get the intended result:
> ```
> Hello, World!
> Hello, World!
> Hello, World!
> ```
> The same behavior has been recorded on Windows. I've also tried this with the
> amazon coretto version of java 21, OpenJDK Java 21 GA release and OpenJDK
> java 21.ea.35-open.
> Maven is also a clean install of 3.9.4, but was reproduced with a 3.8 I had
> installed previously.
> Here's also a repository where I have uploaded the code base for this bug
> report:
> [https://github.com/VladGaluska/jdk21-preview-bug]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest
slawekjaranowski commented on PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#issuecomment-1736735173 This patch make a build green https://github.com/apache/maven/actions/runs/6318762268 but not resolve a problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] gnodet opened a new pull request, #308: Fix expectations on IT MNG-7836 following the modifications on the consumer pom
gnodet opened a new pull request, #308: URL: https://github.com/apache/maven-integration-testing/pull/308 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #308: Fix expectations on IT MNG-7836 following the modifications on the consumer pom
slawekjaranowski commented on PR #308: URL: https://github.com/apache/maven-integration-testing/pull/308#issuecomment-1736754890 Can we change in: https://github.com/apache/maven-integration-testing/pull/307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] gnodet commented on pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest
gnodet commented on PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#issuecomment-1736792190 The fix is #308. The problem occurred because I split some PRs. Each PR was individually passing the tests, but when both had been merged, the test from the first PR was broken by the second PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest
gnodet commented on code in PR #307:
URL:
https://github.com/apache/maven-integration-testing/pull/307#discussion_r1338119093
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7836AlternativePomSyntaxTest.java:
##
@@ -64,8 +66,11 @@ void testAlternativeSyntax() throws Exception {
assertTrue(Files.isRegularFile(consumerPom));
List consumerPomLines = Files.readAllLines(consumerPom,
StandardCharsets.UTF_8);
-assertFalse(consumerPomLines.stream().anyMatch(l ->
l.contains("Apache-2.0")));
-assertTrue(consumerPomLines.stream().anyMatch(l ->
l.contains("")));
+
+// looks like consumerPom is an effective pom
+// both assertions will fail
+// assertFalse(consumerPomLines.stream().anyMatch(l ->
l.contains("Apache-2.0")));
+// assertTrue(consumerPomLines.stream().anyMatch(l ->
l.contains("")));
Review Comment:
The assertions need to be inverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #307: Try to fix MavenITmng7836AlternativePomSyntaxTest
gnodet commented on code in PR #307: URL: https://github.com/apache/maven-integration-testing/pull/307#discussion_r1338125407 ## core-it-suite/src/test/resources-filtered/settings-remote.xml: ## @@ -67,6 +67,35 @@ plugins/artifacts from test repos so use of these settings should be the excepti + + asf-snapshot-repo + + + asf-snapshot + Apache Maven Snapshot Repository + https://repository.apache.org/snapshots/ + +false + + +true + + + + + + asf-snapshot + Apache Maven Snapshot Repository + https://repository.apache.org/snapshots/ + +false + + +true + + + + Review Comment: Those should not be needed. IIUC, this should already be fixed by https://github.com/apache/maven/commit/f24266eb64fbb4f23655fbc7d76dbf4be61045c2#diff-5dbf1a803ecc13ff945a08ed3eb09149a83615e83f15320550af8e3a91976446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
