[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885643#comment-15885643
 ] 

ASF subversion and git services commented on GEODE-2428:


Commit a8757f6a16920488d15f78174f1638c87565eacf in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a8757f6 ]

GEODE-2428: Adding support of Serialization/deserialization of LinkedHashMap in 
DataSerializer
Also added a test for the same.

GEODE-2428: Addressing review comment, Fixing the wild-card import
issue.


> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885642#comment-15885642
 ] 

ASF subversion and git services commented on GEODE-2428:


Commit a8757f6a16920488d15f78174f1638c87565eacf in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a8757f6 ]

GEODE-2428: Adding support of Serialization/deserialization of LinkedHashMap in 
DataSerializer
Also added a test for the same.

GEODE-2428: Addressing review comment, Fixing the wild-card import
issue.


> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #388: GEODE-2428: Adding support of Serialization/deseria...

[davinash]

Github user davinash closed the pull request at:

https://github.com/apache/geode/pull/388


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #388: GEODE-2428: Adding support of Serialization/deserializatio...

[davinash]

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/388
  
Closing, merged to develop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885650#comment-15885650
 ] 

ASF GitHub Bot commented on GEODE-2428:
---

Github user davinash commented on the issue:

https://github.com/apache/geode/pull/388
  
Closing, merged to develop


> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885651#comment-15885651
 ] 

ASF GitHub Bot commented on GEODE-2428:
---

Github user davinash closed the pull request at:

https://github.com/apache/geode/pull/388


> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[Avinash Dongre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avinash Dongre resolved GEODE-2428.
---
Resolution: Fixed

> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2428) Add support for LinkedHashMap in DataSerializer

[Avinash Dongre (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avinash Dongre updated GEODE-2428:
--
Fix Version/s: 1.2.0

> Add support for LinkedHashMap in DataSerializer
> ---
>
> Key: GEODE-2428
> URL: https://issues.apache.org/jira/browse/GEODE-2428
> Project: Geode
>  Issue Type: Improvement
>Reporter: Avinash Dongre
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> DataSerializer should also support serialization and de-serialization of 
> DataSerializer



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885767#comment-15885767
 ] 

ASF subversion and git services commented on GEODE-1887:


Commit f2721dc81256bcec84e855e9dc52d2f234e745da in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f2721dc ]

GEODE-1887: Now Size api goes through ServerProxy when cache is of type client 
and DataPolicy is Empty.
Added a test for both PR and Replicated regions.

GEODE-1887: Addressing review comments, refactor test based on the
region type.

GEODE-1887: Spotless fixes.

GEODE-1887: Addressing Review Comments.

GEODE-1887: Spotless


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885769#comment-15885769
 ] 

ASF subversion and git services commented on GEODE-1887:


Commit f2721dc81256bcec84e855e9dc52d2f234e745da in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f2721dc ]

GEODE-1887: Now Size api goes through ServerProxy when cache is of type client 
and DataPolicy is Empty.
Added a test for both PR and Replicated regions.

GEODE-1887: Addressing review comments, refactor test based on the
region type.

GEODE-1887: Spotless fixes.

GEODE-1887: Addressing Review Comments.

GEODE-1887: Spotless


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885768#comment-15885768
 ] 

ASF subversion and git services commented on GEODE-1887:


Commit f2721dc81256bcec84e855e9dc52d2f234e745da in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f2721dc ]

GEODE-1887: Now Size api goes through ServerProxy when cache is of type client 
and DataPolicy is Empty.
Added a test for both PR and Replicated regions.

GEODE-1887: Addressing review comments, refactor test based on the
region type.

GEODE-1887: Spotless fixes.

GEODE-1887: Addressing Review Comments.

GEODE-1887: Spotless


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885766#comment-15885766
 ] 

ASF subversion and git services commented on GEODE-1887:


Commit f2721dc81256bcec84e855e9dc52d2f234e745da in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f2721dc ]

GEODE-1887: Now Size api goes through ServerProxy when cache is of type client 
and DataPolicy is Empty.
Added a test for both PR and Replicated regions.

GEODE-1887: Addressing review comments, refactor test based on the
region type.

GEODE-1887: Spotless fixes.

GEODE-1887: Addressing Review Comments.

GEODE-1887: Spotless


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885770#comment-15885770
 ] 

ASF subversion and git services commented on GEODE-1887:


Commit f2721dc81256bcec84e855e9dc52d2f234e745da in geode's branch 
refs/heads/develop from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f2721dc ]

GEODE-1887: Now Size api goes through ServerProxy when cache is of type client 
and DataPolicy is Empty.
Added a test for both PR and Replicated regions.

GEODE-1887: Addressing review comments, refactor test based on the
region type.

GEODE-1887: Spotless fixes.

GEODE-1887: Addressing Review Comments.

GEODE-1887: Spotless


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #245: native-client-software-grant - ClientMetadata::getServerLo...

[doribd]

Github user doribd commented on the issue:

https://github.com/apache/geode/pull/245
  
ok thanks, understood now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

jgroups 4.0.0.Final released

[Dor Ben Dov]

Hi, 

Have it being considered switching from 3.6.10 Final to 4.0.0 Final release. 

From Bella's blog it seems that the new version uses java 8 streams, lambda 
expressions as well as
120 issues that were fixed as well as optimizations.

Regards,
Dor


This message and the information contained herein is proprietary and 
confidential and subject to the Amdocs policy statement,

you may review at http://www.amdocs.com/email_disclaimer.asp

Re: [DISCUSS] changes to Redis implementation

[Udo Kohlmeyer]

I've quickly gone through the changes for the pull request.

The most significant change of this pull request is that the collections 
that initially were regions are single collections (not distributed). 
That said, this is something that we've been discussing. The one thing 
that I wonder about is, what will the performance look like when the 
collections become really large? Replicating a whole collection because 
of 1 change does not really make too much sense.


Maybe this implementation becomes the catalyst for future improvements.

--Udo


On 2/24/17 15:25, Bruce Schuchardt wrote:
Gregory Green has posted a pull request that warrants discussion. It 
improves performance for Sets and Hashes by altering the storage 
format for these collections.  As such it will not permit a rolling 
upgrade, though the Redis adapter is labelled "experimental" so maybe 
that's okay.


https://github.com/apache/geode/pull/404

The PR also fixes GEODE-2469, inability to handle hash keys having 
colons.


There was some discussion about altering the storage format that was 
initiated by Hitesh.  Personally I think Gregory's changes are better 
than the current implementation and we should accept them, though I 
haven't gone through the code changes extensively.

[GitHub] geode issue #404: Geode 2469

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on the issue:

https://github.com/apache/geode/pull/404
  
I like the fact that we are now dealing with collections on a single 
machine, rather than all the elements spread distributed. Would you possibly 
have some perf metrics in relation to larger collections. e.g 1mil entries vs 
100. 

I imagine that as the number of entries in the collections grow, so will 
the insert performance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] changes to Redis implementation

[Wes Williams]

>>Replicating a whole collection because of 1 change does not really make
too much sense.<<

I agree but won't delta replication prevent sending the entire collection
across the wire?

*Wes Williams | Pivotal Advisory **Data Engineer*
781.606.0325
http://pivotal.io/big-data/pivotal-gemfire

On Mon, Feb 27, 2017 at 10:08 AM, Udo Kohlmeyer 
wrote:

> I've quickly gone through the changes for the pull request.
>
> The most significant change of this pull request is that the collections
> that initially were regions are single collections (not distributed). That
> said, this is something that we've been discussing. The one thing that I
> wonder about is, what will the performance look like when the collections
> become really large? Replicating a whole collection because of 1 change
> does not really make too much sense.
>
> Maybe this implementation becomes the catalyst for future improvements.
>
> --Udo
>
>
>
> On 2/24/17 15:25, Bruce Schuchardt wrote:
>
>> Gregory Green has posted a pull request that warrants discussion. It
>> improves performance for Sets and Hashes by altering the storage format for
>> these collections.  As such it will not permit a rolling upgrade, though
>> the Redis adapter is labelled "experimental" so maybe that's okay.
>>
>> https://github.com/apache/geode/pull/404
>>
>> The PR also fixes GEODE-2469, inability to handle hash keys having colons.
>>
>> There was some discussion about altering the storage format that was
>> initiated by Hitesh.  Personally I think Gregory's changes are better than
>> the current implementation and we should accept them, though I haven't gone
>> through the code changes extensively.
>>
>>
>

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885970#comment-15885970
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 76ea6c3cae06442fed9ca680d5aacedaf6a4f2dd in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=76ea6c3 ]

GEODE-2142: Removal of offending JSON.ORG code and license information


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885975#comment-15885975
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit 7c8794cb8889d1c2847545bfcfeaea6d6c17e515 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=7c8794c ]

GEODE-2142: Refactoring of tests to work with new JSONObject class.
Changing file export to use Base64 encoding.


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885976#comment-15885976
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit eac0bb8c8e20cae892680a3a39b790c0e05bf4cf in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=eac0bb8 ]

GEODE-2142: spotless


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885974#comment-15885974
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit fdde6181feaae6674173a9c5827849672e291f3b in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=fdde618 ]

GEODE-2142: Amending JSONObject.java with cyclicalDependency management
Refactoring some code in GfJsonObject.java


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885977#comment-15885977
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit cd58f1ffc5beca3b05c15c2dcd9ff609e6313008 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=cd58f1f ]

GEODE-2142: cyclical dependency in gradle build


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885973#comment-15885973
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit b34e47ffaa92007cf059ae5257e481bfb048bfb3 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b34e47f ]

GEODE-2142: Adding JSON library from the https://github.com/tdunning/open-json 
project


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885972#comment-15885972
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit a2f47b724d0894811d77ce92c524e3eba4ed34f2 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a2f47b7 ]

GEODE-2142: Removal of offending JSON.ORG code and license information


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885980#comment-15885980
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit f2262d13a81c59918f06a78c1073c76062e7f238 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f2262d1 ]

GEODE-2142: Removing JSON licence stuff from NOTICE files


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885979#comment-15885979
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit abeaa244b5c814f6040176d34551061c4b3b3b25 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=abeaa24 ]

GEODE-2142: removing tests so run precheckin


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[Udo Kohlmeyer (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885981#comment-15885981
 ] 

Udo Kohlmeyer commented on GEODE-2142:
--

Replaced org.json implementation with an open sourced implementation.

> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2142) Remove JSON.org dependency

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885978#comment-15885978
 ] 

ASF subversion and git services commented on GEODE-2142:


Commit e220d0992bd18a40bf209294cf1cb02106af21d5 in geode's branch 
refs/heads/develop from [~ukohlmeyer]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e220d09 ]

GEODE-2142: final compiling build


> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2142) Remove JSON.org dependency

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer updated GEODE-2142:
-
Fix Version/s: 1.2.0

> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2142) Remove JSON.org dependency

[Udo Kohlmeyer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Udo Kohlmeyer resolved GEODE-2142.
--
Resolution: Fixed
  Assignee: Udo Kohlmeyer

> Remove JSON.org dependency
> --
>
> Key: GEODE-2142
> URL: https://issues.apache.org/jira/browse/GEODE-2142
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Anthony Baker
>Assignee: Udo Kohlmeyer
>Priority: Blocker
>  Labels: json
> Fix For: 1.2.0
>
>
> ASF has determined that the JSON library should be treated as Category X and 
> is incompatible with ASLv2.
> We have until Apr-30, 2017 to remove this dependency.  Any release we ship 
> prior to that time must state this usage via NOTICE.
> http://mail-archives.apache.org/mod_mbox/incubator-general/201611.mbox/%3ccajwfca2ox62mugp+-+-v6ktbkhhgkixucjcr9syes-azfp+...@mail.gmail.com%3e
> There are related reasons for removing the JSON library anyway, but this bug 
> captures the legal reasons.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #39: Add rat checks to travis-ci build

[PivotalSarge]

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/39
  
Where is .ratignore? I don't see it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] changes to Redis implementation

[Udo Kohlmeyer]

Delta could provide us a mechanism to replicate only what is required.

I wonder if we could not create a simple operation replication 
framework. Rather than writing a potential large amounts of code for 
delta, we replicate only the operation.



On 2/27/17 07:18, Wes Williams wrote:

Replicating a whole collection because of 1 change does not really make

too much sense.<<

I agree but won't delta replication prevent sending the entire collection
across the wire?

*Wes Williams | Pivotal Advisory **Data Engineer*
781.606.0325
http://pivotal.io/big-data/pivotal-gemfire

On Mon, Feb 27, 2017 at 10:08 AM, Udo Kohlmeyer 
wrote:


I've quickly gone through the changes for the pull request.

The most significant change of this pull request is that the collections
that initially were regions are single collections (not distributed). That
said, this is something that we've been discussing. The one thing that I
wonder about is, what will the performance look like when the collections
become really large? Replicating a whole collection because of 1 change
does not really make too much sense.

Maybe this implementation becomes the catalyst for future improvements.

--Udo



On 2/24/17 15:25, Bruce Schuchardt wrote:


Gregory Green has posted a pull request that warrants discussion. It
improves performance for Sets and Hashes by altering the storage format for
these collections.  As such it will not permit a rolling upgrade, though
the Redis adapter is labelled "experimental" so maybe that's okay.

https://github.com/apache/geode/pull/404

The PR also fixes GEODE-2469, inability to handle hash keys having colons.

There was some discussion about altering the storage format that was
initiated by Hitesh.  Personally I think Gregory's changes are better than
the current implementation and we should accept them, though I haven't gone
through the code changes extensively.

[jira] [Created] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[Jacob S. Barrett (JIRA)]

Jacob S. Barrett created GEODE-2552:
---

 Summary: Replace NanoTimer with std::chrono / 
std::this_thread::sleep_for
 Key: GEODE-2552
 URL: https://issues.apache.org/jira/browse/GEODE-2552
 Project: Geode
  Issue Type: Task
Reporter: Jacob S. Barrett


Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Build failed in Jenkins: Geode-nightly #761

[Apache Jenkins Server]

See 

--
[...truncated 172.02 KB...]
:geode-json:spotlessCheck
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJava
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-parent/2.4.0/randomizedtesting-parent-2.4.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.4.1/lucene-test-framework-6.4.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.4.1/lucene-codecs-6.4.1.jar
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.4.0/randomizedtesting-runner-2.4.0.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJava
Download 
https://repo1.maven.org/maven2/com/codeborne/phantomjsdriver/1.3.0/phantomjsdriver-1.3.0.pom
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-api/3.0.1/selenium-api-3.0.1.pom
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-remote-driver/3.0.1/selenium-remote-driver-3.0.1.pom
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-support/3.0.1/selenium-support-3.0.1.pom
Download 
https://repo1.maven.org/maven2/org/springframework/spring-test/4.3.6.RELEASE/spring-test-4.3.6.RELEASE.pom
Download 
https://repo1.maven.org/maven2/cglib/cglib-nodep/3.2.4/cglib-nodep-3.2.4.pom
Download 
https://repo1.maven.org/maven2/com/codeborne/phantomjsdriver/1.3.0/phantomjsdriver-1.3.0.jar
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-api/3.0.1/selenium-api-3.0.1.jar
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-remote-driver/3.0.1/selenium-remote-driver-3.0.1.jar
Download 
https://repo1.maven.org/maven2/org/seleniumhq/selenium/selenium-support/3.0.1/selenium-support-3.0.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/spring-test/4.3.6.RELEASE/spring-test-4.3.6.RELEASE.jar
Download 
https://repo1.maven.org/maven2/cglib/cglib-nodep/3.2.4/cglib-nodep-3.2.4.jar
Note: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

[GitHub] geode-native issue #39: Add rat checks to travis-ci build

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/39
  
@PivotalSarge .ratignore is in the base dir of geode-native


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 57070: LuceneServiceImpl should throw CacheClosedException if found cache is null

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57070/#review166884
---



I don't think this is the appropriate thing to do here. The user has passed in 
null; that doesn't mean the cache has not been created or has been closed. I 
think an NPE or an illegal argument exception is more appopriate.

- Dan Smith


On Feb. 26, 2017, 7:41 a.m., xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57070/
> ---
> 
> (Updated Feb. 26, 2017, 7:41 a.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-11
> https://issues.apache.org/jira/browse/GEODE-11
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> util.TestException: Got unexpected exception java.lang.NullPointerException
> 
> at 
> org.apache.geode.cache.lucene.LuceneServiceProvider.get(LuceneServiceProvider.java:34)
> 
> at lucene.LuceneTest.executeLuceneQuery(LuceneTest.java:116)
> 
> at parReg.ParRegTest.doEntryOperations(ParRegTest.java:2916)
> 
> at parReg.ParRegTest.HADoEntryOps(ParRegTest.java:2259)
> 
> at parReg.ParRegTest.HydraTask_HADoEntryOps(ParRegTest.java:1040)
> 
> at sun.reflect.GeneratedMethodAccessor63.invoke(Unknown Source)
> 
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 
> at java.lang.reflect.Method.invoke(Method.java:497)
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneServiceProvider.java
>  a1f73da 
> 
> Diff: https://reviews.apache.org/r/57070/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>

[GitHub] geode-native pull request #40: GEODE-2552: Remove NanoTimer

[pivotal-jbarrett]

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/40

GEODE-2552: Remove NanoTimer

Please focus on commits e541e31 ... daf4234, others are artifacts of 
unpulled requests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEDOE-2552

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 4f8ee0ba64bae9cbc3fd204e759745236d174d6e
Author: Jacob Barrett 
Date:   2017-02-16T06:29:09Z

GEODE-2494: Adds spinlock_mutex.

commit 74efeb5d4ff807720aa051be5765471c64f3d8ea
Author: Jacob Barrett 
Date:   2017-02-16T06:29:37Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++11 standards.

commit f2ec96e50c974f0f8999b0d7b0ae3e0b2ea64244
Author: Jacob Barrett 
Date:   2017-02-16T07:33:21Z

GEODE-2494: Replaced spin lock protected counter with std::atomic.

- Cleanup C++11 standards.

commit ab13aca81d084570d47c090363b5ba92b9ebec3b
Author: Jacob Barrett 
Date:   2017-02-20T21:42:19Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

commit 84e5b333d7f53000593d41dcfe7f4011ea823f9f
Author: Jacob Barrett 
Date:   2017-02-22T05:46:27Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 76ca82febc1d68bd1e09b7639c92d59745d626f9
Author: Jacob Barrett 
Date:   2017-02-22T05:55:33Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 46131bea0d787698c124b822d8348b683633c6a2
Author: Jacob Barrett 
Date:   2017-02-22T06:00:21Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 9c8a9d6644a566f2b2d927da6c69a73ece9f5105
Author: Jacob Barrett 
Date:   2017-02-22T06:14:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ed88029b45b4b4d5155a76e0b0d0c2c882274581
Author: Jacob Barrett 
Date:   2017-02-22T06:52:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 2e2c36b52b48342e59e7f0dac671c59dfb994148
Author: Jacob Barrett 
Date:   2017-02-23T01:58:05Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 8898a1c9b3dc514bd6b8c2630d021a01729d4df8
Author: Jacob Barrett 
Date:   2017-02-23T03:04:10Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ec2e69431c88d00a63b05b3f6fdcec8b970fe780
Author: Jacob Barrett 
Date:   2017-02-23T05:29:49Z

GEODE-2494: Removed SpinLock.

commit cf1ba853195e5ecdd63cc5951bd1497e191e1766
Author: Jacob Barrett 
Date:   2017-02-23T06:38:03Z

GEODE-2531: Replace HostAsm::atomic with std::atomic.

commit e541e31301c1f6ce9834698fa9e8cdf6dbd025bf
Author: Jacob Barrett 
Date:   2017-02-25T21:18:12Z

GEODE-2552: Replace NanoSleep with std::this_thread::sleepFor.

- Replaced custom time/duration with std::crono.

commit 24d74ded53dd262a483d9df8caeb03065727f778
Author: Jacob Barrett 
Date:   2017-02-25T22:02:58Z

GEODE-2552: Replaced NanoTimer with std::chrono.

commit 7bb0435089d2ea678a679bb18e9fe85c5eb9ebfe
Author: Jacob Barrett 
Date:   2017-02-25T22:11:46Z

GEODE-2552: Replaced NanoTimer with std::chrono.

commit daf423443ca1cc897156bc79089fd4e6deecaeb2
Author: Jacob Barrett 
Date:   2017-02-26T23:12:18Z

GEODE-2552: Removed NanoTimer

- Replaced millisleep with std::this_thread::sleep_for.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #39: Add rat checks to travis-ci build

[PivotalSarge]

Github user PivotalSarge commented on the issue:

https://github.com/apache/geode-native/pull/39
  
Ah. `find` does not behave like I think it does with respect to finding dot 
files in the current directory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886045#comment-15886045
 ] 

ASF GitHub Bot commented on GEODE-2552:
---

GitHub user pivotal-jbarrett opened a pull request:

https://github.com/apache/geode-native/pull/40

GEODE-2552: Remove NanoTimer

Please focus on commits e541e31 ... daf4234, others are artifacts of 
unpulled requests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pivotal-jbarrett/geode-native 
feature/GEDOE-2552

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode-native/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 4f8ee0ba64bae9cbc3fd204e759745236d174d6e
Author: Jacob Barrett 
Date:   2017-02-16T06:29:09Z

GEODE-2494: Adds spinlock_mutex.

commit 74efeb5d4ff807720aa051be5765471c64f3d8ea
Author: Jacob Barrett 
Date:   2017-02-16T06:29:37Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++11 standards.

commit f2ec96e50c974f0f8999b0d7b0ae3e0b2ea64244
Author: Jacob Barrett 
Date:   2017-02-16T07:33:21Z

GEODE-2494: Replaced spin lock protected counter with std::atomic.

- Cleanup C++11 standards.

commit ab13aca81d084570d47c090363b5ba92b9ebec3b
Author: Jacob Barrett 
Date:   2017-02-20T21:42:19Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

commit 84e5b333d7f53000593d41dcfe7f4011ea823f9f
Author: Jacob Barrett 
Date:   2017-02-22T05:46:27Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 76ca82febc1d68bd1e09b7639c92d59745d626f9
Author: Jacob Barrett 
Date:   2017-02-22T05:55:33Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 46131bea0d787698c124b822d8348b683633c6a2
Author: Jacob Barrett 
Date:   2017-02-22T06:00:21Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 9c8a9d6644a566f2b2d927da6c69a73ece9f5105
Author: Jacob Barrett 
Date:   2017-02-22T06:14:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ed88029b45b4b4d5155a76e0b0d0c2c882274581
Author: Jacob Barrett 
Date:   2017-02-22T06:52:50Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 2e2c36b52b48342e59e7f0dac671c59dfb994148
Author: Jacob Barrett 
Date:   2017-02-23T01:58:05Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit 8898a1c9b3dc514bd6b8c2630d021a01729d4df8
Author: Jacob Barrett 
Date:   2017-02-23T03:04:10Z

GEODE-2494: Replace SpinLock with spinlock_mutex.

- Cleanup C++ standards.

commit ec2e69431c88d00a63b05b3f6fdcec8b970fe780
Author: Jacob Barrett 
Date:   2017-02-23T05:29:49Z

GEODE-2494: Removed SpinLock.

commit cf1ba853195e5ecdd63cc5951bd1497e191e1766
Author: Jacob Barrett 
Date:   2017-02-23T06:38:03Z

GEODE-2531: Replace HostAsm::atomic with std::atomic.

commit e541e31301c1f6ce9834698fa9e8cdf6dbd025bf
Author: Jacob Barrett 
Date:   2017-02-25T21:18:12Z

GEODE-2552: Replace NanoSleep with std::this_thread::sleepFor.

- Replaced custom time/duration with std::crono.

commit 24d74ded53dd262a483d9df8caeb03065727f778
Author: Jacob Barrett 
Date:   2017-02-25T22:02:58Z

GEODE-2552: Replaced NanoTimer with std::chrono.

commit 7bb0435089d2ea678a679bb18e9fe85c5eb9ebfe
Author: Jacob Barrett 
Date:   2017-02-25T22:11:46Z

GEODE-2552: Replaced NanoTimer with std::chrono.

commit daf423443ca1cc897156bc79089fd4e6deecaeb2
Author: Jacob Barrett 
Date:   2017-02-26T23:12:18Z

GEODE-2552: Removed NanoTimer

- Replaced millisleep with std::this_thread::sleep_for.




> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #39: Add rat checks to travis-ci build

[echobravopapa]

Github user echobravopapa commented on the issue:

https://github.com/apache/geode-native/pull/39
  
I quoted the target, suspecting find would not like it otherwise...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #390: [GEODE-1887] #comment Fix Issue Client PROXY region...

[davinash]

Github user davinash closed the pull request at:

https://github.com/apache/geode/pull/390


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-1887) Client PROXY region should delegate all operations to server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886066#comment-15886066
 ] 

ASF GitHub Bot commented on GEODE-1887:
---

Github user davinash closed the pull request at:

https://github.com/apache/geode/pull/390


> Client PROXY region should delegate all operations to server
> 
>
> Key: GEODE-1887
> URL: https://issues.apache.org/jira/browse/GEODE-1887
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Swapnil Bawaskar
>Assignee: Avinash Dongre
>
> Currently a ClientRegionShortcut.PROXY region sends operations like put() and 
> get() over to the server, but for operations like size() and isEmpty() it 
> just consults the local state on the client  and returns 0 and true 
> respectively, even though there may be data in the servers for that region.
> A PROXY region should not attempt to consult its local state for any 
> operation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #40: GEODE-2552: Remove NanoTimer

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/40
  
> Would adding const to variables like spentWorking and sleepDuration help 
the compiler generate more efficient code?

I doubt the compilers would care since it will know the scope is limited to 
the block and there are no other assignment operations. It does however provide 
more readable and safe coding style. I could make adjustments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886110#comment-15886110
 ] 

ASF GitHub Bot commented on GEODE-2552:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/40
  
> Would adding const to variables like spentWorking and sleepDuration help 
the compiler generate more efficient code?

I doubt the compilers would care since it will know the scope is limited to 
the block and there are no other assignment operations. It does however provide 
more readable and safe coding style. I could make adjustments.


> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #40: GEODE-2552: Remove NanoTimer

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/40
  
@PivotalSarge 
> Why the switch to ACE_OS::localtime() from localtime()?

`localtime` AKA POSIX `localtime` is not thread safe. `ACE_OS::localtime` 
wraps the platform specific `localtime_r` or `localtime_s` functions that are 
thread safe. Ultimately we want to replace these something like `boost::locale` 
until something is adopted into the `std`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886116#comment-15886116
 ] 

ASF GitHub Bot commented on GEODE-2552:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/40
  
@PivotalSarge 
> Nice fix of the broken window of catching exceptions by value.

If you enable `clang-tidy` you will see plenty of them. I am cleaning up 
lots of these bad things along the way.




> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native issue #40: GEODE-2552: Remove NanoTimer

[pivotal-jbarrett]

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/40
  
@PivotalSarge 
> Nice fix of the broken window of catching exceptions by value.

If you enable `clang-tidy` you will see plenty of them. I am cleaning up 
lots of these bad things along the way.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2552) Replace NanoTimer with std::chrono / std::this_thread::sleep_for

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886114#comment-15886114
 ] 

ASF GitHub Bot commented on GEODE-2552:
---

Github user pivotal-jbarrett commented on the issue:

https://github.com/apache/geode-native/pull/40
  
@PivotalSarge 
> Why the switch to ACE_OS::localtime() from localtime()?

`localtime` AKA POSIX `localtime` is not thread safe. `ACE_OS::localtime` 
wraps the platform specific `localtime_r` or `localtime_s` functions that are 
thread safe. Ultimately we want to replace these something like `boost::locale` 
until something is adopted into the `std`.



> Replace NanoTimer with std::chrono / std::this_thread::sleep_for
> 
>
> Key: GEODE-2552
> URL: https://issues.apache.org/jira/browse/GEODE-2552
> Project: Geode
>  Issue Type: Task
>Reporter: Jacob S. Barrett
>
> Replace `NanoTimer` with `std::chrono` / `std::this_thread::sleep_for`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Feature branch cleanup

[Dan Smith]

+1

-Dan

On Fri, Feb 24, 2017 at 10:35 PM, Anthony Baker  wrote:

>
> The following 100+ feature branches are related to closed bugs.  I think
> these can safely be deleted (the branch names aren’t exact but pretty
> close):
>
> GEODE-1017: "Closed"
> GEODE-1040: "Closed"
> GEODE-1050: "Closed"
> GEODE-1056: "Closed"
> GEODE-1072: "Closed"
> GEODE-1096: "Closed"
> GEODE-1109: "Closed"
> GEODE-1162: "Closed"
> GEODE-1186: "Closed"
> GEODE-1199: "Closed"
> GEODE-12: "Closed"
> GEODE-1204: "Closed"
> GEODE-1233: "Closed"
> GEODE-124: "Closed"
> GEODE-1252: "Closed"
> GEODE-1255: "Closed"
> GEODE-1257: "Closed"
> GEODE-1276: "Closed"
> GEODE-1369: "Closed"
> GEODE-1370: "Closed"
> GEODE-1371: "Closed"
> GEODE-1372: "Closed"
> GEODE-1374: "Closed"
> GEODE-1376: "Closed"
> GEODE-1392: "Closed"
> GEODE-14: "Closed"
> GEODE-14: "Closed"
> GEODE-1400: "Closed"
> GEODE-1420: "Closed"
> GEODE-1426: "Closed"
> GEODE-1452: "Closed"
> GEODE-1464: "Closed"
> GEODE-1493: "Closed"
> GEODE-151: "Closed"
> GEODE-1565: "Closed"
> GEODE-1567: "Closed"
> GEODE-1571: "Closed"
> GEODE-1573: "Closed"
> GEODE-1593: "Closed"
> GEODE-160: "Closed"
> GEODE-1673: "Closed"
> GEODE-17: "Closed"
> GEODE-17: "Closed"
> GEODE-1701: "Closed"
> GEODE-1714: "Closed"
> GEODE-1835: "Closed"
> GEODE-1861: "Closed"
> GEODE-1874: "Closed"
> GEODE-1886: "Closed"
> GEODE-189: "Closed"
> GEODE-1952: "Closed"
> GEODE-1952: "Closed"
> GEODE-1952: "Closed"
> GEODE-1983: "Closed"
> GEODE-1985: "Closed"
> GEODE-2012: "Closed"
> GEODE-2026: "Closed"
> GEODE-2104: "Closed"
> GEODE-2157: "Closed"
> GEODE-217: "Closed"
> GEODE-2196: "Closed"
> GEODE-2197: "Closed"
> GEODE-2207: "Closed"
> GEODE-2214: "Closed"
> GEODE-227: "Closed"
> GEODE-2277: "Closed"
> GEODE-2297: "Closed"
> GEODE-2297: "Closed"
> GEODE-2297: "Closed"
> GEODE-233: "Closed"
> GEODE-2386: "Closed"
> GEODE-280: "Closed"
> GEODE-291: "Closed"
> GEODE-33: "Closed"
> GEODE-37: "Closed"
> GEODE-372: "Closed"
> GEODE-374: "Closed"
> GEODE-377: "Closed"
> GEODE-37: "Closed"
> GEODE-37: "Closed"
> GEODE-38: "Closed"
> GEODE-392: "Closed"
> GEODE-409: "Closed"
> GEODE-41: "Closed"
> GEODE-417: "Closed"
> GEODE-420: "Closed"
> GEODE-52: "Closed"
> GEODE-523: "Closed"
> GEODE-523: "Closed"
> GEODE-53: "Closed"
> GEODE-54: "Closed"
> GEODE-542: "Closed"
> GEODE-544: "Closed"
> GEODE-546: "Closed"
> GEODE-563: "Closed"
> GEODE-564: "Closed"
> GEODE-574: "Closed"
> GEODE-578: "Closed"
> GEODE-580: "Closed"
> GEODE-584: "Closed"
> GEODE-607: "Closed"
> GEODE-608: "Closed"
> GEODE-610: "Closed"
> GEODE-611: "Closed"
> GEODE-622: "Closed"
> GEODE-637: "Closed"
> GEODE-639: "Closed"
> GEODE-678: "Closed"
> GEODE-681: "Closed"
> GEODE-714: "Closed"
> GEODE-715: "Closed"
> GEODE-734: "Closed"
> GEODE-77: "Closed"
> GEODE-773: "Closed"
> GEODE-773: "Closed"
> GEODE-781: "Closed"
> GEODE-805: "Closed"
> GEODE-819: "Closed"
> GEODE-831: "Closed"
> GEODE-835: "Closed"
> GEODE-835: "Closed"
> GEODE-837: "Closed"
> GEODE-840: "Closed"
> GEODE-866: "Closed"
> GEODE-870: "Closed"
> GEODE-917: "Closed"
> GEODE-92: "Closed"
> GEODE-93: "Closed"
> GEODE-949: "Closed"
> GEODE-949: "Closed"
> GEODE-951: "Closed"
> GEODE-953: "Closed"
> GEODE-996: "Closed"
>
> Once you’ve merged a feature branch to develop, please make sure to delete
> the remote branch.  If you created one of these branches and you DON”T want
> it deleted, please let me know.  Otherwise I plan to clean these up in a
> week or so.
>
> Anthony
>
>

[GitHub] geode-native pull request #37: GEODE-2531: Replace HostAsm::atomic with std:...

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/37#discussion_r103254380
  
--- Diff: src/cppcache/include/geode/CacheStatistics.hpp ---
@@ -102,8 +102,8 @@ class CPPCACHE_EXPORT CacheStatistics : public 
SharedBase {
   virtual void setLastAccessedTime(uint32_t lat);
   virtual void setLastModifiedTime(uint32_t lmt);
 
-  volatile uint32_t m_lastAccessTime;
-  volatile uint32_t m_lastModifiedTime;
+  std::atomic m_lastAccessTime;
+  std::atomic m_lastModifiedTime;
--- End diff --

std::atomic is pretty cool. It looks like the performance impact is 
negligible, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #37: GEODE-2531: Replace HostAsm::atomic with std:...

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/37#discussion_r103257502
  
--- Diff: src/cppcache/src/statistics/AtomicStatisticsImpl.cpp ---
@@ -330,7 +329,13 @@ double AtomicStatisticsImpl::_incDouble(int32_t 
offset, double delta) {
 throw IllegalArgumentException(s);
   }
 
-  return (doubleStorage[offset] += delta);
+  double expected = doubleStorage[offset];
+  double value;
+  do {
+value = expected + delta;
+  } while (!doubleStorage[offset].compare_exchange_weak(expected, value));
--- End diff --

If compare_exchange_weak() fails, should expected be refreshed with 
doubleStorage[offset]?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #37: GEODE-2531: Replace HostAsm::atomic with std:...

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/37#discussion_r103255168
  
--- Diff: src/cppcache/include/geode/SharedBase.hpp ---
@@ -56,11 +57,12 @@ class CPPCACHE_EXPORT SharedBase {
 
  protected:
   inline SharedBase(bool noInit) {}
+  inline SharedBase(const SharedBase&) {}
 
   virtual ~SharedBase() {}
 
  private:
-  mutable volatile int32_t m_refCount;
+  std::atomic m_refCount;
--- End diff --

Is the mutable unnecessary? Or does std::atomic have const operators that 
can be used to mutate the reference count?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886129#comment-15886129
 ] 

ASF GitHub Bot commented on GEODE-2531:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/37#discussion_r103255168
  
--- Diff: src/cppcache/include/geode/SharedBase.hpp ---
@@ -56,11 +57,12 @@ class CPPCACHE_EXPORT SharedBase {
 
  protected:
   inline SharedBase(bool noInit) {}
+  inline SharedBase(const SharedBase&) {}
 
   virtual ~SharedBase() {}
 
  private:
-  mutable volatile int32_t m_refCount;
+  std::atomic m_refCount;
--- End diff --

Is the mutable unnecessary? Or does std::atomic have const operators that 
can be used to mutate the reference count?


> Replace HostAsm::atomic* and AtomicInc with std::atomic
> ---
>
> Key: GEODE-2531
> URL: https://issues.apache.org/jira/browse/GEODE-2531
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{HostAsm::atomic*}} and {{AtomicInc}} with 
> {{[std::atomic|http://en.cppreference.com/w/cpp/atomic/atomic]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2515) CI Failure: BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries FAILED failed with AssertionFailedError

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886132#comment-15886132
 ] 

ASF subversion and git services commented on GEODE-2515:


Commit 8ff2fd4017ade81510e7705bf0f3254154a8805d in geode's branch 
refs/heads/develop from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8ff2fd4 ]

GEODE-2515: Disabling BaseLineAndCompareQueryPerfJUnitTest

This is a performance test, it should not be run as part of precheckin.


> CI Failure: 
> BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries FAILED 
> failed with AssertionFailedError
> ---
>
> Key: GEODE-2515
> URL: https://issues.apache.org/jira/browse/GEODE-2515
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>
>   java.lang.AssertionError: Avg. Time taken to query with index should be 
> less than time taken without index
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.geode.cache.query.BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries(BaseLineAndCompareQueryPerfJUnitTest.java:299)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886130#comment-15886130
 ] 

ASF GitHub Bot commented on GEODE-2531:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/37#discussion_r103257502
  
--- Diff: src/cppcache/src/statistics/AtomicStatisticsImpl.cpp ---
@@ -330,7 +329,13 @@ double AtomicStatisticsImpl::_incDouble(int32_t 
offset, double delta) {
 throw IllegalArgumentException(s);
   }
 
-  return (doubleStorage[offset] += delta);
+  double expected = doubleStorage[offset];
+  double value;
+  do {
+value = expected + delta;
+  } while (!doubleStorage[offset].compare_exchange_weak(expected, value));
--- End diff --

If compare_exchange_weak() fails, should expected be refreshed with 
doubleStorage[offset]?


> Replace HostAsm::atomic* and AtomicInc with std::atomic
> ---
>
> Key: GEODE-2531
> URL: https://issues.apache.org/jira/browse/GEODE-2531
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{HostAsm::atomic*}} and {{AtomicInc}} with 
> {{[std::atomic|http://en.cppreference.com/w/cpp/atomic/atomic]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2531) Replace HostAsm::atomic* and AtomicInc with std::atomic

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886131#comment-15886131
 ] 

ASF GitHub Bot commented on GEODE-2531:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/37#discussion_r103254380
  
--- Diff: src/cppcache/include/geode/CacheStatistics.hpp ---
@@ -102,8 +102,8 @@ class CPPCACHE_EXPORT CacheStatistics : public 
SharedBase {
   virtual void setLastAccessedTime(uint32_t lat);
   virtual void setLastModifiedTime(uint32_t lmt);
 
-  volatile uint32_t m_lastAccessTime;
-  volatile uint32_t m_lastModifiedTime;
+  std::atomic m_lastAccessTime;
+  std::atomic m_lastModifiedTime;
--- End diff --

std::atomic is pretty cool. It looks like the performance impact is 
negligible, right?


> Replace HostAsm::atomic* and AtomicInc with std::atomic
> ---
>
> Key: GEODE-2531
> URL: https://issues.apache.org/jira/browse/GEODE-2531
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{HostAsm::atomic*}} and {{AtomicInc}} with 
> {{[std::atomic|http://en.cppreference.com/w/cpp/atomic/atomic]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [DISCUSS] changes to Redis implementation

[Michael Stolz]

It does seem like the operations will often be much smaller than the data
they are operating on.
It is almost the classic "move the code to the data" pattern.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: +1-631-835-4771

On Mon, Feb 27, 2017 at 10:51 AM, Udo Kohlmeyer 
wrote:

> Delta could provide us a mechanism to replicate only what is required.
>
> I wonder if we could not create a simple operation replication framework.
> Rather than writing a potential large amounts of code for delta, we
> replicate only the operation.
>
>
> On 2/27/17 07:18, Wes Williams wrote:
>
>> Replicating a whole collection because of 1 change does not really make

>>> too much sense.<<
>>
>> I agree but won't delta replication prevent sending the entire collection
>> across the wire?
>>
>> *Wes Williams | Pivotal Advisory **Data Engineer*
>> 781.606.0325
>> http://pivotal.io/big-data/pivotal-gemfire
>>
>> On Mon, Feb 27, 2017 at 10:08 AM, Udo Kohlmeyer 
>> wrote:
>>
>> I've quickly gone through the changes for the pull request.
>>>
>>> The most significant change of this pull request is that the collections
>>> that initially were regions are single collections (not distributed).
>>> That
>>> said, this is something that we've been discussing. The one thing that I
>>> wonder about is, what will the performance look like when the collections
>>> become really large? Replicating a whole collection because of 1 change
>>> does not really make too much sense.
>>>
>>> Maybe this implementation becomes the catalyst for future improvements.
>>>
>>> --Udo
>>>
>>>
>>>
>>> On 2/24/17 15:25, Bruce Schuchardt wrote:
>>>
>>> Gregory Green has posted a pull request that warrants discussion. It
 improves performance for Sets and Hashes by altering the storage format
 for
 these collections.  As such it will not permit a rolling upgrade, though
 the Redis adapter is labelled "experimental" so maybe that's okay.

 https://github.com/apache/geode/pull/404

 The PR also fixes GEODE-2469, inability to handle hash keys having
 colons.

 There was some discussion about altering the storage format that was
 initiated by Hitesh.  Personally I think Gregory's changes are better
 than
 the current implementation and we should accept them, though I haven't
 gone
 through the code changes extensively.



>

[jira] [Resolved] (GEODE-2515) CI Failure: BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries FAILED failed with AssertionFailedError

[Dan Smith (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith resolved GEODE-2515.
--
   Resolution: Fixed
 Assignee: Dan Smith
Fix Version/s: 1.2.0

> CI Failure: 
> BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries FAILED 
> failed with AssertionFailedError
> ---
>
> Key: GEODE-2515
> URL: https://issues.apache.org/jira/browse/GEODE-2515
> Project: Geode
>  Issue Type: Bug
>  Components: querying
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Dan Smith
> Fix For: 1.2.0
>
>
>   java.lang.AssertionError: Avg. Time taken to query with index should be 
> less than time taken without index
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at 
> org.apache.geode.cache.query.BaseLineAndCompareQueryPerfJUnitTest.testPerformanceForRangeQueries(BaseLineAndCompareQueryPerfJUnitTest.java:299)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #406: GEODE-2526: Enhance log statement to include ResourceTypeN...

[smanvi-pivotal]

Github user smanvi-pivotal commented on the issue:

https://github.com/apache/geode/pull/406
  
@metatype Thank you. I just pushed a new commit with a small refactor. 
Travis build is in progress.
I did run `./gradlew spotlessApply` and `./gradlew build` was successful.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2526) Enhance log statement in StatsArchiveReader

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886144#comment-15886144
 ] 

ASF GitHub Bot commented on GEODE-2526:
---

Github user smanvi-pivotal commented on the issue:

https://github.com/apache/geode/pull/406
  
@metatype Thank you. I just pushed a new commit with a small refactor. 
Travis build is in progress.
I did run `./gradlew spotlessApply` and `./gradlew build` was successful.



> Enhance log statement in StatsArchiveReader
> ---
>
> Key: GEODE-2526
> URL: https://issues.apache.org/jira/browse/GEODE-2526
> Project: Geode
>  Issue Type: New Feature
>  Components: statistics
>Reporter: Srikanth Manvi
>Assignee: Srikanth Manvi
>Priority: Trivial
>
> Rarely stats files are corrupted due to missing ResourceType info in the gfs 
> file. In those cases the gfs files cannot be opened in VSD tool as the tool 
> throws an error while loading.
> The log statement in the method 
> StatsArchiveReader.java(readResourceInstanceCreateToken())  prints out only 
> the missing ResourceTypeId which appears to be dynamically created. 
> If the log message can be enhanced to include the resourceName as well, it 
> will be valuable to know the name of ResourceType that is actually missing in 
> the stats file. 
> There is a [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility which takes in a corrupted stats files, name and id of the missing 
> ResourceType in the corrupted file and outputs a new .gfs file by filling in 
> the missing resource info. The new file can then be loaded and analyzed in 
> VSD.
>  
> For the [stats-cleaner | https://github.com/smanvi-pivotal/stats-cleaner] 
> utility to be usable one needs to know the actual name of missing 
> resourceType, hence this New feature request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103252234
  
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
 m_entryFactory->newMapEntry(key, newEntry);
 newEntry->setValueI(newValue);
 if (m_concurrencyChecksEnabled) {
-  if (versionTag != NULLPTR && versionTag.ptr() != NULL) {
+  if (versionTag != NULLPTR && versionTag.ptr() != nullptr) {
--- End diff --

Any reason that we have to continue to keep `NULLPTR`?  Else it gets a 
little confusing with C++11 keyword `nullptr`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103252978
  
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
 #include "fw_dunit.hpp"
 #include 
 
+#include 
+#include 
+
 #include 
 
 #include 
 #include 
 #include 
 
-namespace apache {
-namespace geode {
-namespace client {
+namespace {
 
-CPPCACHE_EXPORT void* testSpinLockCreate();
-CPPCACHE_EXPORT void testSpinLockAcquire(void* lock);
-CPPCACHE_EXPORT void testSpinLockRelease(void* lock);
-}  // namespace client
-}  // namespace geode
-}  // namespace apache
+using apache::geode::util::concurrent::spinlock_mutex;
 
 DUNIT_TASK(s1p1, Basic)
   {
-void* lock = apache::geode::client::testSpinLockCreate();
-apache::geode::client::testSpinLockAcquire(lock);
-apache::geode::client::testSpinLockRelease(lock);
+spinlock_mutex s;
+{ std::lock_guard lk(s); }
   }
 END_TASK(Basic)
 
 perf::Semaphore* triggerA;
 perf::Semaphore* triggerB;
 perf::Semaphore* triggerM;
 
-void* lock;
+spinlock_mutex lock;
 ACE_Time_Value* btime;
 
 class ThreadA : public ACE_Task_Base {
  public:
   ThreadA() : ACE_Task_Base() {}
 
   int svc() {
-apache::geode::client::testSpinLockAcquire(lock);
-LOG("ThreadA: Acquired lock x.");
-triggerM->release();
-triggerA->acquire();
-apache::geode::client::testSpinLockRelease(lock);
+{
+  std::lock_guard lk(lock);
+  LOG("ThreadA: Acquired lock x.");
+  triggerM->release();
+  triggerA->acquire();
+}
--- End diff --

So this has to be inside its own block scope so that 
`std::lock_guard lk` will go out of scope and release the 
`spinlock_mutex`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native issue #34: GEODE-2513 Rebrand Delta Propagation section of

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/34
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103257643
  
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
  * limitations under the License.
  */
 #include "LRUList.hpp"
-#include "SpinLock.hpp"
+#include "util/concurrent/spinlock_mutex.hpp"
 
-using namespace apache::geode::client;
+#include 
 
-#define LOCK_HEAD SpinLockGuard headLockGuard(m_headLock)
-#define LOCK_TAIL SpinLockGuard tailLockGuard(m_tailLock)
+namespace apache {
+namespace geode {
+namespace client {
+
+using util::concurrent::spinlock_mutex;
+
+//#define LOCK_HEAD SpinLockGuard headLockGuard(m_headLock)
+//#define LOCK_TAIL SpinLockGuard tailLockGuard(m_tailLock)
--- End diff --

Delete?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103256958
  
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -108,21 +98,21 @@ CqQueryStatType::CqQueryStatType()
 

 
 CqQueryVsdStats::CqQueryVsdStats(const char* cqqueryName) {
-  CqQueryStatType* regStatType = CqQueryStatType::getInstance();
+  auto& regStatType = CqQueryStatType::getInstance();
 
-  StatisticsType* statsType = regStatType->getStatType();
+  StatisticsType* statsType = regStatType.getStatType();
 
-  GF_D_ASSERT(statsType != NULL);
+  GF_D_ASSERT(statsType != nullptr);
--- End diff --

Would `static_assert` work here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103262976
  
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -41,6 +40,9 @@
 #include 
 #include "TombstoneList.hpp"
 #include 
+
+#include "util/concurrent/spinlock_mutex.hpp"
--- End diff --

Nit: Why are you using "?  And why is it placed down here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886161#comment-15886161
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103252510
  
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
 #include "fw_dunit.hpp"
 #include 
 
+#include 
+#include 
+
 #include 
 
 #include 
 #include 
 #include 
 
-namespace apache {
-namespace geode {
-namespace client {
+namespace {
 
-CPPCACHE_EXPORT void* testSpinLockCreate();
-CPPCACHE_EXPORT void testSpinLockAcquire(void* lock);
-CPPCACHE_EXPORT void testSpinLockRelease(void* lock);
-}  // namespace client
-}  // namespace geode
-}  // namespace apache
+using apache::geode::util::concurrent::spinlock_mutex;
 
 DUNIT_TASK(s1p1, Basic)
   {
-void* lock = apache::geode::client::testSpinLockCreate();
-apache::geode::client::testSpinLockAcquire(lock);
-apache::geode::client::testSpinLockRelease(lock);
+spinlock_mutex s;
+{ std::lock_guard lk(s); }
--- End diff --

I actually find using separate lines more readable.  How does everybody 
else feel?


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886169#comment-15886169
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103257643
  
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
  * limitations under the License.
  */
 #include "LRUList.hpp"
-#include "SpinLock.hpp"
+#include "util/concurrent/spinlock_mutex.hpp"
 
-using namespace apache::geode::client;
+#include 
 
-#define LOCK_HEAD SpinLockGuard headLockGuard(m_headLock)
-#define LOCK_TAIL SpinLockGuard tailLockGuard(m_tailLock)
+namespace apache {
+namespace geode {
+namespace client {
+
+using util::concurrent::spinlock_mutex;
+
+//#define LOCK_HEAD SpinLockGuard headLockGuard(m_headLock)
+//#define LOCK_TAIL SpinLockGuard tailLockGuard(m_tailLock)
--- End diff --

Delete?


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886172#comment-15886172
 ] 

ASF GitHub Bot commented on GEODE-2513:
---

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode-native/pull/34
  
+1


> Geode Native docs: rebrand to match open-source software
> 
>
> Key: GEODE-2513
> URL: https://issues.apache.org/jira/browse/GEODE-2513
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts 
> that have been purged from the open-source code. Docs should be updated to 
> match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886167#comment-15886167
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103251646
  
--- Diff: src/cppcache/src/util/concurrent/spinlock_mutex.hpp ---
@@ -15,23 +15,37 @@
  * limitations under the License.
  */
 
-#include 
+#pragma once
 
-#include "SpinLock.hpp"
+#ifndef GEODE_UTIL_CONCURRENT_SPINLOCK_MUTEX_H_
+#define GEODE_UTIL_CONCURRENT_SPINLOCK_MUTEX_H_
+
+#include 
 
 namespace apache {
 namespace geode {
-namespace client {
+namespace util {
+namespace concurrent {
+
+class spinlock_mutex final {
--- End diff --

Nice to see some C++11 features/keywords being adopted in this code.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886168#comment-15886168
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103252234
  
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
 m_entryFactory->newMapEntry(key, newEntry);
 newEntry->setValueI(newValue);
 if (m_concurrencyChecksEnabled) {
-  if (versionTag != NULLPTR && versionTag.ptr() != NULL) {
+  if (versionTag != NULLPTR && versionTag.ptr() != nullptr) {
--- End diff --

Any reason that we have to continue to keep `NULLPTR`?  Else it gets a 
little confusing with C++11 keyword `nullptr`.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886163#comment-15886163
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103258922
  
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -19,18 +19,22 @@
 #include "TrackedMapEntry.hpp"
 #include "RegionInternal.hpp"
 #include "TableOfPrimes.hpp"
-#include "SpinLock.hpp"
 #include "Utils.hpp"
 #include "ThinClientPoolDM.hpp"
 #include "ThinClientRegion.hpp"
 #include "TombstoneExpiryHandler.hpp"
 #include 
 #include "ace/Time_Value.h"
-using namespace apache::geode::client;
 
-#define _GF_GUARD_SEGMENT SpinLockGuard mapGuard(m_spinlock)
--- End diff --

Yay, one less macro!


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103256152
  
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -20,43 +20,38 @@
 #include "CqQueryVsdStats.hpp"
 //#include "StatisticsFactory.hpp"
 
-#include 
 #include 
 
-const char* cqStatsName = (const char*)"CqQueryStatistics";
-const char* cqStatsDesc = (const char*)"Statistics for this cq query";
+#include 
+
+#include "util/concurrent/spinlock_mutex.hpp"
+
+const char* cqStatsName = "CqQueryStatistics";
+const char* cqStatsDesc = "Statistics for this cq query";
--- End diff --

Are these constant global variables?  You may want to consider using 
`constexpr` here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886166#comment-15886166
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103258079
  
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -96,33 +102,38 @@ void LRUList::getLRUEntry(LRUListEntryPtr& result) {
 
 template 
 typename LRUList::LRUListNode*
-LRUList::getHeadNode(bool& isLast) {
-  LOCK_HEAD;
+LRUList::getHeadNode(bool* isLast) {
--- End diff --

Why did this need to be changed to a raw pointer?


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103258922
  
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -19,18 +19,22 @@
 #include "TrackedMapEntry.hpp"
 #include "RegionInternal.hpp"
 #include "TableOfPrimes.hpp"
-#include "SpinLock.hpp"
 #include "Utils.hpp"
 #include "ThinClientPoolDM.hpp"
 #include "ThinClientRegion.hpp"
 #include "TombstoneExpiryHandler.hpp"
 #include 
 #include "ace/Time_Value.h"
-using namespace apache::geode::client;
 
-#define _GF_GUARD_SEGMENT SpinLockGuard mapGuard(m_spinlock)
--- End diff --

Yay, one less macro!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886165#comment-15886165
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103251295
  
--- Diff: src/tests/cpp/security/Security.cpp ---
@@ -1014,12 +1016,15 @@ int32_t Security::doEntryOperations() {
 reinterpret_cast(valBuf),
 static_cast(strlen(valBuf)));
 int32_t *val =
-(int32_t *)(dynCast(tmpValue)->value());
+const_cast(reinterpret_cast(
+dynCast(tmpValue)->value()));
--- End diff --

Why are you doing a `reinterpret_cast` and `const_cast` in addition to the 
`dynCast`?


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886162#comment-15886162
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103262976
  
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -41,6 +40,9 @@
 #include 
 #include "TombstoneList.hpp"
 #include 
+
+#include "util/concurrent/spinlock_mutex.hpp"
--- End diff --

Nit: Why are you using "?  And why is it placed down here?


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886170#comment-15886170
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103256958
  
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -108,21 +98,21 @@ CqQueryStatType::CqQueryStatType()
 

 
 CqQueryVsdStats::CqQueryVsdStats(const char* cqqueryName) {
-  CqQueryStatType* regStatType = CqQueryStatType::getInstance();
+  auto& regStatType = CqQueryStatType::getInstance();
 
-  StatisticsType* statsType = regStatType->getStatType();
+  StatisticsType* statsType = regStatType.getStatType();
 
-  GF_D_ASSERT(statsType != NULL);
+  GF_D_ASSERT(statsType != nullptr);
--- End diff --

Would `static_assert` work here?


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886171#comment-15886171
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103256152
  
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -20,43 +20,38 @@
 #include "CqQueryVsdStats.hpp"
 //#include "StatisticsFactory.hpp"
 
-#include 
 #include 
 
-const char* cqStatsName = (const char*)"CqQueryStatistics";
-const char* cqStatsDesc = (const char*)"Statistics for this cq query";
+#include 
+
+#include "util/concurrent/spinlock_mutex.hpp"
+
+const char* cqStatsName = "CqQueryStatistics";
+const char* cqStatsDesc = "Statistics for this cq query";
--- End diff --

Are these constant global variables?  You may want to consider using 
`constexpr` here


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103258079
  
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -96,33 +102,38 @@ void LRUList::getLRUEntry(LRUListEntryPtr& result) {
 
 template 
 typename LRUList::LRUListNode*
-LRUList::getHeadNode(bool& isLast) {
-  LOCK_HEAD;
+LRUList::getHeadNode(bool* isLast) {
--- End diff --

Why did this need to be changed to a raw pointer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103251295
  
--- Diff: src/tests/cpp/security/Security.cpp ---
@@ -1014,12 +1016,15 @@ int32_t Security::doEntryOperations() {
 reinterpret_cast(valBuf),
 static_cast(strlen(valBuf)));
 int32_t *val =
-(int32_t *)(dynCast(tmpValue)->value());
+const_cast(reinterpret_cast(
+dynCast(tmpValue)->value()));
--- End diff --

Why are you doing a `reinterpret_cast` and `const_cast` in addition to the 
`dynCast`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103251646
  
--- Diff: src/cppcache/src/util/concurrent/spinlock_mutex.hpp ---
@@ -15,23 +15,37 @@
  * limitations under the License.
  */
 
-#include 
+#pragma once
 
-#include "SpinLock.hpp"
+#ifndef GEODE_UTIL_CONCURRENT_SPINLOCK_MUTEX_H_
+#define GEODE_UTIL_CONCURRENT_SPINLOCK_MUTEX_H_
+
+#include 
 
 namespace apache {
 namespace geode {
-namespace client {
+namespace util {
+namespace concurrent {
+
+class spinlock_mutex final {
--- End diff --

Nice to see some C++11 features/keywords being adopted in this code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[dgkimura]

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103252510
  
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
 #include "fw_dunit.hpp"
 #include 
 
+#include 
+#include 
+
 #include 
 
 #include 
 #include 
 #include 
 
-namespace apache {
-namespace geode {
-namespace client {
+namespace {
 
-CPPCACHE_EXPORT void* testSpinLockCreate();
-CPPCACHE_EXPORT void testSpinLockAcquire(void* lock);
-CPPCACHE_EXPORT void testSpinLockRelease(void* lock);
-}  // namespace client
-}  // namespace geode
-}  // namespace apache
+using apache::geode::util::concurrent::spinlock_mutex;
 
 DUNIT_TASK(s1p1, Basic)
   {
-void* lock = apache::geode::client::testSpinLockCreate();
-apache::geode::client::testSpinLockAcquire(lock);
-apache::geode::client::testSpinLockRelease(lock);
+spinlock_mutex s;
+{ std::lock_guard lk(s); }
--- End diff --

I actually find using separate lines more readable.  How does everybody 
else feel?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886164#comment-15886164
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user dgkimura commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103252978
  
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
 #include "fw_dunit.hpp"
 #include 
 
+#include 
+#include 
+
 #include 
 
 #include 
 #include 
 #include 
 
-namespace apache {
-namespace geode {
-namespace client {
+namespace {
 
-CPPCACHE_EXPORT void* testSpinLockCreate();
-CPPCACHE_EXPORT void testSpinLockAcquire(void* lock);
-CPPCACHE_EXPORT void testSpinLockRelease(void* lock);
-}  // namespace client
-}  // namespace geode
-}  // namespace apache
+using apache::geode::util::concurrent::spinlock_mutex;
 
 DUNIT_TASK(s1p1, Basic)
   {
-void* lock = apache::geode::client::testSpinLockCreate();
-apache::geode::client::testSpinLockAcquire(lock);
-apache::geode::client::testSpinLockRelease(lock);
+spinlock_mutex s;
+{ std::lock_guard lk(s); }
   }
 END_TASK(Basic)
 
 perf::Semaphore* triggerA;
 perf::Semaphore* triggerB;
 perf::Semaphore* triggerM;
 
-void* lock;
+spinlock_mutex lock;
 ACE_Time_Value* btime;
 
 class ThreadA : public ACE_Task_Base {
  public:
   ThreadA() : ACE_Task_Base() {}
 
   int svc() {
-apache::geode::client::testSpinLockAcquire(lock);
-LOG("ThreadA: Acquired lock x.");
-triggerM->release();
-triggerA->acquire();
-apache::geode::client::testSpinLockRelease(lock);
+{
+  std::lock_guard lk(lock);
+  LOG("ThreadA: Acquired lock x.");
+  triggerM->release();
+  triggerA->acquire();
+}
--- End diff --

So this has to be inside its own block scope so that 
`std::lock_guard lk` will go out of scope and release the 
`spinlock_mutex`?


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #407: GEODE-2550 Improve README and BUILDING

[karensmolermiller]

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/407#discussion_r103267882
  
--- Diff: README.md ---
@@ -1,102 +1,191 @@
 [https://geode.apache.org/img/apache_geode_logo.png"; 
align="center"/>](http://geode.apache.org)
 
-[![Build 
Status](https://travis-ci.org/apache/geode.svg?branch=develop)](https://travis-ci.org/apache/geode)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 [![Maven 
Central](https://maven-badges.herokuapp.com/maven-central/org.apache.geode/geode-core/badge.svg)](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.geode%22)
+[![Build 
Status](https://travis-ci.org/apache/geode.svg?branch=develop)](https://travis-ci.org/apache/geode)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 [![Maven 
Central](https://maven-badges.herokuapp.com/maven-central/org.apache.geode/geode-core/badge.svg)](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.geode%22)
 
[![homebrew](https://img.shields.io/homebrew/v/apache-geode.svg)](http://brewformulas.org/ApacheGeode)
 [![Docker 
Pulls](https://img.shields.io/docker/pulls/apachegeode/geode.svg)](https://hub.docker.com/r/apachegeode/geode/)
+
 
 ## Contents
-1. [Overview](#overview)  
+1. [Overview](#overview)
+2. [How to Get Apache Geode](#obtaining)
 2. [Main Concepts and Components](#concepts)
 3. [Location of Directions for Building from Source](#building)
 4. [Geode in 5 minutes](#started)
 5. [Application Development](#development)
 6. [Documentation](http://geode.apache.org/docs/)
 7. [Wiki](https://cwiki.apache.org/confluence/display/GEODE/Index)
-   

 
-## Overview
-[Apache Geode](http://geode.apache.org/) is a data management platform 
that provides real-time, consistent access to data-intensive applications 
throughout widely distributed cloud architectures.
 
-Apache Geode pools memory, CPU, network resources, and optionally local 
disk across multiple processes to manage application objects and behavior. It 
uses dynamic replication and data partitioning techniques to implement high 
availability, improved performance, scalability, and fault tolerance. In 
addition to being a distributed data container, Apache Geode is an in-memory 
data management system that provides reliable asynchronous event notifications 
and guaranteed message delivery.
+## Overview
 
-Apache Geode is a mature, robust technology originally developed by 
GemStone Systems in Beaverton, Oregon. Commercially available as GemFire™, 
the technology was first deployed in the financial sector as the transactional, 
low-latency data engine used in Wall Street trading platforms.  Today Apache 
Geode is used by over 600 enterprise customers for high-scale business 
applications that must meet low latency and 24x7 availability requirements. An 
example deployment includes [China National 
Railways](http://pivotal.io/big-data/case-study/scaling-online-sales-for-the-largest-railway-in-the-world-china-railway-corporation)
 that uses Geode to run railway ticketing for the entire country of China with 
a 10 node cluster that manages 2 terabytes of "hot data" in memory, and 10 
backup nodes for high availability and elastic scale.
+[Apache Geode](http://geode.apache.org/) is
+a data management platform that provides real-time, consistent access to
+data-intensive applications throughout widely distributed cloud 
architectures.
+
+Apache Geode pools memory, CPU, network resources, and optionally local 
disk
+across multiple processes to manage application objects and behavior. It 
uses
+dynamic replication and data partitioning techniques to implement high
+availability, improved performance, scalability, and fault tolerance. In
+addition to being a distributed data container, Apache Geode is an 
in-memory
+data management system that provides reliable asynchronous event 
notifications
+and guaranteed message delivery.
+
+Apache Geode is a mature, robust technology originally developed by 
GemStone
+Systems. Commercially available as GemFire™, it was first deployed in the
+financial sector as the transactional, low-latency data engine used in Wall
+Street trading platforms.  Today Apache Geode technology is used by 
hundreds of
+enterprise customers for high-scale business applications that must meet 
low
+latency and 24x7 availability requirements.
+
+## How to Get Apache Geode
+
+You can download Apache Geode from the
+[website](http://geode.apache.org/releases/), run a Docker
+[image](https://hub.docker.com/r/apachegeode/geode/), or install 

[jira] [Commented] (GEODE-2550) Improve README

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886209#comment-15886209
 ] 

ASF GitHub Bot commented on GEODE-2550:
---

Github user karensmolermiller commented on a diff in the pull request:

https://github.com/apache/geode/pull/407#discussion_r103267882
  
--- Diff: README.md ---
@@ -1,102 +1,191 @@
 [https://geode.apache.org/img/apache_geode_logo.png"; 
align="center"/>](http://geode.apache.org)
 
-[![Build 
Status](https://travis-ci.org/apache/geode.svg?branch=develop)](https://travis-ci.org/apache/geode)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 [![Maven 
Central](https://maven-badges.herokuapp.com/maven-central/org.apache.geode/geode-core/badge.svg)](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.geode%22)
+[![Build 
Status](https://travis-ci.org/apache/geode.svg?branch=develop)](https://travis-ci.org/apache/geode)
 
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
 [![Maven 
Central](https://maven-badges.herokuapp.com/maven-central/org.apache.geode/geode-core/badge.svg)](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.apache.geode%22)
 
[![homebrew](https://img.shields.io/homebrew/v/apache-geode.svg)](http://brewformulas.org/ApacheGeode)
 [![Docker 
Pulls](https://img.shields.io/docker/pulls/apachegeode/geode.svg)](https://hub.docker.com/r/apachegeode/geode/)
+
 
 ## Contents
-1. [Overview](#overview)  
+1. [Overview](#overview)
+2. [How to Get Apache Geode](#obtaining)
 2. [Main Concepts and Components](#concepts)
 3. [Location of Directions for Building from Source](#building)
 4. [Geode in 5 minutes](#started)
 5. [Application Development](#development)
 6. [Documentation](http://geode.apache.org/docs/)
 7. [Wiki](https://cwiki.apache.org/confluence/display/GEODE/Index)
-   

 
-## Overview
-[Apache Geode](http://geode.apache.org/) is a data management platform 
that provides real-time, consistent access to data-intensive applications 
throughout widely distributed cloud architectures.
 
-Apache Geode pools memory, CPU, network resources, and optionally local 
disk across multiple processes to manage application objects and behavior. It 
uses dynamic replication and data partitioning techniques to implement high 
availability, improved performance, scalability, and fault tolerance. In 
addition to being a distributed data container, Apache Geode is an in-memory 
data management system that provides reliable asynchronous event notifications 
and guaranteed message delivery.
+## Overview
 
-Apache Geode is a mature, robust technology originally developed by 
GemStone Systems in Beaverton, Oregon. Commercially available as GemFire™, the 
technology was first deployed in the financial sector as the transactional, 
low-latency data engine used in Wall Street trading platforms.  Today Apache 
Geode is used by over 600 enterprise customers for high-scale business 
applications that must meet low latency and 24x7 availability requirements. An 
example deployment includes [China National 
Railways](http://pivotal.io/big-data/case-study/scaling-online-sales-for-the-largest-railway-in-the-world-china-railway-corporation)
 that uses Geode to run railway ticketing for the entire country of China with 
a 10 node cluster that manages 2 terabytes of "hot data" in memory, and 10 
backup nodes for high availability and elastic scale.
+[Apache Geode](http://geode.apache.org/) is
+a data management platform that provides real-time, consistent access to
+data-intensive applications throughout widely distributed cloud 
architectures.
+
+Apache Geode pools memory, CPU, network resources, and optionally local 
disk
+across multiple processes to manage application objects and behavior. It 
uses
+dynamic replication and data partitioning techniques to implement high
+availability, improved performance, scalability, and fault tolerance. In
+addition to being a distributed data container, Apache Geode is an 
in-memory
+data management system that provides reliable asynchronous event 
notifications
+and guaranteed message delivery.
+
+Apache Geode is a mature, robust technology originally developed by 
GemStone
+Systems. Commercially available as GemFire™, it was first deployed in the
+financial sector as the transactional, low-latency data engine used in Wall
+Street trading platforms.  Today Apache Geode technology is used by 
hundreds of
+enterprise customers for high-scale business applications that must meet 
low
+latency and 24

[jira] [Commented] (GEODE-2545) NPE during lucene query execution when cache is closing or region is destroyed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886232#comment-15886232
 ] 

ASF subversion and git services commented on GEODE-2545:


Commit c4a5ab284baba371418cb7a389cb0f327d8becdc in geode's branch 
refs/heads/develop from [~huynhja]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c4a5ab2 ]

GEODE-2545: NPE during lucene query execution when cache is closing or region 
is destroyed

* Throw an InternalFunctionTargetInvocationException if executing a query while 
cache is closing


> NPE during lucene query execution when cache is closing or region is destroyed
> --
>
> Key: GEODE-2545
> URL: https://issues.apache.org/jira/browse/GEODE-2545
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>
> If the LuceneQueryFunction executes while a cache is closing, it is possible 
> that the function receives a null region/index.  In this case the NPE is 
> thrown.  Instead we should detect this and fail the function.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2545) NPE during lucene query execution when cache is closing or region is destroyed

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2545.

   Resolution: Fixed
Fix Version/s: 1.2.0

> NPE during lucene query execution when cache is closing or region is destroyed
> --
>
> Key: GEODE-2545
> URL: https://issues.apache.org/jira/browse/GEODE-2545
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> If the LuceneQueryFunction executes while a cache is closing, it is possible 
> that the function receives a null region/index.  In this case the NPE is 
> thrown.  Instead we should detect this and fail the function.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2543) Remove incorrectly marked deprecated methods from LuceneService and LuceneQueryFactory api

[Jason Huynh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh resolved GEODE-2543.

   Resolution: Fixed
Fix Version/s: 1.2.0

> Remove incorrectly marked deprecated methods from LuceneService and 
> LuceneQueryFactory api
> --
>
> Key: GEODE-2543
> URL: https://issues.apache.org/jira/browse/GEODE-2543
> Project: Geode
>  Issue Type: Improvement
>  Components: lucene
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
> Fix For: 1.2.0
>
>
> In the experimental features, we have a few methods marked as deprecated that 
> should either be removed or throw unsupported operation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2478) Replace gf with geode

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison resolved GEODE-2478.

Resolution: Fixed

> Replace gf with geode
> -
>
> Key: GEODE-2478
> URL: https://issues.apache.org/jira/browse/GEODE-2478
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Dodge
>
> The substring "gf" still occurs in some places in the native client codebase. 
> It ought to be replaced with "geode" or "geode-native", whichever makes more 
> sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2480) Need to specify correct version of CMake required for building Native Client

[Addison (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison resolved GEODE-2480.

Resolution: Fixed

> Need to specify correct version of CMake required for building Native Client
> 
>
> Key: GEODE-2480
> URL: https://issues.apache.org/jira/browse/GEODE-2480
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Akihiro Kitada
>
> According to the following doc, the version of CMake required for building 
> Native Client is *4.3* or newer.
> https://github.com/apache/geode-native/blob/develop/BUILDING.md
> However, the latest stable version of CMake is 3.7.2 as of now. Please 
> specify the correct version of CMake (it could be "*3.4* or newer" ?).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #39: Add rat checks to travis-ci build

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-native/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2404) Add API to destroy a region containing lucene indexes

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886248#comment-15886248
 ] 

ASF subversion and git services commented on GEODE-2404:


Commit 11521a824f31ff03db13d0e59cb0fbf29e592151 in geode's branch 
refs/heads/develop from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=11521a8 ]

GEODE-2404: Added support for destroying lucene indexes


> Add API to destroy a region containing lucene indexes
> -
>
> Key: GEODE-2404
> URL: https://issues.apache.org/jira/browse/GEODE-2404
> Project: Geode
>  Issue Type: New Feature
>  Components: lucene
>Reporter: Barry Oglesby
> Attachments: DestroyRegionMultipleMembersFunction.java
>
>
> h2. Description
> An application {{Region}} containing {{LuceneIndexes}} should be able to be 
> destroyed.
> There are several options, including:
> - Invoke one API to destroy both the application {{Region}} and its 
> {{LuceneIndexes}}
> - Invoke two API:
> ## destroy the {{LuceneIndexes}}
> ## destroy application {{Region}} as it is done currently
> h3. One API
> In this case, we would need a callback on {{LuceneService}} to destroy the 
> {{LuceneIndexes}} before destroying the application {{Region}} like:
> {noformat}
> public void beforeDestroyRegion(Region region);
> {noformat}
> This API would get all the {{LuceneIndexes}} for the application {{Region}}, 
> then destroy each one. See the *Two API* section below for details on 
> destroying a {{LuceneIndex}}.
> Without changes to the way {{PartitionedRegions}} are destroyed, this causes 
> an issue though.
> The current behavior of {{PartitionedRegion destroyRegion}} is to first check 
> for colocated children. If there are any, the call fails.
> There are two options for adding the call to destroy the {{LuceneIndexes}}:
> # check for colocated children
> # invoke {{LuceneService beforeDestroyRegion}} to remove the {{LuceneIndexes}}
> # do the rest of the destroy
> 
> # invoke {{LuceneService beforeDestroyRegion}} to remove the {{LuceneIndexes}}
> # check for colocated children
> # do the rest of the destroy
> Both of these options are problematic in different ways.
> In the case of a {{PartitionedRegion}} with {{LuceneIndexes}}, there are 
> colocated children, so the first option would cause the {{destroyRegion}} 
> call to fail; the second option would succeed. I don't think the first option 
> should fail since the colocated children are internal {{Regions}} that the 
> application knows nothing about.
> In the case of a {{PartitionedRegion}} defining {{LuceneIndexes}} and having 
> an {{AsyncEventQueue}}, there are colocated children, so the first option 
> would cause the {{destroyRegion}} call to fail. This is ok since one of the 
> children is an application-known {{AsyncEventQueue}}. The second option would 
> fail in a bad way. It would first remove the {{LuceneIndexes}}, then fail the 
> colocated children check, so the {{destroyRegion}} call would fail. In this 
> case, the application {{Region}} doesn't get destroyed but its 
> {{LuceneIndexes}} do. This would be bad.
> One option would be to look into changing the check for colocated children to 
> check for application-defined (or not hidden) colocated children. Then the 
> code would be something like:
> # check for application-defined colocated children
> # invoke LuceneService beforeDestroyRegion to remove the LuceneIndexes
> # do the rest of the destroy
> I think this would be ok in both cases.
> h3. Two API
> The destroy API on {{LuceneIndex}} would be something like:
> {noformat}
> public void destroy();
> {noformat}
> Destroying each {{LuceneIndex}} would require:
> # destroying the chunk {{Region}}
> # destroying the file {{Region}}
> # destroying the {{AsyncEventQueue}} which would require:
> ## retrieving and stopping the {{AsyncEventQueue's}} underlying 
> {{GatewaySender}} (there probably should be stop API on {{AsyncEventQueue}} 
> which does this)
> ## removing the id from the application {{Region's AsyncEventQueue}} ids
> ## destroying the {{AsyncEventQueue}} (this destroys the underlying 
> {{GatewaySender}} and removes it from the {{GemFireCacheImpl's}} collection 
> of {{GatewaySenders}})
> ## removing the {{AsyncEventQueue}} from the {{GemFireCacheImpl's}} 
> collection of {{AsyncEventQueues}} (this should be included in the destroy 
> method above)
> # removing {{LuceneIndex}} from {{LuceneService's}} map of indexes
> I also think the API on {{LuceneService}} should be something like:
> {noformat}
> public void destroyIndexes(String regionPath);
> public void destroyIndex(String indexName, String regionPath);
> {noformat}
> These methods would get the appropriate {{LuceneIndex(es)}} and invoke 
> destroy on them. Then they would remove t

Re: [DISCUSS] changes to Redis implementation

[Hitesh Khamesra]

The simplicity of Redis API making this problem (delta update)most apparent. 
But,  I would imagine many Geode apps has a similar use case.

-Hitesh

  From: Michael Stolz 
 To: dev@geode.apache.org 
 Sent: Monday, February 27, 2017 9:06 AM
 Subject: Re: [DISCUSS] changes to Redis implementation
   
It does seem like the operations will often be much smaller than the data
they are operating on.
It is almost the classic "move the code to the data" pattern.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: +1-631-835-4771

On Mon, Feb 27, 2017 at 10:51 AM, Udo Kohlmeyer 
wrote:

> Delta could provide us a mechanism to replicate only what is required.
>
> I wonder if we could not create a simple operation replication framework.
> Rather than writing a potential large amounts of code for delta, we
> replicate only the operation.
>
>
> On 2/27/17 07:18, Wes Williams wrote:
>
>> Replicating a whole collection because of 1 change does not really make

>>> too much sense.<<
>>
>> I agree but won't delta replication prevent sending the entire collection
>> across the wire?
>>
>> *Wes Williams | Pivotal Advisory **Data Engineer*
>> 781.606.0325
>> http://pivotal.io/big-data/pivotal-gemfire
>>
>> On Mon, Feb 27, 2017 at 10:08 AM, Udo Kohlmeyer 
>> wrote:
>>
>> I've quickly gone through the changes for the pull request.
>>>
>>> The most significant change of this pull request is that the collections
>>> that initially were regions are single collections (not distributed).
>>> That
>>> said, this is something that we've been discussing. The one thing that I
>>> wonder about is, what will the performance look like when the collections
>>> become really large? Replicating a whole collection because of 1 change
>>> does not really make too much sense.
>>>
>>> Maybe this implementation becomes the catalyst for future improvements.
>>>
>>> --Udo
>>>
>>>
>>>
>>> On 2/24/17 15:25, Bruce Schuchardt wrote:
>>>
>>> Gregory Green has posted a pull request that warrants discussion. It
 improves performance for Sets and Hashes by altering the storage format
 for
 these collections.  As such it will not permit a rolling upgrade, though
 the Redis adapter is labelled "experimental" so maybe that's okay.

 https://github.com/apache/geode/pull/404

 The PR also fixes GEODE-2469, inability to handle hash keys having
 colons.

 There was some discussion about altering the storage format that was
 initiated by Hitesh.  Personally I think Gregory's changes are better
 than
 the current implementation and we should accept them, though I haven't
 gone
 through the code changes extensively.



>


   

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103279163
  
--- Diff: src/cppcache/src/LRUList.hpp ---
@@ -20,32 +20,32 @@
  * limitations under the License.
  */
 
+#include 
+
 #include 
 #include 
-#include "SpinLock.hpp"
+
+#include "util/concurrent/spinlock_mutex.hpp"
 
 namespace apache {
 namespace geode {
 namespace client {
+
 // Bit mask for recently used
-#define RECENTLY_USED_BITS 1ul
+#define RECENTLY_USED_BITS 1u
 // Bit mask for evicted
-#define EVICTED_BITS 2ul
+#define EVICTED_BITS 2u
--- End diff --

Could these be const variables in an anonymous namespace instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103278690
  
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
  * limitations under the License.
  */
 #include "LRUList.hpp"
-#include "SpinLock.hpp"
+#include "util/concurrent/spinlock_mutex.hpp"
 
-using namespace apache::geode::client;
+#include 
 
-#define LOCK_HEAD SpinLockGuard headLockGuard(m_headLock)
-#define LOCK_TAIL SpinLockGuard tailLockGuard(m_tailLock)
--- End diff --

Good to see the removal of more macros.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886286#comment-15886286
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103279163
  
--- Diff: src/cppcache/src/LRUList.hpp ---
@@ -20,32 +20,32 @@
  * limitations under the License.
  */
 
+#include 
+
 #include 
 #include 
-#include "SpinLock.hpp"
+
+#include "util/concurrent/spinlock_mutex.hpp"
 
 namespace apache {
 namespace geode {
 namespace client {
+
 // Bit mask for recently used
-#define RECENTLY_USED_BITS 1ul
+#define RECENTLY_USED_BITS 1u
 // Bit mask for evicted
-#define EVICTED_BITS 2ul
+#define EVICTED_BITS 2u
--- End diff --

Could these be const variables in an anonymous namespace instead?


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2494) Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886285#comment-15886285
 ] 

ASF GitHub Bot commented on GEODE-2494:
---

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103278690
  
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
  * limitations under the License.
  */
 #include "LRUList.hpp"
-#include "SpinLock.hpp"
+#include "util/concurrent/spinlock_mutex.hpp"
 
-using namespace apache::geode::client;
+#include 
 
-#define LOCK_HEAD SpinLockGuard headLockGuard(m_headLock)
-#define LOCK_TAIL SpinLockGuard tailLockGuard(m_tailLock)
--- End diff --

Good to see the removal of more macros.


> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> 
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
>  Issue Type: Sub-task
>  Components: native client
>Reporter: Jacob S. Barrett
>Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style 
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}} 
> class, {{spinlock_mutex}}. You can find several public domain examples of how 
> to implement a {{spinlock_mutex}} that can be used with 
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-native pull request #36: GEODE-2494: Replace SpinLock with spinlock_mu...

[PivotalSarge]

Github user PivotalSarge commented on a diff in the pull request:

https://github.com/apache/geode-native/pull/36#discussion_r103279475
  
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -316,16 +320,16 @@ GfErrType MapSegment::remove(const CacheableKeyPtr& 
key, CacheablePtr& oldValue,
  MapEntryImplPtr& me, int updateCount,
  VersionTagPtr versionTag, bool afterRemote,
  bool& isEntryFound) {
-  //  _GF_GUARD_SEGMENT;
+  //  std::lock_guard lk(m_spinlock);
--- End diff --

Since the code is commented out, should it just be deleted?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---