----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57070/#review166884 -----------------------------------------------------------
I don't think this is the appropriate thing to do here. The user has passed in null; that doesn't mean the cache has not been created or has been closed. I think an NPE or an illegal argument exception is more appopriate. - Dan Smith On Feb. 26, 2017, 7:41 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57070/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2017, 7:41 a.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-11 > https://issues.apache.org/jira/browse/GEODE-11 > > > Repository: geode > > > Description > ------- > > util.TestException: Got unexpected exception java.lang.NullPointerException > > at > org.apache.geode.cache.lucene.LuceneServiceProvider.get(LuceneServiceProvider.java:34) > > at lucene.LuceneTest.executeLuceneQuery(LuceneTest.java:116) > > at parReg.ParRegTest.doEntryOperations(ParRegTest.java:2916) > > at parReg.ParRegTest.HADoEntryOps(ParRegTest.java:2259) > > at parReg.ParRegTest.HydraTask_HADoEntryOps(ParRegTest.java:1040) > > at sun.reflect.GeneratedMethodAccessor63.invoke(Unknown Source) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > at java.lang.reflect.Method.invoke(Method.java:497) > > > Diffs > ----- > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneServiceProvider.java > a1f73da > > Diff: https://reviews.apache.org/r/57070/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > xiaojian zhou > >
