[
https://issues.apache.org/jira/browse/GEODE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886168#comment-15886168
]
ASF GitHub Bot commented on GEODE-2494:
---------------------------------------
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103252234
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
m_entryFactory->newMapEntry(key, newEntry);
newEntry->setValueI(newValue);
if (m_concurrencyChecksEnabled) {
- if (versionTag != NULLPTR && versionTag.ptr() != NULL) {
+ if (versionTag != NULLPTR && versionTag.ptr() != nullptr) {
--- End diff --
Any reason that we have to continue to keep `NULLPTR`? Else it gets a
little confusing with C++11 keyword `nullptr`.
> Replace SpinLock class with C++11 style BasicLockable class, spinlock_mutex.
> ----------------------------------------------------------------------------
>
> Key: GEODE-2494
> URL: https://issues.apache.org/jira/browse/GEODE-2494
> Project: Geode
> Issue Type: Sub-task
> Components: native client
> Reporter: Jacob S. Barrett
> Assignee: Jacob S. Barrett
>
> Replace {{SpinLock}} class with C++11 style
> {{[BasicLockable|http://en.cppreference.com/w/cpp/concept/BasicLockable]}}
> class, {{spinlock_mutex}}. You can find several public domain examples of how
> to implement a {{spinlock_mutex}} that can be used with
> {{[std::lock_guard|http://en.cppreference.com/w/cpp/thread/lock_guard]}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
