Github user dgkimura commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/36#discussion_r103251295
  
    --- Diff: src/tests/cpp/security/Security.cpp ---
    @@ -1014,12 +1016,15 @@ int32_t Security::doEntryOperations() {
                     reinterpret_cast<const unsigned char *>(valBuf),
                     static_cast<int32_t>(strlen(valBuf)));
                 int32_t *val =
    -                (int32_t *)(dynCast<CacheableBytesPtr>(tmpValue)->value());
    +                const_cast<int32_t *>(reinterpret_cast<const int32_t *>(
    +                    dynCast<CacheableBytesPtr>(tmpValue)->value()));
    --- End diff --
    
    Why are you doing a `reinterpret_cast` and `const_cast` in addition to the 
`dynCast`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to