Github user dgkimura commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/36#discussion_r103251646
  
    --- Diff: src/cppcache/src/util/concurrent/spinlock_mutex.hpp ---
    @@ -15,23 +15,37 @@
      * limitations under the License.
      */
     
    -#include <geode/geode_globals.hpp>
    +#pragma once
     
    -#include "SpinLock.hpp"
    +#ifndef GEODE_UTIL_CONCURRENT_SPINLOCK_MUTEX_H_
    +#define GEODE_UTIL_CONCURRENT_SPINLOCK_MUTEX_H_
    +
    +#include <atomic>
     
     namespace apache {
     namespace geode {
    -namespace client {
    +namespace util {
    +namespace concurrent {
    +
    +class spinlock_mutex final {
    --- End diff --
    
    Nice to see some C++11 features/keywords being adopted in this code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to