I've quickly gone through the changes for the pull request.
The most significant change of this pull request is that the collections
that initially were regions are single collections (not distributed).
That said, this is something that we've been discussing. The one thing
that I wonder about is, what will the performance look like when the
collections become really large? Replicating a whole collection because
of 1 change does not really make too much sense.
Maybe this implementation becomes the catalyst for future improvements.
--Udo
On 2/24/17 15:25, Bruce Schuchardt wrote:
Gregory Green has posted a pull request that warrants discussion. It
improves performance for Sets and Hashes by altering the storage
format for these collections. As such it will not permit a rolling
upgrade, though the Redis adapter is labelled "experimental" so maybe
that's okay.
https://github.com/apache/geode/pull/404
The PR also fixes GEODE-2469, inability to handle hash keys having
colons.
There was some discussion about altering the storage format that was
initiated by Hitesh. Personally I think Gregory's changes are better
than the current implementation and we should accept them, though I
haven't gone through the code changes extensively.
